From: Samuel Ortiz [sa...@linux.intel.com]
Sent: Monday, August 22, 2011 8:33 PM
To: Koyamangalath, Abhilash
Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
linux-ker...@vger.kernel.org;
t...@atomide.com; li...@arm.linux.org.uk; Hilman, Kevin; Shilimkar, Santosh;
Premi, Sanjeev;
david.woodho...@intel.com
Subject: Re: [PATCH 3/3] OMAP3: Remove auto-selection of PMICs
Hi Anhilash,
On Fri, Aug 19, 2011 at 05:19:33PM +0530, Abhilash K V wrote:
The current implementation almost assumes that only
TWL4030/TWL5030/TWl6030 are (or can be) used with the
OMAP processors. This is, however, not true.
I don't like the mfd/Kconfig change. Why would those drivers be only buildable
on OMAP processors ?
Unless there is a real reason for this, you should fix the drivers instead.
You are right. The change for config item TWL4030_CORE should be removed.
- depends on I2C=y GENERIC_HARDIRQS
+ depends on I2C=y GENERIC_HARDIRQS (ARCH_OMAP3 || ARCH_OMAP4)
In fact, change for TWL4030_POWER should be
- depends on TWL4030_CORE ARM
+ depends on TWL4030_CORE
This would allow these PMICs to be used with other processors as well. There may
be issues run-time issues; but they would most likely surface only when there is
a combination without any of the OMAPs. (We would try a dummy build for another
processor with TWL4030 selected.)
The original idea was to ensure that nothing else breaks when the auto selection
of the PMICs is removed.
~sanjeev
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
