Re: [PATCH v2] Keyboard: omap-keypad: use matrix_keypad.h

2010-12-20 Thread Aaro Koskinen
Hello, On Sat, 18 Dec 2010, Janusz Krzysztofik wrote: Most keypad drivers make use of the linux/input/matrix_keypad.h defined macros, structures and inline functions. Convert omap-keypad driver to use those as well, as suggested by a compile time warning, hardcoded into the OMAP palt/keypad.h.

Re: [PATCH v2] Keyboard: omap-keypad: use matrix_keypad.h

2010-12-20 Thread Janusz Krzysztofik
Monday 20 December 2010 16:29:32 Aaro Koskinen wrote: Hello, On Sat, 18 Dec 2010, Janusz Krzysztofik wrote: Most keypad drivers make use of the linux/input/matrix_keypad.h defined macros, structures and inline functions. Convert omap-keypad driver to use those as well, as suggested by a

Re: [PATCH v2] Keyboard: omap-keypad: use matrix_keypad.h

2010-12-20 Thread Dmitry Torokhov
On Mon, Dec 20, 2010 at 06:32:22PM +0100, Janusz Krzysztofik wrote: Monday 20 December 2010 16:29:32 Aaro Koskinen wrote: Hello, On Sat, 18 Dec 2010, Janusz Krzysztofik wrote: Most keypad drivers make use of the linux/input/matrix_keypad.h defined macros, structures and inline

Re: [PATCH v2] Keyboard: omap-keypad: use matrix_keypad.h

2010-12-20 Thread Janusz Krzysztofik
Monday 20 December 2010 19:02:08 Dmitry Torokhov wrote: Not sure why exactly your sparse does not pick it up (too old maybe?) but the following: --- linux-2.6.37-rc5/arch/arm/mach-omap1/board-ams-delta.c.orig 2010-12-09 23:07:35.0 +0100 +++

RE: [PATCH v2] Keyboard: omap-keypad: use matrix_keypad.h

2010-12-20 Thread aaro.koskinen
Hi, From: Janusz Krzysztofik [jkrzy...@tis.icnet.pl] Monday 20 December 2010 16:29:32 Aaro Koskinen wrote: You should update the ams_delta_keymap type as well, otherwise this patch will introduce the following sparse warning: CHECK arch/arm/mach-omap1/board-ams-delta.c

Re: [PATCH v2] Keyboard: omap-keypad: use matrix_keypad.h

2010-12-20 Thread Janusz Krzysztofik
Monday 20 December 2010 20:03:58 aaro.koski...@nokia.com wrote: I'm using the latest sparse from: git://git.kernel.org/pub/scm/devel/sparse/sparse.git I don't know about OpenEmbedded, but I've noticed that at least Debian ships with some old version that is missing many checks... Aaro,