RE: [PATCH v5 3/7] OMAP: DSS2: Introduce omap_channel as a omap_dss_device parameter

2010-12-02 Thread Tomi Valkeinen
On Thu, 2010-12-02 at 13:27 +0530, ext Taneja, Archit wrote: Hi, Tomi Valkeinen wrote: Hi, - The files are getting quite crowded with code that checks for the channel and then do the work with bits/irqs depending on the channel. This makes the code a bit difficult to read. I

RE: [PATCH v5 3/7] OMAP: DSS2: Introduce omap_channel as a omap_dss_device parameter

2010-12-02 Thread Taneja, Archit
Hi, [snip] I am assuming that you are referring to 'DISPC_IRQ_MASK_ERROR' and the registering/unregistering of irq masks in manager.c Not only the irqs, but also, for example, code like this: if (channel == OMAP_DSS_CHANNEL_LCD || channel ==

RE: [PATCH v5 3/7] OMAP: DSS2: Introduce omap_channel as a omap_dss_device parameter

2010-12-02 Thread Tomi Valkeinen
On Thu, 2010-12-02 at 15:17 +0530, ext Taneja, Archit wrote: Hi, If you can split this patch into the two parts I suggested (if that's ok for you, you didn't comment on that one), and check if there's anything to add to the commit descriptions, I think we can go and apply this patch set.

RE: [PATCH v5 3/7] OMAP: DSS2: Introduce omap_channel as a omap_dss_device parameter

2010-12-02 Thread Taneja, Archit
Hi, Tomi Valkeinen wrote: On Thu, 2010-12-02 at 15:17 +0530, ext Taneja, Archit wrote: Hi, If you can split this patch into the two parts I suggested (if that's ok for you, you didn't comment on that one), and check if there's anything to add to the commit descriptions, I think we can go

RE: [PATCH v5 3/7] OMAP: DSS2: Introduce omap_channel as a omap_dss_device parameter

2010-12-02 Thread Tomi Valkeinen
On Thu, 2010-12-02 at 16:00 +0530, ext Taneja, Archit wrote: Hi, Unfortunately the panel driver for N800 has not been ported to DSS2. I can possibly try with a 2430sdp, but I don't see the omapdss platform_device board-2430dsp.c. Are you aware of any omap2 setup which I can use to test?

RE: [PATCH v5 3/7] OMAP: DSS2: Introduce omap_channel as a omap_dss_device parameter

2010-12-02 Thread Taneja, Archit
Hi, Tomi Valkeinen wrote: On Thu, 2010-12-02 at 16:00 +0530, ext Taneja, Archit wrote: Hi, Unfortunately the panel driver for N800 has not been ported to DSS2. I can possibly try with a 2430sdp, but I don't see the omapdss platform_device board-2430dsp.c. Are you aware of any omap2 setup

Re: [PATCH v5 3/7] OMAP: DSS2: Introduce omap_channel as a omap_dss_device parameter

2010-12-01 Thread Tomi Valkeinen
Hi, On Mon, 2010-11-22 at 12:53 +0530, ext Archit Taneja wrote: From: Sumit Semwal sumit.sem...@ti.com A new member 'channel' is introduced in omap_dss_device structure to determine which channel the panel uses. The dss_recheck_connections() called in dss_driver_probe() to set the correct

RE: [PATCH v5 3/7] OMAP: DSS2: Introduce omap_channel as a omap_dss_device parameter

2010-12-01 Thread Taneja, Archit
Hi, Tomi Valkeinen wrote: Hi, On Mon, 2010-11-22 at 12:53 +0530, ext Archit Taneja wrote: From: Sumit Semwal sumit.sem...@ti.com A new member 'channel' is introduced in omap_dss_device structure to determine which channel the panel uses. The dss_recheck_connections() called in