RE: [RESEND] [PATCH 1/5] omap2/3/4: mailbox: remove compiler warning

2010-02-23 Thread Anna, Suman
Omar, +#if defined(CONFIG_ARCH_OMAP2420) /* IVA */ err_iva1: - omap_mbox_unregister(mbox_dsp_info); + if (cpu_is_omap2420()) + omap_mbox_unregister(mbox_dsp_info); +#endif why not moving omap_mbox_unregister to the block containing the ifdefs? at least you won't

Re: [RESEND] [PATCH 1/5] omap2/3/4: mailbox: remove compiler warning

2010-02-22 Thread Omar Ramirez Luna
On 2/22/2010 5:41 PM, Anna, Suman wrote: From 657358cd06a3f20bef2472945991749bacef12e6 Mon Sep 17 00:00:00 2001 From: Suman Annas-a...@ti.com Date: Mon, 25 Jan 2010 18:27:21 -0600 Subject: [PATCH] omap2/3/4: mailbox: remove compiler warning Remove a compiler warning in device-specific mailbox

Re: [RESEND] [PATCH 1/5] omap2/3/4: mailbox: remove compiler warning

2010-02-22 Thread Omar Ramirez Luna
On 2/22/2010 5:57 PM, Ramirez Luna, Omar wrote: why not moving omap_mbox_unregister to the block containing the ifdefs? at least you won't be adding an ifdef and if(cpu_xx) i take this back... both statements are needed because of previous registration. - omar -- To unsubscribe from this