RE: [RFC] [PATCH v2 3/4] OMAP4: Keyboard board support

[Pandita, Vikram]

-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Arce, Abraham
Sent: Thursday, May 13, 2010 3:51 PM
To: linux-in...@vger.kernel.org; linux-omap@vger.kernel.org
Subject: [RFC] [PATCH v2 3/4] OMAP4: Keyboard board support

Keyboard support for SDP OMAP4430

Signed-off-by: Abraham Arce x0066...@ti.com
---
 arch/arm/mach-omap2/board-4430sdp.c |  157
+++
 1 files changed, 157 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-
omap2/board-4430sdp.c
index 6cce6f2..19742c5 100644
--- a/arch/arm/mach-omap2/board-4430sdp.c
+++ b/arch/arm/mach-omap2/board-4430sdp.c
@@ -19,6 +19,8 @@
 #include linux/gpio.h
 #include linux/usb/otg.h
 #include linux/spi/spi.h
+#include linux/input.h
+#include linux/input/matrix_keypad.h
...
+
+struct omap_device *od;

Any reason to have this global?

+
+static int __init sdp4430_keypad_init(void)
+{
+  struct omap_hwmod *oh;
+  struct matrix_keypad_platform_data *pdata;
+
...
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [RFC] [PATCH v2 3/4] OMAP4: Keyboard board support

[Arce, Abraham]

Vikram,

 From: Pandita, Vikram

[..]

 +
 +struct omap_device *od;
 
 Any reason to have this global?

Not really... I'll change it local to the keyboard init function, thanks!

Best Regards
Abraham
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html