RE: omap3evm: Doesn't boot at 4fa42e46
-Original Message-
From: Lohithakshan, Ranjith
Sent: Tuesday, February 16, 2010 2:22 PM
To: Premi, Sanjeev
Cc: Tony Lindgren; linux-omap@vger.kernel.org; Lohithakshan, Ranjith
Subject: Re: omap3evm: Doesn't boot at 4fa42e46
This one line change seem to fix the issue on my end
--- a/arch/arm/mach-omap2/mux.c
+++ b/arch/arm/mach-omap2/mux.c
@@ -969,7 +969,7 @@ static void __init omap_mux_init_list(struct
omap_mux *super
}
#endif
-#if defined(CONFIG_OMAP_MUX) defined(CONFIG_DEBUG_FS)
+#ifdef CONFIG_OMAP_MUX
if (!superset-muxnames || !superset-muxnames[0]) {
superset++;
continue;
Not sure why DebugFS need to be defined for the muxname
check. omap3evm
and zoom2/3 dont have DebugFS enabled by default in defconfig and that
could explain why these platforms not booting up.
A formal patch will follow once I get more confirmations that this
change is working.
Ranjith,
The git-bisect brings me here:
premi # g-log-10 78737ae
78737ae : omap: Fix arch/arm/mach-omap2/mux.c: Off by one error
9ecef43 : omap: Fix 3630 mux errors
8d08436 : OMAP2/3: GPMC: ensure valid clock pointer
74005a2 : OMAP2/3: IRQ: ensure valid base address
Kernel boots fine at 8d08436. There was earlier a discussion on 9ecef43 but
it 'seems' to be specific for 3630 only.
But the condition you pointed is added at 9ecef43. So, this IS the problem.
I am also trying to check if 78737ae could also lead to a potential error.
Best regards,
Sanjeev
- Ranjith
On Mon, 15-Feb-10 8:56 PM +0530, Premi, Sanjeev wrote:
-Original Message-
From: Tony Lindgren [mailto:t...@atomide.com]
Sent: Wednesday, February 10, 2010 11:04 PM
To: Premi, Sanjeev
Cc: linux-omap@vger.kernel.org
Subject: Re: omap3evm: Doesn't boot at 4fa42e46
* Premi, Sanjeev pr...@ti.com [100210 09:09]:
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of
Premi, Sanjeev
Sent: Tuesday, February 09, 2010 9:34 PM
To: linux-omap@vger.kernel.org
Subject: RE: omap3evm: Doesn't boot at 4fa42e46
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of
Premi, Sanjeev
Sent: Tuesday, February 09, 2010 9:02 PM
To: linux-omap@vger.kernel.org
Subject: omap3evm: Doesn't boot at 4fa42e46
Hi all,
Just updated my repo to the commit:
commit 4fa42e4679324b0e3c54fb509535eea3923ccb63
Merge: e599f12 c446167
Author: Tony Lindgren t...@atomide.com
Date: Thu Feb 4 20:07:44 2010 -0800
The kernel builds fine; but doesn't boot on the OMAP3EVM.
I have been able to trace the code until rest_init(); but
will need to restart debugging.
There seems to be an exception during execution.
Will continue to dig further. This is just an FYI.
The kernel panics during I2C init in function
omap3_evm_i2c_init()
during this call:
omap_register_i2c_bus(2, 400, NULL, 0);
I see that there isn't any difference between
omap3_evm_i2c_init()
and omap3430_i2c_init(). Has anyone tried the booting 3430SDP at
this commit?
...just trying to understand if this is a board specific issue
OR is it a generic OMAP3 issue before I try bisect.
~sanjeev
uImage created with omap3_defconfig at the HEAD boots fine on the
EVM. I couldn't find much differences between this defconfig and
my .config - related to i2c where the failure occurs.
Maybe post the diff -u of the configs?
Unfortunately bisect didn't help much :( I just know the last
commit where the EVM boots fine (with defconfig).
9b17b59 : Add devkit8000_defconfig
Just a snapshot of git-bisect from my command history:
premi # git-bisect bad f9ffaa9
Some good revs are not ancestor of the bad rev.
git bisect cannot work properly in this case.
Maybe you mistake good and bad revs?
premi #
premi # history | grep bisect | grep good
512 git-bisect good c6348aa
518 git-bisect good a9861b5
523 git-bisect good 9b17b59
premi #
premi # history | grep bisect | grep bad
507 git-bisect bad 4fa42e4
533 git-bisect bad 0b421ec
538 git-bisect bad fc76be4
543 git-bisect bad 66ddfc6
547 git-bisect bad f9ffaa9
premi #
Can you try bisecting the omap for-next branch starting at
9ba874506b7b3883d78b8cad61eba39c4bb09885?
If 9ba874506b7b3883d78b8cad61eba39c4bb09885 does not boot,
then you have to start at 4f4e65d2484811210a2826fa9d59712c7fcf1b49.
Had to step away from the problem fore few days. Started
bisecting now.
~sanjeev
Otherwise you'll end up bisecting all kinds of merges..
Regards,
Tony
--
To unsubscribe from this list: send the line unsubscribe
linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: omap3evm: Doesn't boot at 4fa42e46
* Premi, Sanjeev pr...@ti.com [100216 01:35]:
-Original Message-
From: Lohithakshan, Ranjith
Sent: Tuesday, February 16, 2010 2:22 PM
To: Premi, Sanjeev
Cc: Tony Lindgren; linux-omap@vger.kernel.org; Lohithakshan, Ranjith
Subject: Re: omap3evm: Doesn't boot at 4fa42e46
This one line change seem to fix the issue on my end
--- a/arch/arm/mach-omap2/mux.c
+++ b/arch/arm/mach-omap2/mux.c
@@ -969,7 +969,7 @@ static void __init omap_mux_init_list(struct
omap_mux *super
}
#endif
-#if defined(CONFIG_OMAP_MUX) defined(CONFIG_DEBUG_FS)
+#ifdef CONFIG_OMAP_MUX
if (!superset-muxnames || !superset-muxnames[0]) {
superset++;
continue;
Not sure why DebugFS need to be defined for the muxname
check. omap3evm
and zoom2/3 dont have DebugFS enabled by default in defconfig and that
could explain why these platforms not booting up.
Hmm sounds like that's a bug there. The muxnames are available only during
__init, and optimized out if CONFIG_OMAP_MUX is not set. Initially the
muxnames were there only if CONFIG_DEBUG_FS was set.
A formal patch will follow once I get more confirmations that this
change is working.
Please send a formal patch ASAP so we can get it into 2.6.33.
The git-bisect brings me here:
premi # g-log-10 78737ae
78737ae : omap: Fix arch/arm/mach-omap2/mux.c: Off by one error
9ecef43 : omap: Fix 3630 mux errors
8d08436 : OMAP2/3: GPMC: ensure valid clock pointer
74005a2 : OMAP2/3: IRQ: ensure valid base address
Kernel boots fine at 8d08436. There was earlier a discussion on 9ecef43
but
it 'seems' to be specific for 3630 only.
But the condition you pointed is added at 9ecef43. So, this IS the problem.
I am also trying to check if 78737ae could also lead to a potential error.
The only concernd there AFAIK is that if mode0 names for some yet unknown
mux modes are longer than OMAP_MUX_DEFNAME_LEN.
Regards,
Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: omap3evm: Doesn't boot at 4fa42e46
-Original Message- From: Tony Lindgren [mailto:t...@atomide.com] Sent: Wednesday, February 10, 2010 11:04 PM To: Premi, Sanjeev Cc: linux-omap@vger.kernel.org Subject: Re: omap3evm: Doesn't boot at 4fa42e46 * Premi, Sanjeev pr...@ti.com [100210 09:09]: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Premi, Sanjeev Sent: Tuesday, February 09, 2010 9:34 PM To: linux-omap@vger.kernel.org Subject: RE: omap3evm: Doesn't boot at 4fa42e46 -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Premi, Sanjeev Sent: Tuesday, February 09, 2010 9:02 PM To: linux-omap@vger.kernel.org Subject: omap3evm: Doesn't boot at 4fa42e46 Hi all, Just updated my repo to the commit: commit 4fa42e4679324b0e3c54fb509535eea3923ccb63 Merge: e599f12 c446167 Author: Tony Lindgren t...@atomide.com Date: Thu Feb 4 20:07:44 2010 -0800 The kernel builds fine; but doesn't boot on the OMAP3EVM. I have been able to trace the code until rest_init(); but will need to restart debugging. There seems to be an exception during execution. Will continue to dig further. This is just an FYI. The kernel panics during I2C init in function omap3_evm_i2c_init() during this call: omap_register_i2c_bus(2, 400, NULL, 0); I see that there isn't any difference between omap3_evm_i2c_init() and omap3430_i2c_init(). Has anyone tried the booting 3430SDP at this commit? ...just trying to understand if this is a board specific issue OR is it a generic OMAP3 issue before I try bisect. ~sanjeev uImage created with omap3_defconfig at the HEAD boots fine on the EVM. I couldn't find much differences between this defconfig and my .config - related to i2c where the failure occurs. Maybe post the diff -u of the configs? Unfortunately bisect didn't help much :( I just know the last commit where the EVM boots fine (with defconfig). 9b17b59 : Add devkit8000_defconfig Just a snapshot of git-bisect from my command history: premi # git-bisect bad f9ffaa9 Some good revs are not ancestor of the bad rev. git bisect cannot work properly in this case. Maybe you mistake good and bad revs? premi # premi # history | grep bisect | grep good 512 git-bisect good c6348aa 518 git-bisect good a9861b5 523 git-bisect good 9b17b59 premi # premi # history | grep bisect | grep bad 507 git-bisect bad 4fa42e4 533 git-bisect bad 0b421ec 538 git-bisect bad fc76be4 543 git-bisect bad 66ddfc6 547 git-bisect bad f9ffaa9 premi # Can you try bisecting the omap for-next branch starting at 9ba874506b7b3883d78b8cad61eba39c4bb09885? If 9ba874506b7b3883d78b8cad61eba39c4bb09885 does not boot, then you have to start at 4f4e65d2484811210a2826fa9d59712c7fcf1b49. Had to step away from the problem fore few days. Started bisecting now. ~sanjeev Otherwise you'll end up bisecting all kinds of merges.. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: omap3evm: Doesn't boot at 4fa42e46
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Premi, Sanjeev Sent: Tuesday, February 09, 2010 9:34 PM To: linux-omap@vger.kernel.org Subject: RE: omap3evm: Doesn't boot at 4fa42e46 -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Premi, Sanjeev Sent: Tuesday, February 09, 2010 9:02 PM To: linux-omap@vger.kernel.org Subject: omap3evm: Doesn't boot at 4fa42e46 Hi all, Just updated my repo to the commit: commit 4fa42e4679324b0e3c54fb509535eea3923ccb63 Merge: e599f12 c446167 Author: Tony Lindgren t...@atomide.com Date: Thu Feb 4 20:07:44 2010 -0800 The kernel builds fine; but doesn't boot on the OMAP3EVM. I have been able to trace the code until rest_init(); but will need to restart debugging. There seems to be an exception during execution. Will continue to dig further. This is just an FYI. The kernel panics during I2C init in function omap3_evm_i2c_init() during this call: omap_register_i2c_bus(2, 400, NULL, 0); I see that there isn't any difference between omap3_evm_i2c_init() and omap3430_i2c_init(). Has anyone tried the booting 3430SDP at this commit? ...just trying to understand if this is a board specific issue OR is it a generic OMAP3 issue before I try bisect. ~sanjeev uImage created with omap3_defconfig at the HEAD boots fine on the EVM. I couldn't find much differences between this defconfig and my .config - related to i2c where the failure occurs. Unfortunately bisect didn't help much :( I just know the last commit where the EVM boots fine (with defconfig). 9b17b59 : Add devkit8000_defconfig Just a snapshot of git-bisect from my command history: premi # git-bisect bad f9ffaa9 Some good revs are not ancestor of the bad rev. git bisect cannot work properly in this case. Maybe you mistake good and bad revs? premi # premi # history | grep bisect | grep good 512 git-bisect good c6348aa 518 git-bisect good a9861b5 523 git-bisect good 9b17b59 premi # premi # history | grep bisect | grep bad 507 git-bisect bad 4fa42e4 533 git-bisect bad 0b421ec 538 git-bisect bad fc76be4 543 git-bisect bad 66ddfc6 547 git-bisect bad f9ffaa9 premi # Best regards, Sanjeev Best regards, Sanjeev -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: omap3evm: Doesn't boot at 4fa42e46
* Premi, Sanjeev pr...@ti.com [100210 09:09]: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Premi, Sanjeev Sent: Tuesday, February 09, 2010 9:34 PM To: linux-omap@vger.kernel.org Subject: RE: omap3evm: Doesn't boot at 4fa42e46 -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Premi, Sanjeev Sent: Tuesday, February 09, 2010 9:02 PM To: linux-omap@vger.kernel.org Subject: omap3evm: Doesn't boot at 4fa42e46 Hi all, Just updated my repo to the commit: commit 4fa42e4679324b0e3c54fb509535eea3923ccb63 Merge: e599f12 c446167 Author: Tony Lindgren t...@atomide.com Date: Thu Feb 4 20:07:44 2010 -0800 The kernel builds fine; but doesn't boot on the OMAP3EVM. I have been able to trace the code until rest_init(); but will need to restart debugging. There seems to be an exception during execution. Will continue to dig further. This is just an FYI. The kernel panics during I2C init in function omap3_evm_i2c_init() during this call: omap_register_i2c_bus(2, 400, NULL, 0); I see that there isn't any difference between omap3_evm_i2c_init() and omap3430_i2c_init(). Has anyone tried the booting 3430SDP at this commit? ...just trying to understand if this is a board specific issue OR is it a generic OMAP3 issue before I try bisect. ~sanjeev uImage created with omap3_defconfig at the HEAD boots fine on the EVM. I couldn't find much differences between this defconfig and my .config - related to i2c where the failure occurs. Maybe post the diff -u of the configs? Unfortunately bisect didn't help much :( I just know the last commit where the EVM boots fine (with defconfig). 9b17b59 : Add devkit8000_defconfig Just a snapshot of git-bisect from my command history: premi # git-bisect bad f9ffaa9 Some good revs are not ancestor of the bad rev. git bisect cannot work properly in this case. Maybe you mistake good and bad revs? premi # premi # history | grep bisect | grep good 512 git-bisect good c6348aa 518 git-bisect good a9861b5 523 git-bisect good 9b17b59 premi # premi # history | grep bisect | grep bad 507 git-bisect bad 4fa42e4 533 git-bisect bad 0b421ec 538 git-bisect bad fc76be4 543 git-bisect bad 66ddfc6 547 git-bisect bad f9ffaa9 premi # Can you try bisecting the omap for-next branch starting at 9ba874506b7b3883d78b8cad61eba39c4bb09885? If 9ba874506b7b3883d78b8cad61eba39c4bb09885 does not boot, then you have to start at 4f4e65d2484811210a2826fa9d59712c7fcf1b49. Otherwise you'll end up bisecting all kinds of merges.. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: omap3evm: Doesn't boot at 4fa42e46
Sanjeev/Tony
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Tony
Lindgren
Sent: Wednesday, February 10, 2010 11:34 AM
To: Premi, Sanjeev
Cc: linux-omap@vger.kernel.org
Subject: Re: omap3evm: Doesn't boot at 4fa42e46
* Premi, Sanjeev pr...@ti.com [100210 09:09]:
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Premi, Sanjeev
Sent: Tuesday, February 09, 2010 9:34 PM
To: linux-omap@vger.kernel.org
Subject: RE: omap3evm: Doesn't boot at 4fa42e46
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of
Premi, Sanjeev
Sent: Tuesday, February 09, 2010 9:02 PM
To: linux-omap@vger.kernel.org
Subject: omap3evm: Doesn't boot at 4fa42e46
Hi all,
Just updated my repo to the commit:
commit 4fa42e4679324b0e3c54fb509535eea3923ccb63
Merge: e599f12 c446167
Author: Tony Lindgren t...@atomide.com
Date: Thu Feb 4 20:07:44 2010 -0800
The kernel builds fine; but doesn't boot on the OMAP3EVM.
I have been able to trace the code until rest_init(); but
will need to restart debugging.
There seems to be an exception during execution.
Will continue to dig further. This is just an FYI.
The kernel panics during I2C init in function omap3_evm_i2c_init()
during this call:
omap_register_i2c_bus(2, 400, NULL, 0);
I see that Zoom2/3 also don't boot up and given that DEBUG_LL does not work for
these boards,
its very difficult to narrow down the problem.
After around 2 hours of narrowing down, this is what solves the issue probably:
m0_entry seems to be null, causing strcmp() to crash.
Patch: (will not apply as TABS are not there :) )
diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
index 986077f..d5a03f8 100644
--- a/arch/arm/mach-omap2/mux.c
+++ b/arch/arm/mach-omap2/mux.c
@@ -435,7 +435,7 @@ int __init omap_mux_init_signal(char *muxname, int val)
char *m0_entry = m-muxnames[0];
int i;
- if (m0_name strcmp(m0_name, m0_entry))
+ if (m0_name m0_entry strcmp(m0_name, m0_entry))
continue;
for (i = 0; i OMAP_MUX_NR_MODES; i++) {
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: omap3evm: Doesn't boot at 4fa42e46
* Pandita, Vikram vikram.pand...@ti.com [100210 14:56]:
snip
The kernel panics during I2C init in function omap3_evm_i2c_init()
during this call:
omap_register_i2c_bus(2, 400, NULL, 0);
I see that Zoom2/3 also don't boot up and given that DEBUG_LL does not work
for these boards,
its very difficult to narrow down the problem.
After around 2 hours of narrowing down, this is what solves the issue
probably:
m0_entry seems to be null, causing strcmp() to crash.
Patch: (will not apply as TABS are not there :) )
diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
index 986077f..d5a03f8 100644
--- a/arch/arm/mach-omap2/mux.c
+++ b/arch/arm/mach-omap2/mux.c
@@ -435,7 +435,7 @@ int __init omap_mux_init_signal(char *muxname, int val)
char *m0_entry = m-muxnames[0];
int i;
- if (m0_name strcmp(m0_name, m0_entry))
+ if (m0_name m0_entry strcmp(m0_name, m0_entry))
continue;
for (i = 0; i OMAP_MUX_NR_MODES; i++) {
Hmm is this only with CONFIG_OMAP_MUX and only on 3630?
In for-next we don't have yet the recent mux fix commit
9ecef433204f9b06550dd45cf84f14706f8fe4f0. Can you make sure
you have that applied and see if that solves the problem?
To me it seems that m0_entry should never be NULL after mux
init as that's the signal register name. The 3630 entries should
get populated by omap_mux_init_list.
If omap36xx_cbp_subset is missing some of the 3630 only entries
added by commit 9ecef433204f9b06550dd45cf84f14706f8fe4f0 into
omap3_muxmodes, then that would explain why m0_entry would
be NULL..
Anyways, as I don't have a 3630 here I'm just guessing. Until
you get the DEBUG_LL working on zoom3, you can just increase
the CONFIG_LOG_BUF_SHIFT to something large enough and printk
m0_name and m0_entry without doing anything with them. Then
after the boot you can take a look at dmesg and see if it
provides any clues.
Regards,
Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: omap3evm: Doesn't boot at 4fa42e46
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Premi, Sanjeev Sent: Tuesday, February 09, 2010 9:02 PM To: linux-omap@vger.kernel.org Subject: omap3evm: Doesn't boot at 4fa42e46 Hi all, Just updated my repo to the commit: commit 4fa42e4679324b0e3c54fb509535eea3923ccb63 Merge: e599f12 c446167 Author: Tony Lindgren t...@atomide.com Date: Thu Feb 4 20:07:44 2010 -0800 The kernel builds fine; but doesn't boot on the OMAP3EVM. I have been able to trace the code until rest_init(); but will need to restart debugging. There seems to be an exception during execution. Will continue to dig further. This is just an FYI. The kernel panics during I2C init in function omap3_evm_i2c_init() during this call: omap_register_i2c_bus(2, 400, NULL, 0); I see that there isn't any difference between omap3_evm_i2c_init() and omap3430_i2c_init(). Has anyone tried the booting 3430SDP at this commit? ...just trying to understand if this is a board specific issue OR is it a generic OMAP3 issue before I try bisect. ~sanjeev Best regards, Sanjeev -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
