Re: board_onenand_init() build error in linux-next

2012-06-20 Thread Tony Lindgren
* Joe Woodward j...@terrafix.co.uk [120615 05:51]:
 Someone may have spotted this already...
 
 But if you build todays linux-next (next-20120615) without 
 CONFIG_MTD_ONENAND_OMAP2 or 
 CONFIG_MTD_ONENAND_OMAP2_MODULE then board_onenand_init() is defined in two 
 places 
 (in board-flash.c:102 as an empty function, and board-flash.h:56 as a static 
 inline).
 
 This causes the build to fail as board-flash.c includes board-flash.h:
   CC  arch/arm/mach-omap2/board-flash.o
 arch/arm/mach-omap2/board-flash.c:102:8: error: redefinition of 
 'board_onenand_init'
 arch/arm/mach-omap2/board-flash.h:56:20: note: previous definition of 
 'board_onenand_init' 
 was here
 make[1]: *** [arch/arm/mach-omap2/board-flash.o] Error 1
 
 I'm fairly sure this isn't right!?

Yeah sounds like a bug, got a patch for it?

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


board_onenand_init() build error in linux-next

2012-06-15 Thread Joe Woodward
Someone may have spotted this already...

But if you build todays linux-next (next-20120615) without 
CONFIG_MTD_ONENAND_OMAP2 or 
CONFIG_MTD_ONENAND_OMAP2_MODULE then board_onenand_init() is defined in two 
places 
(in board-flash.c:102 as an empty function, and board-flash.h:56 as a static 
inline).

This causes the build to fail as board-flash.c includes board-flash.h:
  CC  arch/arm/mach-omap2/board-flash.o
arch/arm/mach-omap2/board-flash.c:102:8: error: redefinition of 
'board_onenand_init'
arch/arm/mach-omap2/board-flash.h:56:20: note: previous definition of 
'board_onenand_init' 
was here
make[1]: *** [arch/arm/mach-omap2/board-flash.o] Error 1

I'm fairly sure this isn't right!?

Cheers,
Joe


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html