Re: [PATCH] ARM: OMAP3: cm-t35: fix mux mode for DSS pins

2011-11-06 Thread Igor Grinberg
Hi Tony, This one is stand alone and can be applied to fixes. I will re spin the rest in a couple of hours. Thanks On 10/19/11 18:46, Igor Grinberg wrote: OMAP pin mux configuration API has been used incorrectly resulting in wrong mux mode set for several DSS pins. Signed-off-by: Igor

OMAP CRAP: The Continuing Story Of Brokenness

2011-11-06 Thread Russell King - ARM Linux
Yet again I find that I'm having to email about crap on OMAP3. I'm getting really fed up with OMAP stuff which keeps breaking in idiotic ways - and the way there's fatal build errors at EVERY merge window. The OMAP workflow is totally broken. Something MUST change in the way the OMAP community

Re: OMAP CRAP: The Continuing Story Of Brokenness

2011-11-06 Thread S, Venkatraman
On Sun, Nov 6, 2011 at 5:48 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Yet again I find that I'm having to email about crap on OMAP3. I'm getting really fed up with OMAP stuff which keeps breaking in idiotic ways - and the way there's fatal build errors at EVERY merge window.  

Re: [PATCH 1/4] ARM: OMAP3: cm-t35: add regulator supply for ads7846

2011-11-06 Thread Igor Grinberg
Hi Tony, On 11/05/11 01:57, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [04 16:05]: * Igor Grinberg grinb...@compulab.co.il [111019 02:05]: Applying to board branch for v3.3 merge window. Hmm, actually I suggest you respin patches 2 and 3 so they apply on their own to

Pet Peaves about Platform code, and arch_reset

2011-11-06 Thread Russell King - ARM Linux
Here's a list of my peaves about current platform code - which are causing me great issue when trying to clean up the arch_reset() stuff: 1. Lack of trailing ',' on structure initializers This makes it much harder to add additional initializers at the end of existing initializers, and

[PATCH v2 0/4] ARM: OMAP3: cm-t35/cm-t3730 fixes

2011-11-06 Thread Igor Grinberg
This patch series fixes several issues on boards in subj. It is based on Tony's fixes branch. v2: - Rebase on top of fixes branch - Elaborate more in the commit messages Igor Grinberg (4): ARM: OMAP3: cm-t35: fix ads7846 touchscreen ARM: OMAP3: cm-t35: fix DSS regulator supply

[PATCH v2 1/4] ARM: OMAP3: cm-t35: fix ads7846 touchscreen

2011-11-06 Thread Igor Grinberg
ads7846 driver fails to find the regulator supply and as a result the touchscreen is not working. Fix this by adding a regulator supply for the ads7846 driver. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- v2: - Rebase on top of fixes branch - Elaborate on the problem in

[PATCH v2 2/4] ARM: OMAP3: cm-t35: fix DSS regulator supply

2011-11-06 Thread Igor Grinberg
cm-t35 DSS suplies are connected to VIO. In fact, TPS65930 does not have VPLL2. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- v2: - Rebase on top of fixes branch arch/arm/mach-omap2/board-cm-t35.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) diff --git

[PATCH v2 3/4] ARM: OMAP3: cm-t35: fix audio

2011-11-06 Thread Igor Grinberg
TWL4030 audio codec is not being registered if no platform data is supplied. Provide platform data for the TWL4030 audio codec. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- v2: - Rebase on top of fixes branch - fix the commit message (10x to Sergei)

[PATCH v2 4/4] ARM: OMAP3: cm-t35: fix USB hub

2011-11-06 Thread Igor Grinberg
USB hub is not functional until is reset. Reset the USB hub on SB-T35. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- v2: - Rebase on top of fixes branch - Elaborate on the problem in the commit message arch/arm/mach-omap2/board-cm-t35.c | 22 -- 1

Re: OMAP CRAP: The Continuing Story Of Brokenness

2011-11-06 Thread Per Förlin
On 11/06/2011 01:18 PM, Russell King - ARM Linux wrote: Yet again I find that I'm having to email about crap on OMAP3. I'm getting really fed up with OMAP stuff which keeps breaking in idiotic ways - and the way there's fatal build errors at EVERY merge window. The OMAP workflow is totally

Re: [PATCH] cbus-tahvo: Add tahvo_write_reg locking

2011-11-06 Thread Felipe Balbi
Hi, On Sat, Nov 05, 2011 at 05:19:54PM +0100, Michael Büsch wrote: tahvo_write_reg() needs to take the mutex to avoid a race condition with tahvo_set_clear_reg_bits: tahvo_set_clear_reg_bits(): | tahvo_write_reg(): __tahvo_read_reg()| |

Re: [PATCH 2/4] mmc: omap: adapt the hsmmc driver to device tree

2011-11-06 Thread Rajendra Nayak
On Saturday 05 November 2011 02:55 AM, Cousson, Benoit wrote: +Required properties: +- compatible: Should be ti,omap-hsmmcn, ti,omap2-hsmmc; +n is controller instance starting 0, for OMAP2/3 controllers No, no, no. You should not have to specify the unit-address in the compatible field. They

Re: [PATCH 2/4] mmc: omap: adapt the hsmmc driver to device tree

2011-11-06 Thread Rajendra Nayak
On Saturday 05 November 2011 01:34 AM, Olof Johansson wrote: On Fri, Nov 04, 2011 at 05:20:39PM +0530, Rajendra Nayak wrote: Define dt bindings for the ti-omap-hsmmc, and adapt the driver to extract data (which was earlier passed as platform_data) from device tree node. Signed-off-by: Rajendra

Re: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data

2011-11-06 Thread Rajendra Nayak
Hi Olof, On Saturday 05 November 2011 01:59 AM, Olof Johansson wrote: +- regulator-min-uV: smallest voltage consumers may set +- regulator-max-uV: largest voltage consumers may set +- regulator-uV-offset: Offset applied to voltages to compensate for voltage drops +- regulator-min-uA:

Re: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data

2011-11-06 Thread Rajendra Nayak
On Saturday 05 November 2011 02:52 AM, Olof Johansson wrote: Also, lower-caps is common instead of V and A. On the other hand the case is pretty important for SI units Yeah, true. The fixed regulators used microvolt instead, which could be a good way to do it. Ok, will use microvolt

Re: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data

2011-11-06 Thread Rajendra Nayak
On Saturday 05 November 2011 03:46 AM, Olof Johansson wrote: Yeah, ok, but it shouldn't be part of the description of regulator properties per se. See how gpio does it, defining how a gpio-specifier is crafted. The equivalent should be done for regulators. That seems to be pretty much

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-06 Thread Rajendra Nayak
+- regulator-fixed-gpio: gpio to use for enable control +- regulator-fixed-startup-delay: startup time in microseconds startup-delay-ms ? ok. +- regulator-fixed-enable-high: Polarity of enable GPIO, + 1 = Active High, 0 = Active low Some gpio specifiers allow you to specify active