Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Tomi Valkeinen
Hi, On Wed, 2012-05-23 at 15:08 -0500, Andy Gross wrote: Register OMAP DRM/KMS platform device. DMM is split into a separate device using hwmod. Signed-off-by: Andy Gross andy.gr...@ti.com snip +static int __init omap_init_drm(void) +{ + struct omap_hwmod *oh = NULL; + struct

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Clark, Rob
On Thu, May 24, 2012 at 12:01 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Wed, 2012-05-23 at 15:08 -0500, Andy Gross wrote: Register OMAP DRM/KMS platform device.  DMM is split into a separate device using hwmod. Signed-off-by: Andy Gross andy.gr...@ti.com snip +static int

Re: MFD USB host: prevents CORE retention in idle

2012-05-24 Thread Munegowda, Keshava
On Thu, May 24, 2012 at 5:55 AM, Kevin Hilman khil...@ti.com wrote: On 05/23/2012 05:01 PM, Kevin Hilman wrote: Hi Keshava, Using current l-o master, I noticed that CORE was not hitting retention in idle on my 3530/Overo.  CORE hits retention on suspend just fine. Debugging this, I found

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Tomi Valkeinen
On Thu, 2012-05-24 at 00:27 -0600, Clark, Rob wrote: On Thu, May 24, 2012 at 12:01 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Wed, 2012-05-23 at 15:08 -0500, Andy Gross wrote: Register OMAP DRM/KMS platform device. DMM is split into a separate device using hwmod.

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Tomi Valkeinen
On Thu, 2012-05-24 at 10:05 +0300, Tomi Valkeinen wrote: On Thu, 2012-05-24 at 00:27 -0600, Clark, Rob wrote: On Thu, May 24, 2012 at 12:01 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Wed, 2012-05-23 at 15:08 -0500, Andy Gross wrote: Register OMAP DRM/KMS platform

RE: [PATCH-V3 3/3] ARM: OMAP3+: clock33xx: Add AM33XX clock tree data

2012-05-24 Thread Paul Walmsley
Hi On Wed, 23 May 2012, Hiremath, Vaibhav wrote: I believe register read/write to IP block is depends on only interface Clocks? Atleast in case of OMAP3, it was like that, right?? No, on OMAP3, most modules need both the interface clock enabled, and at least one of their functional clocks.

Re: [PATCH 0/2] OMAPDSS: write-through caching support for omapfb

2012-05-24 Thread Tomi Valkeinen
On Tue, 2012-05-22 at 22:54 +0300, Siarhei Siamashka wrote: This is a very simple few-liner patchset, which allows to optionally enable write-through caching for OMAP DSS framebuffer. The problem with the current writecombine cacheability attribute is that it only speeds up writes. Uncached

Re: [PATCH] ARM: OMAP: PM: Lock clocks list while generating summary

2012-05-24 Thread Paul Walmsley
On Fri, 18 May 2012, Nishanth Menon wrote: From: Todd Poynor toddpoy...@google.com commit a53025724052b2b1edbc982a4a248784638f563d (OMAP: Add debugfs node to show the summary of all clocks) Introduced clock summary, however, we are interested in seeing snapshot of the clock state, not in

Re: [PATCH] ARM: OMAP3+: dpll: optimize noncore dpll locking logic

2012-05-24 Thread Paul Walmsley
Hi Nishanth On Fri, 18 May 2012, Nishanth Menon wrote: From: Vikram Pandita vikram.pand...@ti.com If the dpll is already locked, code can be optimized to return much earlier than doing redundent set of lock mode and wait on idlest. Cc: Tony Lindgren t...@atomide.com Cc: Jon Hunter

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Rob Clark
On Thu, May 24, 2012 at 1:05 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Thu, 2012-05-24 at 00:27 -0600, Clark, Rob wrote: On Thu, May 24, 2012 at 12:01 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Wed, 2012-05-23 at 15:08 -0500, Andy Gross wrote: Register OMAP DRM/KMS

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Rob Clark
On Thu, May 24, 2012 at 1:21 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Thu, 2012-05-24 at 10:05 +0300, Tomi Valkeinen wrote: On Thu, 2012-05-24 at 00:27 -0600, Clark, Rob wrote: On Thu, May 24, 2012 at 12:01 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Wed,

[PATCH] Fix OMAP4 boot regression

2012-05-24 Thread Russell King - ARM Linux
Fix a boot regression in existing kernels causing: genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq XXX caused by 1c6c6952 (genirq: Reject bogus threaded irq requests). Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk -- drivers/mmc/host/omap_hsmmc.c |2 +-

Re: [PATCH] remoteproc: block premature rproc booting

2012-05-24 Thread Stephen Boyd
On 5/22/2012 4:51 AM, Ohad Ben-Cohen wrote: When an rproc instance is registered, remoteproc asynchronously loads its firmware in order to tell which vdevs it supports. Later on those vdevs are registered, and when probed, their drivers usually trigger powering on of the remote processor.

Re: [PATCH] Fix OMAP4 boot regression

2012-05-24 Thread S, Venkatraman
On Thu, May 24, 2012 at 2:34 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Fix a boot regression in existing kernels causing: genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq XXX caused by 1c6c6952 (genirq: Reject bogus threaded irq requests).

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Tomi Valkeinen
On Thu, 2012-05-24 at 02:35 -0600, Rob Clark wrote: On Thu, May 24, 2012 at 1:05 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Thu, 2012-05-24 at 00:27 -0600, Clark, Rob wrote: On Thu, May 24, 2012 at 12:01 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Wed,

Re: v3.4-rc4 DSS PM problem (Was: Re: Problems with 3.4-rc5)

2012-05-24 Thread Tomi Valkeinen
On Wed, 2012-05-16 at 12:09 +0200, Cousson, Benoit wrote: Hi Tomi, On 5/16/2012 11:08 AM, Tomi Valkeinen wrote: Disabling DPLL3 autoidle fixes the problem. Disabling DPLL4 autoidle doesn't affect the problem. The issues your are facing seems to be the well known DSS low power refresh

Re: [PATCH] ARM: OMAP3+: dpll: optimize noncore dpll locking logic

2012-05-24 Thread Menon, Nishanth
On Thu, May 24, 2012 at 2:49 AM, Paul Walmsley p...@pwsan.com wrote: Hi Nishanth On Fri, 18 May 2012, Nishanth Menon wrote: From: Vikram Pandita vikram.pand...@ti.com If the dpll is already locked, code can be optimized to return much earlier than doing redundent set of lock mode and wait

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Gross, Andy
On Thu, May 24, 2012 at 1:01 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: +struct omap_drm_platform_data { +     struct omap_kms_platform_data *kms_pdata; +}; This one is missing struct omap_dmm_platform_data *dmm_pdata, so you didn't just move the struct. Is that on purpose? Good point.

Re: [PATCH] ARM: OMAP3+: dpll: optimize noncore dpll locking logic

2012-05-24 Thread Paul Walmsley
On Thu, 24 May 2012, Menon, Nishanth wrote: On Thu, May 24, 2012 at 2:49 AM, Paul Walmsley p...@pwsan.com wrote: On Fri, 18 May 2012, Nishanth Menon wrote: From: Vikram Pandita vikram.pand...@ti.com If the dpll is already locked, code can be optimized to return much earlier than

Re: [PATCH] ARM: OMAP3+: dpll: optimize noncore dpll locking logic

2012-05-24 Thread Menon, Nishanth
On Thu, May 24, 2012 at 9:57 AM, Paul Walmsley p...@pwsan.com wrote: Okay.  As I understand it, the maintainers above me would like Signed-off-by:s from the entire submission patch, even if there are no contributions to the patch itself.  So please let me know if it's okay for me to add your

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Gross, Andy
On Thu, May 24, 2012 at 7:13 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Thu, 2012-05-24 at 02:44 -0600, Rob Clark wrote: but other drivers *can* use tiler, thanks to dmabuf.. I have omap4iss v4l2 camera working w/ tiler buffers on my pandaboard, for example. Maybe fbdev is an

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Tomi Valkeinen
On Thu, 2012-05-24 at 10:09 -0500, Gross, Andy wrote: On Thu, May 24, 2012 at 7:13 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Thu, 2012-05-24 at 02:44 -0600, Rob Clark wrote: but other drivers *can* use tiler, thanks to dmabuf.. I have omap4iss v4l2 camera working w/ tiler buffers

Re: [PATCH 0/2] OMAP: mailbox initial device tree support

2012-05-24 Thread Cousson, Benoit
On 5/2/2012 7:42 AM, Bedia, Vaibhav wrote: Hi Omar, On Tue, May 01, 2012 at 23:17:38, Omar Ramirez Luna wrote: To allow mailbox driver to function with device tree. Tested in OMAP4 and OMAP3. OMAP2 untested. I think the mailbox code needs a cleanup similar to what you had proposed earlier

Re: [PATCH 2/2] arm/dts: OMAP2+: Add mailbox nodes

2012-05-24 Thread Cousson, Benoit
On 5/1/2012 7:47 PM, Omar Ramirez Luna wrote: Add nodes for mailbox DT, to interface with hwmods. Signed-off-by: Omar Ramirez Lunaomar.l...@linaro.org Acked-by: Benoit Cousson b-cous...@ti.com --- arch/arm/boot/dts/omap2.dtsi |5 + arch/arm/boot/dts/omap3.dtsi |5 +

Re: v3.4-rc4 DSS PM problem (Was: Re: Problems with 3.4-rc5)

2012-05-24 Thread Paul Walmsley
On Wed, 16 May 2012, Tomi Valkeinen wrote: JFYI, I also tested changing DISPC's SYSCONFIG:CLOCKACTIVITY, which, to me, sounds a bit related to dpll autoidle. By default it's 0, interface and functional clocks can be switched off. I tested the three other values, but none of them had any

[PATCH] staging: omapdrm: Fix error paths during dmm init

2012-05-24 Thread Andy Gross
Failures during the dmm probe can cause the kernel to crash. Moved the spinlock to a global and moved list initializations immediately after the allocation of the dmm private structure. Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm/omap_dmm_priv.h |1 -

[PATCH] staging: omapdrm: fix crash when freeing bad fb

2012-05-24 Thread Andy Gross
During unload, don't cleanup the framebuffer if it is not valid. Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm/omap_fbdev.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/omapdrm/omap_fbdev.c

Re: MFD USB host: prevents CORE retention in idle

2012-05-24 Thread Kevin Hilman
Munegowda, Keshava keshava_mgo...@ti.com writes: On Thu, May 24, 2012 at 5:55 AM, Kevin Hilman khil...@ti.com wrote: On 05/23/2012 05:01 PM, Kevin Hilman wrote: Hi Keshava, Using current l-o master, I noticed that CORE was not hitting retention in idle on my 3530/Overo.  CORE hits

Re: [PATCH V3 00/10] PM: Create the AVS(Adaptive Voltage Scaling)

2012-05-24 Thread Kevin Hilman
J, KEERTHY j-keer...@ti.com writes: On Tue, May 15, 2012 at 11:16 AM, J, KEERTHY j-keer...@ti.com wrote: On Tue, May 8, 2012 at 5:21 AM, Kevin Hilman khil...@ti.com wrote: Rafael, Keerthy j-keer...@ti.com writes: From: J Keerthy j-keer...@ti.com AVS(Adaptive Voltage Scaling) is a power

usage of sparse or other trick for improved type safety

2012-05-24 Thread Woodruff, Richard
Hi Tony, I am hoping to solicit an opinion from you for OMAP frameworks in general. In some recent review there was some debate about how it was good practice to form parameters in a way which didn't get misused. Nishanth was having some experience where end users doing custom ports made some

Re: [PATCH] staging: omapdrm: Fix error paths during dmm init

2012-05-24 Thread Rob Clark
On Thu, May 24, 2012 at 10:43 AM, Andy Gross andy.gr...@ti.com wrote: Failures during the dmm probe can cause the kernel to crash.  Moved the spinlock to a global and moved list initializations immediately after the allocation of the dmm private structure. Signed-off-by: Andy Gross

Re: [PATCH] staging: omapdrm: fix crash when freeing bad fb

2012-05-24 Thread Rob Clark
On Thu, May 24, 2012 at 10:44 AM, Andy Gross andy.gr...@ti.com wrote: During unload, don't cleanup the framebuffer if it is not valid. Signed-off-by: Andy Gross andy.gr...@ti.com Reviewed-by: Rob Clark rob.cl...@linaro.org ---  drivers/staging/omapdrm/omap_fbdev.c |   10 +++---  1

Re: [PATCH] staging: omapdrm: fix crash when freeing bad fb

2012-05-24 Thread Rob Clark
On Thu, May 24, 2012 at 10:44 AM, Andy Gross andy.gr...@ti.com wrote: During unload, don't cleanup the framebuffer if it is not valid. Signed-off-by: Andy Gross andy.gr...@ti.com Reviewed-by: Rob Clark rob.cl...@linaro.org ---  drivers/staging/omapdrm/omap_fbdev.c |   10 +++---  1

Re: [PATCH 0/4] omap legacy full speed usb cleanup for v3.6

2012-05-24 Thread Paul Walmsley
On Mon, 21 May 2012, Tony Lindgren wrote: This series removes the old legacy fulls speed support for omap2 as it's pretty much only used for omap1 only. For omap2, only n8x0 seems to have active development, and that has the external high speed tusb chip instead. Just FYI, full speed host

Re: [PATCH] OMAP4+: hwmod: fix issue causing IPs not going back to Smart-Standby

2012-05-24 Thread Paul Walmsley
On Fri, 20 Apr 2012, Djamil Elaidi wrote: If an IP is configured in Smart-Standby-Wakeup, when disabling wakeup feature the IP will not go back to Smart-Standby, but will remain in Smart-Standby-Wakeup. Signed-off-by: Djamil Elaidi d-ela...@ti.com Thanks, queued for 3.5-rc fixes. - Paul

Re: [PATCH] remoteproc: block premature rproc booting

2012-05-24 Thread Ohad Ben-Cohen
Hi Stephen, On Thu, May 24, 2012 at 12:15 PM, Stephen Boyd sb...@codeaurora.org wrote: The request_firmware timeout is defaulted to 60 seconds but not necessarily 60 if the user has changed the timeout in sysfs. .. Why does this need to be a timeout at all? Presumably

RE: [PATCH-V3 3/3] ARM: OMAP3+: clock33xx: Add AM33XX clock tree data

2012-05-24 Thread Hiremath, Vaibhav
On Thu, May 24, 2012 at 13:01:11, Paul Walmsley wrote: Hi On Wed, 23 May 2012, Hiremath, Vaibhav wrote: I believe register read/write to IP block is depends on only interface Clocks? Atleast in case of OMAP3, it was like that, right?? No, on OMAP3, most modules need both the

RE: [PATCH-V3 3/3] ARM: OMAP3+: clock33xx: Add AM33XX clock tree data

2012-05-24 Thread Paul Walmsley
On Thu, 24 May 2012, Hiremath, Vaibhav wrote: On Thu, May 24, 2012 at 13:01:11, Paul Walmsley wrote: On Wed, 23 May 2012, Hiremath, Vaibhav wrote: I came across situation where, two modules fall into different clock domains but their functional clock is happened to be coming from

Re: MFD USB host: prevents CORE retention in idle

2012-05-24 Thread Kevin Hilman
Kevin Hilman khil...@ti.com writes: Munegowda, Keshava keshava_mgo...@ti.com writes: On Thu, May 24, 2012 at 5:55 AM, Kevin Hilman khil...@ti.com wrote: On 05/23/2012 05:01 PM, Kevin Hilman wrote: Hi Keshava, Using current l-o master, I noticed that CORE was not hitting retention in idle

Re: [linux-pm] [PATCH V3 00/10] PM: Create the AVS(Adaptive Voltage Scaling)

2012-05-24 Thread Kevin Hilman
Menon, Nishanth n...@ti.com writes: On Wed, May 9, 2012 at 1:29 PM, Kevin Hilman khil...@ti.com wrote: Woodruff, Richard r-woodru...@ti.com writes: From: Hilman, Kevin Sent: Tuesday, May 08, 2012 5:17 PM A basic OMAP AVS driver has been in mainline for a long time, yet we have not seen

Re: v3.4-rc4 DSS PM problem (Was: Re: Problems with 3.4-rc5)

2012-05-24 Thread Paul Walmsley
cc Jean Hello Tomi, On Wed, 16 May 2012, Tomi Valkeinen wrote: I also suspect that this could be just a plain DSS bug. The default FIFO low/high thresholds are 960/1023 bytes (i.e. DSS starts refilling the FIFO when there are 960 or less bytes in the fifo, and stops at 1023. The fifo is