On Mon, Jul 27, 2015 at 11:16:14AM +0200, Robert Baldyga wrote:
Convert endpoint configuration to new capabilities model.
Fixed typo in epc-nulk to epc-bulk.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/staging/emxx_udc/emxx_udc.c | 60
On 29/07/15 17:08, nick wrote:
On 2015-07-29 09:52 AM, Roger Quadros wrote:
On 29/07/15 15:13, nick wrote:
On 2015-07-29 08:06 AM, Roger Quadros wrote:
Tony,
On 13/07/15 15:40, Tony Lindgren wrote:
* Roger Quadros rog...@ti.com [150713 03:07]:
Tony,
On 13/07/15 10:10, Tony Lindgren
On 29/07/15 18:26, nick wrote:
On 2015-07-29 11:12 AM, Roger Quadros wrote:
On 29/07/15 17:08, nick wrote:
On 2015-07-29 09:52 AM, Roger Quadros wrote:
On 29/07/15 15:13, nick wrote:
On 2015-07-29 08:06 AM, Roger Quadros wrote:
Tony,
On 13/07/15 15:40, Tony Lindgren wrote:
* Roger
On Mon, 23 Mar 2015 13:14:50 +0100 jake42
jak...@rommel.stw.uni-erlangen.de wrote:
Hello Neil,
some suggestions:
On 23.03.2015 00:20, NeilBrown wrote:
From: NeilBrown ne...@suse.de
diff --git a/Documentation/ABI/testing/sysfs-class-power-twl4030
On 07/29/2015 06:09 AM, Kishon Vijay Abraham I wrote:
For beagle x15, both the vdd and io lines are connected to the
same regulator (ldo1_reg). However vmmc_aux is populated to vdd_3v3.
Remove it.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
Now that twl4030_bci_probe can safely return -EPROBE_DEFER,
do so when devm_usb_get_phy_by_node returns that error.
Signed-off-by: NeilBrown n...@brown.name
---
drivers/power/twl4030_charger.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
From: Pavel Machek pa...@ucw.cz
Drivers using module_platform_driver_probe cannot return
EPROBE_DEFER from the probe function, which makes them rather useless
these days...
Convert to module_platform_driver() so EPROBE_DEFER can be used.
Signed-off-by: Pavel Machek pa...@ucw.cz
Signed-off-by:
The twl4030 allows control of the incoming current.
Part of this control is a 'CGAIN' setting which doubles
the range for half the precision. This control affects
several different current setting, so all need to be updated
at once when CGAIN is changed.
With this patch, all of these current
Following is most of my twl4030_charger patches, rebased against
git://git.infradead.org/battery-2.6
Since the previous set I have added the conversion to
module_platform_driver so EPROBE_DEFER can be used, and fixed
a few minor typos.
This does not include the changes to add extcon support,
'max_current' sysfs attributes are created which allow the
max to be set.
Whenever a current source changes, the default is restored.
This will be followed by a uevent, so user-space can decide to
update again.
Acked-by: Pavel Machek pa...@ucw.cz
Signed-off-by: NeilBrown n...@brown.name
---
The usb phy driver already determines when VBUS is available,
so repeating the test in the charger driver is pointless duplication.
On probe, process the last event from the phy, and from then on,
do whatever the phy tells us without double-checking.
Signed-off-by: NeilBrown n...@brown.name
---
'off' or 'auto' to
/sys/class/power/twl4030_usb/mode
will now enable or disable charging from USB port. Normally this is
enabled on 'plug' and disabled on 'unplug'.
Unplug will still disable charging. 'plug' will only enable it if
'auto' if selected.
Acked-by: Pavel Machek pa...@ucw.cz
The twl4030 charger has two current sources, 'USB' and 'AC'
(presumably Accessory Charger because it isn't Alternating Current).
If 'AC' is providing current, we should set the current limit
differently to when it isn't (and so USB is used).
So split 'cur' into 'usb_cur' and 'ac_cur' and use
We will need this calculation in other places, so
create functions to map between register value and uA value.
Acked-by: Pavel Machek pa...@ucw.cz
Signed-off-by: NeilBrown n...@brown.name
---
drivers/power/twl4030_charger.c | 48 ---
1 file changed, 35
The twl4030 usb phy needs to be active while we are using
the USB VBUS as a current source for charging.
In particular, the usb3v1 regulator must be enabled and the
PHY_PWR_PHYPWD bit must be set to keep the phy powered.
commit ab37813f4093a5f59cb8e083cde277289dc72ed3
twl4030_charger: Allow
This allows AC charging to be turned off, much like usb charging.
continuous mode is not available though.
Acked-by: Pavel Machek pa...@ucw.cz
Signed-off-by: NeilBrown n...@brown.name
---
.../ABI/testing/sysfs-class-power-twl4030 | 10 ++
drivers/power/twl4030_charger.c
On 07/23/2015 09:05 PM, R, Vignesh wrote:
On 7/16/2015 9:01 PM, R, Vignesh wrote:
Hi,
On 07/16/2015 03:24 AM, Paul Walmsley wrote:
Hi,
some comments.
On Wed, 3 Jun 2015, Vignesh R wrote:
Add hwmod entries for the PWMSS on DRA7.
Set l4_root_clk_div as the main_clk of PWMSS. It is
On 07/27/2015 02:24 PM, Kishon Vijay Abraham I wrote:
vsel_reg and enable_reg of the pbias regulator descriptor should actually
have the offset from syscon. However after the pbias device tree node
is moved as a child node of syscon, vsel_reg and enable_reg has the
absolute address because of
On 07/27/2015 03:16 PM, Kishon Vijay Abraham I wrote:
pbias device creation got broken once SCM cleanup got merged.
This patch series re-enables device creation by adding
simple-bus in the compatible property of the syscon
dt node.
validated this series in DRA72, OMAP4 PANDA and OMAP5 UEVM
On Di, 2015-07-14 at 14:12 +0200, Wolfram Sang wrote:
On Tue, Jul 14, 2015 at 03:10:01PM +0300, Grygorii Strashko wrote:
Hi Wolfram,
On 07/14/2015 02:10 PM, Wolfram Sang wrote:
On Wed, Jul 08, 2015 at 04:35:27PM +0200, Jan Luebbe wrote:
At least on the AM335x, enabling
No functional change. Cleanup omap_hsmmc_set_power by adding separate
functions for enable/disable supply and invoke it from
omap_hsmmc_set_power.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
drivers/mmc/host/omap_hsmmc.c | 101 +++--
1 file
No functional change. Instead of using our own vcc and vcc_aux
members, use vmmc and vqmmc present in mmc_host which is present
for the same purpose.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Reviewed-by: Roger Quadros rog...@ti.com
---
drivers/mmc/host/omap_hsmmc.c | 63
If the regulator is enabled on boot (checked using regulator_is_enabled),
invoke regulator_enable() so that the usecount reflects the correct
state of the regulator and then disable the regulator so that the
initial state of the regulator is disabled. Avoid using -set_power,
since set_power also
For beagle x15, both the vdd and io lines are connected to the
same regulator (ldo1_reg). However vmmc_aux is populated to vdd_3v3.
Remove it.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
arch/arm/boot/dts/am57xx-beagle-x15.dts |1 -
1 file changed, 1 deletion(-)
diff --git
If the vmmc regulator provides a valid ocrmask, use it. By this even if
the pdata has a valid ocrmask, it will be overwritten with the ocrmask
of the vmmc regulator.
Also remove the unnecessary compatibility check between the ocrmask in
the pdata and the ocrmask from the vmmc regulator.
enable vmmc_aux regulator only if it is in disabled state and disable
vmmc_aux regulator only if it is in enabled state.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
drivers/mmc/host/omap_hsmmc.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
vdd voltage is set in mmc core to ios-vdd and vmmc should actually
be set to this voltage. Modify omap_hsmmc_enable_supply
to not take vdd as argument since now it's directly set to
the voltage in ios-vdd.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
drivers/mmc/host/omap_hsmmc.c |
Use regulator_is_enabled of pbias regulator to find pbias regulator
status instead of maintaining a custom bookkeeping
pbias_enabled variable.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
drivers/mmc/host/omap_hsmmc.c |8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
Now that support for platforms which have optional regulator is added,
remove CONFIG_REGULATOR check in omap_hsmmc.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
drivers/mmc/host/omap_hsmmc.c | 35 +++
1 file changed, 3 insertions(+), 32 deletions(-)
No functional change. Cleanup omap_hsmmc_set_power by adding separate
functions to set pbias and invoke it from omap_hsmmc_set_power.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
drivers/mmc/host/omap_hsmmc.c | 78 +
1 file changed, 48
From: Roger Quadros rog...@ti.com
For platforms that doesn't have explicit regulator control in MMC,
populate voltage-ranges in MMC device tree node and use
mmc_of_parse_voltage to get ocr_avail
Signed-off-by: Roger Quadros rog...@ti.com
Signed-off-by: Lokesh Vutla lokeshvu...@ti.com
Since vmmc can be optional for some platforms, use
devm_regulator_get_optional() for vmmc. Now return error only
in the case of -EPROBE_DEFER and for all other cases set
host-vcc to NULL.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
drivers/mmc/host/omap_hsmmc.c |8 +---
1
No functional change. Instead of using a local regulator variable
in omap_hsmmc_reg_get() for holding the return value of
devm_regulator_get_optional() and then assigning to omap_hsmmc_host
regulator members: vcc, vcc_aux and pbias, directly use the
omap_hsmmc_host regulator members.
Fix omap_hsmmc_set_power so that pbias regulator is not enabled
during power off.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
drivers/mmc/host/omap_hsmmc.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c
This patch series does the following
*) Uses devm_regulator_get_optional() for vmmc and then removes the
CONFIG_REGULATOR check altogether.
*) return on -EPROBE_DEFER
*) enable/disable vmmc_aux regulator based on prior state
This series is in preparation for implementing the voltage switch
Return error if any of the regulator APIs (regulator_enable,
regulator_disable, regulator_set_voltage) fails in
omap_hsmmc_set_power to avoid undefined behavior.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
drivers/mmc/host/omap_hsmmc.c | 52 +++--
EPROBE_DEFER is not fatal and it means the regulator can still be
obtained. Hence return error if devm_regulator_get_optional for
vmmc_aux and pbias returns -EPROBE_DEFER. This gives omap_hsmmc
driver another chance to get these regulators.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
Remove the unnecessary pbias regulator_set_voltage done after
pbias regulator_disable in omap_hsmmc_set_power.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Reviewed-by: Roger Quadros rog...@ti.com
---
drivers/mmc/host/omap_hsmmc.c |1 -
1 file changed, 1 deletion(-)
diff --git
Tony,
On 13/07/15 15:40, Tony Lindgren wrote:
* Roger Quadros rog...@ti.com [150713 03:07]:
Tony,
On 13/07/15 10:10, Tony Lindgren wrote:
* Roger Quadros rog...@ti.com [150710 05:26]:
Since the Interrupt Events are used only by the NAND driver,
there is no point in managing the Interrupt
On 07/29/2015 02:09 PM, Kishon Vijay Abraham I wrote:
Since vmmc can be optional for some platforms, use
devm_regulator_get_optional() for vmmc. Now return error only
in the case of -EPROBE_DEFER and for all other cases set
host-vcc to NULL.
Signed-off-by: Kishon Vijay Abraham I
If it cannot, we will stop pulling more current when voltage drops.
Signed-off-by: NeilBrown n...@brown.name
---
drivers/power/twl4030_charger.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c
index
The USB Battery Charging spec (BC1.2) suggests a dedicated
charging port can deliver from 0.5 to 5.0A at between 4.75 and 5.25
volts.
To choose the correct current voltage setting requires a trial
and error approach: try to draw current and see if the voltage drops
too low.
Even with a
Add a 'continuous' option for usb charging which enables
the linear charging mode of the twl4030.
Linear charging does a good job with not-so-reliable power sources.
Auto mode does not work well as it switches off when voltage drops
momentarily. Care must be taken not to over-charge.
It was
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Monday, July 27, 2015 8:38 PM
To: Badola Nikhil-B46172
Cc: ba...@ti.com; linux-ker...@vger.kernel.org; linux-...@vger.kernel.org;
linux-omap@vger.kernel.org; gre...@linuxfoundation.org
Subject: Re: [PATCH 2/3]
On 29/07/15 15:13, nick wrote:
On 2015-07-29 08:06 AM, Roger Quadros wrote:
Tony,
On 13/07/15 15:40, Tony Lindgren wrote:
* Roger Quadros rog...@ti.com [150713 03:07]:
Tony,
On 13/07/15 10:10, Tony Lindgren wrote:
* Roger Quadros rog...@ti.com [150710 05:26]:
Since the Interrupt
Hi,
On Wed, Jul 29, 2015 at 11:19:01AM +, Badola Nikhil wrote:
yet another problem is that this register doesn't exist in *all*
versions of DWC3. It was introduced in version 2.50a so the branch I
typed above needs one extra check, and since it's getting so large,
it deserves
46 matches
Mail list logo
