[PATCH] arm: omap3: igep0020: Add console default kernel arguments

2012-12-20 Thread Ezequiel Garcia
IGEP v2 boards has console as ttyO2,115200n8. It's better so simply set this as the default kernel argument directly in the device tree board file. Cc: Enric Balletbo i Serra eballe...@gmail.com Cc: Javier Martinez Canillas jav...@dowhile0.org Signed-off-by: Ezequiel Garcia ezequiel.gar...@free

Re: [PATCH 0/8] Flip on multiplatform support for omap2plus for v3.9

2012-12-20 Thread Ezequiel Garcia
Hello Tony, On Thu, Dec 20, 2012 at 12:55 PM, Tony Lindgren t...@atomide.com wrote: * Tony Lindgren t...@atomide.com [121219 11:28]: Hi all, These patches enable multiplatform support for omap2plus. To build and boot it against the current mainline kernel you need the following: [PATCH

Re: [PATCH 0/8] Flip on multiplatform support for omap2plus for v3.9

2012-12-21 Thread Ezequiel Garcia
successfully booted my IGEPv2 board using: * arm-soc/for-next * igep DT patches * this multiplatform series * the two patches mentioned above With this series CONFIG_MACH_IGEP0020 is not needed, just CONFIG_MACH_OMAP_GENERIC is selected. So I guess this means, for igep v2, Tested-by: Ezequiel

Re: [RESEND PATCH] leds: leds-gpio: set devm_gpio_request_one() flags correctly

2012-12-21 Thread Ezequiel Garcia
) ? + GPIOF_OUT_INIT_HIGH : GPIOF_OUT_INIT_LOW, + template-name); if (ret 0) return ret; -- 1.7.7.6 Without this patch my IGEP v2 LEDs were dead, and this patch brings them back. Tested-by: Ezequiel Garcia ezequiel.gar...@free

Re: [PATCH] arm: omap3: igep0020: Add console default kernel arguments

2012-12-22 Thread Ezequiel Garcia
Hi Enric and Javier, The u-boot 'bootargs' env overwrites the one from chosen ? I just tested and U-Boot 'bootargs' has precedence over DT bootargs but I didn't find a way to append boot parameters from U-Boot. You can either overwrite it completely or not. Yes. That seems to be the

Re: [PATCH] arm: omap3: igep0020: Add console default kernel arguments

2012-12-23 Thread Ezequiel Garcia
On Sun, Dec 23, 2012 at 3:22 PM, Javier Martinez Canillas martinez.jav...@gmail.com wrote: On Sat, Dec 22, 2012 at 3:17 PM, Ezequiel Garcia elezegar...@gmail.com wrote: Hi Enric and Javier, The u-boot 'bootargs' env overwrites the one from chosen ? I just tested and U-Boot 'bootargs' has

Re: [PATCH v8 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-12-23 Thread Ezequiel Garcia
Hi Daniel, Nice job! On Fri, Dec 14, 2012 at 7:36 AM, Daniel Mack zon...@gmail.com wrote: This patch adds basic DT bindings for OMAP GPMC. The actual peripherals are instantiated from child nodes within the GPMC node, and the only type of device that is currently supported is NAND. Code

[PATCH 0/3] OMAP GPMC OneNAND DT bindings

2012-12-23 Thread Ezequiel Garcia
Hi everyone, Just in case anyone wants to access his OneNAND device, here's a little patchset. Feedback is more than welcome. It's based on arm-soc/for-next with Daniel Mack's GPMC patches. Ezequiel Garcia (3): mtd: omap-onenand: pass device_node in platform data arm: omap2: gpmc-onenand

[PATCH 1/3] mtd: omap-onenand: pass device_node in platform data

2012-12-23 Thread Ezequiel Garcia
-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- drivers/mtd/onenand/omap2.c |4 +++- include/linux/platform_data/mtd-onenand-omap2.h |3 +++ 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c

[PATCH 2/3] arm: omap2: gpmc-onenand: drop __init annotation

2012-12-23 Thread Ezequiel Garcia
gpmc_onenand_init() will be called from another driver's probe() function, so drop the __init annotation, in order to prevent section mismatches. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-onenand.c |2 +- 1 files changed, 1 insertions

[PATCH 3/3] arm: omap2: gpmc: add DT bindings for OneNAND

2012-12-23 Thread Ezequiel Garcia
This patch adds device tree bindings for OMAP OneNAND devices. Tested on an OMAP3 3430 IGEPv2 board. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- .../devicetree/bindings/mtd/gpmc-onenand.txt | 44 arch/arm/mach-omap2/gpmc.c

Re: [PATCH 3/3] arm: omap2: gpmc: add DT bindings for OneNAND

2012-12-23 Thread Ezequiel Garcia
On Sun, Dec 23, 2012 at 9:01 PM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: This patch adds device tree bindings for OMAP OneNAND devices. Tested on an OMAP3 3430 IGEPv2 board. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- .../devicetree/bindings/mtd

[PATCH] ARM: dts: omap3-igep: Add fixed always-on regulators to common dtsi file

2012-12-29 Thread Ezequiel Garcia
These regulators are common to igep0020 and igep0030 boards and are needed by smsc911x controller. Cc: BenoƮt Cousson b-cous...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Enric Balletbo i Serra eballe...@gmail.com Cc: Javier Martinez Canillas jav...@dowhile0.org Signed-off-by: Ezequiel Garcia

Re: [PATCH v8 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2013-01-15 Thread Ezequiel Garcia
On Tue, Jan 15, 2013 at 3:03 PM, Tony Lindgren t...@atomide.com wrote: * Daniel Mack zon...@gmail.com [130114 15:30]: On Jan 15, 2013 2:06 AM, Tony Lindgren t...@atomide.com wrote: * Ezequiel Garcia elezegar...@gmail.com [121223 13:49]: On Fri, Dec 14, 2012 at 7:36 AM, Daniel Mack zon

Re: [PATCH 1/3] mtd: omap-onenand: pass device_node in platform data

2013-01-15 Thread Ezequiel Garcia
Artem, On Sun, Dec 23, 2012 at 9:01 PM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: Pass an optional device_node pointer in the platform data, which in turn will be put into a mtd_part_parser_data. This way, code that sets up the platform devices can pass along the node from DT

Re: [PATCH v8 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2013-01-18 Thread Ezequiel Garcia
Tony, On Tue, Jan 15, 2013 at 3:03 PM, Tony Lindgren t...@atomide.com wrote: * Daniel Mack zon...@gmail.com [130114 15:30]: On Jan 15, 2013 2:06 AM, Tony Lindgren t...@atomide.com wrote: * Ezequiel Garcia elezegar...@gmail.com [121223 13:49]: On Fri, Dec 14, 2012 at 7:36 AM, Daniel Mack

Re: [PATCH v8 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2013-01-18 Thread Ezequiel Garcia
On Fri, Jan 18, 2013 at 6:11 PM, Tony Lindgren t...@atomide.com wrote: * Ezequiel Garcia elezegar...@gmail.com [130118 11:43]: Tony, On Tue, Jan 15, 2013 at 3:03 PM, Tony Lindgren t...@atomide.com wrote: * Daniel Mack zon...@gmail.com [130114 15:30]: On Jan 15, 2013 2:06 AM, Tony Lindgren

[PATCH v2 1/3] mtd: omap-onenand: pass device_node in platform data

2013-01-19 Thread Ezequiel Garcia
Bityutskiy artem.bityuts...@linux.intel.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- drivers/mtd/onenand/omap2.c |4 +++- include/linux/platform_data/mtd-onenand-omap2.h |3 +++ 2 files changed, 6 insertions(+), 1 deletions(-) diff --git

[PATCH v2 2/3] arm: omap2: gpmc-onenand: drop __init annotation

2013-01-19 Thread Ezequiel Garcia
gpmc_onenand_init() will be called from another driver's probe() function, so drop the __init annotation, in order to prevent section mismatches. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-onenand.c |2 +- 1 files changed, 1 insertions

[PATCH v2 3/3] arm: omap2: gpmc: add DT bindings for OneNAND

2013-01-19 Thread Ezequiel Garcia
This patch adds device tree bindings for OMAP OneNAND devices. Tested on an OMAP3 3430 IGEPv2 board. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- Changes from v1: * Fix typo in Documentation/devicetree/bindings/mtd/gpmc-onenand.txt .../devicetree/bindings/mtd/gpmc

Re: [PATCH v2 3/3] arm: omap2: gpmc: add DT bindings for OneNAND

2013-01-21 Thread Ezequiel Garcia
Hi Mark, On Mon, Jan 21, 2013 at 9:30 AM, Mark Rutland mark.rutl...@arm.com wrote: [...] diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index 01ce462..f7de9eb 100644 --- a/arch/arm/mach-omap2/gpmc.c +++ b/arch/arm/mach-omap2/gpmc.c @@ -39,6 +39,7 @@ #include

Re: [PATCH v2 3/3] arm: omap2: gpmc: add DT bindings for OneNAND

2013-01-22 Thread Ezequiel Garcia
On Mon, Jan 21, 2013 at 10:32 PM, Daniel Mack zon...@gmail.com wrote: Hi Tony, Mark, Ezequiel, Tony Lindgren t...@atomide.com wrote: * Ezequiel Garcia elezegar...@gmail.com [130121 09:00]: Hi Mark, On Mon, Jan 21, 2013 at 9:30 AM, Mark Rutland mark.rutl...@arm.com wrote: [...] diff

Re: [PATCH v2 3/3] arm: omap2: gpmc: add DT bindings for OneNAND

2013-01-22 Thread Ezequiel Garcia
On Tue, Jan 22, 2013 at 3:27 PM, Tony Lindgren t...@atomide.com wrote: * Ezequiel Garcia elezegar...@gmail.com [130122 10:17]: On Mon, Jan 21, 2013 at 10:32 PM, Daniel Mack zon...@gmail.com wrote: I'm currently far away from my computer and can't prepare a patch for this, sorry. But I

[PATCH] ARM: omap2: gpmc: Remove unneeded of_node_put()

2013-01-25 Thread Ezequiel Garcia
for_each_node_by_name() automatically calls of_node_put() on each node passed; so don't do it explicitly unless there's an error. Reported-by: Mark Rutland mark.rutl...@arm.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc.c |5 +++-- 1 files

[PATCH v3 1/3] mtd: omap-onenand: pass device_node in platform data

2013-01-25 Thread Ezequiel Garcia
Bityutskiy artem.bityuts...@linux.intel.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- drivers/mtd/onenand/omap2.c |4 +++- include/linux/platform_data/mtd-onenand-omap2.h |3 +++ 2 files changed, 6 insertions(+), 1 deletions(-) diff --git

[PATCH v3 2/3] arm: omap2: gpmc-onenand: drop __init annotation

2013-01-25 Thread Ezequiel Garcia
gpmc_onenand_init() will be called from another driver's probe() function, so drop the __init annotation, in order to prevent section mismatches. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-onenand.c |2 +- 1 files changed, 1 insertions

[PATCH v3 3/3] arm: omap2: gpmc: add DT bindings for OneNAND

2013-01-25 Thread Ezequiel Garcia
This patch adds device tree bindings for OMAP OneNAND devices. Tested on an OMAP3 3430 IGEPv2 board. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- Changes from v2: * Remove unneeded of_node_put() as reported by Mark Rutland Changes from v1: * Fix typo in Documentation

Re: [PATCH v3 3/3] arm: omap2: gpmc: add DT bindings for OneNAND

2013-01-25 Thread Ezequiel Garcia
Hi Mark, First of all: thanks for reviewing. On Fri, Jan 25, 2013 at 12:56 PM, Mark Rutland mark.rutl...@arm.com wrote: Hi, I have a couple more comments after looking though this a bit more thoroughly. On Fri, Jan 25, 2013 at 12:23:11PM +, Ezequiel Garcia wrote: This patch adds device

Re: DT GPMC SRAM and NOR flash support ?

2013-02-09 Thread Ezequiel Garcia
Hi Mark, On Thu, Feb 7, 2013 at 6:51 AM, Mark Jackson mpfj-l...@mimc.co.uk wrote: Okay ... I have made some progress, but it's not ideal. Currently I've hacked the GPMC DT driver (gpmc_probe_dt(), etc) so it now handles setting up the chip selects and timings for NOR devices, e.g.

Re: [PATCH 1/2] ARM: OMAP2+: Prevent potential crash if GPMC probe fails

2013-02-09 Thread Ezequiel Garcia
of the probe, but before we call the gpmc child probe functions (for device-tree) which request a chip-select. Signed-off-by: Jon Hunter jon-hun...@ti.com Without this patch, GPMC is currently broken on my igep board setup, if initialized through a device tree. Tested-by: Ezequiel Garcia

[PATCH 0/7] ARM: omap2: GPMC cleanup

2013-02-09 Thread Ezequiel Garcia
the gpmc-nand patch is tested by compilation only. Altough these patchset is almost trivial, any feedback or testing is more than welcome. Ezequiel Garcia (7): ARM: omap2: gpmc: Mark local scoped functions static ARM: omap2: gpmc: Remove unused gpmc_round_ns_to_ticks() function ARM: omap2: gpmc

[PATCH 1/7] ARM: omap2: gpmc: Mark local scoped functions static

2013-02-09 Thread Ezequiel Garcia
This patch marks a bunch of functions that are local to gpmc.c file only as static. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc.c | 14 +++--- arch/arm/mach-omap2/gpmc.h |7 --- 2 files changed, 7 insertions(+), 14 deletions

[PATCH 2/7] ARM: omap2: gpmc: Remove unused gpmc_round_ns_to_ticks() function

2013-02-09 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index ffe3e1e..bd3bc93 100644 --- a/arch/arm/mach-omap2/gpmc.c

[PATCH 3/7] ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value

2013-02-09 Thread Ezequiel Garcia
Fix gpmc_cs_reserved() so it returns 0 if the chip select is available (not reserved) or an error otherwise. This allows to use the return value directly and return a proper error code. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc.c | 12

[PATCH 4/7] ARM: omap2: gpmc-nand: Print something useful on CS request failure

2013-02-09 Thread Ezequiel Garcia
If CS request fails the current error message is rather unhelpful. Fix it by printing the failing chip select and the error code. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-nand.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

[PATCH 5/7] ARM: omap2: gpmc-onenand: Print something useful on CS request failure

2013-02-09 Thread Ezequiel Garcia
If CS request fails the current error message is rather unhelpful. Fix it by printing the failing chip select and the error code. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-onenand.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

[PATCH 6/7] ARM: omap2: gpmc-onenand: Replace pr_err() with dev_err()

2013-02-09 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-onenand.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc-onenand.c b/arch/arm/mach-omap2/gpmc-onenand.c index 0ee5317..4771945 100644 --- a/arch

[PATCH 7/7] ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn()

2013-02-09 Thread Ezequiel Garcia
Since the condition is not an error but a warning, replace printk KERN_ERR with dev_warn. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-onenand.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc

Re: [PATCH 7/7] ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn()

2013-02-09 Thread Ezequiel Garcia
On Sat, Feb 09, 2013 at 06:55:32PM +0200, Felipe Balbi wrote: Hi, On Sat, Feb 09, 2013 at 01:38:16PM -0300, Ezequiel Garcia wrote: Since the condition is not an error but a warning, replace printk KERN_ERR with dev_warn. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free

Re: [PATCH 3/7] ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value

2013-02-09 Thread Ezequiel Garcia
Hi Felipe, On Sat, Feb 09, 2013 at 06:53:35PM +0200, Felipe Balbi wrote: On Sat, Feb 09, 2013 at 01:38:12PM -0300, Ezequiel Garcia wrote: Fix gpmc_cs_reserved() so it returns 0 if the chip select is available (not reserved) or an error otherwise. This allows to use the return value

Re: DT GPMC SRAM and NOR flash support ?

2013-02-12 Thread Ezequiel Garcia
Hi Jon On Mon, Feb 11, 2013 at 7:21 PM, Jon Hunter jon-hun...@ti.com wrote: This is being call from the mach-omap2/board-generic.c file on boot. Where are you suggesting this is called from? I was suggesting this could be called in gpmc_probe_dt() in gpmc.c. Instead of using

[PATCH v2 0/8] ARM: omap2: GPMC cleanup

2013-02-12 Thread Ezequiel Garcia
. Ezequiel Garcia (8): ARM: omap2: gpmc: Mark local scoped functions static ARM: omap2: gpmc: Remove unused gpmc_round_ns_to_ticks() function ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value ARM: omap2: gpmc-nand: Print something useful on CS request failure ARM: omap2: gpmc-onenand

[PATCH v2 1/8] ARM: omap2: gpmc: Mark local scoped functions static

2013-02-12 Thread Ezequiel Garcia
This patch marks a bunch of functions that are local to gpmc.c file only as static. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc.c | 14 +++--- arch/arm/mach-omap2/gpmc.h |7 --- 2 files changed, 7 insertions(+), 14 deletions

[PATCH v2 2/8] ARM: omap2: gpmc: Remove unused gpmc_round_ns_to_ticks() function

2013-02-12 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index ffe3e1e..bd3bc93 100644 --- a/arch/arm/mach-omap2/gpmc.c

[PATCH v2 4/8] ARM: omap2: gpmc-nand: Print something useful on CS request failure

2013-02-12 Thread Ezequiel Garcia
If CS request fails the current error message is rather unhelpful. Fix it by printing the failing chip select and the error code. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-nand.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

[PATCH v2 3/8] ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value

2013-02-12 Thread Ezequiel Garcia
is reserved, * false if it's available Suggested-by: Felipe Balbi ba...@ti.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- Changelog from v1: * As suggested by Felipe Balbi, fix return code to a boolean arch/arm/mach-omap2/gpmc.c |4 ++-- 1 files changed, 2 insertions

[PATCH v2 5/8] ARM: omap2: gpmc-onenand: Print something useful on CS request failure

2013-02-12 Thread Ezequiel Garcia
If CS request fails the current error message is rather unhelpful. Fix it by printing the failing chip select and the error code. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-onenand.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

[PATCH v2 6/8] ARM: omap2: gpmc-onenand: Replace pr_err() with dev_err()

2013-02-12 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-onenand.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc-onenand.c b/arch/arm/mach-omap2/gpmc-onenand.c index 0ee5317..4771945 100644 --- a/arch

[PATCH v2 7/8] ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn()

2013-02-12 Thread Ezequiel Garcia
Since the condition is not an error but a warning, replace printk KERN_ERR with dev_warn. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-onenand.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc

[PATCH v2 8/8] ARM: omap2: gpmc: Remove redundant chip select out of range check

2013-02-12 Thread Ezequiel Garcia
This check is done before the call to gpmc_cs_reserved() and gpmc_cs_set_reserved() and it's redundant to do it again in each function. This simplifies the code a bit. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc.c | 10 +- 1 files

Re: [PATCH v2 0/8] ARM: omap2: GPMC cleanup

2013-02-12 Thread Ezequiel Garcia
On Tue, Feb 12, 2013 at 09:12:53AM -0800, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130212 08:36]: On 02/12/2013 09:18 AM, Ezequiel Garcia wrote: This patchset is v2 of the small cleanup consisting in: * mark some functions as 'static' when appropriate * remove

Re: [PATCH v2 0/8] ARM: omap2: GPMC cleanup

2013-02-12 Thread Ezequiel Garcia
On Tue, Feb 12, 2013 at 10:43:25AM -0800, Tony Lindgren wrote: * Ezequiel Garcia ezequiel.gar...@free-electrons.com [130212 10:29]: On Tue, Feb 12, 2013 at 09:12:53AM -0800, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130212 08:36]: On 02/12/2013 09:18 AM, Ezequiel Garcia

[PATCH v3 0/8] ARM: omap2: GPMC cleanup

2013-02-12 Thread Ezequiel Garcia
is tested by compilation only. Altough this patchset is almost trivial, any feedback or testing is more than welcome. Thanks to Jon Hunter for his kind review! Ezequiel Garcia (8): ARM: omap2: gpmc: Mark local scoped functions static ARM: omap2: gpmc: Remove unused gpmc_round_ns_to_ticks() function

[PATCH v3 1/8] ARM: omap2: gpmc: Mark local scoped functions static

2013-02-12 Thread Ezequiel Garcia
This patch marks a bunch of functions that are local to gpmc.c file only as static. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Reviewed-by: Jon Hunter jon-hun...@ti.com --- arch/arm/mach-omap2/gpmc.c | 14 +++--- arch/arm/mach-omap2/gpmc.h |7 --- 2 files

[PATCH v3 2/8] ARM: omap2: gpmc: Remove unused gpmc_round_ns_to_ticks() function

2013-02-12 Thread Ezequiel Garcia
This function is not used anywhere, so it's safe to remove it. This means less code to maintain. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Reviewed-by: Jon Hunter jon-hun...@ti.com --- arch/arm/mach-omap2/gpmc.c |7 --- 1 files changed, 0 insertions(+), 7

[PATCH v3 3/8] ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value

2013-02-12 Thread Ezequiel Garcia
is reserved, * false if it's available Suggested-by: Felipe Balbi ba...@ti.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Reviewed-by: Jon Hunter jon-hun...@ti.com --- Changelog from v1: * As suggested by Felipe Balbi, fix return code to a boolean arch/arm/mach-omap2/gpmc.c

[PATCH v3 4/8] ARM: omap2: gpmc-nand: Print something useful on CS request failure

2013-02-12 Thread Ezequiel Garcia
If CS request fails the current error message is rather unhelpful. Fix it by printing the failing chip select and the error code. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Reviewed-by: Jon Hunter jon-hun...@ti.com --- arch/arm/mach-omap2/gpmc-nand.c |3 ++- 1 files

[PATCH v3 5/8] ARM: omap2: gpmc-onenand: Print something useful on CS request failure

2013-02-12 Thread Ezequiel Garcia
If CS request fails the current error message is rather unhelpful. Fix it by printing the failing chip select and the error code. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Reviewed-by: Jon Hunter jon-hun...@ti.com --- arch/arm/mach-omap2/gpmc-onenand.c |3 ++- 1 files

[PATCH v3 6/8] ARM: omap2: gpmc-onenand: Replace pr_err() with dev_err()

2013-02-12 Thread Ezequiel Garcia
Do this becasue dev_err() is preferred over pr_err() and because it will match gpmc-nand, thus the code shows looks more consistent. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Reviewed-by: Jon Hunter jon-hun...@ti.com --- arch/arm/mach-omap2/gpmc-onenand.c |7

[PATCH v3 7/8] ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn()

2013-02-12 Thread Ezequiel Garcia
Since the condition is not an error but a warning, replace printk KERN_ERR with dev_warn. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Reviewed-by: Jon Hunter jon-hun...@ti.com --- arch/arm/mach-omap2/gpmc-onenand.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH v3 8/8] ARM: omap2: gpmc: Remove redundant chip select out of range check

2013-02-12 Thread Ezequiel Garcia
This check is done before the call to gpmc_cs_reserved() and gpmc_cs_set_reserved() and it's redundant to do it again in each function. This simplifies the code a bit. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Reviewed-by: Jon Hunter jon-hun...@ti.com --- arch/arm/mach

[RFC 0/1] ARM: omap2: gpmc: Move binding documentation

2013-02-13 Thread Ezequiel Garcia
a bit strange to put GPMC under drivers/bus. Ezequiel Garcia (1): ARM: omap2: gpmc: Move binding documentation to memory-controller .../ti-gpmc.txt = memory-controllers/ti/gpmc.txt} |0 1 files changed, 0 insertions(+), 0 deletions(-) rename Documentation/devicetree/bindings/{bus/ti

[RFC 1/1] ARM: omap2: gpmc: Move binding documentation to memory-controller

2013-02-13 Thread Ezequiel Garcia
-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- .../ti-gpmc.txt = memory-controllers/ti/gpmc.txt} |0 1 files changed, 0 insertions(+), 0 deletions(-) rename Documentation/devicetree/bindings/{bus/ti-gpmc.txt = memory-controllers/ti/gpmc.txt} (100%) diff --git a/Documentation

Re: DT GPMC SRAM and NOR flash support ?

2013-02-14 Thread Ezequiel Garcia
Hi Jon, I'm working on a similar memory controller for plat-orion. I have a few questions about your approach. On Wed, Feb 13, 2013 at 03:07:06PM -0600, Jon Hunter wrote: On 02/07/2013 03:51 AM, Mark Jackson wrote: Okay ... I have made some progress, but it's not ideal. Currently I've

Re: [RFC 1/1] ARM: omap2: gpmc: Move binding documentation to memory-controller

2013-02-14 Thread Ezequiel Garcia
On Wed, Feb 13, 2013 at 09:13:27AM -0600, Jon Hunter wrote: On 02/13/2013 05:13 AM, Ezequiel Garcia wrote: GPMC stands for General Purpose Memory Controller, and it's primarily used to handle memories such as NOR, NAND, SRAM. Note that this controller is also used to handle network

Re: Build error: OMAP randconfig / mvebu

2013-02-14 Thread Ezequiel Garcia
On Thu, Feb 14, 2013 at 10:09:26AM +, Russell King - ARM Linux wrote: On Fri, Feb 08, 2013 at 02:33:29PM +0100, Arnd Bergmann wrote: On Friday 08 February 2013 12:06:44 Gregory CLEMENT wrote: I don't know what to do here, there is no point to build any of the files in mach-mvebu

Re: Build error: OMAP randconfig / mvebu

2013-02-14 Thread Ezequiel Garcia
On Thu, Feb 14, 2013 at 11:08:03AM +, Russell King - ARM Linux wrote: On Thu, Feb 14, 2013 at 08:03:08AM -0300, Ezequiel Garcia wrote: On Thu, Feb 14, 2013 at 10:09:26AM +, Russell King - ARM Linux wrote: On Fri, Feb 08, 2013 at 02:33:29PM +0100, Arnd Bergmann wrote: On Friday 08

Re: Build error: OMAP randconfig / mvebu

2013-02-14 Thread Ezequiel Garcia
Hi Arnd, On Thu, Feb 14, 2013 at 11:27:07AM +, Arnd Bergmann wrote: On Thursday 14 February 2013, Ezequiel Garcia wrote: On Thu, Feb 14, 2013 at 11:08:03AM +, Russell King - ARM Linux wrote: It's all publically available via my website. I'm kind of new around here, and I

Re: Build error: OMAP randconfig / mvebu

2013-02-14 Thread Ezequiel Garcia
Arnd, On Thu, Feb 14, 2013 at 12:21:16PM +, Arnd Bergmann wrote: On Thursday 14 February 2013, Ezequiel Garcia wrote: Now, using the random config there's a new error, unrelated to the previous one: ERROR: twl6030_interrupt_unmask [drivers/usb/otg/twl6030-usb.ko] undefined

Guidelines to move mach-omap2/gpmc to drivers/memory-controller

2013-02-15 Thread Ezequiel Garcia
Hello, I'd like to know which are the current constraints preventing us from moving OMAP's GPMC memory controller driver from mach-omap2/ to drivers/memory-controller. I imagine one of the biggest issues is GPMC's dependency on hwmod code. Can anyone shed some light on how to handle this? Is

Re: [PATCH v2 3/8] ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value

2013-02-15 Thread Ezequiel Garcia
Hi Anil, On Fri, Feb 15, 2013 at 09:49:21PM +0530, Anil Kumar wrote: Hi, On Tue, Feb 12, 2013 at 8:48 PM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: Currently gpmc_cs_reserved() return value is somewhat inconsistent, returning a negative value on an error condition

Re: [PATCH 1/2] ARM: dts: omap3: Add gpmc node

2013-02-16 Thread Ezequiel Garcia
Hi Anil, On Sat, Feb 16, 2013 at 05:08:27PM +0530, Anil Kumar wrote: Add gpmc DT node. Signed-off-by: Anil Kumar anilk...@gmail.com --- :100644 100644 1acc261... 9f36531... March/arm/boot/dts/omap3.dtsi arch/arm/boot/dts/omap3.dtsi | 11 +++ 1 files changed, 11

Re: Guidelines to move mach-omap2/gpmc to drivers/memory-controller

2013-02-19 Thread Ezequiel Garcia
Hi Jon, On Fri, Feb 15, 2013 at 02:08:08PM -0600, Jon Hunter wrote: On 02/15/2013 01:53 PM, Paul Walmsley wrote: Hi, On Fri, 15 Feb 2013, Ezequiel Garcia wrote: I imagine one of the biggest issues is GPMC's dependency on hwmod code. Can anyone shed some light on how to handle

Re: [PATCH 12/14] ARM: OMAP2+: Add additional GPMC timing parameters

2013-03-01 Thread Ezequiel Garcia
Hi Jon, On Tue, Feb 26, 2013 at 2:30 PM, Jon Hunter jon-hun...@ti.com wrote: [...] + if (!of_property_read_u32(np, gpmc,bus-turnaround, val)) + gpmc_t-bus_turnaround = val; + AFAIK, you don't need to test if the property is defined. You can just read it straightforward,

Re: [PATCH 12/14] ARM: OMAP2+: Add additional GPMC timing parameters

2013-03-01 Thread Ezequiel Garcia
On Fri, Mar 1, 2013 at 5:11 PM, Ezequiel Garcia elezegar...@gmail.com wrote: Hi Jon, On Tue, Feb 26, 2013 at 2:30 PM, Jon Hunter jon-hun...@ti.com wrote: [...] + if (!of_property_read_u32(np, gpmc,bus-turnaround, val)) + gpmc_t-bus_turnaround = val; + AFAIK, you don't

Re: DT GPMC SRAM and NOR flash support ?

2013-03-01 Thread Ezequiel Garcia
Hi Jon, Yet more questions :-) See below... On Wed, Feb 13, 2013 at 7:07 PM, Jon Hunter jon-hun...@ti.com wrote: You don't need this extra entry if you add simple-bus to the gpmc node compatible string. + gpmc: gpmc@6800a000 { + compatible =

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-01 Thread Ezequiel Garcia
Hi Jon, On Tue, Feb 26, 2013 at 2:30 PM, Jon Hunter jon-hun...@ti.com wrote: [...] +static int gpmc_probe_nor_child(struct platform_device *pdev, + struct device_node *child) +{ + struct gpmc_settings gpmc_s; + struct gpmc_timings gpmc_t; +

Re: DT GPMC SRAM and NOR flash support ?

2013-03-01 Thread Ezequiel Garcia
On Fri, Mar 1, 2013 at 6:08 PM, Ezequiel Garcia elezegar...@gmail.com wrote: Hi Jon, Yet more questions :-) See below... On Wed, Feb 13, 2013 at 7:07 PM, Jon Hunter jon-hun...@ti.com wrote: You don't need this extra entry if you add simple-bus to the gpmc node compatible string

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-04 Thread Ezequiel Garcia
Hi Jon, On Tue, Feb 26, 2013 at 2:30 PM, Jon Hunter jon-hun...@ti.com wrote: + +Example: + +gpmc: gpmc@6e00 { + compatible = ti,omap3430-gpmc, simple-bus; I'm concern about using simple-bus, and I'm not entirely sure this will work. AFAIK, you can't correlate a parent-child

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-05 Thread Ezequiel Garcia
Hi Jon, On Tue, Mar 5, 2013 at 2:30 PM, Jon Hunter jon-hun...@ti.com wrote: This really highlights a weakness in the GPMC driver, particularly for NOR, where the child device can only be probed once the parent is probed. I don't see this as being DT specific issue, because even on older OMAP

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-06 Thread Ezequiel Garcia
Jon, On Tue, Mar 5, 2013 at 6:34 PM, Jon Hunter jon-hun...@ti.com wrote: By the way, with this version you should remove simple-bus from your gpmc node compatible strings. I now call of_platform_device_create() to create the child device during the GPMC probe. I think that this is a safer

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-06 Thread Ezequiel Garcia
On Wed, Mar 6, 2013 at 1:46 PM, Jon Hunter jon-hun...@ti.com wrote: On 03/06/2013 05:58 AM, Ezequiel Garcia wrote: I'll submit this driver by the end of this week, in case you want to take a look at it. Ok, but this is not for omap right? No, this is a new driver for a memory controller

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-07 Thread Ezequiel Garcia
On Wed, Mar 6, 2013 at 1:54 PM, Ezequiel Garcia elezegar...@gmail.com wrote: On Wed, Mar 6, 2013 at 1:46 PM, Jon Hunter jon-hun...@ti.com wrote: On 03/06/2013 05:58 AM, Ezequiel Garcia wrote: I'll submit this driver by the end of this week, in case you want to take a look at it. Ok

Re: [PATCH 5/9] ARM: dts: Add GPMC node for OMAP2, OMAP4 and OMAP5

2013-03-09 Thread Ezequiel Garcia
On Fri, Mar 8, 2013 at 10:25 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Fri, Mar 8, 2013 at 10:41 PM, Jon Hunter jon-hun...@ti.com wrote: Yes you are correct. In general, I have been trying to stay some-what consistent with what hwmod was doing as this was being auto-generated

Re: [PATCH 5/9] ARM: dts: Add GPMC node for OMAP2, OMAP4 and OMAP5

2013-03-14 Thread Ezequiel Garcia
On Thu, Mar 14, 2013 at 12:50 PM, Jon Hunter jon-hun...@ti.com wrote: Yes, I full agree with that as well. The size should be purely HW related. So we should not take any assumption about the page size / alignment. Ok, what is best to use? The size from hwmod structures or the size from the

Re: [PATCH V3 02/18] ARM: OMAP2+: Add variable to store number of GPMC waitpins

2013-03-16 Thread Ezequiel Garcia
Hi Jon, On Fri, Mar 15, 2013 at 10:21:00AM -0500, Jon Hunter wrote: The GPMC has wait-pin signals that can be assigned to a chip-select to monitor the ready signal of an external device. Add a variable to indicate the total number of wait-pins for a given device. This will allow us to detect

Re: [PATCH V3 10/18] ARM: OMAP2+: Add function to read GPMC settings from device-tree

2013-03-16 Thread Ezequiel Garcia
Hi Jon, I have some tiny nitpicks... On Fri, Mar 15, 2013 at 10:21:08AM -0500, Jon Hunter wrote: Adds a function to read the various GPMC chip-select settings from device-tree and store them in the gpmc_settings structure. Update the GPMC device-tree binding documentation to describe these

Re: [PATCH V3 00/18] ARM: OMAP2+: GPMC clean-up and DT update

2013-03-16 Thread Ezequiel Garcia
mode, burst settings, wait monitoring etc. Therefore, to simplify the GPMC code and add device-tree support for NOR, it was first necessary to consolidate how these settings are programmed. Series based upon Mark Jackson's patch [1] and Ezequiel Garcia GPMC clean-up series [2]. Entire series

Re: musb: dsps: make it work with two instances

2013-07-06 Thread Ezequiel Garcia
Hi Sebastian, On Fri, Jul 5, 2013 at 10:32 AM, Sebastian Andrzej Siewior bige...@linutronix.de wrote: This enables the two musb instances on am335x to work. I like a lot the idea of splitting the DT representation of the two USB instances. The DT binding looks much better this way. After some

Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well

2013-07-07 Thread Ezequiel Garcia
Hi guys, On Fri, Jun 28, 2013 at 09:27:20PM +0530, Balaji T K wrote: On Friday 28 June 2013 06:04 PM, a-bin...@ti.com wrote: From: Amarinder Bindra a-bin...@ti.com OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation. Considering that the device tree entries are already

Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well

2013-07-08 Thread Ezequiel Garcia
On Mon, Jul 08, 2013 at 02:58:28PM -0500, Nishanth Menon wrote: On 10:46-20130708, Felipe Balbi wrote: On Sun, Jul 07, 2013 at 05:13:10PM -0300, Ezequiel Garcia wrote: Hi guys, On Fri, Jun 28, 2013 at 09:27:20PM +0530, Balaji T K wrote: On Friday 28 June 2013 06:04 PM, a-bin

Re: [PATCH 0/5] Add phy support for AM335X platform using Generic PHy framework

2013-07-08 Thread Ezequiel Garcia
Hi, On Mon, Jul 08, 2013 at 09:44:33PM +0200, Sebastian Andrzej Siewior wrote: We need two nodes each one with a glue layer and a musb child node. The instances crap in kernel has to vanish. Also that means your phy nodes are wrong. This is not musb with two ports but two musb instances each

Re: [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices

2013-07-10 Thread Ezequiel Garcia
for these, allow the driver to be built using the config ARCH_OMAP2PLUS rather than individually adding a config for each SoC to enable the support. Use COMPILE_TEST to enable the build for other platforms. Signed-off-by: Amarinder Bindra a-bin...@ti.com Cc: Ezequiel Garcia ezequiel.gar...@free

Re: musb: dsps: make it work with two instances

2013-07-17 Thread Ezequiel Garcia
Hi Sebastian, On Wed, Jul 17, 2013 at 07:12:29PM +0200, Sebastian Andrzej Siewior wrote: After some minor DT tweaking on the current patchset, I've managed to detect an USB mass storage device in the second instance (host / usb1) using a Beaglebone black board. Beaglebone black, that one

[PATCH] ARM: omap2: Use a consistent AM33XX SoC option description

2013-08-08 Thread Ezequiel Garcia
Fix the option description to match the other TI SoCs. This is just a cosmetic change. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach

Re: [PATCH v2 0/4] Add phy support for AM335X platform using Generic PHy framework

2013-08-10 Thread Ezequiel Garcia
On Fri, Jul 19, 2013 at 06:04:33PM +0530, George Cherian wrote: This patch series adds phy support for AM335X platform. This patch series is based on Generic PHY framework [1]. This series has - adds dual musb instances support for am335x platform - adds phy-am-usb

Re: [PATCH] ARM: omap2: Use a consistent AM33XX SoC option description

2013-08-20 Thread Ezequiel Garcia
On Fri, Aug 09, 2013 at 11:18:43AM +0200, Javier Martinez Canillas wrote: On Thu, Aug 8, 2013 at 11:32 PM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: Fix the option description to match the other TI SoCs. This is just a cosmetic change. Signed-off-by: Ezequiel Garcia

Re: [PATCH v10 04/10] mtd: nand: omap: fix device scan: NAND_CMD_READID, NAND_CMD_RESET, CMD_CMD_PARAM use only x8 bus

2013-10-23 Thread Ezequiel Garcia
Brian, On Tue, Oct 22, 2013 at 11:13:32PM -0700, Brian Norris wrote: On 10/22/2013 10:07 PM, Gupta, Pekon wrote: From: Brian Norris [mailto:computersforpe...@gmail.com] On Sat, Oct 19, 2013 at 02:14:08PM +0530, Pekon Gupta wrote: [...] Thus this patch run nand_scan_ident() with

Re: [PATCH v10 04/10] mtd: nand: omap: fix device scan: NAND_CMD_READID, NAND_CMD_RESET, CMD_CMD_PARAM use only x8 bus

2013-10-23 Thread Ezequiel Garcia
Hi Gupta, On Wed, Oct 23, 2013 at 01:15:20PM +, Gupta, Pekon wrote: Hi, From: Ezequiel Garcia [mailto:ezequiel.gar...@free-electrons.com] [...] FWIW, I have a Beaglebone with a 16-bit bus NAND attached to it. Coincidentally, yesterday I was doing some tests as I'm ramping up

Re: [PATCH v10 10/10] mtd: nand: omap: remove selection of BCH ecc-scheme via KConfig

2013-10-23 Thread Ezequiel Garcia
Gupta, I already have a question :-) On Sat, Oct 19, 2013 at 02:14:14PM +0530, Pekon Gupta wrote: With OMAP NAND driver updates, selection of ecc-scheme: *DT enabled kernel* depends on ti,nand-ecc-opt and ti,elm-id DT bindings. *Non DT enabled kernel* depends on elm_dev and

  1   2   3   >