[RFC PATCH 0/2] ARM: OMAP4+: Clk registration update

2012-10-18 Thread Grygorii Strashko
macros from the system. Please comment if this is an acceptable approach - at a first glance, it seems to pave way to be capable of being replaced potentially by DT data as well. Grygorii Strashko (2): ARM: OMAP2+: clock: Add omap2_clks_register API ARM: OMAP4: clock: use omap4_clks_register

[RFC PATCH 1/2] ARM: OMAP2+: clock: Add omap2_clks_register API

2012-10-18 Thread Grygorii Strashko
clocks set for OMAP446x SoCs Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- arch/arm/mach-omap2/clock.c | 36 arch/arm/mach-omap2/clock.h |3 +++ 2 files changed, 39 insertions(+) diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2

[RFC PATCH 2/2] ARM: OMAP4: clock: use omap4_clks_register API

2012-10-18 Thread Grygorii Strashko
, then, it is possible to do the same. One additional benefit seen is that the match logic can entirely be skipped. Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- arch/arm/mach-omap2/clock44xx_data.c | 40 ++ 1 file changed, 21 insertions(+), 19

Re: [RFC PATCH 5/6] ARM: OMAP3+: ABB: introduce ABB driver

2013-04-02 Thread Grygorii Strashko
; regulator-max-microvolt = 145; }; Regards, Grygorii Strashko -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

2013-04-05 Thread Grygorii Strashko
On 04/04/2013 07:41 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130404 00:39]: On 04/04/2013 02:42 AM, Tony Lindgren wrote: --- a/arch/arm/mach-omap2/cclock44xx_data.c +++ b/arch/arm/mach-omap2/cclock44xx_data.c @@ -27,6 +27,7 @@ #include linux/clk-private.h #include

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

2013-04-11 Thread Grygorii Strashko
node described in typo: an-a device tree blob is used to identify the exact clock provided in the SoC specific data. This is then linked back using of_clk_add_provider to the device node to be accessible by of_clk_get. Based on discussion contributions from Roger Quadros, Grygorii Strashko

Re: [BUG] omap: mfd/regulator: twl/core: init order

2013-04-15 Thread Grygorii Strashko
On 04/13/2013 09:27 PM, Christoph Fritz wrote: Hi while testing an omap3 board with device tree support I stumbled upon a bug which is due to wrong initialization order of twl-core and twl-regulator (I suppose): In the boot process they get loaded way too late so that a lot of drivers before

Re: [BUG] omap: mfd/regulator: twl/core: init order

2013-04-15 Thread Grygorii Strashko
On 04/15/2013 01:56 PM, Christoph Fritz wrote: On Mon, 2013-04-15 at 13:20 +0300, Grygorii Strashko wrote: On 04/13/2013 09:27 PM, Christoph Fritz wrote: Hi while testing an omap3 board with device tree support I stumbled upon a bug which is due to wrong initialization order of twl-core

[RFC v1 0/1] introduce regulator chain locking scheme

2013-04-15 Thread Grygorii Strashko
? Grygorii Strashko (1): regulator: core: introduce regulator chain locking scheme drivers/regulator/core.c | 134 -- include/linux/regulator/driver.h |2 + 2 files changed, 88 insertions(+), 48 deletions(-) Regards Grygorii Strashko Cc: linux

[RFC v1] regulator: core: introduce regulator chain locking scheme

2013-04-15 Thread Grygorii Strashko
: Mike Turquette mturque...@linaro.org Cc: Nishanth Menon n...@ti.com Cc: Tero Kristo t-kri...@ti.com Cc: linux-omap linux-omap@vger.kernel.org Cc: linux-arm linux-arm-ker...@lists.infradead.org Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- drivers/regulator/core.c | 134

Re: [BUG] omap: mfd/regulator: twl/core: init order

2013-04-16 Thread Grygorii Strashko
On 04/16/2013 10:45 AM, Peter Ujfalusi wrote: On 04/15/2013 06:25 PM, Tony Lindgren wrote: This fix should not be needed. It just means the real problem is somewhere else. Pinctrl is already before the i2c in drivers/Makefile. Maybe one of the MFD drivers has a wrong initcall level? FYI; I

Re: [RFC PATCH v2 0/6] ARM: OMAP3+: Introduce ABB driver

2013-04-18 Thread Grygorii Strashko
On 04/16/2013 10:07 PM, Mike Turquette wrote: Quoting Andrii Tseglytskyi (2013-04-16 05:40:44) On 04/16/2013 12:53 AM, Kevin Hilman wrote: In addition to Mike's comments (which I completely agree with), it would be very helfpul to see how this is actually used. e.g, how the regulators are

Re: [RFC v1] regulator: core: introduce regulator chain locking scheme

2013-04-18 Thread Grygorii Strashko
On 04/15/2013 07:40 PM, Mark Brown wrote: On Mon, Apr 15, 2013 at 07:21:25PM +0300, Andrii Tseglytskyi wrote: On 04/15/2013 06:50 PM, Mark Brown wrote: In addition, such locking scheme allows to have access to the supplier regulator API from inside child's (consumer) regulator API. I've still

Re: [PATCH 0/6] Serial Omap fixes and cleanups

2013-04-19 Thread Grygorii Strashko
On 04/18/2013 10:17 PM, Sourav Poddar wrote: Hi Kevin, On Thursday 18 April 2013 11:53 PM, Kevin Hilman wrote: Hi Sourav, Sourav Poddarsourav.pod...@ti.com writes: Hi, This patch series contains fixes and cleanups around the issue that the console UART should not idled on suspend while

Re: Multiple issues with omap4 panda es in linux next

2013-04-22 Thread Grygorii Strashko
On 04/22/2013 01:24 PM, Tomi Valkeinen wrote: On 2013-04-22 12:08, Tomi Valkeinen wrote: On 2013-04-19 20:13, Tony Lindgren wrote: 3. DSS fails with DT booting Works with legacy booting but fails with DT. I'm almost certain the DT booting was working last week or so? This is what I now get

Re: [RFC/PATCHv2 5/5] arm: omap2+: omap_device: remove no_idle_on_suspend

2013-04-22 Thread Grygorii Strashko
: Grygorii Strashko grygorii.stras...@ti.com Signed-off-by: Sourav Poddar sourav.pod...@ti.com --- Hi Kevin, I have put this as an RFC, due to few comments on cover letter of the previous version by Grygorii Strashko. As, he has mentioned that there are Audio playback use cases which also requires

Re: [PATCHv2 2/5] driver: serial: omap: prevent runtime PM for no_console_suspend

2013-04-22 Thread Grygorii Strashko
On 04/22/2013 04:43 PM, Sourav Poddar wrote: The driver manages no_console_suspend by preventing runtime PM during the suspend path, which forces the console UART to stay awake. Signed-off-by: Sourav Poddar sourav.pod...@ti.com --- drivers/tty/serial/omap-serial.c |5 - 1 files

Re: [RFC/PATCHv2 5/5] arm: omap2+: omap_device: remove no_idle_on_suspend

2013-04-23 Thread Grygorii Strashko
to few comments on cover letter of the previous version by Grygorii Strashko. As, he has mentioned that there are Audio playback use cases which also requires no_idle_on_suspend and using them on mainline after this series can cause regression. What you think will be the right approach

[PATCH 0/2] OMAP: fix boot sequence

2013-04-23 Thread Grygorii Strashko
of subsys init layer where initialization dependencies resolved indirectly in drivers/Makefile now. Grygorii Strashko (2): i2c: omap: convert to module_platform_driver() mfd: twl-core: convert to module_i2c_driver() drivers/i2c/busses/i2c-omap.c | 14 +- drivers/mfd/twl-core.c

[PATCH 2/2] mfd: twl-core: convert to module_i2c_driver()

2013-04-23 Thread Grygorii Strashko
@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- drivers/mfd/twl-core.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c index 4f3baad..f01340d 100644

[PATCH 1/2] i2c: omap: convert to module_platform_driver()

2013-04-23 Thread Grygorii Strashko
-off-by: Grygorii Strashko grygorii.stras...@ti.com --- drivers/i2c/busses/i2c-omap.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 4cc2f05..70d3fed 100644 --- a/drivers/i2c/busses/i2c-omap.c

Re: Multiple issues with omap4 panda es in linux next

2013-04-23 Thread Grygorii Strashko
On 04/22/2013 09:08 PM, Tony Lindgren wrote: * Grygorii Strashko grygorii.stras...@ti.com [130422 05:27]: On 04/22/2013 01:24 PM, Tomi Valkeinen wrote: On 2013-04-22 12:08, Tomi Valkeinen wrote: On 2013-04-19 20:13, Tony Lindgren wrote: 3. DSS fails with DT booting Works with legacy

Re: [PATCH 0/2] OMAP: fix boot sequence

2013-04-23 Thread Grygorii Strashko
On 04/23/2013 08:34 PM, Tony Lindgren wrote: * Grygorii Strashko grygorii.stras...@ti.com [130423 06:25]: Hi There are two public discussions now related to OMAP boot and drivers initialization issues: Multiple issues with omap4 panda es in linux next http://www.spinics.net/lists/linux-omap

Re: [PATCH 2/2] mfd: twl-core: convert to module_i2c_driver()

2013-05-17 Thread Grygorii Strashko
On 05/17/2013 01:58 AM, Tony Lindgren wrote: * Samuel Ortiz sa...@linux.intel.com [130516 15:22]: Hi Grygorii, On Tue, Apr 23, 2013 at 04:19:10PM +0300, Grygorii Strashko wrote: Shift TWL initialization to module/device init layer, because I2C now is not initialized on subsys init layer

Re: [PATCH] ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

2013-05-29 Thread Grygorii Strashko
On 05/28/2013 09:33 PM, Kevin Hilman wrote: Nishanth Menon n...@ti.com writes: On Fri, May 24, 2013 at 5:15 PM, Kevin Hilman khil...@linaro.org wrote: Kevin Hilman khil...@linaro.org writes: Nishanth Menon n...@ti.com writes: [...] Actually 2 things: a) patch seems to do the wrong thing

Re: [PATCH 11/11] i2c: omap: enhance pinctrl support

2013-05-31 Thread Grygorii Strashko
On 05/31/2013 01:13 PM, Hebbar Gururaja wrote: Amend the I2C omap pin controller to optionally take a pin control handle and set the state of the pins to: - default on boot, resume and before performing an i2c transfer - idle after initial default, after resume default, and after each i2c xfer

Re: [PATCH 05/32] OMAPDSS: fix dss_get_ctx_loss_count for DT

2013-05-31 Thread Grygorii Strashko
On 05/30/2013 07:36 PM, Kevin Hilman wrote: Tomi Valkeinen tomi.valkei...@ti.com writes: When using DT, dss device does not have platform data. However, dss_get_ctx_loss_count() uses dss device's platform data to find the get_ctx_loss_count function pointer. To fix this,

Re: [PATCH] rtc: rtc-twl: ensure IRQ is wakeup enabled

2013-06-04 Thread Grygorii Strashko
Hi Kevin, On 06/01/2013 01:37 AM, Kevin Hilman wrote: Currently, the RTC IRQ is never wakeup-enabled so is not capable of bringing the system out of suspend. On OMAP platforms, we have gotten by without this because the TWL RTC is on an I2C-connected chip which is capable of waking up the OMAP

Re: [PATCH 1/2] i2c: omap: convert to module_platform_driver()

2013-06-04 Thread Grygorii Strashko
Hi Kevin, On 06/03/2013 11:59 PM, Kevin Hilman wrote: Grygorii Strashko grygorii.stras...@ti.com writes: The OMAP I2C driver has a relation to pinctrl-single driver. As result, its probe will be deferred during system boot until late init time, because the pinctrl-single is initizalized

Re: [PATCH 11/11] i2c: omap: enhance pinctrl support

2013-06-04 Thread Grygorii Strashko
Hi Kevin, Gururaja On 05/31/2013 08:34 PM, Kevin Hilman wrote: Hebbar Gururaja gururaja.heb...@ti.com writes: Amend the I2C omap pin controller to optionally take a pin control handle and set the state of the pins to: - default on boot, resume and before performing an i2c transfer - idle

[PATCH] i2c: Let users disable Probe an I2C bus for certain devices

2013-06-04 Thread Grygorii Strashko
: linux-...@vger.kernel.org CC: linux-ker...@vger.kernel.org CC: linux-omap@vger.kernel.org Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- drivers/i2c/Kconfig| 10 ++ drivers/i2c/i2c-core.c |6 ++ 2 files changed, 16 insertions(+) diff --git a/drivers/i2c

[PATCH] rtc: rtc-twl: fix initialization sequence

2013-06-05 Thread Grygorii Strashko
-foundation.org Cc: Tony Lindgren t...@atomide.com Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- drivers/rtc/rtc-twl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c index bbda0fd..1698115 100644

Re: [PATCH] rtc: rtc-twl: fix initialization sequence

2013-06-05 Thread Grygorii Strashko
Pls, ignore this patch. It duplicates: https://patchwork.kernel.org/patch/2448251/ - [v2,1/2] RTC: rtc-twl: Fix rtc_reg_map initialization from Peter Ujfalusi On 06/05/2013 02:19 PM, Grygorii Strashko wrote: The twl-rtc has the following dependencies from other drivers during the boot

Re: [PATCH 1/2] i2c: omap: convert to module_platform_driver()

2013-06-05 Thread Grygorii Strashko
On 06/04/2013 09:29 PM, Kevin Hilman wrote: Grygorii Strashko grygorii.stras...@ti.com writes: Hi Kevin, On 06/03/2013 11:59 PM, Kevin Hilman wrote: Grygorii Strashko grygorii.stras...@ti.com writes: The OMAP I2C driver has a relation to pinctrl-single driver. As result, its probe

Re: [PATCH v2 1/2] RTC: rtc-twl: Fix rtc_reg_map initialization

2013-06-05 Thread Grygorii Strashko
Hi Peter, Tested on OMAP4460 SDP - see no issues during boot. -grygorii On 04/16/2013 11:30 AM, Peter Ujfalusi wrote: Initialize the rtc_reg_map in platform_driver's probe function instead at module_init time. This way we can make sure that the twl-core has been already probed and initialized

Re: [PATCH] rtc: rtc-twl: ensure IRQ is wakeup enabled

2013-06-05 Thread Grygorii Strashko
On 06/04/2013 08:46 PM, Kevin Hilman wrote: Grygorii Strashko grygorii.stras...@ti.com writes: Hi Kevin, On 06/01/2013 01:37 AM, Kevin Hilman wrote: Currently, the RTC IRQ is never wakeup-enabled so is not capable of bringing the system out of suspend. On OMAP platforms, we have gotten

Re: [PATCH] i2c: Let users disable Probe an I2C bus for certain devices

2013-06-05 Thread Grygorii Strashko
Hi On 06/04/2013 08:49 PM, Wolfram Sang wrote: On Tue, Jun 04, 2013 at 08:33:42PM +0300, Grygorii Strashko wrote: Currently the I2C devices instantiation Method 3 Probe an I2C bus for certain devices (see Documentation/i2c/instantiating-devices) is always enabled for all platforms (boards

Re: [PATCH 1/2] i2c: omap: convert to module_platform_driver()

2013-06-06 Thread Grygorii Strashko
On 06/05/2013 04:50 PM, Wolfram Sang wrote: The similar patch already exists: https://patchwork.kernel.org/patch/2448251/ - [v2,1/2] RTC: rtc-twl: Fix rtc_reg_map initialization from Peter Ujfalusi So, I think it is best if you resend this patch after all the fixes it needs are applied or you

Re: [PATCH] i2c: Let users disable Probe an I2C bus for certain devices

2013-06-07 Thread Grygorii Strashko
Hi Wolfram, On 06/07/2013 12:06 PM, Wolfram Sang wrote: 3) Thinking about Mainline: To reach the same target - no I2C detection - and taking into account above assumption No changes in default behavior the following will need to be done: - change i2c-omap/i2c-gpio DT bindings and add parameter

Re: i2c issue on Panda with DT boot, v3.10-rc4

2013-06-07 Thread Grygorii Strashko
hi Tomi, On 06/07/2013 02:53 PM, Tomi Valkeinen wrote: Hi, I was testing DT boot with 3.10-rc1 and Pandaboard, and couldn't get the DVI output's EDID reading to work. Testing with i2cget and i2cdump, I see that I can read individual bytes with i2cget, but using i2cdump doesn't work, it just

[PATCH 0/5] v3.10-rc4: fix OMAP4 boot failure if CONFIG_SENSORS_LM75=y

2013-06-07 Thread Grygorii Strashko
. This patch series based on top of: http://patchwork.ozlabs.org/patch/248188/ Grygorii Strashko (4): i2c: omap: add runtime check in isr to be sure that i2c is enabled i2c: omap: handle all irqs befor unblocking omap_i2c_xfer_msg() i2c: omap: query STP always when NACK is received i2c: omap: remove

[PATCH 0/5] v3.10-rc4: fix OMAP4 boot failure if CONFIG_SENSORS_LM75=y

2013-06-07 Thread Grygorii Strashko
. This patch series based on top of: http://patchwork.ozlabs.org/patch/248188/ Grygorii Strashko (4): i2c: omap: add runtime check in isr to be sure that i2c is enabled i2c: omap: handle all irqs befor unblocking omap_i2c_xfer_msg() i2c: omap: query STP always when NACK is received i2c: omap: remove

[PATCH 5/5] i2c: omap: remove omap_i2c_isr() hw irq handler

2013-06-07 Thread Grygorii Strashko
Hilman khil...@linaro.org Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- This is clean-up patch. drivers/i2c/busses/i2c-omap.c | 33 + 1 file changed, 1 insertion(+), 32 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c

[PATCH 3/5] i2c: omap: handle all irqs befor unblocking omap_i2c_xfer_msg()

2013-06-07 Thread Grygorii Strashko
: omap: ack IRQ in parts. CC: Kevin Hilman khil...@linaro.org Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- drivers/i2c/busses/i2c-omap.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index

[PATCH 4/5] i2c: omap: query STP always when NACK is received

2013-06-07 Thread Grygorii Strashko
received during the last message transmitting/recieving. This may lead to stuck Bus in Bus Busy until I2C IP reset (idle/enable). Hence, fix it by querying Stop condition (STP) always when NACK is received. CC: Kevin Hilman khil...@linaro.org CC: Felipe Balbi ba...@ti.com Signed-off-by: Grygorii

[PATCH 2/5] i2c: omap: add runtime check in isr to be sure that i2c is enabled

2013-06-07 Thread Grygorii Strashko
IRQ_NONE; } Produce warning in case if ISR called when i2c is disabled CC: Kevin Hilman khil...@linaro.org Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- drivers/i2c/busses/i2c-omap.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/i2c/busses/i2c

[PATCH 1/5] i2c: omap: fix spurious IRQs: disable/enable IRQ at INTC when idle

2013-06-07 Thread Grygorii Strashko
() |- oops is here - I2C module is in idle state Cc: Nishanth Menon n...@ti.com Signed-off-by: Kevin Hilman khil...@linaro.org Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- drivers/i2c/busses/i2c-omap.c |4 1 file changed, 4 insertions

Re: [RFC] i2c: add deprecation warning for class based instantiation

2013-06-19 Thread Grygorii Strashko
On 06/07/2013 12:09 PM, Wolfram Sang wrote: Class based instantiation can cause huge delays when booting. This mechanism was used when it was not possible to describe slaves on I2C busses. We now have other mechanisms, so most embedded I2C will not need classes and it was explicitly not

Re: [RFC] i2c: add deprecation warning for class based instantiation

2013-06-19 Thread Grygorii Strashko
Hi Wolfram, On 06/19/2013 01:15 PM, Wolfram Sang wrote: On Fri, Jun 07, 2013 at 11:09:26AM +0200, Wolfram Sang wrote: Class based instantiation can cause huge delays when booting. This mechanism was used when it was not possible to describe slaves on I2C busses. We now have other mechanisms,

[RFC 1/2] i2c: omap: drop class based instantiation of slaves

2013-06-19 Thread Grygorii Strashko
undefined (remove I2C_CLASS_HWMON). CC: Tony Lindgren t...@atomide.com Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- drivers/i2c/busses/i2c-omap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index

[RFC 2/2] i2c: gpio: drop class based instantiation of slaves

2013-06-19 Thread Grygorii Strashko
, so disable it by leaving I2C adapter class field undefined (remove I2C_CLASS_HWMON and I2C_CLASS_SPD) and add a deprecation warning to allow users, relying on this mechanism, to switch to something better. CC: Haavard Skinnemoen hskinnem...@gmail.com Signed-off-by: Grygorii Strashko

Re: [PATCH 3/5] i2c: omap: handle all irqs befor unblocking omap_i2c_xfer_msg()

2013-06-19 Thread Grygorii Strashko
Hi Felipe, On 06/07/2013 10:05 PM, Felipe Balbi wrote: Hi, On Fri, Jun 07, 2013 at 09:46:06PM +0300, Grygorii Strashko wrote: ARDY|NACK and ARDY|AL are set together in OMAP_I2C_STAT_REG, which will be Have you seen that happen ever ? AL is Arbitration Lost, we never put OMAP in a multi-master

Re: [PATCH 2/5] i2c: omap: add runtime check in isr to be sure that i2c is enabled

2013-06-19 Thread Grygorii Strashko
Hi Felipe, On 06/07/2013 10:02 PM, Felipe Balbi wrote: Hi, On Fri, Jun 07, 2013 at 09:46:05PM +0300, Grygorii Strashko wrote: Add runtime check at the beginning of omap_i2c_isr/omap_i2c_isr_thread to be sure that i2c is enabled, before performing IRQ handling and accessing I2C IP registers

Re: [PATCH 5/5] i2c: omap: remove omap_i2c_isr() hw irq handler

2013-06-19 Thread Grygorii Strashko
Hi Felipe, On 06/07/2013 10:07 PM, Felipe Balbi wrote: Hi, On Fri, Jun 07, 2013 at 09:46:08PM +0300, Grygorii Strashko wrote: The omap_i2c_isr() does the irq check and schedules threaded handler if any of enabled IRQs is active, but currently the I2C IRQs are enabled just once, when I2C IP

Re: [PATCH 1/5] i2c: omap: fix spurious IRQs: disable/enable IRQ at INTC when idle

2013-06-19 Thread Grygorii Strashko
On 06/07/2013 11:51 PM, Kevin Hilman wrote: Grygorii Strashko grygorii.stras...@ti.com writes: From: Kevin Hilman khil...@deeprootsystems.com Currently, runtime PM is used to keep the device enabled only during active transfers and for a configurable runtime PM autosuspend timout after

[RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-21 Thread Grygorii Strashko
://lkml.org/lkml/2013/5/31/210 CC: Hebbar Gururaja gururaja.heb...@ti.com CC: Linus Walleij linus.wall...@linaro.org CC: linux-arm-ker...@lists.infradead.org CC: linux-omap@vger.kernel.org CC: linux-ker...@vger.kernel.org Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- Hi Kevin, Tony

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-26 Thread Grygorii Strashko
Hi All, On 06/25/2013 09:58 AM, Tony Lindgren wrote: * Linus Walleij linus.wall...@linaro.org [130624 05:13]: On Fri, Jun 21, 2013 at 5:03 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: Hence, add pinctrl handling in omap_device core: 1) on PM runtime resume - switch pinctrl state

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-26 Thread Grygorii Strashko
Picture format fixed. Sorry for that. On 06/26/2013 04:20 PM, Grygorii Strashko wrote: Hi All, On 06/25/2013 09:58 AM, Tony Lindgren wrote: * Linus Walleij linus.wall...@linaro.org [130624 05:13]: On Fri, Jun 21, 2013 at 5:03 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: Hence, add

Re: AM35xx i2c3 issues

2013-06-27 Thread Grygorii Strashko
Hi Marc, Could you try these patches first: https://patchwork.kernel.org/patch/2685541/ http://patchwork.ozlabs.org/patch/252639/ Then try this patch alone: https://patchwork.kernel.org/patch/2689171/ Also could you provide your .config? Do you have lm75 (or any other hwmon devices) enabled?

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-27 Thread Grygorii Strashko
Hi Linus, On 06/26/2013 10:31 PM, Linus Walleij wrote: On Wed, Jun 26, 2013 at 3:20 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: The Sleep pinctrl state is optional - if sleep state isn't defined then Idle pinctrl state will be used during suspend. Why? If we have a clear cut

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-27 Thread Grygorii Strashko
On 06/27/2013 05:45 PM, Tony Lindgren wrote: * Grygorii Strashko grygorii.stras...@ti.com [130627 07:12]: As you can see, from 12 pins only 3 pins need to be reconfigured while switching from active-idle states and back (and as I mentioned above for OMAP idle == sleep now). Regarding OFF

Re: Boot hang regression 3.10.0-rc4 - 3.10.0

2013-07-09 Thread Grygorii Strashko
Hi, On 07/09/2013 09:42 AM, Felipe Balbi wrote: Hi, On Tue, Jul 09, 2013 at 11:03:54AM +0530, Rajendra Nayak wrote: On Monday 08 July 2013 07:05 PM, Felipe Balbi wrote: Hi, On Mon, Jul 08, 2013 at 06:50:01PM +0530, Rajendra Nayak wrote: I wonder if this is because the timeouts get now

Re: Boot hang regression 3.10.0-rc4 - 3.10.0

2013-07-10 Thread Grygorii Strashko
On 07/09/2013 10:41 PM, Felipe Balbi wrote: Hi, On Tue, Jul 09, 2013 at 09:59:28PM +0300, Grygorii Strashko wrote: Imagine the device is marked as suspended even though it's fully enabled (it hasn't been suspended by hwmod due to NO_IDLE flag). In that case your context structure is all zeroes

Re: Boot hang regression 3.10.0-rc4 - 3.10.0

2013-07-11 Thread Grygorii Strashko
On 07/11/2013 12:17 PM, Rajendra Nayak wrote: On Wednesday 10 July 2013 09:37 PM, Felipe Balbi wrote: how about something like below ? It makes omap_device/hwmod and pm_runtime agree on the initial state of the device and will prevent -runtime_resume() from being called on first

Re: Boot hang regression 3.10.0-rc4 - 3.10.0

2013-07-11 Thread Grygorii Strashko
Hi, On 07/11/2013 09:32 AM, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [130710 09:18]: On Wed, Jul 10, 2013 at 07:07:04PM +0300, Felipe Balbi wrote: how about something like below ? It makes omap_device/hwmod and pm_runtime agree on the initial state of the device and will prevent

Re: How to keep DM37x GPIO_162 high during off-mode

2013-07-11 Thread Grygorii Strashko
Hi Peter, On 07/11/2013 10:00 PM, Peter Barada wrote: On 07/09/2013 11:55 AM, Tony Lindgren wrote: * Peter Barada peter.bar...@logicpd.com [130709 08:14]: I'm working with a 3.0.8 kernel in Android ICS and have run into a problem using wl12xx bluetooth after a suspend/resume cycle. GPIO_162

[PATCH 2/2] serial: omap: fix wrong context restoration on init

2013-07-12 Thread Grygorii Strashko
://www.spinics.net/lists/arm-kernel/msg258062.html [3] http://www.spinics.net/lists/arm-kernel/msg258040.html CC: Tony Lindgren t...@atomide.com CC: Rajendra Nayak rna...@ti.com CC: Felipe Balbi ba...@ti.com CC: Kevin Hilman khil...@linaro.org Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- tested

[PATCH 1/2] serial: omap: enable PM runtime only when its fully configured

2013-07-12 Thread Grygorii Strashko
after all its parameters are configured. CC: Tony Lindgren t...@atomide.com CC: Rajendra Nayak rna...@ti.com CC: Felipe Balbi ba...@ti.com CC: Kevin Hilman khil...@linaro.org Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- tested on OMAP4 SDP with and without earlyprintk enabled

Re: [PATCH] arm: omap2plus: unidle devices which are about to probe

2013-07-12 Thread Grygorii Strashko
On 07/11/2013 01:16 PM, Felipe Balbi wrote: in order to make HWMOD and pm_runtime agree on the initial state of the device, we will unidle the device and call pm_runtime_set_active() to tell pm_runtime that the device is really active. By the time driver's probe() is reached, a call to

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-07-12 Thread Grygorii Strashko
Hi Linus, On 07/10/2013 11:36 PM, Linus Walleij wrote: On Thu, Jun 27, 2013 at 4:01 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: I think, In the future the OMAP pinctrl configurations would be manged in more flexible way then now (thanks to pinctrl PM helpers and you;)) - Idle state

Re: [PATCH v3 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver

2013-07-15 Thread Grygorii Strashko
Hi All, I have a question regarding this patch and IIO in general - Does IIO provide sync mechanism with system wide suspend/resume or this should be handled by each driver itself? What if during system suspend iio_read_channel_raw() (or any other consumer API) will be called after gpadc

Re: Boot hang regression 3.10.0-rc4 - 3.10.0

2013-07-16 Thread Grygorii Strashko
Hi Rajendra, On 07/11/2013 12:17 PM, Rajendra Nayak wrote: On Wednesday 10 July 2013 09:37 PM, Felipe Balbi wrote: how about something like below ? It makes omap_device/hwmod and pm_runtime agree on the initial state of the device and will prevent -runtime_resume() from being called on first

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Grygorii Strashko
Hi Hein, Felipe On 07/16/2013 12:42 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 05:33:47PM +0800, Hein Tibosch wrote: On 7/16/2013 5:03 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 04:19:35PM +0800, Hein Tibosch wrote: Hi Vikram, On a OMAP4460, i2c-bus-3: A driver (lm75)

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Grygorii Strashko
Hi Felipe, On 07/16/2013 02:27 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 02:01:11PM +0300, Grygorii Strashko wrote: On a OMAP4460, i2c-bus-3: A driver (lm75) is causing many 'timeout waiting for bus ready' errors. SDA remains high (as it should), but SCL remains low after a NACK

Re: [PATCH 1/4] pinctrl: Remove duplicate code in pinctrl_pm_select_state functions

2013-07-16 Thread Grygorii Strashko
Hi Tony, This patch causes boot failure when I've applied my patch [RFC] ARM: OMAP2+: omap_device: add pinctrl handling https://lkml.org/lkml/2013/6/21/309 on top of it: [0.264007] L310 cache controller enabled [0.268310] l2x0: 16 ways, CACHE_ID 0x41c4, AUX_CTRL 0x7e47, Cache

Re: [PATCH 1/4] pinctrl: Remove duplicate code in pinctrl_pm_select_state functions

2013-07-16 Thread Grygorii Strashko
Hi Tony, On 07/16/2013 04:41 PM, Tony Lindgren wrote: * Grygorii Strashko grygorii.stras...@ti.com [130716 06:22]: Hi Tony, This patch causes boot failure when I've applied my patch [RFC] ARM: OMAP2+: omap_device: add pinctrl handling https://lkml.org/lkml/2013/6/21/309 on top of it: Hmm

[PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling

2013-07-17 Thread Grygorii Strashko
/2670291/ - mmc: omap_hsmmc: Remux pins to support SDIO interrupt and PM runtime https://patchwork.kernel.org/patch/2690191/ - [PATCH 00/11] drivers: Add Pinctrl PM support https://lkml.org/lkml/2013/5/31/210 Grygorii Strashko (3): pinctrl: rollback check for !dev-pins in pinctrl_pm_select*() APIs

[PATCH 3/3] ARM: dts: omap4-sdp: add dynamic pin states for uart3/4

2013-07-17 Thread Grygorii Strashko
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- arch/arm/boot/dts/omap4-sdp.dts | 34 ++ 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts index 7951b4e..2624504 100644

[PATCH 1/3] pinctrl: rollback check for !dev-pins in pinctrl_pm_select*() APIs

2013-07-17 Thread Grygorii Strashko
...@linaro.org Cc: Stephen Warren swar...@wwwdotorg.org Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- Seems this one can be squashed in series [PATCH 0/4] improved support for runtime muxing for pinctrl http://www.spinics.net/lists/arm-kernel/msg258827.html drivers/pinctrl/core.c

[PATCH 2/3] ARM: OMAP2+: omap_device: add pinctrl handling

2013-07-17 Thread Grygorii Strashko
SDIO interrupt and PM runtime https://patchwork.kernel.org/patch/2690191/ - [PATCH 00/11] drivers: Add Pinctrl PM support https://lkml.org/lkml/2013/5/31/210 CC: Linus Walleij linus.wall...@linaro.org Cc: Stephen Warren swar...@wwwdotorg.org Signed-off-by: Grygorii Strashko grygorii.stras

Re: [PATCH 0/4] improved support for runtime muxing for pinctrl

2013-07-17 Thread Grygorii Strashko
to do the muxing for runtime PM. I've posted my patch and tested this patch series. Seems everything is ok (except patch pinctrl: Remove duplicate code in pinctrl_pm_select_state functions). See http://www.spinics.net/lists/arm-kernel/msg259180.html So, Tested-By: Grygorii Strashko

Re: [PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling

2013-07-17 Thread Grygorii Strashko
On 07/17/2013 02:57 PM, Roger Quadros wrote: Hi Grygorii, On 07/17/2013 02:41 PM, Grygorii Strashko wrote: Hi Tony, Kevin This patch series introduces dynamic pinctrl handling in OMAP device framework in the same way as it was before switching to DT. This allow OMAP devices driver's

Re: [PATCH 3/3] ARM: dts: omap4-sdp: add dynamic pin states for uart3/4

2013-07-17 Thread Grygorii Strashko
Hi, On 07/17/2013 06:32 PM, Tony Lindgren wrote: * Grygorii Strashko grygorii.stras...@ti.com [130717 04:49]: Add dynamic active/idle pin states for uart3/4 which will be applied when uart3/4 state is switched from active to idle and back by Runtime PM or during system suspend. This is good

Re: [PATCH 2/3] ARM: OMAP2+: omap_device: add pinctrl handling

2013-07-17 Thread Grygorii Strashko
On 07/17/2013 06:38 PM, Tony Lindgren wrote: * Grygorii Strashko grygorii.stras...@ti.com [130717 04:49]: Before switching to DT pinctrl states of OMAP IPs have been handled by hwmod framework. After switching to DT-boot the pinctrl handling was dropped from hwmod framework

Re: [PATCH 3/3] ARM: dts: omap4-sdp: add dynamic pin states for uart3/4

2013-07-18 Thread Grygorii Strashko
On 07/18/2013 11:09 AM, Tony Lindgren wrote: * Grygorii Strashko grygorii.stras...@ti.com [130717 09:48]: Hi, On 07/17/2013 06:32 PM, Tony Lindgren wrote: * Grygorii Strashko grygorii.stras...@ti.com [130717 04:49]: Add dynamic active/idle pin states for uart3/4 which will be applied when

Re: [PATCH 2/3] ARM: OMAP2+: omap_device: add pinctrl handling

2013-07-18 Thread Grygorii Strashko
On 07/18/2013 11:14 AM, Tony Lindgren wrote: * Grygorii Strashko grygorii.stras...@ti.com [130717 10:11]: On 07/17/2013 06:38 PM, Tony Lindgren wrote: * Grygorii Strashko grygorii.stras...@ti.com [130717 04:49]: Before switching to DT pinctrl states of OMAP IPs have been handled by hwmod

Re: [PATCH 3/3] ARM: dts: omap4-sdp: add dynamic pin states for uart3/4

2013-07-18 Thread Grygorii Strashko
Hi Tony, On 07/18/2013 12:04 PM, Tony Lindgren wrote: * Grygorii Strashko grygorii.stras...@ti.com [130718 02:01]: On 07/18/2013 11:09 AM, Tony Lindgren wrote: Don't think it's debug code - IO chain need to be rearmed after each PRCM IO IRQ - otherwise IO wakeup events may be lost (at least

Re: [PATCH 3/4] pinctrl: Add support for additional dynamic states

2013-07-19 Thread Grygorii Strashko
Hi Tony, Stephen On 07/19/2013 10:39 AM, Tony Lindgren wrote: * Stephen Warren swar...@wwwdotorg.org [130718 12:33]: On 07/18/2013 01:36 AM, Tony Lindgren wrote: * Stephen Warren swar...@wwwdotorg.org [130717 14:30]: On 07/16/2013 03:05 AM, Tony Lindgren wrote: ... Why shouldn't e.g. a

Re: [PATCH v6 1/2] ARM: dts: twl: Add GPADC data to device tree

2013-07-19 Thread Grygorii Strashko
On 07/19/2013 05:39 PM, Sergei Shtylyov wrote: Hello. On 19-07-2013 13:27, Oleksandr Kozaruk wrote: GPADC is the general purpose ADC present on twl6030. The dt data is interrupt used to trigger end of ADC conversion. Signed-off-by: Oleksandr Kozaruk oleksandr.koza...@ti.com ---

[PATCH 1/4] mfd: twl6030-irq: migrate to IRQ threaded handler

2013-07-23 Thread Grygorii Strashko
oleg.koshel...@ti.com Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- drivers/mfd/twl6030-irq.c | 146 +++-- 1 file changed, 49 insertions(+), 97 deletions(-) diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c index 277a8db..b6030d9

[PATCH 0/4] mfd: twl6030-irq: rework and add twl6032 support

2013-07-23 Thread Grygorii Strashko
on OMAP4430/TWL6030 and OMAP4470/TWL6032. Grygorii Strashko (2): mfd: twl6030-irq: add error check when IRQs are masked initially mfd: twl6030-irq: convert to use linear irq_domain Naga Venkata Srikanth V (1): mfd: twl6030-irq: migrate to IRQ threaded handler Oleksandr Dmytryshyn (1): mfd

[PATCH 4/4] mfd: twl6030-irq: Add interrupt mapping table for the twl6032

2013-07-23 Thread Grygorii Strashko
From: Oleksandr Dmytryshyn oleksandr.dmytrys...@ti.com This patch adds interrupt mapping table for the twl6032. Signed-off-by: Oleksandr Dmytryshyn oleksandr.dmytrys...@ti.com Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- drivers/mfd/twl6030-irq.c | 49

[PATCH 3/4] mfd: twl6030-irq: convert to use linear irq_domain

2013-07-23 Thread Grygorii Strashko
of irq_domain. So, IRQ mapping and descriptors allocation will be performed dynamically basing on DT configuration. The error message will be reported in case if unmapped IRQ is received by TWL6030 (virq==0). Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- drivers/mfd/twl6030-irq.c | 114

[PATCH 2/4] mfd: twl6030-irq: add error check when IRQs are masked initially

2013-07-23 Thread Grygorii Strashko
Add a missed check for errors when TWL IRQs are masked initially on probe and report an error in case of failure. Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- drivers/mfd/twl6030-irq.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers

Re: [PATCH 2/4] mfd: twl6030-irq: add error check when IRQs are masked initially

2013-07-24 Thread Grygorii Strashko
On 07/23/2013 09:08 PM, Graeme Gregory wrote: On 23/07/13 17:07, Grygorii Strashko wrote: Add a missed check for errors when TWL IRQs are masked initially on probe and report an error in case of failure. Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- drivers/mfd/twl6030-irq.c

Re: [PATCH 1/4] mfd: twl6030-irq: migrate to IRQ threaded handler

2013-07-24 Thread Grygorii Strashko
On 07/24/2013 01:49 PM, Lee Jones wrote: On Tue, 23 Jul 2013, Grygorii Strashko wrote: From: Naga Venkata Srikanth V vnv.srika...@samsung.com 1) Removed request_irq() and replaced it with request_threaded_irq(). 2) Removed generic_handle_irq() and replaced it with handle_nested_irq

Re: [PATCH 1/4] mfd: twl6030-irq: migrate to IRQ threaded handler

2013-07-24 Thread Grygorii Strashko
On 07/24/2013 03:50 PM, Lee Jones wrote: + if (ret) { + pr_warn(%s: I2C error %d reading PIH ISR\n, __func__, ret); Does the user really care which function we're returning from. Would it be better if you replace '__func__' with the device name? This module hasn't been

Re: [PATCH 3/4] mfd: twl6030-irq: convert to use linear irq_domain

2013-07-24 Thread Grygorii Strashko
On 07/24/2013 02:35 PM, Lee Jones wrote: On Tue, 23 Jul 2013, Grygorii Strashko wrote: Since the TWL6030 PMIC is used with OMAP4 SoCs only and OMAP4 legacy boot is dropped there are no needs to allocate the range of IRQ descriptors during system boot to support TWL6030 IRQs. Hence, convert

Re: [PATCH 4/4] mfd: twl6030-irq: Add interrupt mapping table for the twl6032

2013-07-24 Thread Grygorii Strashko
On 07/24/2013 02:52 PM, Lee Jones wrote: On Tue, 23 Jul 2013, Grygorii Strashko wrote: From: Oleksandr Dmytryshyn oleksandr.dmytrys...@ti.com This patch adds interrupt mapping table for the twl6032. Repeating the $SUBJECT line is never helpful. Signed-off-by: Oleksandr Dmytryshyn

[PATCH v2 0/5] mfd: twl6030-irq: rework and add twl6032 support

2013-07-25 Thread Grygorii Strashko
irq_domain: The irq_find_mapping() is used in twl6030_mmc_card_detect_config() to get virtual IRQ number. Based on v3.11-rc1 Tested generation of RTC_ALARM(3) and PWRON(0) IRQs on OMAP4430/TWL6030 and OMAP4470/TWL6032. Grygorii Strashko (3): mfd: twl6030-irq: add error check when IRQs are masked

  1   2   3   4   >