Re: [PATCHv11 0/6] I2C cleanups

2012-07-09 Thread Shubhrajyoti Datta
On Thu, Jun 28, 2012 at 8:41 PM, Shubhrajyoti D shubhrajy...@ti.com wrote: This is a minimal cleanup series. If there are no further comments can this series be queued? The patch series does the following - Bus busy recovery mechanism. - Make the i2c use SET_RUNTIME_PM_OPS - Use

Re: [RFC/PATCH 3/3] i2c: omap: Add support for I2C_M_STOP message flag

2012-07-18 Thread Shubhrajyoti Datta
On Wed, Jul 18, 2012 at 4:43 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Shubhrajyoti, On Wednesday 18 July 2012 11:49:24 Shubhrajyoti wrote: On Tuesday 26 June 2012 07:47 PM, Laurent Pinchart wrote: Generate a stop condition after each message marked with I2C_M_STOP.

Re: rmk back but still recovering (was Re: Reminder - rmk still on vacation)

2012-07-30 Thread Shubhrajyoti Datta
On Mon, Jul 30, 2012 at 1:10 PM, Shilimkar, Santosh santosh.shilim...@ti.com wrote: [...] Why? The DMA driver itself is optional. That was Tony's point too. Unfortunately MMC and SPI driver don't work today without DMA. Some works needs to be done to support polling mode and am bit skeptical

Re: [PATCH] omap-hsmmc: Implementation of i761 errata

2012-08-20 Thread Shubhrajyoti Datta
On Mon, Aug 20, 2012 at 12:25 PM, Shilimkar, Santosh santosh.shilim...@ti.com wrote: On Mon, Aug 20, 2012 at 12:08 PM, S, Venkatraman svenk...@ti.com wrote: On Fri, Aug 17, 2012 at 11:43 PM, Puttagunta, Viswanath vi...@ti.com wrote: [...] Signed-off-by: Semen Protsenko semen.protse...@ti.com

Re: [PATCH 06/10] mmc: omap_hsmmc: remove access to SYSCONFIG register

2012-08-21 Thread Shubhrajyoti Datta
Hi Venkat, Some doubts below. On Sat, Aug 18, 2012 at 12:22 AM, Venkatraman S svenk...@ti.com wrote: SYSCONFIG register of HSMMC IP is managed by the omap hwmod abstraction layer. At init only right? Resetting the IP and configuring the correct SYSCONFIG mode is centrally managed by hwmod.

Re: [PATCHv2 0/3] spi: omap2-mcspi: spi cleanups

2012-08-22 Thread Shubhrajyoti Datta
On Wed, Aug 22, 2012 at 10:29 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Aug 22, 2012 at 11:35:11AM +0530, Shubhrajyoti D wrote: This patch does the following Calls the pm_runtime_* functions directly. Remove the MOD_REG_BIT macro usage thereby removiing un-needed

Re: [PATCHv7 00/23]I2C big cleanup

2012-09-12 Thread Shubhrajyoti Datta
On Wed, Sep 12, 2012 at 7:14 PM, Wolfram Sang w.s...@pengutronix.de wrote: On Wed, Sep 12, 2012 at 12:18:50PM +0200, Wolfram Sang wrote: I donot see the warning. Am I missing something? I deleted my logfiles already. Ignore it for now, if it comes up again with your new series, I will give

Re: [PATCH] RTC: TWL: ensure all interrupts are disabled during probe

2012-09-14 Thread Shubhrajyoti Datta
Hi Kevin, On Fri, Sep 14, 2012 at 2:15 AM, Kevin Hilman khil...@deeprootsystems.com wrote: From: Kevin Hilman khil...@ti.com On some platforms, bootloaders are known to do some interesting RTC programming. Without going into the obscurities as to why this may be the case, suffice it to say

Re: [PATCH] RTC: TWL: ensure all interrupts are disabled during probe

2012-09-14 Thread Shubhrajyoti Datta
On Fri, Sep 14, 2012 at 7:37 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Shubhrajyoti Datta omaplinuxker...@gmail.com writes: Hi Kevin, On Fri, Sep 14, 2012 at 2:15 AM, Kevin Hilman khil...@deeprootsystems.com wrote: From: Kevin Hilman khil...@ti.com On some platforms, bootloaders

Re: [PATCH 2/2] OMAP i2c: pinctrl-ify i2c-omap.c

2012-09-19 Thread Shubhrajyoti Datta
On Thu, Sep 20, 2012 at 12:04 PM, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Add support for pinctrl mux settings in the OMAP I2C driver. If no such pinctl bindings are found a warning message is printed. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com --- looks

Re: [PATCH] ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints

2012-09-21 Thread Shubhrajyoti Datta
On Thu, Sep 20, 2012 at 9:38 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Convert the driver from the outdated omap_pm_set_max_mpu_wakeup_lat API to the new PM QoS API. Since the constraint is on the MPU subsystem, use the PM_QOS_CPU_DMA_LATENCY class of PM QoS. The resulting MPU

Re: [PATCH] serial: omap: fix the overrun case

2012-09-21 Thread Shubhrajyoti Datta
On Fri, Sep 21, 2012 at 5:05 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Sep 21, 2012 at 04:46:52PM +0530, Shubhrajyoti wrote: On Friday 21 September 2012 04:30 PM, Felipe Balbi wrote: On Fri, Sep 21, 2012 at 03:52:56PM +0530, Shubhrajyoti D wrote: [...] it it is ! BRK_ERROR_BITS I return.

Re: [PATCH] serial: omap: fix the overrun case

2012-09-21 Thread Shubhrajyoti Datta
On Fri, Sep 21, 2012 at 7:48 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Shubhrajyoti D shubhrajy...@ti.com writes: [...] Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- - functional testing on omap4sdp - Verified idle and suspend path hits off on beagle. Tested-by: Kevin

Re: [PATCH v3] ARM: OMAP: i2c: fix interrupt flood during resume

2012-10-11 Thread Shubhrajyoti Datta
On Wed, Oct 10, 2012 at 5:48 PM, Kalle Jokiniemi kalle.jokini...@jollamobile.com wrote: The resume_noirq enables interrupts one-by-one starting from first one. Now if the wake up event for suspend came from i2c device, the i2c bus irq gets enabled before the threaded i2c device irq, causing a

Re: [PATCH v3] ARM: OMAP: i2c: fix interrupt flood during resume

2012-10-12 Thread Shubhrajyoti Datta
On Fri, Oct 12, 2012 at 10:13 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Strashko, Grygorii grygorii.stras...@ti.com writes: Hi Kevin, yep, [1] is the same fix - thanks. Hi Kalle, i've applied these changes and PM runtime fix on top of

Re: [PATCH] i2c: omap: fix spurious IRQs: disable/enable IRQ at INTC when idle

2012-10-12 Thread Shubhrajyoti Datta
this, also disable interrupts at the MPU INTC when idling the device in -runtime_suspend() (and re-enable them in -runtime_resume().) This part based on an original patch from Shubhrajyoti Datta. NOTE: for proper sharing the I2C with a coprocessor, this driver still needs hwspinlock support

Re: [PATCH v3] ARM: OMAP: i2c: fix interrupt flood during resume

2012-10-15 Thread Shubhrajyoti Datta
On Mon, Oct 15, 2012 at 2:46 PM, Kalle Jokiniemi kalle.jokini...@jollamobile.com wrote: ma, 2012-10-15 kello 09:21 +0300, Kalle Jokiniemi kirjoitti: Hi, pe, 2012-10-12 kello 14:46 +, Strashko, Grygorii kirjoitti: Hi Kevin, yep, [1] is the same fix - thanks. Hi Kalle, i've

Re: [PATCH] i2c: omap: revert i2c: omap: switch to threaded IRQ support

2012-10-16 Thread Shubhrajyoti Datta
On Mon, Oct 15, 2012 at 7:21 AM, Paul Walmsley p...@pwsan.com wrote: Commit 3b2f8f82dad7d1f79cdc8fc05bd1c94baf109bde (i2c: omap: switch to threaded IRQ support) causes communication with I2C devices to fail after system suspend/resume on all OMAP3 devices: Could you tell me which omap3

Re: [PATCH] i2c: omap: adopt pinctrl support

2012-10-17 Thread Shubhrajyoti Datta
On Tue, Oct 16, 2012 at 8:53 PM, Sebastien Guiriec s-guir...@ti.com wrote: Some GPIO expanders need some early pin control muxing. Due to legacy boards sometimes the driver uses subsys_initcall instead of module_init. This patch takes advantage of defer probe feature and pin control in order

Re: [PATCH 2/4] ARM/dts: omap5: Update I2C with address space and interrupts

2012-10-22 Thread Shubhrajyoti Datta
On Mon, Oct 22, 2012 at 3:52 PM, Sebastien Guiriec s-guir...@ti.com wrote: Add base address and interrupt line inside Device Tree data for OMAP5 Looks good to me. Thanks , Reviewed-by: Shubhrajyoti D shubhrajy...@ti.com Signed-off-by: Sebastien Guiriec s-guir...@ti.com ---

Re: [PATCH 0/8] I2C patches for v3.8 merge window

2012-10-22 Thread Shubhrajyoti Datta
On Mon, Oct 22, 2012 at 7:00 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Oct 22, 2012 at 12:46:50PM +0300, Felipe Balbi wrote: Hi guys, here's another series for OMAP I2C driver. There are a few cleanups and one very nice new feature: we can now report how many bytes we transferred

Re: [RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod

2012-10-23 Thread Shubhrajyoti Datta
On Tue, Oct 23, 2012 at 3:16 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Tero Kristo t-kri...@ti.com writes: When waking up from off-mode, some IP blocks are reset automatically by hardware. For this reason, software must wait until the reset has completed before attempting to access

Re: [RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod

2012-10-23 Thread Shubhrajyoti Datta
On Tue, Oct 23, 2012 at 9:39 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Shubhrajyoti Datta omaplinuxker...@gmail.com writes: [...] Could you please explain what worked and didn't work on each platforms? Also, which 3430 did you test on? If it's SDP, then it has a UART1 console

Re: [PATCH] i2c: omap: re-factor omap_i2c_init function

2012-10-23 Thread Shubhrajyoti Datta
On Tue, Oct 23, 2012 at 10:48 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Oct 23, 2012 at 08:57:19PM +0530, Shubhrajyoti D wrote: re-factor omap_i2c_init() so that we can re-use it for resume. While at it also remove the bufstate variable as we write it in omap_i2c_resize_fifo for every

Re: [PATCH] i2c: omap: re-factor omap_i2c_init function

2012-10-23 Thread Shubhrajyoti Datta
On Tue, Oct 23, 2012 at 11:27 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Oct 23, 2012 at 11:26:15PM +0530, Shubhrajyoti Datta wrote: @@ -1268,23 +1271,8 @@ static int omap_i2c_runtime_resume(struct device *dev) { struct omap_i2c_dev *_dev = dev_get_drvdata(dev

Re: [PATCH] i2c: omap: re-factor omap_i2c_init function

2012-10-24 Thread Shubhrajyoti Datta
On Tue, Oct 23, 2012 at 11:27 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Oct 23, 2012 at 11:26:15PM +0530, Shubhrajyoti Datta wrote: @@ -1268,23 +1271,8 @@ static int omap_i2c_runtime_resume(struct device *dev) { struct omap_i2c_dev *_dev = dev_get_drvdata(dev

Re: [PATCH v2] i2c: omap: re-factor omap_i2c_init function

2012-10-25 Thread Shubhrajyoti Datta
On Thu, Oct 25, 2012 at 12:06 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Oct 25, 2012 at 12:06:51PM +0530, Shubhrajyoti D wrote: re-factor omap_i2c_init() so that we can re-use it for resume. While at it also remove the bufstate variable as we write it in omap_i2c_resize_fifo for every

Re: [PATCH] i2c: omap: ensure writes to dev-buf_len are ordered

2012-10-25 Thread Shubhrajyoti Datta
On Thu, Oct 25, 2012 at 2:30 PM, Felipe Balbi ba...@ti.com wrote: if we allow compiler reorder our writes, we could fall into a situation where dev-buf_len is reset for no apparent reason. This bug was found with a simple script which would transfer data to an i2c client from 1 to 1024 bytes

Re: [PATCH v2] i2c: omap: re-factor omap_i2c_init function

2012-10-25 Thread Shubhrajyoti Datta
On Thu, Oct 25, 2012 at 12:06 PM, Felipe Balbi ba...@ti.com wrote: [...] + * Don't write to this register if the IE state is 0 as it can + * cause deadlock. + */ + if (dev-iestate) + omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, dev-iestate); +} + static int

Re: [PATCH 2/8] i2c: omap: reorder exit path of omap_i2c_xfer_msg()

2012-10-25 Thread Shubhrajyoti Datta
On Mon, Oct 22, 2012 at 3:16 PM, Felipe Balbi ba...@ti.com wrote: just a cleanup patch trying to make exit path more straightforward. No changes otherwise. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/i2c-omap.c | 26 +- 1 file changed, 17

Re: [PATCH RFC] i2c: omap: Fix the revision register read

2012-10-31 Thread Shubhrajyoti Datta
On Wed, Oct 31, 2012 at 2:29 PM, Shubhrajyoti D shubhrajy...@ti.com wrote: The revision register on OMAP4 is a 16-bit lo and a 16-bit hi. Currently the driver reads only the lower 8-bits. Fix the same by preventing the truncating of the rev register for OMAP4. Also use the scheme bit ie

Re: [PATCH 2/2] i2c: omap: use revision check for OMAP_I2C_FLAG_APPLY_ERRATA_I207

2012-11-02 Thread Shubhrajyoti Datta
On Fri, Nov 2, 2012 at 4:37 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Nov 02, 2012 at 04:09:45PM +0530, Shubhrajyoti D wrote: The errata i207 is enabled for 2430 and 3xxx. Use the revision check to enable the erratum instead. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com very good. I

Re: [PATCH 1/2] i2c: omap: Fix the revision register read

2012-11-02 Thread Shubhrajyoti Datta
On Fri, Nov 2, 2012 at 4:36 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Nov 02, 2012 at 04:09:44PM +0530, Shubhrajyoti D wrote: The revision register on OMAP4 is a 16-bit lo and a 16-bit hi. Currently the driver reads only the lower 8-bits. Fix the same by preventing the truncating of

Re: [PATCHv2 1/7] i2c: omap: Fix the revision register read

2012-11-05 Thread Shubhrajyoti Datta
On Mon, Nov 5, 2012 at 2:34 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Nov 05, 2012 at 02:04:56PM +0530, Shubhrajyoti wrote: @@ -1155,7 +1187,7 @@ omap_i2c_probe(struct platform_device *pdev) dev-fifo_size = (dev-fifo_size / 2); - if (dev-rev

Re: [PATCHv3 8/8] i2c: omap: cleanup the sysc write

2012-11-05 Thread Shubhrajyoti Datta
On 11/5/12, Cousson, Benoit b-cous...@ti.com wrote: On 11/5/2012 3:25 PM, Felipe Balbi wrote: Hi, On Mon, Nov 05, 2012 at 07:53:45PM +0530, Shubhrajyoti wrote: On Monday 05 November 2012 07:44 PM, Felipe Balbi wrote: - dev-syscstate); -

Re: [PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

2012-11-06 Thread Shubhrajyoti Datta
On Tue, Nov 6, 2012 at 2:33 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Nov 06, 2012 at 02:30:19PM +0530, Shubhrajyoti D wrote: The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] changed the wait_for_completion order. Move the wait so that the rx doesnot wait

Re: OMAP baseline test results for v3.7-rc1

2012-11-06 Thread Shubhrajyoti Datta
On Tue, Nov 6, 2012 at 5:31 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Jean Pihet jean.pi...@newoldbits.com writes: [...] I ran some intensive stress tests on the I2C and ... unfortunately I could not trigger the problem. It looks like the issue is caused by some transient

Re: [PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

2012-11-06 Thread Shubhrajyoti Datta
On Tue, Nov 6, 2012 at 2:52 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Nov 06, 2012 at 02:47:27PM +0530, Shubhrajyoti D wrote: The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] changed the wait_for_completion order. Move the wait so that the rx doesnot wait

Re: [RFC PATCH 07/11] mfd: omap: control: usb-phy: introduce the ctrl-module usb driver

2012-05-25 Thread Shubhrajyoti Datta
Hi Edurardo, A few doubts, On Fri, May 25, 2012 at 1:55 PM, Eduardo Valentin eduardo.valen...@ti.com wrote: Created a new platform driver for the platform device created by the control module mfd core, wrt usb. This driver has API's to power on/off the phy and the API's to write to musb

Re: [PATCHv10 00/11] I2C fixes

2012-06-09 Thread Shubhrajyoti Datta
On Fri, Jun 1, 2012 at 4:29 AM, Kevin Hilman khil...@ti.com wrote: Shubhrajyoti D shubhrajy...@ti.com writes: The patch series does the following - Warn fixes if CONFIG_PM_RUNTIME is not selected. - In case of i2c remove register access was done without any  get_sync fix the same. - Folds

Re: [PATCHv8 13/13] I2C: OMAP: simplify omap_i2c_ack_stat()

2012-06-19 Thread Shubhrajyoti Datta
On Mon, Jun 18, 2012 at 9:00 PM, Wolfram Sang w.s...@pengutronix.de wrote: On Mon, Jun 18, 2012 at 08:00:28PM +0530, Shubhrajyoti D wrote: From: Felipe Balbi ba...@ti.com stat BIT(1) is the same as BIT(1), Not true. I'd guess you are missing some context in the patch description. See the

Re: [PATCHv8 06/13] I2C: OMAP: Correct I2C revision for OMAP3

2012-06-21 Thread Shubhrajyoti Datta
On Wed, Jun 20, 2012 at 7:44 PM, Tony Lindgren t...@atomide.com wrote: * Shubhrajyoti shubhrajy...@ti.com [120620 06:06]: On Wednesday 20 June 2012 04:02 PM, Tony Lindgren wrote: * Shubhrajyoti D shubhrajy...@ti.com [120618 07:35]: From: Jon Hunter jon-hun...@ti.com The OMAP3530 is based

Re: [PATCHv9 3/8] I2C: OMAP: use devm_* functions

2012-06-25 Thread Shubhrajyoti Datta
On Mon, Jun 25, 2012 at 3:21 PM, Felipe Balbi ba...@ti.com wrote: On Thu, Jun 21, 2012 at 03:38:44PM +0530, Shubhrajyoti D wrote: The various devm_* functions allocate memory that is released when a driver detaches. This patch uses devm_kzalloc, devm_request_and_ioremap for data that is

Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

2012-06-27 Thread Shubhrajyoti Datta
Hi Kevin, Thanks for the patch , a doubt below On Wed, Jun 27, 2012 at 7:15 AM, Kevin Hilman khil...@ti.com wrote: In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on failure. So the failure means that the usecount is incremented. However the device was not enabled. In that case

Re: [PATCH 07/11] I2C: OMAP: Handle error check for pm runtime

2012-06-27 Thread Shubhrajyoti Datta
On Wed, Jun 27, 2012 at 7:13 AM, Kevin Hilman khil...@ti.com wrote: Shubhrajyoti D shubhrajy...@ti.com writes: If PM runtime get_sync fails return with the error so that no further reads/writes goes through the interface. This will avoid possible abort. Add a error message in case of failure

Re: [PATCHv3 06/17] i2c: omap: split out [XR]DR and [XR]RDY

2012-07-02 Thread Shubhrajyoti Datta
On Mon, Jul 2, 2012 at 5:26 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Jun 29, 2012 at 03:43:26PM +0530, Shubhrajyoti D wrote: From: Felipe Balbi ba...@ti.com While they do pretty much the same thing, there are a few peculiarities. Specially WRT erratas, it's best to split those out

Re: [PATCH 0/5] spi: omap2-mcspi: driver updates

2012-03-27 Thread Shubhrajyoti Datta
Hi Grant, On Wed, Mar 28, 2012 at 3:28 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, 26 Mar 2012 19:14:35 +0530, Shubhrajyoti D shubhrajy...@ti.com wrote: The patch series does the following cleanups - Converts the spi to module_platform_driver - Use the devm functions so that

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-03-28 Thread Shubhrajyoti Datta
Hi Igor, On Wed, Mar 28, 2012 at 4:43 PM, Igor Grinberg grinb...@compulab.co.il wrote: Hi Shubhrajyoti, On 03/28/12 12:03, Shubhrajyoti wrote: On Tuesday 27 March 2012 07:38 PM, Igor Grinberg wrote: When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not

Re: [PATCH v2 1/5] spi/omap: Remove bus_num usage for instance index

2012-03-29 Thread Shubhrajyoti Datta
Hi Tarun, On Wed, Mar 28, 2012 at 2:15 PM, DebBarma, Tarun Kanti tarun.ka...@ti.com wrote: On Mon, Mar 26, 2012 at 7:14 PM, Shubhrajyoti D shubhrajy...@ti.com wrote: From: Benoit Cousson b-cous...@ti.com bus_num was used to reference the mcspi controller instance in a fixed array. Remove

Re: Suspend broken on 3.3?

2012-03-29 Thread Shubhrajyoti Datta
Hi Joe, After digging a bit further I found that the problem isn't lost characters or character corruption at all... The UART is actually at 430KBaud (not 900KBaud as I mentioned earlier). How did you verify that register read? The data received is very bursty (i.e. sets of messages every

Re: [PATCHv3 0/3] spi: omap2-mcspi: driver updates

2012-04-02 Thread Shubhrajyoti Datta
Hi Grant On Tue, Apr 3, 2012 at 1:10 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Sat, 31 Mar 2012 17:06:55 +0530, Shubhrajyoti D shubhrajy...@ti.com wrote: The patch series does the following cleanups - Makes the driver use autosuspend - Folds Benoit's bus_num removal patch in the

Re: [PATCHv5 16/18] I2C: OMAP: fix missing handling of errata I2C_OMAP3_1P153

2012-04-04 Thread Shubhrajyoti Datta
Hi Jon, +       if (dev-flags  OMAP_I2C_FLAG_APPLY_ERRATA_I207) +               dev-errata |= I2C_OMAP_ERRATA_I207; +        if (dev-rev= OMAP_I2C_REV_ON_3430_3530)                dev-errata |= I2C_OMAP3_1P153; The errata ID is not correct. I believe that 1P153 is referring to the

Re: [PATCHv7 01/18] I2C: OMAP: make omap_i2c_unidle/idle functions depend on CONFIG_PM_RUNTIME

2012-04-11 Thread Shubhrajyoti Datta
Hi Felipe, On Wed, Apr 11, 2012 at 5:02 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Apr 11, 2012 at 04:42:39PM +0530, Shubhrajyoti D wrote: The functions omap_i2c_unidle/idle are called from omap_i2c_runtime_resume and omap_i2c_runtime_suspend which is compiled for CONFIG_PM_RUNTIME. This

Re: [PATCHv7 14/18] I2C: OMAP: Use SET_RUNTIME_PM_OPS

2012-04-11 Thread Shubhrajyoti Datta
Hi Felipe, On Wed, Apr 11, 2012 at 5:05 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Apr 11, 2012 at 04:42:52PM +0530, Shubhrajyoti D wrote: Use SET_RUNTIME_PM_OPS macro to set runtime functions. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com ---  drivers/i2c/busses/i2c-omap.c |   11

Re: [PATCHv8 04/18] I2C: OMAP: I2C register restore only if context is lost

2012-04-17 Thread Shubhrajyoti Datta
Hi Kevin, Thanks for your review, On Tue, Apr 17, 2012 at 7:15 PM, Kevin Hilman khil...@ti.com wrote: Shubhrajyoti D shubhrajy...@ti.com writes:  Currently i2c register restore is done always.  Adding conditional restore.  The i2c register restore is done only if the context is lost. OK,

Re: [PATCH 2/7] UART: OMAP: Cut the clock in the error cases

2012-04-20 Thread Shubhrajyoti Datta
On Wed, Apr 18, 2012 at 8:43 PM, Shubhrajyoti shubhrajy...@ti.com wrote: Kevin Yes agree completely. Will describe that in the changelog. -- Does the following changelog look ok? From 37fdc2d40c9b2b19b8c5a9a4b8f7dd547d420f55 Mon Sep 17 00:00:00 2001 From: Shubhrajyoti D shubhrajy...@ti.com

Re: [PATCH 00/19] ARM: OMAP4 device off support

2012-04-23 Thread Shubhrajyoti Datta
On Fri, Apr 20, 2012 at 8:37 PM, Tero Kristo t-kri...@ti.com wrote: On Fri, 2012-04-20 at 20:21 +0530, Datta, Shubhrajyoti wrote: On Fri, Apr 20, 2012 at 8:13 PM, Tero Kristo t-kri...@ti.com wrote: On Fri, 2012-04-20 at 06:55 -0700, Kevin Hilman wrote: Tero Kristo t-kri...@ti.com writes:

Re: [PATCH RFC 1/2] watchdog : omap_wdt : Implement WDIOC_GETBOOTSTATUS for omap3+

2012-01-23 Thread Shubhrajyoti Datta
Hi Vaibhav, On Tue, Jan 24, 2012 at 10:32 AM, Bedia, Vaibhav vaibhav.be...@ti.com wrote: On Mon, Jan 23, 2012 at 16:43:07, Datta, Shubhrajyoti wrote: This patch intends to implement the WDIOC_GETBOOTSTATUS ioctl for the omap3 and omap4. Instead of just returning the register content why not

Re: [PATCH] I2C: OMAP: fix build breakage when CONFIG_OF is not set

2012-02-08 Thread Shubhrajyoti Datta
On Wed, Feb 8, 2012 at 4:34 PM, Luciano Coelho coe...@ti.com wrote: On Wed, 2012-02-08 at 12:59 +0200, Felipe Balbi wrote: On Wed, Feb 08, 2012 at 12:56:52PM +0200, Luciano Coelho wrote: Since commit 6145197be6cc0583fa1a2f4ec1079d366137061e, building we generally like to see the commit

Re: [PATCH v2] i2c: fix missing handling of errata I2C_OMAP3_1P153

2012-02-16 Thread Shubhrajyoti Datta
Hi , On Tue, Feb 14, 2012 at 3:45 PM, Tasslehoff Kjappfot tasskj...@gmail.com wrote: Sorry about the bad mails. First time I use git send-email to follow up on a patch, and it seems I need to read up a bit more on it. Anyway. This patch is tested on our custom board based on Beagleboard rev

Re: [PATCH v3] i2c: fix missing handling of errata I2C_OMAP3_1P153

2012-02-17 Thread Shubhrajyoti Datta
Hello, On Fri, Feb 17, 2012 at 5:49 PM, Tasslehoff Kjappfot tasskj...@gmail.com wrote: From 0195dcf606b0ad069d8b5bc56cb877ff65ebea22 Mon Sep 17 00:00:00 2001 From: Tasslehoff Kjappfot tasskj...@gmail.com Date: Mon, 6 Feb 2012 14:14:23 +0100 Subject: [PATCH] i2c: fix missing handling of

Re: [PATCH] mtd: omap2: Release memory region in .remove function

2012-02-17 Thread Shubhrajyoti Datta
On Fri, Feb 17, 2012 at 8:19 PM, Bernhard Walle wa...@corscience.de wrote: When the driver is compiled as module, it's not possible to unload and reload the driver again:    omap2-nand: probe of omap2-nand.0 failed with error -16 Looks right to me Reviewed-by: Shubhrajyoti D

Re: [PATCH] Revert ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints

2012-11-06 Thread Shubhrajyoti Datta
On Tue, Nov 6, 2012 at 10:01 PM, Paul Walmsley p...@pwsan.com wrote: This reverts commit 3db11feffc1ad2ab9dea27789e6b5b3032827adc. This commit causes I2C timeouts to appear on several OMAP3430/3530-based boards: http://marc.info/?l=linux-arm-kernelm=135071372426971w=2

Re: [PATCHv3 0/7] i2c: omap: updates

2012-11-13 Thread Shubhrajyoti Datta
On Mon, Nov 5, 2012 at 5:53 PM, Shubhrajyoti D shubhrajy...@ti.com wrote: Does the followiing - Make the revision a 32- bit consisting of rev_lo amd rev_hi each of 16 bits. - Also use the revision register for the erratum i207. - Refactor the i2c_omap_init code. Adds a patch to remove the

Re: [PATCHv2] i2c: omap: Move the remove constraint

2012-11-15 Thread Shubhrajyoti Datta
On Thu, Nov 15, 2012 at 1:46 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Hi Shubhrajyoti, On Thu, Nov 15, 2012 at 8:34 AM, Shubhrajyoti D shubhrajy...@ti.com wrote: Currently we just queue the transfer and release the qos constraints, however we donot wait for the transfer Typo: donot

Re: [PATCH] i2c: omap: don't save a value only needed for read-clearing

2012-11-15 Thread Shubhrajyoti Datta
On Thu, Nov 15, 2012 at 12:20 AM, Wolfram Sang w.s...@pengutronix.de wrote: This makes one of my code analyzers happy and makes me a part of the anything open source which we could all be using ? :-) 'my' as in 'one of those I am using'. It was cppcheck which found that flaw. Its use for

Re: [PATCHv3] i2c: omap: Move the remove constraint

2012-11-17 Thread Shubhrajyoti Datta
On Fri, Nov 16, 2012 at 7:50 PM, Wolfram Sang w.s...@pengutronix.de wrote: On Thu, Nov 15, 2012 at 02:19:21PM +0530, Shubhrajyoti D wrote: Currently we just queue the transfer and release the qos constraints, however we do not wait for the transfer to complete to release the constraint. Move

Re: [PATCH] i2c: omap: Remove the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE flag

2012-11-26 Thread Shubhrajyoti Datta
On Mon, Nov 26, 2012 at 2:44 PM, Felipe Balbi ba...@ti.com wrote: - OMAP_I2C_FLAG_BUS_SHIFT_2, + .flags = OMAP_I2C_FLAG_BUS_SHIFT_2, if it's not used anymore, how about removing its definition too ? Just updated the patch , thanks. -- To unsubscribe from

Re: [PATCH RFC] i2c: omap: Remove the OMAP_I2C_IP_VERSION_*

2012-11-26 Thread Shubhrajyoti Datta
On Mon, Nov 26, 2012 at 5:22 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Nov 26, 2012 at 05:09:42PM +0530, Shubhrajyoti D wrote: The OMAP_I2C_IP_VERSION_1 and OMAP_I2C_IP_VERSION_2 was needed as on VER2 we were not reading all the 32-bits. Since now that we read the hi register we do

Re: [PATCH] Input: omap4-keypad: Remove the OMAP4_KBD_SYSCONFIG and OMAP4_KBD_SYSSTATUS

2012-11-26 Thread Shubhrajyoti Datta
On Mon, Nov 26, 2012 at 11:31 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Mon, Nov 26, 2012 at 04:21:19PM +0530, Shubhrajyoti D wrote: The macros OMAP4_KBD_SYSSTATUS and OMAP4_KBD_SYSSTATUS are not used so remove them. They document the existing registers and do not add bloat to

Re: AM335x BeagleBone SPI Issues

2012-12-10 Thread Shubhrajyoti Datta
On Mon, Dec 10, 2012 at 8:49 PM, Jack Mitchell m...@communistcode.co.uk wrote: On 10/12/12 14:59, Felipe Balbi wrote: Hi, On Mon, Dec 10, 2012 at 02:50:16PM +, Jack Mitchell wrote: On Mon, Dec 10, 2012 at 01:23:09PM +, Jack Mitchell wrote: Hi, I am currently having issues with

RE: [PATCH 0/3]OMAP4: Keypad support

2011-02-15 Thread Shubhrajyoti Datta
Hi, Any comments on this series. Thanking you, With Regards, Shubhro -Original Message- From: shubhrajy...@ti.com [mailto:shubhrajy...@ti.com] Sent: Monday, December 27, 2010 11:22 AM To: linux-omap@vger.kernel.org; linux-in...@vger.kernel.org Cc: Shubhrajyoti D Subject: [PATCH