Re: [PM-OPP][PATCH 0/4] OMAP: Clean up series for generic opp layer.
Thara Gopinath had written, on 07/13/2010 12:47 AM, the following: This patch series does some clean up of the opp layer including removal of compilation warnings, avoiding wrong inclusioin of header files, correcting some srror checks and removing the dependency of opp layer on cpu freq layer. Apart from all these there is still one more concern i have in this generic opp layer. This is regarding the separate PMIC opp file opp_twl_tps.c which today caters to only twl4030 and twl5030 pmic. What is the approach to be taken if the PMIC changes? I am already facing this issue with OMAP4 where the PMIC is twl6030 and the formulas for converting vsel into voltage and vice versa are different. I am against adding another file for twl6030. The approach is not scalable. We need to keep these vsel to uV and vice versa convertion in one place or make them functions pointers. why is opp_twl_tps.c unable to decide the vsel conversion routines based on twl version? it seems to me (only watching l-o - not dug inside twl6030 datamanual), that rest of 6030 code seem to share 5030 codebase mostly.. on a side note - this is a bigger problem for voltage.c which seem to have some ingrained idea that each step is 12.5mV and delays are coded in.. but not related to opp layer at all. Thara Gopinath (4): OMAP: Fix the compilation warning in the opp layer OMAP: Correct the return value check after call into find_device_opp OMAP: Remove inclusion of PMIC specific header file in generic opp layer. OMAP: Remove dependency of generic opp layer on cpufreq. This specific series once the minor comment provided is looking good to me. arch/arm/plat-omap/Makefile |4 ++-- arch/arm/plat-omap/include/plat/opp.h |4 ++-- arch/arm/plat-omap/opp.c |7 +++ 3 files changed, 7 insertions(+), 8 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PM-OPP][PATCH 0/4] OMAP: Clean up series for generic opp layer.
-Original Message- From: Menon, Nishanth Sent: Tuesday, July 13, 2010 9:23 PM To: Gopinath, Thara Cc: linux-omap@vger.kernel.org; khil...@deeprootsystems.com; p...@pwsan.com; t...@atomide.com; Cousson, Benoit; Sawant, Anand; Sripathy, Vishwanath; Premi, Sanjeev Subject: Re: [PM-OPP][PATCH 0/4] OMAP: Clean up series for generic opp layer. Thara Gopinath had written, on 07/13/2010 12:47 AM, the following: This patch series does some clean up of the opp layer including removal of compilation warnings, avoiding wrong inclusioin of header files, correcting some srror checks and removing the dependency of opp layer on cpu freq layer. Apart from all these there is still one more concern i have in this generic opp layer. This is regarding the separate PMIC opp file opp_twl_tps.c which today caters to only twl4030 and twl5030 pmic. What is the approach to be taken if the PMIC changes? I am already facing this issue with OMAP4 where the PMIC is twl6030 and the formulas for converting vsel into voltage and vice versa are different. I am against adding another file for twl6030. The approach is not scalable. We need to keep these vsel to uV and vice versa convertion in one place or make them functions pointers. why is opp_twl_tps.c unable to decide the vsel conversion routines based on twl version? it seems to me (only watching l-o - not dug inside twl6030 datamanual), that rest of 6030 code seem to share 5030 codebase mostly.. on a side note - this is a bigger problem for voltage.c which seem to have some ingrained idea that each step is 12.5mV and delays are coded in.. but not related to opp layer at all. Nope voltage.c ideally uses the opp_tpl_twl layer to get the vsel to uV and uV to vsel conversion. I think today there a couple of places where it does a manual calculation but that will be removed in the next version. All the delays are #defines and can be changed whenever needed. Also I am no sure if u saw the latest implementation where I have a hook to get the step size and slew rate from the PMIC. Regards Thara Thara Gopinath (4): OMAP: Fix the compilation warning in the opp layer OMAP: Correct the return value check after call into find_device_opp OMAP: Remove inclusion of PMIC specific header file in generic opp layer. OMAP: Remove dependency of generic opp layer on cpufreq. This specific series once the minor comment provided is looking good to me. arch/arm/plat-omap/Makefile |4 ++-- arch/arm/plat-omap/include/plat/opp.h |4 ++-- arch/arm/plat-omap/opp.c |7 +++ 3 files changed, 7 insertions(+), 8 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PM-OPP][PATCH 0/4] OMAP: Clean up series for generic opp layer.
This patch series does some clean up of the opp layer including removal of compilation warnings, avoiding wrong inclusioin of header files, correcting some srror checks and removing the dependency of opp layer on cpu freq layer. Apart from all these there is still one more concern i have in this generic opp layer. This is regarding the separate PMIC opp file opp_twl_tps.c which today caters to only twl4030 and twl5030 pmic. What is the approach to be taken if the PMIC changes? I am already facing this issue with OMAP4 where the PMIC is twl6030 and the formulas for converting vsel into voltage and vice versa are different. I am against adding another file for twl6030. The approach is not scalable. We need to keep these vsel to uV and vice versa convertion in one place or make them functions pointers. Thara Gopinath (4): OMAP: Fix the compilation warning in the opp layer OMAP: Correct the return value check after call into find_device_opp OMAP: Remove inclusion of PMIC specific header file in generic opp layer. OMAP: Remove dependency of generic opp layer on cpufreq. arch/arm/plat-omap/Makefile |4 ++-- arch/arm/plat-omap/include/plat/opp.h |4 ++-- arch/arm/plat-omap/opp.c |7 +++ 3 files changed, 7 insertions(+), 8 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
