RE: [PATCH 01/10] ARM: OMAP3/4: cpuidle: fix sparse and checkpatch warnings

2012-12-13 Thread Hiremath, Vaibhav 
On Thu, Dec 13, 2012 at 12:59:49, Paul Walmsley wrote:
 On Thu, 13 Dec 2012, Hiremath, Vaibhav wrote:
 
  On Thu, Dec 13, 2012 at 11:11:49, Paul Walmsley wrote:
   
   The branch name to use is:
   
   TEST_pwrdm_post_fpwrst_devel_a_3.9
  
  If I am correct, it only includes one additional patch (merge commit), 
  right???
  
  commit d94831e0005fee743cefd28f4c20b7c435c71236
  Merge: 3e885c6 80ab3b2
  Author: Paul Walmsley p...@pwsan.com
  Date:   Sun Dec 9 13:06:51 2012 -0700
  
  build fixes
  
  
  
  Does this also fix sparse warnings? 
 
 Just ran a quick sparse check on mach-omap2 at 3e885c6 and d94831e with 
 'make -j4 C=2 arch/arm/mach-omap2', and no warnings showed up.  There were 
 some sparse issues that got fixed at an earlier point, though, so perhaps 
 you have an older copy of the branches somehow?
 

Ignore my earlier comment on sparse warning, it was my wrong sparse tool 
which was culprit here. I am working on remote server, which has sparse 
present inside /usr/bin, and somehow my default config using that one 
instead of what I was building.

I fixed this by changing the PATH, and now I do not see any issues/warnings.

Thanks,
Vaibhav
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/10] ARM: OMAP3/4: cpuidle: fix sparse and checkpatch warnings

2012-12-12 Thread Vaibhav Hiremath 


On 12/9/2012 6:53 AM, Paul Walmsley wrote:
 Fix the following sparse warnings in the OMAP3/4 CPUIdle code:
 
 arch/arm/mach-omap2/cpuidle34xx.c:272:1: warning: symbol 'omap3_idle_dev' was 
 not declared. Should it be static?
 arch/arm/mach-omap2/cpuidle34xx.c:274:23: warning: symbol 'omap3_idle_driver' 
 was not declared. Should it be static?
 arch/arm/mach-omap2/cpuidle44xx.c:164:1: warning: symbol 'omap4_idle_dev' was 
 not declared. Should it be static?
 arch/arm/mach-omap2/cpuidle44xx.c:166:23: warning: symbol 'omap4_idle_driver' 
 was not declared. Should it be static?
 
 Also fix the following checkpatch warnings:
 
 WARNING: please, no space before tabs
 #44: FILE: arch/arm/mach-omap2/cpuidle34xx.c:105:
 +^I.name = ^Iomap3_idle,$
 
 WARNING: please, no space before tabs
 #45: FILE: arch/arm/mach-omap2/cpuidle34xx.c:106:
 +^I.owner = ^ITHIS_MODULE,$
 
 ERROR: code indent should use tabs where possible
 #211: FILE: arch/arm/mach-omap2/cpuidle44xx.c:74:
 +/* C2 - CPU0 OFF + CPU1 OFF + MPU CSWR */$
 
 

Paul,

I am using your paul-linux-pwrdm_post_fpwrst_devel_a_3.9 branch, where
all the patches which you have posted are present (I believe so) and I
am getting following sparse warning -


  CHECK   arch/arm/mach-omap2/powerdomain.c
arch/arm/mach-omap2/powerdomain.c:811:2: warning: context imbalance in
'pwrdm_lock': unexpected unlock
arch/arm/mach-omap2/powerdomain.c:811:2:default context: wanted 1, got 0
include/linux/spinlock.h:340:2: warning: context problem in
'pwrdm_unlock': '_raw_spin_unlock_irqrestore' expected different context
include/linux/spinlock.h:340:2:context 'lock': wanted = 1, got 0
arch/arm/mach-omap2/powerdomain.c:1130:14: warning: context problem in
'pwrdm_state_switch': 'pwrdm_unlock' expected different context
arch/arm/mach-omap2/powerdomain.c:1130:14:default context: wanted =
1, got 0
arch/arm/mach-omap2/powerdomain.c:1295:14: warning: context problem in
'pwrdm_set_next_fpwrst': 'pwrdm_unlock' expected different context
arch/arm/mach-omap2/powerdomain.c:1295:14:default context: wanted =
1, got 0
arch/arm/mach-omap2/powerdomain.c:1317:14: warning: context problem in
'pwrdm_read_next_fpwrst': 'pwrdm_unlock' expected different context
arch/arm/mach-omap2/powerdomain.c:1317:14:default context: wanted =
1, got 0
arch/arm/mach-omap2/powerdomain.c:1382:14: warning: context problem in
'pwrdm_set_fpwrst': 'pwrdm_unlock' expected different context
arch/arm/mach-omap2/powerdomain.c:1382:14:default context: wanted =
1, got 0
arch/arm/mach-omap2/powerdomain.c:1407:14: warning: context problem in
'pwrdm_read_fpwrst': 'pwrdm_unlock' expected different context
arch/arm/mach-omap2/powerdomain.c:1407:14:default context: wanted =
1, got 0
arch/arm/mach-omap2/powerdomain.c:1432:14: warning: context problem in
'pwrdm_read_prev_fpwrst': 'pwrdm_unlock' expected different context
arch/arm/mach-omap2/powerdomain.c:1432:14:default context: wanted =
1, got 0
arch/arm/mach-omap2/powerdomain.c:1505:14: warning: context problem in
'pwrdm_dbg_show_counter': 'pwrdm_unlock' expected different context
arch/arm/mach-omap2/powerdomain.c:1505:14:default context: wanted =
1, got 0
arch/arm/mach-omap2/powerdomain.c:1542:14: warning: context problem in
'pwrdm_dbg_show_timer': 'pwrdm_unlock' expected different context
arch/arm/mach-omap2/powerdomain.c:1542:14:default context: wanted =
1, got 0
  CC  arch/arm/mach-omap2/powerdomain.o



On the other hand, I have boot tested it on BeagleBone platform.

Thanks,
Vaibhav
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/10] ARM: OMAP3/4: cpuidle: fix sparse and checkpatch warnings

2012-12-12 Thread Santosh Shilimkar 

On Sunday 09 December 2012 02:23 AM, Paul Walmsley wrote:

Fix the following sparse warnings in the OMAP3/4 CPUIdle code:

arch/arm/mach-omap2/cpuidle34xx.c:272:1: warning: symbol 'omap3_idle_dev' was 
not declared. Should it be static?
arch/arm/mach-omap2/cpuidle34xx.c:274:23: warning: symbol 'omap3_idle_driver' 
was not declared. Should it be static?
arch/arm/mach-omap2/cpuidle44xx.c:164:1: warning: symbol 'omap4_idle_dev' was 
not declared. Should it be static?
arch/arm/mach-omap2/cpuidle44xx.c:166:23: warning: symbol 'omap4_idle_driver' 
was not declared. Should it be static?

Also fix the following checkpatch warnings:

WARNING: please, no space before tabs
#44: FILE: arch/arm/mach-omap2/cpuidle34xx.c:105:
+^I.name = ^Iomap3_idle,$

WARNING: please, no space before tabs
#45: FILE: arch/arm/mach-omap2/cpuidle34xx.c:106:
+^I.owner = ^ITHIS_MODULE,$

ERROR: code indent should use tabs where possible
#211: FILE: arch/arm/mach-omap2/cpuidle44xx.c:74:
+/* C2 - CPU0 OFF + CPU1 OFF + MPU CSWR */$


Signed-off-by: Paul Walmsley p...@pwsan.com
Cc: Kevin Hilman khil...@ti.com
---


Acked-by: Santosh shilim...@ti.com

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/10] ARM: OMAP3/4: cpuidle: fix sparse and checkpatch warnings

2012-12-12 Thread Paul Walmsley 
On Wed, 12 Dec 2012, Vaibhav Hiremath wrote:

 I am using your paul-linux-pwrdm_post_fpwrst_devel_a_3.9 branch, where
 all the patches which you have posted are present (I believe so) and I
 am getting following sparse warning -

The branch name to use is:

TEST_pwrdm_post_fpwrst_devel_a_3.9


- Paul
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 01/10] ARM: OMAP3/4: cpuidle: fix sparse and checkpatch warnings

2012-12-12 Thread Hiremath, Vaibhav 
On Thu, Dec 13, 2012 at 11:11:49, Paul Walmsley wrote:
 On Wed, 12 Dec 2012, Vaibhav Hiremath wrote:
 
  I am using your paul-linux-pwrdm_post_fpwrst_devel_a_3.9 branch, where
  all the patches which you have posted are present (I believe so) and I
  am getting following sparse warning -
 
 The branch name to use is:
 
 TEST_pwrdm_post_fpwrst_devel_a_3.9
 

If I am correct, it only includes one additional patch (merge commit), 
right???

commit d94831e0005fee743cefd28f4c20b7c435c71236
Merge: 3e885c6 80ab3b2
Author: Paul Walmsley p...@pwsan.com
Date:   Sun Dec 9 13:06:51 2012 -0700

build fixes



Does this also fix sparse warnings? 

Thanks,
Vaibhav

 
 - Paul
 

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 01/10] ARM: OMAP3/4: cpuidle: fix sparse and checkpatch warnings

2012-12-12 Thread Paul Walmsley 
On Thu, 13 Dec 2012, Hiremath, Vaibhav wrote:

 On Thu, Dec 13, 2012 at 11:11:49, Paul Walmsley wrote:
  
  The branch name to use is:
  
  TEST_pwrdm_post_fpwrst_devel_a_3.9
 
 If I am correct, it only includes one additional patch (merge commit), 
 right???
 
 commit d94831e0005fee743cefd28f4c20b7c435c71236
 Merge: 3e885c6 80ab3b2
 Author: Paul Walmsley p...@pwsan.com
 Date:   Sun Dec 9 13:06:51 2012 -0700
 
 build fixes
 
 
 
 Does this also fix sparse warnings? 

Just ran a quick sparse check on mach-omap2 at 3e885c6 and d94831e with 
'make -j4 C=2 arch/arm/mach-omap2', and no warnings showed up.  There were 
some sparse issues that got fixed at an earlier point, though, so perhaps 
you have an older copy of the branches somehow?


- Paul

paul@dusk:/kernel/kernel/current$ git log -1
commit d94831e0005fee743cefd28f4c20b7c435c71236
Merge: 3e885c6 80ab3b2
Author: Paul Walmsley p...@pwsan.com
Date:   Sun Dec 9 13:06:51 2012 -0700

build fixes
paul@dusk:/kernel/kernel/current$ make C=2 -j4 arch/arm/mach-omap2/
  CHK include/generated/uapi/linux/version.h
  CHECK   scripts/mod/empty.c
  CHK include/generated/utsrelease.h
  UPD include/generated/utsrelease.h
make[1]: `include/generated/mach-types.h' is up to date.
  CC  kernel/bounds.s
  GEN include/generated/bounds.h
  CC  arch/arm/kernel/asm-offsets.s
  GEN include/generated/asm-offsets.h
  CALLscripts/checksyscalls.sh
  CHECK   arch/arm/mach-omap2/id.c
  CHECK   arch/arm/mach-omap2/io.c
  CHECK   arch/arm/mach-omap2/control.c
  CHECK   arch/arm/mach-omap2/mux.c
  CC  arch/arm/mach-omap2/id.o
  CC  arch/arm/mach-omap2/control.o
  CC  arch/arm/mach-omap2/io.o
  CC  arch/arm/mach-omap2/mux.o
  CHECK   arch/arm/mach-omap2/devices.c
  CHECK   arch/arm/mach-omap2/serial.c
  CHECK   arch/arm/mach-omap2/gpmc.c
  CC  arch/arm/mach-omap2/devices.o
  CC  arch/arm/mach-omap2/serial.o
  CC  arch/arm/mach-omap2/gpmc.o
  CHECK   arch/arm/mach-omap2/timer.c
  CHECK   arch/arm/mach-omap2/pm.c
  CC  arch/arm/mach-omap2/timer.o
  CC  arch/arm/mach-omap2/pm.o
  CHECK   arch/arm/mach-omap2/common.c
  CC  arch/arm/mach-omap2/common.o
  CHECK   arch/arm/mach-omap2/gpio.c
  CC  arch/arm/mach-omap2/gpio.o
  CHECK   arch/arm/mach-omap2/dma.c
  CC  arch/arm/mach-omap2/dma.o
  CHECK   arch/arm/mach-omap2/wd_timer.c
  CHECK   arch/arm/mach-omap2/display.c
  CHECK   arch/arm/mach-omap2/i2c.c
  CC  arch/arm/mach-omap2/wd_timer.o
  CC  arch/arm/mach-omap2/i2c.o
  CC  arch/arm/mach-omap2/display.o
  CHECK   arch/arm/mach-omap2/hdq1w.c
  CC  arch/arm/mach-omap2/hdq1w.o
  CHECK   arch/arm/mach-omap2/omap_hwmod.c
  CHECK   arch/arm/mach-omap2/omap_device.c
  CC  arch/arm/mach-omap2/omap_hwmod.o
  CC  arch/arm/mach-omap2/omap_device.o
  CHECK   arch/arm/mach-omap2/irq.c
  CHECK   arch/arm/mach-omap2/omap_hwmod_common_data.c
  CC  arch/arm/mach-omap2/irq.o
  CC  arch/arm/mach-omap2/omap_hwmod_common_data.o
  CHECK   arch/arm/mach-omap2/omap-secure.c
  CC  arch/arm/mach-omap2/omap-secure.o
  CHECK   arch/arm/mach-omap2/prm44xx.c
  CHECK   arch/arm/mach-omap2/mcbsp.c
  CC  arch/arm/mach-omap2/prm44xx.o
  CC  arch/arm/mach-omap2/mcbsp.o
  CHECK   arch/arm/mach-omap2/omap_twl.c
  CC  arch/arm/mach-omap2/omap_twl.o
  CHECK   arch/arm/mach-omap2/sdrc.c
  CC  arch/arm/mach-omap2/sdrc.o
  CHECK   arch/arm/mach-omap2/omap-smp.c
  CHECK   arch/arm/mach-omap2/omap-hotplug.c
  CC  arch/arm/mach-omap2/omap-smp.o
  CC  arch/arm/mach-omap2/omap-hotplug.o
  CHECK   arch/arm/mach-omap2/omap4-common.c
  CC  arch/arm/mach-omap2/omap4-common.o
  CHECK   arch/arm/mach-omap2/omap-wakeupgen.c
  AS  arch/arm/mach-omap2/sram242x.o
  AS  arch/arm/mach-omap2/sram243x.o
  CC  arch/arm/mach-omap2/omap-wakeupgen.o
  AS  arch/arm/mach-omap2/sram34xx.o
  CHECK   arch/arm/mach-omap2/omap2-restart.c
  CHECK   arch/arm/mach-omap2/omap3-restart.c
  CC  arch/arm/mach-omap2/omap2-restart.o
  CC  arch/arm/mach-omap2/omap3-restart.o
  CHECK   arch/arm/mach-omap2/mux2420.c
  CC  arch/arm/mach-omap2/mux2420.o
  CHECK   arch/arm/mach-omap2/mux2430.c
  CHECK   arch/arm/mach-omap2/mux34xx.c
  CHECK   arch/arm/mach-omap2/mux44xx.c
  CC  arch/arm/mach-omap2/mux2430.o
  CC  arch/arm/mach-omap2/mux34xx.o
  CC  arch/arm/mach-omap2/mux44xx.o
  CHECK   arch/arm/mach-omap2/sdrc2xxx.c
  CHECK   arch/arm/mach-omap2/opp.c
  CC  arch/arm/mach-omap2/sdrc2xxx.o
  CC  arch/arm/mach-omap2/opp.o
  CHECK   arch/arm/mach-omap2/opp3xxx_data.c
  CHECK   arch/arm/mach-omap2/opp4xxx_data.c
  CC  arch/arm/mach-omap2/opp3xxx_data.o
  CC  arch/arm/mach-omap2/opp4xxx_data.o
  CHECK   arch/arm/mach-omap2/pm24xx.c
  AS  arch/arm/mach-omap2/sleep24xx.o
  CHECK   arch/arm/mach-omap2/pm34xx.c
  AS  arch/arm/mach-omap2/sleep34xx.o
  CHECK   arch/arm/mach-omap2/pm44xx.c
  CC  arch/arm/mach-omap2/pm24xx.o
  CHECK