RE: [PATCH] Added sleep support to UART

2008-06-13 Thread Paul Walmsley
Hi Tero, Let me begin by saying that I don't care too much about the 32-bit SCM register read change; I just happen to think that it is easier to read. That said, one comment of yours bears some additional discussion: On Thu, 12 Jun 2008, [EMAIL PROTECTED] wrote: Also, the spec says that

RE: [PATCH] Added sleep support to UART

2008-06-12 Thread Tero.Kristo
Hi, A few minor comments based on a quick look. In terms of the OMAP3 code, is that for retention-idle only, or does it work with off-idle also? That patch should basically work in off-mode also, however it requires correct settings in the padconfig registers which are currently done in the

Re: [PATCH] Added sleep support to UART

2008-06-11 Thread Paul Walmsley
Hello Tero, A few minor comments based on a quick look. In terms of the OMAP3 code, is that for retention-idle only, or does it work with off-idle also? On Tue, 10 Jun 2008, Tero Kristo wrote: +const u32 omap2_uart_wk_bit[OMAP_MAX_NR_PORTS] = { + OMAP24XX_ST_UART1,

Re: [PATCH] Added sleep support to UART

2008-06-10 Thread Tony Lindgren
* Tero Kristo [EMAIL PROTECTED] [080610 07:16]: UART usage (e.g. serial console) now denies sleep for 5 seconds. This makes it possible to use serial console when dynamic idle is enabled. Also moved code from pm-debug.c to serial.c, and made pm24xx.c use this new implementation. I've pushed