Re: [PATCH 0/2] OMAP: DSS2: Add new display panel

2010-11-02 Thread Tomi Valkeinen
On Mon, 2010-11-01 at 17:45 +0100, ext Bryan Wu wrote:
 On Mon, Nov 1, 2010 at 10:15 AM, Tomi Valkeinen
 tomi.valkei...@nokia.com wrote:

  What we need is a common driver for all these dummy panels, and the
  driver would contain configurations for all the supported panels. The
  board file would pass the name of the panel used in that board to the
  driver, and the driver would use the configurations for that panel.
 
 
 It looks like that we just need one file name displays.c to do those
 generic things and pass the configuration from board files to this
 driver, such as timing or other things.

Not quite. If you pass timing information from the board files then
every board file has to define all the timings, even if they are using
the same panel.

That's why the configs should be in the panel driver, and the board file
only has to define which panel is actually connected.

  This has been discussed a few times in l-o list, but I haven't found
  time to implement it and nobody else has done it either.
 
 
 I'm quite happy to do this, thanks,

Thanks, I appreciate that.

 Tomi


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/2] OMAP: DSS2: Add new display panel

2010-11-01 Thread Tomi Valkeinen
Hi,

On Thu, 2010-10-28 at 16:43 +0200, ext Enric Balletbo i Serra wrote:
 Hi,
 
 Next patches adds support for the two new LCD panel display used
 on IGEP boards.
 
  Powertip PH480272T LCD 4.3inch (480x242) display
  Seiko 70WVW1TZ3 LCD 7.0inch WVGA (800x480) display
 
 Please, consider adding in next merge window.
 
 Cheers,
 
 Enric Balletbo i Serra (2):
   OMAP: DSS2: Add Powertip PH480272T display panel
   OMAP: DSS2: Add Seiko 70WVW1TZ3 display panel

These both are dummy panels, and the driver is basically a copy of the
existing drivers. I don't think I will merge any more of these, sorry.

What we need is a common driver for all these dummy panels, and the
driver would contain configurations for all the supported panels. The
board file would pass the name of the panel used in that board to the
driver, and the driver would use the configurations for that panel.

This has been discussed a few times in l-o list, but I haven't found
time to implement it and nobody else has done it either.

 Tomi


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/2] OMAP: DSS2: Add new display panel

2010-11-01 Thread Bryan Wu
On Mon, Nov 1, 2010 at 10:15 AM, Tomi Valkeinen
tomi.valkei...@nokia.com wrote:
 Hi,

 On Thu, 2010-10-28 at 16:43 +0200, ext Enric Balletbo i Serra wrote:
 Hi,

 Next patches adds support for the two new LCD panel display used
 on IGEP boards.

  Powertip PH480272T LCD 4.3inch (480x242) display
  Seiko 70WVW1TZ3 LCD 7.0inch WVGA (800x480) display

 Please, consider adding in next merge window.

 Cheers,

 Enric Balletbo i Serra (2):
   OMAP: DSS2: Add Powertip PH480272T display panel
   OMAP: DSS2: Add Seiko 70WVW1TZ3 display panel

 These both are dummy panels, and the driver is basically a copy of the
 existing drivers. I don't think I will merge any more of these, sorry.

 What we need is a common driver for all these dummy panels, and the
 driver would contain configurations for all the supported panels. The
 board file would pass the name of the panel used in that board to the
 driver, and the driver would use the configurations for that panel.


It looks like that we just need one file name displays.c to do those
generic things and pass the configuration from board files to this
driver, such as timing or other things.

 This has been discussed a few times in l-o list, but I haven't found
 time to implement it and nobody else has done it either.


I'm quite happy to do this, thanks,

-- 
Bryan Wu bryan...@canonical.com
Kernel Developer    +86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html