Re: [PATCH 1/4] ARM: OMAP3: cm-t35: add regulator supply for ads7846
On 11/19/11 02:14, Tony Lindgren wrote: * Igor Grinberg grinb...@compulab.co.il [08 04:47]: On 11/07/11 22:31, Tony Lindgren wrote: * Igor Grinberg grinb...@compulab.co.il [06 04:45]: Hi Tony, On 11/05/11 01:57, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [04 16:05]: * Igor Grinberg grinb...@compulab.co.il [111019 02:05]: Applying to board branch for v3.3 merge window. Hmm, actually I suggest you respin patches 2 and 3 so they apply on their own to current fixes branch. Then update 1 and 4 to apply on top of those. This way we can apply 2 and 3 during the -rc cycle, and then queue 1 and 4 for the next merge window. Well, actually all them are fixes, although it cannot be understood from the subject. I will adjust the subjects (and may be the commit messages also) to be more specific and resend. Hmm 1 4 are features that never worked type fixes, so they have flame potential. Those have to wait for the next merge window. Not exactly: 1/4 is a fix that I should have submitted more than a year ago, just after the ads7846 got support for the regulators: Sounds like it's not that urgent then :) Or I can just apply all of them into board branch to wait for the next merge window. That can be an option, if it bothers you too much, but I prefer to have this already in 3.2. I'll just apply them into board branch to wait for the next merge window then. No problem, thanks -- Regards, Igor. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] ARM: OMAP3: cm-t35: add regulator supply for ads7846
* Igor Grinberg grinb...@compulab.co.il [08 04:47]: On 11/07/11 22:31, Tony Lindgren wrote: * Igor Grinberg grinb...@compulab.co.il [06 04:45]: Hi Tony, On 11/05/11 01:57, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [04 16:05]: * Igor Grinberg grinb...@compulab.co.il [111019 02:05]: Applying to board branch for v3.3 merge window. Hmm, actually I suggest you respin patches 2 and 3 so they apply on their own to current fixes branch. Then update 1 and 4 to apply on top of those. This way we can apply 2 and 3 during the -rc cycle, and then queue 1 and 4 for the next merge window. Well, actually all them are fixes, although it cannot be understood from the subject. I will adjust the subjects (and may be the commit messages also) to be more specific and resend. Hmm 1 4 are features that never worked type fixes, so they have flame potential. Those have to wait for the next merge window. Not exactly: 1/4 is a fix that I should have submitted more than a year ago, just after the ads7846 got support for the regulators: Sounds like it's not that urgent then :) Or I can just apply all of them into board branch to wait for the next merge window. That can be an option, if it bothers you too much, but I prefer to have this already in 3.2. I'll just apply them into board branch to wait for the next merge window then. Thanks, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] ARM: OMAP3: cm-t35: add regulator supply for ads7846
On 11/07/11 22:31, Tony Lindgren wrote: * Igor Grinberg grinb...@compulab.co.il [06 04:45]: Hi Tony, On 11/05/11 01:57, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [04 16:05]: * Igor Grinberg grinb...@compulab.co.il [111019 02:05]: Applying to board branch for v3.3 merge window. Hmm, actually I suggest you respin patches 2 and 3 so they apply on their own to current fixes branch. Then update 1 and 4 to apply on top of those. This way we can apply 2 and 3 during the -rc cycle, and then queue 1 and 4 for the next merge window. Well, actually all them are fixes, although it cannot be understood from the subject. I will adjust the subjects (and may be the commit messages also) to be more specific and resend. Hmm 1 4 are features that never worked type fixes, so they have flame potential. Those have to wait for the next merge window. Not exactly: 1/4 is a fix that I should have submitted more than a year ago, just after the ads7846 got support for the regulators: - commit 91143379b01b2020d8878d627ebe9dfb9d6eb4c8 Author: Grazvydas Ignotas nota...@gmail.com Date: Thu Feb 25 02:04:56 2010 -0800 Input: ads7846 - add regulator support The ADS7846/TSC2046 touchscreen controllers can (and usually are) connected to various regulators for power, so add regulator support. Valid regulator will now be required, so boards without complete regulator setup should either disable regulator framework or enable CONFIG_REGULATOR_DUMMY. Signed-off-by: Grazvydas Ignotas nota...@gmail.com Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Signed-off-by: Dmitry Torokhov d...@mail.ru - 4/4 is a functionality fix, that also should have been submitted some time ago. We had this one locally and finally I've sent it out. With out it, the USB hub sometimes works, but not always. I've came back to that issue while working on CM-T3730 and finally sent it. So now, when I'm sure you have all the information, what will it be? If you still think it should be split up - that's fine with me, I will do the thing and resend. Otherwise, what about the v2 I've sent? Patches 2 3 could be justified as fixes during the -rc cycle. So here we have no doubt. Good. Or I can just apply all of them into board branch to wait for the next merge window. That can be an option, if it bothers you too much, but I prefer to have this already in 3.2. Thanks -- Regards, Igor. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] ARM: OMAP3: cm-t35: add regulator supply for ads7846
* Igor Grinberg grinb...@compulab.co.il [06 04:45]: Hi Tony, On 11/05/11 01:57, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [04 16:05]: * Igor Grinberg grinb...@compulab.co.il [111019 02:05]: Applying to board branch for v3.3 merge window. Hmm, actually I suggest you respin patches 2 and 3 so they apply on their own to current fixes branch. Then update 1 and 4 to apply on top of those. This way we can apply 2 and 3 during the -rc cycle, and then queue 1 and 4 for the next merge window. Well, actually all them are fixes, although it cannot be understood from the subject. I will adjust the subjects (and may be the commit messages also) to be more specific and resend. Hmm 1 4 are features that never worked type fixes, so they have flame potential. Those have to wait for the next merge window. Patches 2 3 could be justified as fixes during the -rc cycle. Or I can just apply all of them into board branch to wait for the next merge window. Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] ARM: OMAP3: cm-t35: add regulator supply for ads7846
Hi Tony, On 11/05/11 01:57, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [04 16:05]: * Igor Grinberg grinb...@compulab.co.il [111019 02:05]: Applying to board branch for v3.3 merge window. Hmm, actually I suggest you respin patches 2 and 3 so they apply on their own to current fixes branch. Then update 1 and 4 to apply on top of those. This way we can apply 2 and 3 during the -rc cycle, and then queue 1 and 4 for the next merge window. Well, actually all them are fixes, although it cannot be understood from the subject. I will adjust the subjects (and may be the commit messages also) to be more specific and resend. Thanks -- Regards, Igor. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] ARM: OMAP3: cm-t35: add regulator supply for ads7846
* Igor Grinberg grinb...@compulab.co.il [111019 02:05]:
Signed-off-by: Igor Grinberg grinb...@compulab.co.il
---
arch/arm/mach-omap2/board-cm-t35.c | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-cm-t35.c
b/arch/arm/mach-omap2/board-cm-t35.c
index e15d39b..6d93db0 100644
--- a/arch/arm/mach-omap2/board-cm-t35.c
+++ b/arch/arm/mach-omap2/board-cm-t35.c
@@ -343,6 +343,10 @@ static struct regulator_consumer_supply
cm_t35_vdvi_supply[] = {
REGULATOR_SUPPLY(vdvi, omapdss),
};
+static struct regulator_consumer_supply cm_t35_vio_supplies[] = {
+ REGULATOR_SUPPLY(vcc, spi1.0),
+};
+
/* VMMC1 for MMC1 pins CMD, CLK, DAT0..DAT3 (20 mA, plus card == max 220 mA)
*/
static struct regulator_init_data cm_t35_vmmc1 = {
.constraints = {
@@ -373,6 +377,19 @@ static struct regulator_init_data cm_t35_vsim = {
.consumer_supplies = cm_t35_vsim_supply,
};
+static struct regulator_init_data cm_t35_vio = {
+ .constraints = {
+ .min_uV = 180,
+ .max_uV = 180,
+ .apply_uV = true,
+ .valid_modes_mask = REGULATOR_MODE_NORMAL
+ | REGULATOR_MODE_STANDBY,
+ .valid_ops_mask = REGULATOR_CHANGE_MODE,
+ },
+ .num_consumer_supplies = ARRAY_SIZE(cm_t35_vio_supplies),
+ .consumer_supplies = cm_t35_vio_supplies,
+};
+
static uint32_t cm_t35_keymap[] = {
KEY(0, 0, KEY_A), KEY(0, 1, KEY_B), KEY(0, 2, KEY_LEFT),
KEY(1, 0, KEY_UP), KEY(1, 1, KEY_ENTER), KEY(1, 2, KEY_DOWN),
@@ -456,6 +473,7 @@ static struct twl4030_platform_data cm_t35_twldata = {
.gpio = cm_t35_gpio_data,
.vmmc1 = cm_t35_vmmc1,
.vsim = cm_t35_vsim,
+ .vio= cm_t35_vio,
};
static void __init cm_t35_init_i2c(void)
Applying to board branch for v3.3 merge window.
Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] ARM: OMAP3: cm-t35: add regulator supply for ads7846
* Tony Lindgren t...@atomide.com [04 16:05]: * Igor Grinberg grinb...@compulab.co.il [111019 02:05]: Applying to board branch for v3.3 merge window. Hmm, actually I suggest you respin patches 2 and 3 so they apply on their own to current fixes branch. Then update 1 and 4 to apply on top of those. This way we can apply 2 and 3 during the -rc cycle, and then queue 1 and 4 for the next merge window. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
