Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features

[Paul Kocialkowski]

Hi,

Le mercredi 23 décembre 2015 à 07:44 -0800, Tony Lindgren a écrit :
> * Paul Kocialkowski  [151223 03:00]:
> > + {
> > +   ti,no-reset-on-init;
> > +};
> > +
> > + {
> > +   ti,no-reset-on-init;
> > +};
> > +
> > + {
> > +   ti,no-reset-on-init;
> > +};
> > +
> > + {
> > +   ti,no-reset-on-init;
> > +};
> > +
> > + {
> > +   ti,no-reset-on-init;
> > +};
> > +
> > + {
> > +   ti,no-reset-on-init;
> > +};
> 
> Care to try to narrow down exactly which GPIO(s) need to be preserved?
> Chances are this will unnecessarily block deeper idle states in hardware
> otherwise.
> 
> My guess is that the GPIO pins that need to be preserved if any are in
> the GPIO bank 1 as that's always powered..

Well, I actually need to keep the GPIOs handling backlight control,
buttons LEDs and the micro USB connector muxing (which can be set to
UART or USB). Those are spread accross gpio2, gpio5 and gpio6, so I'll
only enable these in v2.

Thanks for the review!

-- 
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: https://www.replicant.us/
Blog: https://blog.replicant.us/
Wiki/tracker/forums: https://redmine.replicant.us/



signature.asc
Description: This is a digitally signed message part

Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features

[Paul Kocialkowski]

Hi,

Le mercredi 23 décembre 2015 à 13:03 -0300, Javier Martinez Canillas a
écrit :
> Hello Paul,
> 
> [snip]
> 
> > +
> > +_pmx_core {
> > +   pinctrl-names = "default";
> > +
> > +   uart3_pins: pinmux_uart3_pins {
> > +   pinctrl-single,pins = <
> > +   0x16e (PIN_INPUT | MUX_MODE0)   /* 
> > uart3_rx_irrx */
> > +   0x170 (PIN_OUTPUT | MUX_MODE0)  /* 
> > uart3_tx_irtx */
> > +   >;
> 
> Could you please use the IOPAD mux macros from
> include/dt-bindings/pinctrl/omap.h instead?
> 
> We just did a massive cleanup on the OMAP DTS to use them instead of
> an offset from the padconf registers.

Sure thing, will do in v2.

Thanks for the review!

-- 
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: https://www.replicant.us/
Blog: https://blog.replicant.us/
Wiki/tracker/forums: https://redmine.replicant.us/



signature.asc
Description: This is a digitally signed message part

Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features

[Tony Lindgren]

Hi,

* Paul Kocialkowski  [151223 03:00]:
> The LG Optimus Black (P970) codename sniper is a smartphone that was designed
> and manufactured by LG Electronics (LGE) and released back in 2011.
> It is using an OMAP3630 SoC, GP version.
> 
> This adds devicetree support for the device, with only a few basic features
> supported, such as debug uart, i2c, internal emmc and external mmc.

Cool :)

> + {
> + ti,no-reset-on-init;
> +};
> +
> + {
> + ti,no-reset-on-init;
> +};
> +
> + {
> + ti,no-reset-on-init;
> +};
> +
> + {
> + ti,no-reset-on-init;
> +};
> +
> + {
> + ti,no-reset-on-init;
> +};
> +
> + {
> + ti,no-reset-on-init;
> +};

Care to try to narrow down exactly which GPIO(s) need to be preserved?
Chances are this will unnecessarily block deeper idle states in hardware
otherwise.

My guess is that the GPIO pins that need to be preserved if any are in
the GPIO bank 1 as that's always powered..

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features

[Javier Martinez Canillas]

Hello Paul,

[snip]

> +
> +_pmx_core {
> +   pinctrl-names = "default";
> +
> +   uart3_pins: pinmux_uart3_pins {
> +   pinctrl-single,pins = <
> +   0x16e (PIN_INPUT | MUX_MODE0)   /* 
> uart3_rx_irrx */
> +   0x170 (PIN_OUTPUT | MUX_MODE0)  /* 
> uart3_tx_irtx */
> +   >;

Could you please use the IOPAD mux macros from
include/dt-bindings/pinctrl/omap.h instead?

We just did a massive cleanup on the OMAP DTS to use them instead of
an offset from the padconf registers.

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html