Re: [PATCH v3 3/5] char: ti-usim: Add driver for USIM module on AM43xx

[Greg Kroah-Hartman]

On Thu, May 29, 2014 at 03:35:37PM +0530, Satish Patel wrote:
 +enum usim_card_mode {
 +   USIM_CARD_MODE_ASYNC = 0,   /* asynchronous mode */
 +   USIM_CARD_MODE_SYNC_TYPE1,  /* synchronous mode: Type 1 */
 +   USIM_CARD_MODE_SYNC_TYPE2,  /* synchronous mode: Type 2 */
 +   USIM_CARD_MODE_SYNC_OTHER,  /* Any other synchronous type */
 +};
 +struct usim_data {
 +   int slot;
 +   int rxexplen;
 +   int txlen;
 +   unsigned char apdu[256];
 +};

You need to use the proper variable types for a structure that is going
to cross the user/kernel boundry in an ioctl :(

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 3/5] char: ti-usim: Add driver for USIM module on AM43xx

[Satish Patel]

On 5/29/2014 9:23 PM, Greg Kroah-Hartman wrote:

On Thu, May 29, 2014 at 03:35:37PM +0530, Satish Patel wrote:

+enum usim_card_mode {
+   USIM_CARD_MODE_ASYNC = 0,   /* asynchronous mode */
+   USIM_CARD_MODE_SYNC_TYPE1,  /* synchronous mode: Type 1 */
+   USIM_CARD_MODE_SYNC_TYPE2,  /* synchronous mode: Type 2 */
+   USIM_CARD_MODE_SYNC_OTHER,  /* Any other synchronous type */
+};
+struct usim_data {
+   int slot;
+   int rxexplen;
+   int txlen;
+   unsigned char apdu[256];
+};


You need to use the proper variable types for a structure that is going
to cross the user/kernel boundry in an ioctl :(
Do you mean to use __u32 instead int ? make use of types defined in 
types.h ? if yes, I will make that change :). Thanks for pointing out.



--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html