Re: Nokia N900: Broken lirc ir-rx51 driver
* Pali Rohár [160105 02:19]: > On Saturday 02 January 2016 09:06:57 Tony Lindgren wrote: > > > > Yup please take a look at thread "[PATCH 0/3] pwm: omap: Add PWM support > > using dual-mode timers". Chances are we still need to set up the dmtimer > > code to provide also irqchip functions. That way ir-rx51.c can just do > > request_irq on the selected dmtimer for interrupts. > > No I see that patch from that thread uses dmtimer.h from plat-omap. So > it is really OK? It's using the header to populate the platform data in mach-omap2 so that's fine. But we do not want to directly expose the dmtimer functions to device drivers as they are not Linux generic at this point. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Nokia N900: Broken lirc ir-rx51 driver
On Saturday 02 January 2016 09:06:57 Tony Lindgren wrote: > Hi, > > * Pali Rohár [160102 06:46]: > > --- a/drivers/media/rc/ir-rx51.c > > +++ b/drivers/media/rc/ir-rx51.c > > @@ -25,9 +25,9 @@ > > #include > > #include > > #include > > +#include > > > > -#include > > -#include > > +#include "../../../arch/arm/plat-omap/include/plat/dmtimer.h" > > Well we don't want to export the dmtimer functions to drivers..But > we now have the PWM driver that can be already used for most of the > ir-rx51.c. Ok. Is PWM driver included in mainline kernel? > > #include > > #include > > @@ -208,7 +208,7 @@ static int lirc_rx51_init_port(struct lirc_rx51 > > *lirc_rx51) > > } > > > > clk_fclk = omap_dm_timer_get_fclk(lirc_rx51->pwm_timer); > > - lirc_rx51->fclk_khz = clk_fclk->rate / 1000; > > + lirc_rx51->fclk_khz = clk_get_rate(clk_fclk) / 1000; > > > > return 0; > > > > > > So Tony, you are author of that commit (a62a6e98c3) which broke ir-rx51 > > module for Nokia N900. Do you know how to fix this driver for upstream > > kernel? It would be great to have driver working and not to have it in > > this dead state... > > Yup please take a look at thread "[PATCH 0/3] pwm: omap: Add PWM support > using dual-mode timers". Chances are we still need to set up the dmtimer > code to provide also irqchip functions. That way ir-rx51.c can just do > request_irq on the selected dmtimer for interrupts. No I see that patch from that thread uses dmtimer.h from plat-omap. So it is really OK? > > Also platform data for this driver are only in legacy board code. > > Support in DTS is missing, so driver (after fixing above problem) cannot > > be used on DT booted kernel. > > Yeah those parts should be already doable with the PWM timer code AFAIK. > > Regards, > > Tony > > -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Nokia N900: Broken lirc ir-rx51 driver
Hi, * Pali Rohár [160102 06:46]: > --- a/drivers/media/rc/ir-rx51.c > +++ b/drivers/media/rc/ir-rx51.c > @@ -25,9 +25,9 @@ > #include > #include > #include > +#include > > -#include > -#include > +#include "../../../arch/arm/plat-omap/include/plat/dmtimer.h" Well we don't want to export the dmtimer functions to drivers..But we now have the PWM driver that can be already used for most of the ir-rx51.c. > #include > #include > @@ -208,7 +208,7 @@ static int lirc_rx51_init_port(struct lirc_rx51 > *lirc_rx51) > } > > clk_fclk = omap_dm_timer_get_fclk(lirc_rx51->pwm_timer); > - lirc_rx51->fclk_khz = clk_fclk->rate / 1000; > + lirc_rx51->fclk_khz = clk_get_rate(clk_fclk) / 1000; > > return 0; > > > So Tony, you are author of that commit (a62a6e98c3) which broke ir-rx51 > module for Nokia N900. Do you know how to fix this driver for upstream > kernel? It would be great to have driver working and not to have it in > this dead state... Yup please take a look at thread "[PATCH 0/3] pwm: omap: Add PWM support using dual-mode timers". Chances are we still need to set up the dmtimer code to provide also irqchip functions. That way ir-rx51.c can just do request_irq on the selected dmtimer for interrupts. > Also platform data for this driver are only in legacy board code. > Support in DTS is missing, so driver (after fixing above problem) cannot > be used on DT booted kernel. Yeah those parts should be already doable with the PWM timer code AFAIK. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
