Re: [PATCH RESEND] ARM: pxa: fix error handling in pxa2xx_drv_pcmcia_probe

2011-12-27 Thread Eric Miao
On Tue, Dec 27, 2011 at 4:25 PM, Axel Lin axel@gmail.com wrote: If pxa2xx_drv_pcmcia_add_one fails, it will go to err1 error path. Add a missing clk_put in the error path. Checking the ret value after the for loop is redundant, it is always false. Thus remove the redundant checking.

Re: [PATCH RESEND] ARM: pxa: fix error handling in pxa2xx_drv_pcmcia_probe

2011-12-27 Thread Marek Vasut
If pxa2xx_drv_pcmcia_add_one fails, it will go to err1 error path. Add a missing clk_put in the error path. Checking the ret value after the for loop is redundant, it is always false. Thus remove the redundant checking. Signed-off-by: Axel Lin axel@gmail.com ---

Re: [PATCH RESEND] ARM: pxa: fix error handling in pxa2xx_drv_pcmcia_probe

2011-12-27 Thread Eric Miao
...@lists.infradead.org; linux-pcmcia@lists.infradead.org Subject: Re: [PATCH RESEND] ARM: pxa: fix error handling in pxa2xx_drv_pcmcia_probe On Tue, Dec 27, 2011 at 4:25 PM, Axel Lin axel@gmail.com wrote: If pxa2xx_drv_pcmcia_add_one fails, it will go to err1 error path. Add a missing

Re: [PATCH RESEND] ARM: pxa: fix error handling in pxa2xx_drv_pcmcia_probe

2011-12-27 Thread Haojian Zhuang
: linux-ker...@vger.kernel.org; Haojian Zhuang; Russell King; linux-arm-ker...@lists.infradead.org; linux-pcmcia@lists.infradead.org Subject: Re: [PATCH RESEND] ARM: pxa: fix error handling in pxa2xx_drv_pcmcia_probe On Tue, Dec 27, 2011 at 4:25 PM, Axel Lin axel@gmail.com wrote