[PATCH 14/22] pcmcia: avoid messages on module (un)loading

2010-10-21 Thread Dominik Brodowski
printk() statements on module load or unload are frowned upon. Also, add a few __init or __exit declarations. Tested-by: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/char/pcmcia/cm4000_cs.c|5 -

[PATCH 12/22] pcmcia: remove the Finally, report what we've done message

2010-10-21 Thread Dominik Brodowski
Remove this unnecessary message -- this info is either available in sysfs or by enabling dynamic debug from the PCMCIA core. CC: net...@vger.kernel.org CC: linux-wirel...@vger.kernel.org CC: linux-s...@vger.kernel.org CC: linux-...@vger.kernel.org Tested-by: Wolfram Sang w.s...@pengutronix.de

[PATCH 09/22] pcmcia: Documentation update

2010-10-21 Thread Dominik Brodowski
Fill in missing descriptions and update some others for functions in pcmcia_resource.c. Tested-by: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/pcmcia_resource.c | 111 ++ 1 files changed,

[PATCH 21/22] pcmcia: don't call flush_scheduled_work() spuriously

2010-10-21 Thread Dominik Brodowski
From: Tejun Heo t...@kernel.org au100_generic and soc_common call flush_scheduled_work() spuriously. Remove them. This is to prepare for the deprecation and removal of flush_scheduled_work(). Signed-off-by: Tejun Heo t...@kernel.org Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net

[PATCH 02/22] pcmcia: split up modify_configuration() into two fixup functions

2010-10-21 Thread Dominik Brodowski
pcmcia_modify_configuration() was only used by two drivers to fix up one issue each: setting the Vpp to a different value, and reducing the IO width to 8 bit. Introduce two explicitly named functions handling these things, and remove one further typedef. CC: net...@vger.kernel.org CC:

[PATCH 16/22] pcmcia: add a few debug statements

2010-10-21 Thread Dominik Brodowski
Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/pcmcia_resource.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c index 3194d51..a9af0d7 100644 ---

[PATCH 18/22] pcmcia: fix unused function compile warning

2010-10-21 Thread Dominik Brodowski
From: Maciej Żenczykowski zenczykow...@gmail.com pcmcia_socket_dev_resume() is only referenced from macro SET_SYSTEM_SLEEP_PM_OPS(NULL, pcmcia_socket_dev_resume) which based on CONFIG_PM_SLEEP may or may not actually use its second parameter. Signed-off-by: Maciej Żenczykowski

[PATCH 17/22] pcmcia: vrc4173_cardu: Fix error path for pci_release_regions and pci_disable_device

2010-10-21 Thread Dominik Brodowski
From: Rahul Ruikar rahul.rui...@gmail.com - pci_release_regions called during return error path. - pci_disable_device called for cases where earlier it was enabled. - code duplication avoided/reduced by adding resource release at goto statements. Signed-off-by: Rahul Ruikar

[PATCH 22/22] pcmcia: synclink_cs: fix information leak to userland

2010-10-21 Thread Dominik Brodowski
From: Vasiliy Kulikov sego...@gmail.com Structure new_line is copied to userland with some padding fields unitialized. It leads to leaking of stack memory. Signed-off-by: Vasiliy Kulikov sego...@gmail.com CC: sta...@kernel.org Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net ---

[PATCH 07/22] pcmcia: move config_{base, index, regs} to struct pcmcia_device

2010-10-21 Thread Dominik Brodowski
Several drivers prefer to explicitly set config_{base,index,regs}, formerly known as ConfigBase, ConfigIndex and Present. Instead of passing these values inside config_req_t, store it in struct pcmcia_device. CC: net...@vger.kernel.org CC: linux-wirel...@vger.kernel.org CC:

[git pull] PCMCIA updates for 2.6.36

2010-10-21 Thread Dominik Brodowski
Linus, several PCMCIA updates for 2.6.37 are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git master Please pull from that location. The diffstat and list of changes is below, the individual diffs are sent (at least) to the linux-pcmcia

[PATCH 01/22] pcmcia: do not use win_req_t when calling pcmcia_request_window()

2010-10-21 Thread Dominik Brodowski
Instead of win_req_t, drivers are now requested to fill out struct pcmcia_device *p_dev-resource[2,3,4,5] for up to four iomem ranges. After a call to pcmcia_request_window(), the windows found there are reserved and may be used until pcmcia_release_window() is called. CC: net...@vger.kernel.org

[PATCH 19/22] pcmcia/yenta: guide users in case of problems with O2-bridges

2010-10-21 Thread Dominik Brodowski
From: Wolfram Sang w.s...@pengutronix.de Some cards need the speedups on, some need them off. As we can't detect this reliably, at least give the users a hint how to tweak the system. Reported-by: David Bluecame david.bluec...@gmail.com Signed-off-by: Wolfram Sang w.s...@pengutronix.de

[PATCH 03/22] pcmcia: move Vpp setup to struct pcmcia_device

2010-10-21 Thread Dominik Brodowski
Some drivers prefer to explicitly set Vpp. Instead of passing the voltage inside config_req_t, store it in struct pcmcia_device. CC: linux-...@vger.kernel.org CC: net...@vger.kernel.org CC: linux-...@lists.infradead.org CC: linux-wirel...@vger.kernel.org CC: linux-ser...@vger.kernel.org CC:

[PATCH 13/22] pcmcia: move driver name to struct pcmcia_driver

2010-10-21 Thread Dominik Brodowski
Tested-by: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/ata/pata_pcmcia.c|4 +--- drivers/bluetooth/bluecard_cs.c |4 +--- drivers/bluetooth/bt3c_cs.c |4 +---