[PATCH RESEND] pcmcia: convert drivers/pcmcia/* to use module_platform_driver()

2011-12-27 Thread Axel Lin
This patch converts the drivers in drivers/pcmcia/* to use the module_platform_driver() macro which makes the code smaller and a bit simpler. Cc: Michael Hennerich henner...@blackfin.uclinux.org Cc: Manuel Lauss manuel.la...@gmail.com Cc: Olof Johansson o...@lixom.net Cc: Marc Zyngier

[PATCH] pcmcia: Convert to DEFINE_PCI_DEVICE_TABLE

2011-12-27 Thread Axel Lin
Convert static struct pci_device_id *[] to static DEFINE_PCI_DEVICE_TABLE tables. Also convert to use PCI_DEVICE macro for better readablity. Cc: Maxime Bizon mbi...@freebox.fr Cc: Arjan Van De Ven arj...@redhat.com Cc: Jun Komuro komurojun-...@nifty.com Cc: Yoichi Yuasa yu...@linux-mips.org Cc:

Re: [PATCH RESEND] ARM: pxa: fix error handling in pxa2xx_drv_pcmcia_probe

2011-12-27 Thread Eric Miao
On Tue, Dec 27, 2011 at 4:25 PM, Axel Lin axel@gmail.com wrote: If pxa2xx_drv_pcmcia_add_one fails, it will go to err1 error path. Add a missing clk_put in the error path. Checking the ret value after the for loop is redundant, it is always false. Thus remove the redundant checking.

Re: [PATCH RESEND] ARM: pxa: fix error handling in pxa2xx_drv_pcmcia_probe

2011-12-27 Thread Marek Vasut
If pxa2xx_drv_pcmcia_add_one fails, it will go to err1 error path. Add a missing clk_put in the error path. Checking the ret value after the for loop is redundant, it is always false. Thus remove the redundant checking. Signed-off-by: Axel Lin axel@gmail.com ---

[PATCH RESEND] ARM: pxa: fix error handling in pxa2xx_drv_pcmcia_probe

2011-12-27 Thread Axel Lin
If pxa2xx_drv_pcmcia_add_one fails, it will go to err1 error path. Add a missing clk_put in the error path. Checking the ret value after the for loop is redundant, it is always false. Thus remove the redundant checking. Signed-off-by: Axel Lin axel@gmail.com --- drivers/pcmcia/pxa2xx_base.c

Re: [PATCH RESEND] ARM: pxa: fix error handling in pxa2xx_drv_pcmcia_probe

2011-12-27 Thread Eric Miao
On Tue, Dec 27, 2011 at 5:18 PM, Haojian Zhuang hzhua...@marvell.com wrote: From: Eric Miao [eric.y.m...@gmail.com] Sent: Tuesday, December 27, 2011 5:11 PM To: Axel Lin Cc: linux-ker...@vger.kernel.org; Haojian Zhuang; Russell King;

Re: [PATCH RESEND] ARM: pxa: fix error handling in pxa2xx_drv_pcmcia_probe

2011-12-27 Thread Haojian Zhuang
On Tue, Dec 27, 2011 at 5:25 PM, Eric Miao eric.y.m...@gmail.com wrote: On Tue, Dec 27, 2011 at 5:18 PM, Haojian Zhuang hzhua...@marvell.com wrote: From: Eric Miao [eric.y.m...@gmail.com] Sent: Tuesday, December 27, 2011 5:11 PM To: Axel Lin Cc: