[PATCH] PCMCIA: prevent auto insert during resume.

2007-10-26 Thread Rodolfo Giometti
If a socket has been ejected before sleeping, at resume time it shouldn't be awaked. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- drivers/pcmcia/cs.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c index

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-10-26 Thread Russell King
On Fri, Oct 26, 2007 at 12:51:25PM +0200, Rodolfo Giometti wrote: If a socket has been ejected before sleeping, at resume time it shouldn't be awaked. Conversely, if a card has been inserted into an empty slot prior to resuming, it should be detected. Removing this check prevents that

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-10-26 Thread Russell King
On Fri, Oct 26, 2007 at 05:47:06PM +0200, Rodolfo Giometti wrote: On Fri, Oct 26, 2007 at 04:11:41PM +0100, Russell King wrote: On Fri, Oct 26, 2007 at 12:51:25PM +0200, Rodolfo Giometti wrote: If a socket has been ejected before sleeping, at resume time it shouldn't be awaked.

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-10-26 Thread Russell King
On Fri, Oct 26, 2007 at 06:27:06PM +0200, Rodolfo Giometti wrote: On Fri, Oct 26, 2007 at 05:02:06PM +0100, Russell King wrote: When you bring the battery device out of resume, and you've inserted a card, you want it to be detected. Your change means you have to wait until the system has

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-10-26 Thread Rodolfo Giometti
On Fri, Oct 26, 2007 at 06:00:31PM +0100, Russell King wrote: Also if you didn't eject the socket, at resume the device will be powered up again, my patch just prevents that a pre-powered off device to be turned on at resume time. However you should consider that some

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-10-26 Thread Russell King
On Fri, Oct 26, 2007 at 06:54:00PM +0200, Rodolfo Giometti wrote: On Fri, Oct 26, 2007 at 05:36:51PM +0100, Russell King wrote: On Fri, Oct 26, 2007 at 06:27:06PM +0200, Rodolfo Giometti wrote: On Fri, Oct 26, 2007 at 05:02:06PM +0100, Russell King wrote: When you bring the battery

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-10-26 Thread Rodolfo Giometti
On Fri, Oct 26, 2007 at 07:37:40PM +0100, Russell King wrote: On Fri, Oct 26, 2007 at 07:18:57PM +0200, Rodolfo Giometti wrote: On Fri, Oct 26, 2007 at 06:00:31PM +0100, Russell King wrote: Or that - probably a sysfs attribute on the pcmcia socket would be better. Ok, but how can I