[PATCH 0/5] PXA LX platform support

2009-04-18 Thread Russell King - ARM Linux
The following series adds basic support for the LX platform. This platform is a portable small netbook style machine, with support for touch screen LCD, sound, MMC/SD, one serial port, CF, PCMCIA and MMC. The entire series is posted to the linux-arm-kernel list; individual patches are only

Re: [PATCH] pcmcia: pxa2xx-sharpsl: check if we do have Scoop config

2009-04-20 Thread Russell King - ARM Linux
On Mon, Apr 20, 2009 at 08:01:19PM +0400, Dmitry Eremin-Solenikov wrote: Check if we really have Scoop config, otherwice we can get a nice Oops during probe. Looks to me like -rc material. Please submit to the patch tracker with your (missing) sign-off. Thanks. ---

Re: [RFC PATCH 05/10] PCMCIA: sa1111: wrap soc_pcmcia_socket to contain sa1111 specific data

2009-10-04 Thread Russell King - ARM Linux
On Sun, Oct 04, 2009 at 06:01:40PM -0500, Larry Finger wrote: Russell King wrote: Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/pcmcia/pxa2xx_base.c | 19 +++ drivers/pcmcia/pxa2xx_base.h |3 ++ drivers/pcmcia/pxa2xx_lubbock.c| 10

Re: [RFC PATCH 05/10] PCMCIA: sa1111: wrap soc_pcmcia_socket to contain sa1111 specific data

2009-10-06 Thread Russell King - ARM Linux
On Mon, Oct 05, 2009 at 11:21:13AM +0200, Kristoffer Ericson wrote: My bad, it sent an updated version to linux-pcmcia while forgetting to CC arm. Also totally forgot that I still had it pending inside linux-arm patch tracker. This series has been rebased in my git tree - branch pcmcia. I'll

[RFC PATCH 01/10] PCMCIA: soc_common: convert to a stand alone module

2009-10-27 Thread Russell King - ARM Linux
Convert soc_common.c to be a stand alone module, rather than wrapping it up into the individual SoC specific base modules. In doing this, we need to add init/exit functions for soc_common to register/remove the cpufreq notifier. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk ---

[RFC PATCH 02/10] PCMCIA: soc_common: provide single socket add/remove functionality

2009-10-27 Thread Russell King - ARM Linux
Factor out the functionality for adding and removing a single socket, thereby allowing SoCs to individually register each socket. The advantage of this approach is that SoCs can then extend soc_pcmcia_socket as they wish. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk ---

[RFC PATCH 03/10] PCMCIA: soc_common: push socket removal down to SoC specific support

2009-10-27 Thread Russell King - ARM Linux
Mechanically transplant the removal code from soc_common into each SoC specific base support file, thereby allowing soc_common_drv_pcmcia_remove to be removed. No other changes. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/pcmcia/pxa2xx_base.c| 11 ++-

[RFC PATCH 04/10] PCMCIA: soc_common: push socket probe down into SoC specific support

2009-10-27 Thread Russell King - ARM Linux
Move the individual socket probing and initialization down into the SoC specific support files, thereby allowing soc_common_drv_pcmcia_probe to be eliminated. soc_common.c now no longer deals with distinct groups of sockets. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk ---

[RFC PATCH 05/10] PCMCIA: sa1111: wrap soc_pcmcia_socket to contain sa1111 specific data

2009-10-27 Thread Russell King - ARM Linux
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/pcmcia/pxa2xx_base.c | 19 +++ drivers/pcmcia/pxa2xx_base.h |3 ++ drivers/pcmcia/pxa2xx_lubbock.c| 10 -- drivers/pcmcia/sa1100_badge4.c |7 - drivers/pcmcia/sa1100_jornada720.c |

Re: [RFC PATCH 00/10] PCMCIA soc_common re-factorization

2009-10-27 Thread Russell King - ARM Linux
This is a re-post of the previous patch series, but rebased forward earlier on this month. Review comments would be nice to have, or alternatively acks. Lastly, is there an active PCMCIA maintainer who should take these? ___ Linux PCMCIA

Re: [RFC PATCH 00/10] PCMCIA soc_common re-factorization

2009-10-27 Thread Russell King - ARM Linux
On Tue, Oct 27, 2009 at 11:18:49PM +, Russell King - ARM Linux wrote: This is a re-post of the previous patch series, but rebased forward earlier on this month. Review comments would be nice to have, or alternatively acks. Lastly, is there an active PCMCIA maintainer who should take

Re: [PATCH 3/8] drivers/pcmcia: remove unnecessary kzalloc

2009-11-21 Thread Russell King - ARM Linux
On Sat, Nov 21, 2009 at 04:12:59PM +0100, Julia Lawall wrote: Both kzallocs were added at the same time, when the function was added in commit 701a5dc05ad99a06958b3f97cb69d99b47cebee3. I have added the author to the CC list. That commit id means nothing to me.

[PATCH] add pismo support

2009-11-29 Thread Russell King - ARM Linux
The following patch adds support for PISMO modules found on ARM Ltd development platforms. These are MTD modules, and can have a selection of SRAM, flash or DOC devices as described by an on-board I2C EEPROM. We support SRAM and NOR flash devices only by registering appropriate conventional MTD

Re: [RFC PATCH 01/10] PCMCIA: soc_common: convert to a stand alone module

2009-12-05 Thread Russell King - ARM Linux
On Sat, Dec 05, 2009 at 10:56:33AM +0100, Dominik Brodowski wrote: Russell, On Fri, Dec 04, 2009 at 05:24:17PM +, Russell King - ARM Linux wrote: For the time being, I'll merge your patch into my git tree, but unless Dominik hands my patches back to me for merging, it will be lost

Re: [RFC PATCH 01/10] PCMCIA: soc_common: convert to a stand alone module

2009-12-05 Thread Russell King - ARM Linux
On Sat, Dec 05, 2009 at 12:04:17PM +0100, Dominik Brodowski wrote: Russell, On Sat, Dec 05, 2009 at 10:28:16AM +, Russell King - ARM Linux wrote: On Sat, Dec 05, 2009 at 10:56:33AM +0100, Dominik Brodowski wrote: Russell, On Fri, Dec 04, 2009 at 05:24:17PM +, Russell King

Re: [PATCH] pcmcia/at91_cf: don't redefine SZ_2K

2009-12-22 Thread Russell King - ARM Linux
On Sun, Dec 20, 2009 at 10:10:34PM +0100, Uwe Kleine-König wrote: This fixes: drivers/pcmcia/at91_cf.c:55:1: warning: SZ_2K redefined Since c1191b0 ([ARM] Kirkwood: create a mapping for the Security Accelerator SRAM) Have you checked whether everything which uses at91_cf

Re: [PATCH 0/3] MXC PCMCIA Support

2010-02-20 Thread Russell King - ARM Linux
On Sat, Feb 20, 2010 at 04:32:01PM +0100, Martin Fuzzey wrote: This patch series adds support for the MXC PCMCIA / CF controller. It has been tested on MX21 (with CF card + ide-cs as well as a broadcom based wificard using b43 driver) It has been compile only tested for MX27, MX31 as I

Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c

2010-03-24 Thread Russell King - ARM Linux
On Wed, Mar 24, 2010 at 08:04:58PM -0300, Marcelo Roberto Jimenez wrote: - debug(skt, 2, mask: %s%s%s%s%s%sflags: %s%s%s%s%s%sVcc %d Vpp %d irq %d\n, - (state-csc_mask==0)?NONE :, - (state-csc_maskSS_DETECT)?DETECT :, -

Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c

2010-03-26 Thread Russell King - ARM Linux
On Thu, Mar 25, 2010 at 01:19:29PM +0300, Sergei Shtylyov wrote: Hello. Russell King - ARM Linux wrote: - debug(skt, 2, mask: %s%s%s%s%s%sflags: %s%s%s%s%s%sVcc %d Vpp %d irq %d\n, - (state-csc_mask==0)?NONE :, - (state-csc_maskSS_DETECT)?DETECT

Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c

2010-03-26 Thread Russell King - ARM Linux
On Fri, Mar 26, 2010 at 06:57:07PM -0300, Marcelo Jimenez wrote: On Fri, Mar 26, 2010 at 15:18, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Mar 25, 2010 at 01:19:29PM +0300, Sergei Shtylyov wrote:   I'd disagree in this case. Anybody will hardly grep for mask: %s%s%s%s

Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c

2010-03-28 Thread Russell King - ARM Linux
On Thu, Mar 25, 2010 at 06:04:40PM +0100, Dominik Brodowski wrote: do you prefer me pushing these patches upstream (possibly even for -rc3), or do you wish to take these patches? I'll take them through the patch system, but as they're not bug fixes I'd queue them for the next merge window.

Re: [PATCH] spi: reorganize drivers

2011-06-06 Thread Russell King - ARM Linux
On Mon, Jun 06, 2011 at 11:00:38AM +0200, Arnd Bergmann wrote: This leaves out the two most common buses, USB and PCI, mostly because the directories contain a lot of stuff that is not really bus code but actual drivers. It does include i2c and spi, which stick out by being a lot larger than

[PATCH 00/19] ARM SA11x0 / PXA / SoC-common PCMCIA cleanups

2012-01-20 Thread Russell King - ARM Linux
What follows is a series of 19 patches cleaning up the SA11xx and PXA PCMCIA support, which uses the soc-common infrastructure. Now that we have proper gpiolib support in the kernel for these platforms, with properly implemented gpio_to_irq() functionality, we can move some things that the

[PATCH 01/19] PCMCIA: soc_common: move common initialization into soc_common

2012-01-20 Thread Russell King - ARM Linux
Move common socket initialization into soc_common.c. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/pcmcia/pxa2xx_base.c|5 + drivers/pcmcia/sa_generic.c |4 +--- drivers/pcmcia/sa11xx_base.c|5 + drivers/pcmcia/soc_common.c | 10

[PATCH 03/19] PCMCIA: pxa: convert PXA socket drivers to use new irq/gpio management

2012-01-20 Thread Russell King - ARM Linux
Convert all the PXA platform socket drivers to use the new irq/gpio management provided by soc_common. This relieves these drivers from having to do anything with these GPIOs other than provide the numbers to soc_common. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk ---

[PATCH 05/19] PCMCIA: sa11x0: assabet: convert to use new irq/gpio management

2012-01-20 Thread Russell King - ARM Linux
Convert Assabet socket driver to use the new irq/gpio management. This is slightly more involved because we have to touch the private platform header file to modify the GPIO bitmasks to be GPIO numbers. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk ---

[PATCH 06/19] PCMCIA: sa11x0: cerf: convert to use new irq/gpio management

2012-01-20 Thread Russell King - ARM Linux
Convert Cerf socket driver to use the new irq/gpio management. This is slightly more involved because we have to touch the private platform header file to modify the GPIO bitmasks to be GPIO numbers. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk ---

[PATCH 07/19] PCMCIA: sa11x0: cerf: convert reset handling to use GPIO subsystem

2012-01-20 Thread Russell King - ARM Linux
Rather than accessing GPSR and GPCR directly, use the GPIO subsystem instead. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- arch/arm/mach-sa1100/include/mach/cerf.h |2 +- drivers/pcmcia/sa1100_cerf.c | 19 ++- 2 files changed, 15 insertions(+), 6

[PATCH 08/19] PCMCIA: sa11x0: nanoengine: convert to use new irq/gpio management

2012-01-20 Thread Russell King - ARM Linux
Convert Nanoengine socket driver to use the new irq/gpio management. This is slightly more involved because we have to touch the private platform header file to modify the GPIO bitmasks to be GPIO numbers. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk ---

[PATCH 09/19] PCMCIA: sa11x0: nanoengine: convert reset handling to use GPIO subsystem

2012-01-20 Thread Russell King - ARM Linux
Rather than accessing GPSR and GPCR directly, use the GPIO subsystem instead. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- arch/arm/mach-sa1100/include/mach/nanoengine.h |4 +- drivers/pcmcia/sa1100_nanoengine.c | 38 ++-- 2 files changed, 18

[PATCH 10/19] PCMCIA: sa11x0: shannon: convert to use new irq/gpio management

2012-01-20 Thread Russell King - ARM Linux
Convert Shannon socket driver to use the new irq/gpio management. This is slightly more involved because we have to touch the private platform header file to modify the GPIO bitmasks to be GPIO numbers. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk ---

[PATCH 11/19] PCMCIA: sa11x0: simpad: convert to use new irq/gpio management

2012-01-20 Thread Russell King - ARM Linux
Convert Simpad socket driver to use the new irq/gpio management. This is slightly more involved because we have to touch the private platform header file to modify the GPIO bitmasks to be GPIO numbers. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk ---

[PATCH 12/19] PCMCIA: sa11x0: h3600: convert to use new irq/gpio management

2012-01-20 Thread Russell King - ARM Linux
Convert iPAQ socket driver to use the new irq/gpio management. As this already uses the GPIO subsystem, these changes are localized to just the PCMCIA directory. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/pcmcia/sa1100_h3600.c | 95

[PATCH 14/19] PCMCIA: soc_common: remove explicit wrprot initialization in socket drivers

2012-01-20 Thread Russell King - ARM Linux
soc_common already initializes state.wrprot to zero, so explicitly setting wrprot to zero in the socket drivers has no additional effect. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/pcmcia/pxa2xx_balloon3.c |1 - drivers/pcmcia/pxa2xx_cm_x255.c|1 -

[PATCH 15/19] PCMCIA: sa1111: pass along sa1111_pcmcia_configure_socket() failure code

2012-01-20 Thread Russell King - ARM Linux
Pass along the sa_pcmcia_configure_socket() failure code to higher levels, rather than just returning zero. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/pcmcia/sa1100_badge4.c |2 +- drivers/pcmcia/sa1100_neponset.c |2 +- 2 files changed, 2 insertions(+), 2

[PATCH 16/19] PCMCIA: sa1111: jornada720: no need to disable IRQs around sa1111_set_io

2012-01-20 Thread Russell King - ARM Linux
sa_set_io() already contains the necessary locking within itself to safely change the state of a set of GPIOs. There's no need for callers to protect this by disabling IRQs themselves. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/pcmcia/sa1100_jornada720.c |7

[PATCH 17/19] PCMCIA: Add Kconfig control for building sa11xx_base.c

2012-01-20 Thread Russell King - ARM Linux
sa11xx_base.c is currently built when either PCMCIA_SA1100 or PCMCIA_SA are selected. Let's move the logic into Kconfig. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/pcmcia/Kconfig |5 + drivers/pcmcia/Makefile |5 +++-- 2 files changed, 8 insertions(+),

[PATCH 18/19] PCMCIA: make lubbock socket driver part of sa1111_cs

2012-01-20 Thread Russell King - ARM Linux
Lubbock is just another SA socket driver, so now that Kconfig has better control of which files get built, we can sanitize the build for this. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/pcmcia/Kconfig |5 +++-- drivers/pcmcia/Makefile |3 +-- 2 files

[PATCH 19/19] PCMCIA: sa1111: rename sa1111 socket drivers to have sa1111_ prefix.

2012-01-20 Thread Russell King - ARM Linux
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/pcmcia/Makefile|8 +- drivers/pcmcia/pxa2xx_lubbock.c| 236 drivers/pcmcia/sa1100_badge4.c | 166 - drivers/pcmcia/sa1100_jornada720.c | 114

Re: [PATCH 00/19] ARM SA11x0 / PXA / SoC-common PCMCIA cleanups

2012-01-20 Thread Russell King - ARM Linux
On Fri, Jan 20, 2012 at 10:17:09AM +, Russell King - ARM Linux wrote: What follows is a series of 19 patches cleaning up the SA11xx and PXA PCMCIA support, which uses the soc-common infrastructure. Now that we have proper gpiolib support in the kernel for these platforms, with properly

[BUG] PCMCIA card inserted, five s2ram cycles, you're dead

2012-01-21 Thread Russell King - ARM Linux
ARM platform, a pcnet_cs CF card inserted in pcmcia_socket0's slot which works after each resume. The messages below are produced by: printk(%s: %p [%s] %u\n, __func__, dev, kobject_name(dev-kobj), atomic_read(dev-kobj.kref.refcount)); placed before get_device() in each of the stated functions

[PATCH,FIXED] PCMCIA card inserted, five s2ram cycles, you're dead

2012-01-22 Thread Russell King - ARM Linux
Last night, I wrote: static int pcmcia_bus_early_resume(struct pcmcia_socket *skt) { if (!verify_cis_cache(skt)) { pcmcia_put_socket(skt); return 0; } I've not been able to check that theory tonight. Maybe someone who knows the code can

Re: [PATCH,FIXED] PCMCIA card inserted, five s2ram cycles, you're dead

2012-01-22 Thread Russell King - ARM Linux
Unfortunately, the description will need a couple of edits for it to apply properly (I just applied it to a local private branch.) On Sun, Jan 22, 2012 at 08:51:57AM +, Russell King - ARM Linux wrote: @@ -546,8 +524,8 @@ static int socket_late_resume(struct pcmcia_socket *skt) This needs

Re: [PATCH 1/5] arm: sa1100: add cpu clock

2013-11-12 Thread Russell King - ARM Linux
On Tue, Nov 12, 2013 at 07:32:08AM +0400, Dmitry Eremin-Solenikov wrote: Both SA1100 framebuffer and PCMCIA drivers require knowledge of cpu frequency to correctly program timings. Currently they receive timing information by calling cpufreq_get(0). However if cpu frequency driver is not

Re: [PATCH 2/6] PCI/arm: Use list_for_each_entry() for bus traversal

2014-02-13 Thread Russell King - ARM Linux
On Thu, Feb 13, 2014 at 09:13:59PM +0800, Yijing Wang wrote: Replace list_for_each() + pci_bus_b() with the simpler list_for_each_entry(). Signed-off-by: Yijing Wang wangyij...@huawei.com Acked-by: Russell King rmk+ker...@arm.linux.org.uk -- FTTC broadband for 0.8mile line: 5.8Mbps down

Re: [PATCHv2] pcmcia:Fix memory leak in the function, sa11xx_drv_pcmcia_probe

2015-03-26 Thread Russell King - ARM Linux
On Wed, Mar 25, 2015 at 11:15:52PM -0400, Nicholas Krause wrote: This fixes the memory found when running coccinelle on the latest How does this fix the memory ? Is the memory faulty? kernel tree for if we are unable to successfully allocate memory for the structure pointer,sinfo of type

[PATCH 0/8] sa11x0 PCMCIA updates

2015-03-26 Thread Russell King - ARM Linux
Here's a collection of patches which cleans up and updates the SA11x0 and PXA2xx socket drivers, particularly converting them to the devm_* APIs to ensure that resources are properly cleaned up. I've stopped short of totally converting sa_generic as there are some corner cases where we want

Re: [PATCHv2] pcmcia:Fix memory leak in the function, sa11xx_drv_pcmcia_probe

2015-03-26 Thread Russell King - ARM Linux
On Thu, Mar 26, 2015 at 07:14:38AM -0400, Nicholas Krause wrote: On March 26, 2015 5:52:25 AM EDT, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Mar 25, 2015 at 11:15:52PM -0400, Nicholas Krause wrote: This fixes the memory found when running coccinelle on the latest

Re: [PATCH 4/8] pcmcia: pxa2xx: convert memory allocation to devm_* API

2015-03-28 Thread Russell King - ARM Linux
On Sat, Mar 28, 2015 at 10:38:24PM +0100, Robert Jarzmik wrote: Russell King rmk+ker...@arm.linux.org.uk writes: Convert the pxa2xx socket driver memory allocation to use devm_kzalloc() to simplify the cleanup path. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk ---

Re: [PATCH] Drivers: pcmcia: Fix memroy leak in sa11xx_drv_pcmcia_probe()

2015-04-22 Thread Russell King - ARM Linux
On Wed, Apr 22, 2015 at 04:25:48PM +0800, Firo Yang wrote: From: Firo Yang fir...@gmail.com Allocated clk was never freed if kzalloc() failed to alloc memory for skt_dev_info *sinfo. So just free clk when kzalloc() failed. A similar patch was posted in March, and in March I posted a series

[PATCH 0/8] sa11x0 PCMCIA updates

2015-07-15 Thread Russell King - ARM Linux
A series of PCMCIA updates for SA11x0/PXA devices consisting mainly of patches switching the code to use the devm_* APIs, thus cleaning the code up. The first patch fixes an omitted clk_put() in sa11xx_base.c by switching the clk_get to devm_clk_get(). drivers/pcmcia/pxa2xx_base.c| 17

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-09-02 Thread Russell King - ARM Linux
Linus, There's a change I'd like to merge into patch 5 - overall it looks like the below, and allows us to use gpio-reg with the PXA mainstone MST_PCMCIA[01] registers. Some of these GPIO signals have hardware interrupts associated with them, but not all. Do you approve? Thanks. 8< From:

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-09-02 Thread Russell King - ARM Linux
On Fri, Sep 02, 2016 at 07:50:35PM +0200, Robert Jarzmik wrote: > Russell King - ARM Linux <li...@armlinux.org.uk> writes: > >> Moreover, I have a bit of homework as I also see : > >> - no SA interrupts at all, especially nothing when I insert/remove m

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-09-02 Thread Russell King - ARM Linux
On Fri, Sep 02, 2016 at 11:21:12PM +0200, Robert Jarzmik wrote: > Ah I think I know what happens. The trick is that when this > irq_set_chained_handler_and_data() is called, the irq_desc for irq 305 is not > yet allocated (ie. is NULL). And it is not allocated because >

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-09-05 Thread Russell King - ARM Linux
On Mon, Sep 05, 2016 at 11:06:28AM +0200, Linus Walleij wrote: > I couldn't resist testing on the Compaq iPAQ h3600. It works the > same as before so: > Tested-by: Linus Walleij [for Compaq iPAQ H3600] Great news. I've been thinking about digging out my h3600, but it's

Re: [PATCH 0/3] SA11x0/PXA pcmcia fixes

2016-09-06 Thread Russell King - ARM Linux
On Mon, Aug 29, 2016 at 11:02:32AM +0100, Russell King - ARM Linux wrote: > Further to the DS suspend/resume fix, here's a few more for SA11x0/PXA. > > drivers/pcmcia/sa11xx_base.c | 8 > drivers/pcmcia/soc_common.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletion

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-09-01 Thread Russell King - ARM Linux
On Thu, Sep 01, 2016 at 11:58:28PM +0200, Robert Jarzmik wrote: > Russell King - ARM Linux <li...@armlinux.org.uk> writes: > > On Thu, Sep 01, 2016 at 09:19:13AM +0200, Robert Jarzmik wrote: > > It looks like: > > > > (a) pcmcia_probe() in drivers/pcmc

Re: [PATCH 8/8] ARM: pxa/lubbock: add pcmcia clock

2016-09-07 Thread Russell King - ARM Linux
On Tue, Sep 06, 2016 at 07:17:09PM +0200, Robert Jarzmik wrote: > Russell King writes: > > > Add the required PCMCIA clock for the SA "1800" device. This clock > > is used to compute timing information for the PCMCIA interface in the > > SoC device, rather than

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-09-04 Thread Russell King - ARM Linux
On Sun, Sep 04, 2016 at 09:04:59PM +0200, Robert Jarzmik wrote: > And retested with my 3 patches on top of it. Everything works fine : > - CF insertion is correctly detected now ! > - AT/2 keyboard interrupts fire, keys are there, etc ... > - the AT/2 warning is now gone > > The pxa_cplds_irqs

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-09-03 Thread Russell King - ARM Linux
On Thu, Sep 01, 2016 at 09:19:13AM +0200, Robert Jarzmik wrote: > >From 977c16201a752aac8a8fb2da1f4271795f0b2122 Mon Sep 17 00:00:00 2001 > From: Robert Jarzmik > Date: Thu, 1 Sep 2016 08:31:08 +0200 > Subject: [PATCH] pcmcia: lubbock: fix sockets configuration > > On

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-09-03 Thread Russell King - ARM Linux
On Wed, Aug 31, 2016 at 09:49:38AM +0100, Russell King - ARM Linux wrote: > On Tue, Aug 30, 2016 at 11:32:16PM +0200, Robert Jarzmik wrote: > > Russell King - ARM Linux <li...@armlinux.org.uk> writes: > > > > > If you can wait a day or two, I'll push a branch o

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-09-03 Thread Russell King - ARM Linux
On Fri, Sep 02, 2016 at 11:21:12PM +0200, Robert Jarzmik wrote: > It looks that I have an ordering problem : > - I want gpio-pxa.probe() to be called at device initcall time > - pxa_cplds_irqs.probe() cannot complete before gpio-pxa.probe() because it >needs GPIO0 as its interrupt source >

Re: [PATCH 06/33] ARM: pxa/lubbock: add GPIO driver for LUB_MISC_WR register

2016-08-29 Thread Russell King - ARM Linux
On Mon, Aug 29, 2016 at 09:57:20PM +0200, Robert Jarzmik wrote: > Russell King writes: > If gpio_reg_init() failed (and I know, the probability of a lack of memory at > that stage of the kernel boot is ridiculous), this will end up as an NULL > pointer dereference if

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-29 Thread Russell King - ARM Linux
On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote: > Hi Russell, > > Russell King writes: > > > Add a simple, generic, single register fixed-direction GPIO driver. > > This is able to support a single register where a fixed number of > > bits are used

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-30 Thread Russell King - ARM Linux
On Tue, Aug 30, 2016 at 06:42:03PM +0200, Robert Jarzmik wrote: > Russell King - ARM Linux <li...@armlinux.org.uk> writes: > > > On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote: > >> Maybe this one would deserve a doxygen comment ? > > > > Do

Re: [RFC PATCH 00/33] SA11x0/PXA GPIO rework (Core + PCMCIA only)

2016-09-01 Thread Russell King - ARM Linux
On Tue, Aug 30, 2016 at 11:31:58PM +0200, Linus Walleij wrote: > For all the GPIO patches: > Acked-by: Linus Walleij > > With the smallish changes needed to patch 5/33 that one is acked too. > > In fact I would ACK it anyway, because the net total cleanup is so > nice

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-30 Thread Russell King - ARM Linux
On Tue, Aug 30, 2016 at 11:25:19PM +0200, Linus Walleij wrote: > On Mon, Aug 29, 2016 at 12:24 PM, Russell King > wrote: > > > Add a simple, generic, single register fixed-direction GPIO driver. > > This is able to support a single register where a fixed number of > >

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-31 Thread Russell King - ARM Linux
On Tue, Aug 30, 2016 at 11:32:16PM +0200, Robert Jarzmik wrote: > Russell King - ARM Linux <li...@armlinux.org.uk> writes: > > > If you can wait a day or two, I'll push a branch out for everything in > > all these multiple series. > Sure, just ping me wh

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-31 Thread Russell King - ARM Linux
On Wed, Aug 31, 2016 at 09:49:38AM +0100, Russell King - ARM Linux wrote: > On Tue, Aug 30, 2016 at 11:32:16PM +0200, Robert Jarzmik wrote: > > Russell King - ARM Linux <li...@armlinux.org.uk> writes: > > > > > If you can wait a day or two, I'll push a branch o

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-30 Thread Russell King - ARM Linux
On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote: > Maybe this one would deserve a doxygen comment ? Does this solve it? diff --git a/drivers/gpio/gpio-reg.c b/drivers/gpio/gpio-reg.c index fc7e0a395f9f..b91488ec122c 100644 --- a/drivers/gpio/gpio-reg.c +++

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-30 Thread Russell King - ARM Linux
On Tue, Aug 30, 2016 at 09:08:03AM +0300, Alexander Shiyan wrote: > >Вторник, 30 августа 2016, 2:12 +03:00 от Russell King - ARM Linux > ><li...@armlinux.org.uk>: > > > >On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote: > >> Hi Rus

Re: [PATCH 18/33] pcmcia: sa1100: provide generic CF support

2016-09-14 Thread Russell King - ARM Linux
On Wed, Sep 14, 2016 at 10:52:39AM +0200, Linus Walleij wrote: > On Mon, Aug 29, 2016 at 12:25 PM, Russell King > wrote: > > > Provide generic non-voltage sensing socket support for StrongARM > > platforms using the gpiolib and regulator subsystems to obtain the > >

Re: [PATCH 10/33] pcmcia: soc_common: switch to using gpio_descs

2016-09-14 Thread Russell King - ARM Linux
On Wed, Sep 14, 2016 at 01:29:04PM +0200, Linus Walleij wrote: > On Mon, Aug 29, 2016 at 12:24 PM, Russell King > wrote: > > > Switch to using the gpiod_* consumer API rather than the legacy API. > > > > Signed-off-by: Russell King > (...)

Re: [PATCH] pcmcia: ds: fix suspend/resume

2016-08-27 Thread Russell King - ARM Linux
On Sat, Aug 27, 2016 at 02:05:22PM +0200, Dominik Brodowski wrote: > Russell, > > On Sun, Aug 21, 2016 at 12:05:30AM +0100, Russell King wrote: > > PCMCIA suspend/resume no longer works since the commit mentioned below, > > as the callbacks are no longer made. Convert the driver to the new > >

[PATCH 0/3] SA11x0/PXA pcmcia fixes

2016-08-29 Thread Russell King - ARM Linux
Further to the DS suspend/resume fix, here's a few more for SA11x0/PXA. drivers/pcmcia/sa11xx_base.c | 8 drivers/pcmcia/soc_common.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for

[RFC PATCH 00/33] SA11x0/PXA GPIO rework (Core + PCMCIA only)

2016-08-29 Thread Russell King - ARM Linux
Following on from the PCMCIA fixes, this series reworks GPIO on SA11x0 and PXA platforms. This is a subset of a larger series, which I'm splitting up due to its size. This part contains the base and PCMCIA updates. Further updates for IrDA drivers, DMA engine, serial, and ethernet will follow

Re: [PATCH 16/28] pcmcia: fix return value of soc_pcmcia_regulator_set

2016-10-18 Thread Russell King - ARM Linux
On Tue, Oct 18, 2016 at 12:13:37AM +0200, Arnd Bergmann wrote: > The newly introduced soc_pcmcia_regulator_set() function sometimes returns > without setting its return code, as shown by this warning: > > drivers/pcmcia/soc_common.c: In function 'soc_pcmcia_regulator_set': >

Re: [PATCH] drivers/pcmcia: Convert timers to use timer_setup()

2017-10-27 Thread Russell King - ARM Linux
On Tue, Oct 24, 2017 at 03:23:31AM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Florian Fainelli