[PATCH 1/3] pcmcia: m32r_pcc: check return from request_irq

2016-09-18 Thread Sudip Mukherjee
it to the caller. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- m32r allmodconfig build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/160355863 drivers/pcmcia/m32r_pcc.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/d

[PATCH 3/3] pcmcia: m32r_pcc: check return from add_pcc_socket

2016-09-18 Thread Sudip Mukherjee
If request_irq() fails it passes the error to the caller. The caller now checks it and jumps to the common error path on failure. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/pcmcia/m32r_pcc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)

Re: [PATCH 1/3] pcmcia: m32r_pcc: check return from request_irq

2016-11-13 Thread Sudip Mukherjee
On Sunday 18 September 2016 11:21 PM, Sudip Mukherjee wrote: While building m32r allmodconfig we were getting warning: drivers/pcmcia/m32r_pcc.c:331:2: warning: ignoring return value of 'request_irq', declared with attribute warn_unused_result request_irq() can fail and we should always