Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Thu, Sep 8, 2016 at 3:21 PM, Linus Walleij wrote: > On Mon, Sep 5, 2016 at 2:26 PM, Russell King - ARM Linux > wrote: >> On Mon, Sep 05, 2016 at 11:06:28AM +0200, Linus Walleij wrote: >>> I couldn't resist testing on the Compaq iPAQ h3600. It

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Mon, Sep 5, 2016 at 2:26 PM, Russell King - ARM Linux wrote: > On Mon, Sep 05, 2016 at 11:06:28AM +0200, Linus Walleij wrote: >> I couldn't resist testing on the Compaq iPAQ h3600. It works the >> same as before so: >> Tested-by: Linus Walleij

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Mon, Sep 05, 2016 at 11:06:28AM +0200, Linus Walleij wrote: > I couldn't resist testing on the Compaq iPAQ h3600. It works the > same as before so: > Tested-by: Linus Walleij [for Compaq iPAQ H3600] Great news. I've been thinking about digging out my h3600, but it's

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Wed, Aug 31, 2016 at 10:49 AM, Russell King - ARM Linux wrote: > git://git.armlinux.org.uk/~rmk/linux-arm.git sa1100 > > It would be great to have this tested on Lubbock, and get the PCMCIA > issues fixed. Maybe we can look at converting mainstone as well? I couldn't

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Fri, Sep 2, 2016 at 7:00 PM, Russell King - ARM Linux wrote: > Linus, > > There's a change I'd like to merge into patch 5 - overall it looks > like the below, and allows us to use gpio-reg with the PXA mainstone > MST_PCMCIA[01] registers. Some of these GPIO signals

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Sun, Sep 04, 2016 at 09:04:59PM +0200, Robert Jarzmik wrote: > And retested with my 3 patches on top of it. Everything works fine : > - CF insertion is correctly detected now ! > - AT/2 keyboard interrupts fire, keys are there, etc ... > - the AT/2 warning is now gone > > The pxa_cplds_irqs

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

Russell King - ARM Linux writes: > On Wed, Aug 31, 2016 at 09:49:38AM +0100, Russell King - ARM Linux wrote: >> On Tue, Aug 30, 2016 at 11:32:16PM +0200, Robert Jarzmik wrote: >> > Russell King - ARM Linux writes: >> > >> > > If you can wait a day

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

Russell King - ARM Linux writes: > On Wed, Aug 31, 2016 at 09:49:38AM +0100, Russell King - ARM Linux wrote: >> On Tue, Aug 30, 2016 at 11:32:16PM +0200, Robert Jarzmik wrote: >> > Russell King - ARM Linux writes: >> > >> > > If you can wait a day

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Fri, Sep 02, 2016 at 11:21:12PM +0200, Robert Jarzmik wrote: > It looks that I have an ordering problem : > - I want gpio-pxa.probe() to be called at device initcall time > - pxa_cplds_irqs.probe() cannot complete before gpio-pxa.probe() because it >needs GPIO0 as its interrupt source >

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Thu, Sep 01, 2016 at 09:19:13AM +0200, Robert Jarzmik wrote: > >From 977c16201a752aac8a8fb2da1f4271795f0b2122 Mon Sep 17 00:00:00 2001 > From: Robert Jarzmik > Date: Thu, 1 Sep 2016 08:31:08 +0200 > Subject: [PATCH] pcmcia: lubbock: fix sockets configuration > > On

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Fri, Sep 02, 2016 at 07:50:35PM +0200, Robert Jarzmik wrote: > Russell King - ARM Linux writes: > >> Moreover, I have a bit of homework as I also see : > >> - no SA interrupts at all, especially nothing when I insert/remove my > >>CompactFlash card > >>This

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

Russell King - ARM Linux writes: >> You're right, I submitted a patch for that, and I confirm it actually >> happens on >> lubbock. > > That'll work fine for lubbock, but not the others (we can have several > of the others enabled on sa11x0 platforms - eg, badge4 with

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

Linus, There's a change I'd like to merge into patch 5 - overall it looks like the below, and allows us to use gpio-reg with the PXA mainstone MST_PCMCIA[01] registers. Some of these GPIO signals have hardware interrupts associated with them, but not all. Do you approve? Thanks. 8< From:

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Thu, Sep 01, 2016 at 11:58:28PM +0200, Robert Jarzmik wrote: > Russell King - ARM Linux writes: > > On Thu, Sep 01, 2016 at 09:19:13AM +0200, Robert Jarzmik wrote: > > It looks like: > > > > (a) pcmcia_probe() in drivers/pcmcia/sa_generic.c doesn't check the > >

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Wed, Aug 31, 2016 at 09:49:38AM +0100, Russell King - ARM Linux wrote: > On Tue, Aug 30, 2016 at 11:32:16PM +0200, Robert Jarzmik wrote: > > Russell King - ARM Linux writes: > > > > > If you can wait a day or two, I'll push a branch out for everything in > > > all these

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Tue, Aug 30, 2016 at 11:32:16PM +0200, Robert Jarzmik wrote: > Russell King - ARM Linux writes: > > > If you can wait a day or two, I'll push a branch out for everything in > > all these multiple series. > Sure, just ping me when you have something.

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Tue, Aug 30, 2016 at 11:42 PM, Russell King - ARM Linux wrote: > On Tue, Aug 30, 2016 at 11:25:19PM +0200, Linus Walleij wrote: >> > +#define to_gpio_reg(x) container_of(x, struct gpio_reg, gc) >> >> You don't need that trickery anymore, just: >> >> > +static int

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Tue, Aug 30, 2016 at 11:25:19PM +0200, Linus Walleij wrote: > On Mon, Aug 29, 2016 at 12:24 PM, Russell King > wrote: > > > Add a simple, generic, single register fixed-direction GPIO driver. > > This is able to support a single register where a fixed number of > >

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

Russell King - ARM Linux writes: > If you can wait a day or two, I'll push a branch out for everything in > all these multiple series. Sure, just ping me when you have something. Cheers. -- Robert ___ Linux PCMCIA

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Mon, Aug 29, 2016 at 12:24 PM, Russell King wrote: > Add a simple, generic, single register fixed-direction GPIO driver. > This is able to support a single register where a fixed number of > bits are used for input and a fixed number of bits used for output. > >

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Tue, Aug 30, 2016 at 06:42:03PM +0200, Robert Jarzmik wrote: > Russell King - ARM Linux writes: > > > On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote: > >> Maybe this one would deserve a doxygen comment ? > > > > Does this solve it? > Oh yes, that's very

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

Russell King - ARM Linux writes: > On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote: >> Maybe this one would deserve a doxygen comment ? > > Does this solve it? Oh yes, that's very nice, especially the "1 = in" for which I have always a doubt. Reviewed-by:

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Tue, Aug 30, 2016 at 09:08:03AM +0300, Alexander Shiyan wrote: > >Вторник, 30 августа 2016, 2:12 +03:00 от Russell King - ARM Linux > >: > > > >On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote: > >> Hi Russell, > >> > >> Russell King <

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

>Вторник, 30 августа 2016, 2:12 +03:00 от Russell King - ARM Linux >: > >On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote: >> Hi Russell, >> >> Russell King < rmk+ker...@armlinux.org.uk > writes: >> >> > Add a simple, generic, single register fixed-direction

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote: > Hi Russell, > > Russell King writes: > > > Add a simple, generic, single register fixed-direction GPIO driver. > > This is able to support a single register where a fixed number of > > bits are used

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

Hi Russell, Russell King writes: > Add a simple, generic, single register fixed-direction GPIO driver. > This is able to support a single register where a fixed number of > bits are used for input and a fixed number of bits used for output. > > Signed-off-by: Russell