Re: [PATCH 06/11] drivers/net: use module_pcmcia_driver() in pcmcia drivers

2013-03-07 Thread Kurt Van Dijck 
Hi,

I just realized that after this patch, you may want to include
drivers/net/can/softing/softing_cs.c in your series too.
I will send you that in a minute.

Kind regards,
Kurt Van Dijck
--
commit 583c422b0c141caaca89c131475cc9dd5f67bab7
Author: Kurt Van Dijck kurt.van.di...@eia.be
Date:   Thu Mar 7 13:20:20 2013

softingcs: initialize spinlock with macro

Signed-off-by: Kurt Van Dijck kurt.van.di...@eia.be

diff --git a/drivers/net/can/softing/softing_cs.c 
b/drivers/net/can/softing/softing_cs.c
index c0e1b1e..5dec2db 100644
--- a/drivers/net/can/softing/softing_cs.c
+++ b/drivers/net/can/softing/softing_cs.c
@@ -27,7 +27,7 @@
 #include softing_platform.h
 
 static int softingcs_index;
-static spinlock_t softingcs_index_lock;
+static DEFINE_SPINLOCK(softingcs_index_lock);
 
 static int softingcs_reset(struct platform_device *pdev, int v);
 static int softingcs_enable_irq(struct platform_device *pdev, int v);
@@ -343,7 +343,6 @@ static struct pcmcia_driver softingcs_driver = {
 
 static int __init softingcs_start(void)
 {
-   spin_lock_init(softingcs_index_lock);
return pcmcia_register_driver(softingcs_driver);
 }
 

___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia

Re: [PATCH 06/11] drivers/net: use module_pcmcia_driver() in pcmcia drivers

2013-03-07 Thread Kurt Van Dijck 
As promised, a patch that will apply afther modifying the spinlock initializer.

--
commit 7e82c8d4f4fd2eb503952f0ce8186a4fa606f084
Author: Kurt Van Dijck kurt.van.di...@eia.be
Date:   Thu Mar 7 13:21:20 2013

softingcs: use module_pcmcia_driver

Signed-off-by: Kurt Van Dijck kurt.van.di...@eia.be

diff --git a/drivers/net/can/softing/softing_cs.c 
b/drivers/net/can/softing/softing_cs.c
index 5dec2db..993d83e 100644
--- a/drivers/net/can/softing/softing_cs.c
+++ b/drivers/net/can/softing/softing_cs.c
@@ -341,18 +341,7 @@ static struct pcmcia_driver softingcs_driver = {
.remove = __devexit_p(softingcs_remove),
 };
 
-static int __init softingcs_start(void)
-{
-   return pcmcia_register_driver(softingcs_driver);
-}
-
-static void __exit softingcs_stop(void)
-{
-   pcmcia_unregister_driver(softingcs_driver);
-}
-
-module_init(softingcs_start);
-module_exit(softingcs_stop);
+module_pcmcia_driver(softingcs_driver);
 
 MODULE_DESCRIPTION(softing CANcard driver
, links PCMCIA card to softing driver);

___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia