Re: SOLVED: kernel-mode PPPoE does not seem able to work with MPPE.

On 26/10/17 11:39, David Fernandez wrote: Right, seems that the latest kernel has not bother with this at all (at least in kernel.org). The two patches proposed in the links above are basically all that is needed AFAICS, only that the first one seems wrong in using only ccount to avoid the

Re: SOLVED: kernel-mode PPPoE does not seem able to work with MPPE.

On 06/11/17 14:19, Charlie Brady wrote: Why would you do this, rather than just delete the code you are removing? --- a/drivers/net/ppp/ppp_mppe.c +++ b/drivers/net/ppp/ppp_mppe.c @@ -521,11 +521,12 @@ mppe_decompress(void *arg, unsigned char     state->sanity_errors += 100;  

Re: [PATCH v3 04/21] ppp: exit_net cleanup checks added

Hello Vasily Averin, just a general hint: when you send new versions of a patch please document also what you have changed. Here an example from an other ML: The problematic code looks like this: res_seq = res_hdr->xd_hdr.length_sn & TB_XDOMAIN_SN_MASK; res_seq >>=

Re: SOLVED: kernel-mode PPPoE does not seem able to work with MPPE.

Why would you do this, rather than just delete the code you are removing? > --- a/drivers/net/ppp/ppp_mppe.c > +++ b/drivers/net/ppp/ppp_mppe.c > @@ -521,11 +521,12 @@ mppe_decompress(void *arg, unsigned char >     state->sanity_errors += 100; >     goto sanity_error; >   

Re: [PATCH v3 04/21] ppp: exit_net cleanup checks added

Dear Walter, thank you for feedback, I'll do it next time. Changes was listed in cover letter, that was not not submitted into linux-ppp@ list "This patch set checks that lists initialized in net_init hooks were return to initial state at end of net_exit hooks. I hope such checks allows to

[PATCH v3 04/21] ppp: exit_net cleanup checks added

Be sure that lists initialized in net_init hook were return to initial state. Signed-off-by: Vasily Averin --- drivers/net/ppp/ppp_generic.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c index