Re: [patch] md: bitmap read_page error

2007-01-23 Thread Neil Brown
On Tuesday January 23, [EMAIL PROTECTED] wrote: I think your patch is not enough to slove the read_page error completely. I think in the bitmap_init_from_disk we also need to check the 'count' never exceeds the size of file before calling the read_page function. How do your think about it.

[patch] md: bitmap read_page error

2007-01-22 Thread yang yin
If the bitmap size is less than one page including super_block and bitmap and the inode's i_blkbits is also small, when doing the read_page function call to read the sb_page, it may return a error. For example, if the device is 12800 chunks, its bitmap file size is about 1.6KB include the bitmap

Re: [patch] md: bitmap read_page error

2007-01-22 Thread Neil Brown
On Monday January 22, [EMAIL PROTECTED] wrote: If the bitmap size is less than one page including super_block and bitmap and the inode's i_blkbits is also small, when doing the read_page function call to read the sb_page, it may return a error. For example, if the device is 12800 chunks, its

Re: [patch] md: bitmap read_page error

2007-01-22 Thread yang yin
I think your patch is not enough to slove the read_page error completely. I think in the bitmap_init_from_disk we also need to check the 'count' never exceeds the size of file before calling the read_page function. How do your think about it. Thanks your reply. 2007/1/23, Neil Brown [EMAIL