[PATCH] lvm2 support for detecting v1.x MD superblocks

2007-10-23 Thread Mike Snitzer
lvm2's MD v1.0 superblock detection doesn't work at all (because it doesn't use v1 sb offsets). I've tested the attached patch to work on MDs with v0.90.0, v1.0, v1.1, and v1.2 superblocks. please advise, thanks. Mike Index: lib/device/dev-md.c

Re: async_tx: get best channel

2007-10-23 Thread Dan Williams
On Fri, 2007-10-19 at 05:23 -0700, Yuri Tikhonov wrote: Hello Dan, Hi Yuri, sorry it has taken me so long to get back to you... I have a suggestion regarding the async_tx_find_channel() procedure. First, a little introduction. Some processors (e.g. ppc440spe) have several DMA

Re: very degraded RAID5, or increasing capacity by adding discs

2007-10-23 Thread Bill Davidsen
Louis-David Mitterrand wrote: On Tue, Oct 09, 2007 at 01:48:50PM +0400, Michael Tokarev wrote: There still is - at least for ext[23]. Even offline resizers can't do resizes from any to any size, extfs developers recommend to recreate filesystem anyway if size changes significantly. I'm too

Re: Software RAID when it works and when it doesn't

2007-10-23 Thread Bill Davidsen
Alberto Alonso wrote: On Thu, 2007-10-18 at 17:26 +0200, Goswin von Brederlow wrote: Mike Accetta [EMAIL PROTECTED] writes: What I would like to see is a timeout driven fallback mechanism. If one mirror does not return the requested data within a certain time (say 1 second) then

Re: Time to deprecate old RAID formats?

2007-10-23 Thread Bill Davidsen
John Stoffel wrote: Why do we have three different positions for storing the superblock? Why do you suggest changing anything until you get the answer to this question? If you don't understand why there are three locations, perhaps that would be a good initial investigation. Clearly the

Re: Time to deprecate old RAID formats?

2007-10-23 Thread Bill Davidsen
Doug Ledford wrote: On Fri, 2007-10-19 at 23:23 +0200, Iustin Pop wrote: On Fri, Oct 19, 2007 at 02:39:47PM -0400, John Stoffel wrote: And if putting the superblock at the end is problematic, why is it the default? Shouldn't version 1.1 be the default? In my opinion, having

Re: Time to deprecate old RAID formats?

2007-10-23 Thread Bill Davidsen
John Stoffel wrote: Michael == Michael Tokarev [EMAIL PROTECTED] writes: Michael Doug Ledford wrote: Michael [] 1.0, 1.1, and 1.2 are the same format, just in different positions on the disk. Of the three, the 1.1 format is the safest to use since it won't allow you to

Re: Time to deprecate old RAID formats?

2007-10-23 Thread Bill Davidsen
Justin Piszcz wrote: On Fri, 19 Oct 2007, John Stoffel wrote: Justin == Justin Piszcz [EMAIL PROTECTED] writes: Justin On Fri, 19 Oct 2007, John Stoffel wrote: So, Is it time to start thinking about deprecating the old 0.9, 1.0 and 1.1 formats to just standardize on the 1.2 format?

Re: Time to deprecate old RAID formats?

2007-10-23 Thread Doug Ledford
On Tue, 2007-10-23 at 19:03 -0400, Bill Davidsen wrote: John Stoffel wrote: Why do we have three different positions for storing the superblock? Why do you suggest changing anything until you get the answer to this question? If you don't understand why there are three locations,

Re: chunk size (was Re: Time to deprecate old RAID formats?)

2007-10-23 Thread Doug Ledford
On Tue, 2007-10-23 at 21:21 +0200, Michal Soltys wrote: Doug Ledford wrote: Well, first I was thinking of files in the few hundreds of megabytes each to gigabytes each, and when they are streamed, they are streamed at a rate much lower than the full speed of the array, but still at a

Re: Time to deprecate old RAID formats?

2007-10-23 Thread Doug Ledford
On Sat, 2007-10-20 at 22:24 +0400, Michael Tokarev wrote: John Stoffel wrote: Michael == Michael Tokarev [EMAIL PROTECTED] writes: As Doug says, and I agree strongly, you DO NOT want to have the possibility of confusion and data loss, especially on bootup. And There are different point

Re: Time to deprecate old RAID formats?

2007-10-23 Thread Doug Ledford
On Mon, 2007-10-22 at 16:39 -0400, John Stoffel wrote: I don't agree completely. I think the superblock location is a key issue, because if you have a superblock location which moves depending the filesystem or LVM you use to look at the partition (or full disk) then you need to be even more

Re: [lvm-devel] [PATCH] lvm2 support for detecting v1.x MD superblocks

2007-10-23 Thread Alasdair G Kergon
On Tue, Oct 23, 2007 at 11:32:56AM -0400, Mike Snitzer wrote: I've tested the attached patch to work on MDs with v0.90.0, v1.0, v1.1, and v1.2 superblocks. I'll apply this, thanks, but need to add comments (or reference) to explain what the hard-coded numbers are: sb_offset = (size -

Re: [lvm-devel] [PATCH] lvm2 support for detecting v1.x MD superblocks

2007-10-23 Thread Mike Snitzer
On 10/23/07, Alasdair G Kergon [EMAIL PROTECTED] wrote: On Tue, Oct 23, 2007 at 11:32:56AM -0400, Mike Snitzer wrote: I've tested the attached patch to work on MDs with v0.90.0, v1.0, v1.1, and v1.2 superblocks. I'll apply this, thanks, but need to add comments (or reference) to explain

Re: Software RAID when it works and when it doesn't

2007-10-23 Thread Alberto Alonso
On Tue, 2007-10-23 at 18:45 -0400, Bill Davidsen wrote: I'm not sure the timeouts are the problem, even if md did its own timeout, it then needs a way to tell the driver (or device) to stop retrying. I don't believe that's available, certainly not everywhere, and anything other than