Re: [PATCH 003 of 6] md: Remove 'experimental' classification from raid5 reshape.

2006-09-28 Thread Jeff Breidenbach
Typo in last line of this patch. + In unsure, say Y. - To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 004 of 6] md: Use ffz instead of find_first_set to convert multiplier to shift.

2006-09-28 Thread NeilBrown
From: Paul Clements <[EMAIL PROTECTED]> find_first_set doesn't find the least-significant bit on bigendian machines, so it is really wrong to use it. ffs is closer, but takes an 'int' and we have a 'unsigned long'. So use ffz(~X) to convert a chunksize into a chunkshift. Signed-off-by: Neil Br

[PATCH 006 of 6] md: Add error reporting to superblock write failure

2006-09-28 Thread NeilBrown
Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./drivers/md/md.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff .prev/drivers/md/md.c ./drivers/md/md.c --- .prev/drivers/md/md.c 2006-09-29 11:49:00.0 +1000 +++ ./drivers/md/md.c 2006-09-29

[PATCH 002 of 6] md: Remove MAX_MD_DEVS which is an arbitrary limit.

2006-09-28 Thread NeilBrown
Once upon a time we needed to fixed limit to the number of md devices, probably because we preallocated some array. This need no longer exists, but we still have an arbitrary limit. So remove MAX_MD_DEVS and allow as many devices as we can fit into the 'minor' part of a device number. Also remov

[PATCH 001 of 6] md: Fix duplicity of levels in md.txt

2006-09-28 Thread NeilBrown
md.txt has two sections describing the 'level' sysfs attribute, and some of the text is out-of-date. So make just one section, and make it right. Cc: Christian Kujau <[EMAIL PROTECTED]> Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./Documentation/md.txt | 17 +

[PATCH 003 of 6] md: Remove 'experimental' classification from raid5 reshape.

2006-09-28 Thread NeilBrown
I have had enough success reports not to believe that this is safe for 2.6.19. Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./drivers/md/Kconfig | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff .prev/drivers/md/Kconfig ./drivers/md/Kconfig --- .pre

[PATCH 005 of 6] md: Allow SET_BITMAP_FILE to work on 64bit kernel with 32bit userspace.

2006-09-28 Thread NeilBrown
From: Paul Clements <[EMAIL PROTECTED]> Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./include/linux/compat_ioctl.h |1 + 1 file changed, 1 insertion(+) diff .prev/include/linux/compat_ioctl.h ./include/linux/compat_ioctl.h --- .prev/include/linux/compat_ioctl.h 2006-0

Re: [BUG/PATCH] md bitmap broken on big endian machines

2006-09-28 Thread Paul Clements
Michael Tokarev wrote: Neil Brown wrote: ffs is closer, but takes an 'int' and we have a 'unsigned long'. So use ffz(~X) to convert a chunksize into a chunkshift. So we don't use ffs(int) for an unsigned value because of int vs unsigned int, but we use ffz() with negated UNSIGNED. Looks eve

Re: [BUG/PATCH] md bitmap broken on big endian machines

2006-09-28 Thread Michael Tokarev
Neil Brown wrote: [] > Use ffz instead of find_first_set to convert multiplier to shift. > > From: Paul Clements <[EMAIL PROTECTED]> > > find_first_set doesn't find the least-significant bit on bigendian > machines, so it is really wrong to use it. > > ffs is closer, but takes an 'int' and we ha

old raid tools dangerous with 2.6.18?

2006-09-28 Thread Richard Bollinger
It appears that raidhotadd doesn't always trigger a resync under 2.6.18. Starting with a broken raid1 mirror: [EMAIL PROTECTED]:~# mdadm --misc --query --detail /dev/md1 /dev/md1: Version : 00.90.03 Creation Time : Thu Apr 6 13:39:04 2006 Raid Level : raid1 Array Size : 4112576

Re: 2.6.18-mm2

2006-09-28 Thread Michal Piotrowski
Hi, On 28/09/06, Andrew Morton <[EMAIL PROTECTED]> wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18/2.6.18-mm2/ === [ INFO: possible circular locking dependency detected ] 2.6.18-mm2 #1 --

Re: [PATCH] md SET_BITMAP_FILE compat ioctl

2006-09-28 Thread Neil Brown
On Friday September 22, [EMAIL PROTECTED] wrote: > The SET_BITMAP_FILE ioctl currently doesn't have a compat entry, so on > 64-bit systems a 32-bit mdadm will fail: > > Sep 20 16:34:52 caspian kernel: ioctl32(mdadm:8056): Unknown cmd fd(3) > cmd(8004092b){00} arg(0004) on /dev/md0 > > The f