Re: [stable] [PATCH 000 of 2] md: Fixes for md in 2.6.23

2007-11-14 Thread Greg KH
On Tue, Nov 13, 2007 at 10:36:30PM -0700, Dan Williams wrote: > On Nov 13, 2007 8:43 PM, Greg KH <[EMAIL PROTECTED]> wrote: > > > > > > Careful, it looks like you cherry picked commit 4ae3f847 "md: raid5: > > > fix clearing of biofill operations"

Re: [stable] [PATCH 000 of 2] md: Fixes for md in 2.6.23

2007-11-13 Thread Greg KH
On Tue, Nov 13, 2007 at 08:36:05PM -0700, Dan Williams wrote: > On Nov 13, 2007 5:23 PM, Greg KH <[EMAIL PROTECTED]> wrote: > > On Tue, Nov 13, 2007 at 04:22:14PM -0800, Greg KH wrote: > > > On Mon, Oct 22, 2007 at 05:15:27PM +1000, NeilBrown wrote: > > > > >

Re: [stable] [PATCH 000 of 2] md: Fixes for md in 2.6.23

2007-11-13 Thread Greg KH
On Tue, Nov 13, 2007 at 04:22:14PM -0800, Greg KH wrote: > On Mon, Oct 22, 2007 at 05:15:27PM +1000, NeilBrown wrote: > > > > It appears that a couple of bugs slipped in to md for 2.6.23. > > These two patches fix them and are appropriate for 2.6.23.y as well > > as

Re: [stable] [PATCH 000 of 2] md: Fixes for md in 2.6.23

2007-11-13 Thread Greg KH
On Mon, Oct 22, 2007 at 05:15:27PM +1000, NeilBrown wrote: > > It appears that a couple of bugs slipped in to md for 2.6.23. > These two patches fix them and are appropriate for 2.6.23.y as well > as 2.6.24-rcX > > Thanks, > NeilBrown > > [PATCH 001 of 2] md: Fix an unsigned compare to allow cr

[patch 08/26] md: Fix bug in error handling during raid1 repair.

2007-07-30 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Mike Accetta <[EMAIL PROTECTED]> If raid1/repair (which reads all block and fixes any differences it finds) hits a read error, it doesn't reset the bio for writing before writing correct data back,

[patch 07/26] md: Fix two raid10 bugs.

2007-07-30 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- 1/ When resyncing a degraded raid10 which has more than 2 copies of each block, garbage can get synced on top of good data. 2/ We round the wrong way in part of the device size calculation, which can

[patch 11/31] Fix calculation for size of filemap_attr array in md/bitmap.

2007-04-11 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Neil Brown <[EMAIL PROTECTED]> If 'num_pages' were ever 1 more than a multiple of 8 (32bit platforms) for of 16 (64 bit platforms). filemap_attr would be allocated one 'unsigned long' shorter than re

[patch 021/101] md: Avoid possible BUG_ON in md bitmap handling.

2007-03-07 Thread Greg KH
From: Neil Brown <[EMAIL PROTECTED]> md/bitmap tracks how many active write requests are pending on blocks associated with each bit in the bitmap, so that it knows when it can clear the bit (when count hits zero). The counter has 14 bits of space, so if there are ever more than 16383, we cannot c

[patch 045/101] md: Fix raid10 recovery problem.

2007-03-07 Thread Greg KH
From: NeilBrown <[EMAIL PROTECTED]> There are two errors that can lead to recovery problems with raid10 when used in 'far' more (not the default). Due to a '>' instead of '>=' the wrong block is located which would result in garbage being written to some random location, quite possible outside th

Re: 2.6.19.2, cp 18gb_file 18gb_file.2 = OOM killer, 100% reproducible (multi-threaded USB no go)

2007-01-21 Thread Greg KH
On Sun, Jan 21, 2007 at 12:29:51PM -0500, Justin Piszcz wrote: > > > On Sun, 21 Jan 2007, Justin Piszcz wrote: > > > > > > > > > > > Good luck, > > > Jurriaan > > > -- > > > > What does ELF stand for (in respect to Linux?) > > > ELF is the first rock group that Ronnie James Dio performed wit

Re: [PATCH 000 of 6] md: udev events and cache bypass for reads

2006-10-31 Thread Greg KH
On Tue, Oct 31, 2006 at 05:00:40PM +1100, NeilBrown wrote: > Following are 6 patches for md in -lastest which I have been sitting > on for a while because I hadn't had a chance to test them properly. > I now have so there shouldn't be too many bugs left :-) > > First is suitable for 2.6.19 (if it

Re: [PATCH 001 of 6] md: Send online/offline uevents when an md array starts/stops.

2006-10-31 Thread Greg KH
On Tue, Oct 31, 2006 at 05:00:46PM +1100, NeilBrown wrote: > > This allows udev to do something intelligent when an > array becomes available. > > cc: [EMAIL PROTECTED] > Signed-off-by: Neil Brown <[EMAIL PROTECTED]> Acked-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> - To unsubscribe from this lis

[patch 56/67] MD: Fix problem where hot-added drives are not resynced.

2006-10-11 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Neil Brown <[EMAIL PROTECTED]> If a drive is added with HOT_ADD_DISK rather than ADD_NEW_DISK, saved_raid_disk isn't initialised properly, and the drive can be included in the array without a resync

Re: libata hotplug and md raid?

2006-09-14 Thread Greg KH
On Thu, Sep 14, 2006 at 02:24:45PM +0200, Leon Woestenberg wrote: > Hello all, > > On 9/13/06, Tejun Heo <[EMAIL PROTECTED]> wrote: > >Ric Wheeler wrote: > >> Leon Woestenberg wrote: > >>> In short, I use ext3 over /dev/md0 over 4 SATA drives /dev/sd[a-d] > >>> each driven by libata ahci. I unplug

[patch 19/20] MD: Fix a potential NULL dereference in md/raid1

2006-08-21 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: NeilBrown <[EMAIL PROTECTED]> At the point where this 'atomic_add' is, rdev could be NULL, as seen by the fact that we test for this in the very next statement. Further is it is really the wrong pla

Re: [stable] [PATCH] Fix a potential NULL dereference in md/raid1

2006-08-21 Thread Greg KH
On Mon, Aug 21, 2006 at 10:05:26AM +1000, NeilBrown wrote: > patch for 2.6.17 stable series. > Thanks, > NeilBrown > ### Comments for Changeset > > At the point where this 'atomic_add' is, rdev could be NULL, > as seen by the fact that we test for this in the very next > statement. > Further is i

Re: [stable] [PATCH 001 of 5] md: Avoid oops when attempting to fix read errors on raid10

2006-05-01 Thread Greg KH
On Fri, Apr 28, 2006 at 12:50:15PM +1000, NeilBrown wrote: > > We should add to the counter for the rdev *after* checking > if the rdev is NULL !!! > > Signed-off-by: Neil Brown <[EMAIL PROTECTED]> Queued to -stable, thanks. greg k-h - To unsubscribe from this list: send the line "unsubscribe l

Re: [klibc] Exporting which partitions to md-configure

2006-01-30 Thread Greg KH
On Mon, Jan 30, 2006 at 07:21:33PM -0800, Greg KH wrote: > On Mon, Jan 30, 2006 at 04:52:08PM -0800, H. Peter Anvin wrote: > > I'm putting the final touches on kinit, which is the user-space > > replacement (based on klibc) for the whole in-kernel root-mount complex. >

Re: [klibc] Exporting which partitions to md-configure

2006-01-30 Thread Greg KH
On Mon, Jan 30, 2006 at 04:52:08PM -0800, H. Peter Anvin wrote: > I'm putting the final touches on kinit, which is the user-space > replacement (based on klibc) for the whole in-kernel root-mount complex. > Pretty much the one thing remaining -- other than lots of testing -- > is to handle aut

Re: [PATCH md 009 of 10] Improve 'scan_mode' and rename it to 'sync_action'

2005-11-02 Thread Greg KH
On Wed, Nov 02, 2005 at 09:15:55PM +1100, NeilBrown wrote: > > The current sync_action for an array can be one of > >idle - nothing happening >resync - reduncancy being recalcualted >recover - missing device being recoverred to spare >check - user initiated check of redundancy

Re: [PATCH md 004 of 10] Fix some locking and module refcounting issues with md's use of sysfs.

2005-11-02 Thread Greg KH
On Wed, Nov 02, 2005 at 09:15:10PM +1100, NeilBrown wrote: > > 1/ I really should be using the __ATTR macros for defining attributes, so > that the .owner field get set properly, otherwise modules can be removed > while sysfs files are open. > This also involves some name changes of _show routi

Re: [PATCH md 001 of 10] Make sure /block link in /sys/.../md/ goes to correct devices.

2005-11-02 Thread Greg KH
On Wed, Nov 02, 2005 at 09:14:52PM +1100, NeilBrown wrote: > > If a block_device is a partition, then it's kobject is > bdev->bd_part->kobj > otherwise (if it is a full device), the kobject is > bdev->bd_disk->kobj > > As md wants back-links to the correct object (whether partition or > not)

Re: [PATCH md 010 of 10] Document sysfs usage of md, and make a couple of small refinements.

2005-11-02 Thread Greg KH
On Wed, Nov 02, 2005 at 09:16:03PM +1100, NeilBrown wrote: > > Document in Documentation/md.txt the files that now appear in sysfs, > and make a couple of small refinements to exactly when 'level' and > 'raid_disks' are empty, to make it match the documentation. > > Signed-off-by: Neil Brown <[EM

Re: [PATCH md 005 of 10] Split off some md attributes in sysfs to a separate group.

2005-11-02 Thread Greg KH
On Wed, Nov 02, 2005 at 09:15:16PM +1100, NeilBrown wrote: > > Some, but not all, md array support data redundancy and hence > support checking and restoring that redundancy (resync, rebuild). > > Some attributes apply specifically to functions involving this > redundancy, and so should only appe