Re: [PATCH 002 of 4] md: Make 'repair' actually work for raid1.

2007-01-23 Thread Neil Brown
On Tuesday January 23, [EMAIL PROTECTED] wrote: > On Tue, 23 Jan 2007 11:26:52 +1100 > NeilBrown <[EMAIL PROTECTED]> wrote: > > > + for (j = 0; j < vcnt ; j++) > > + > > memcpy(page_address(sbio->bi_io_vec[j].bv_page), >

Re: [PATCH 002 of 4] md: Make 'repair' actually work for raid1.

2007-01-23 Thread Andrew Morton
On Tue, 23 Jan 2007 11:26:52 +1100 NeilBrown <[EMAIL PROTECTED]> wrote: > + for (j = 0; j < vcnt ; j++) > + > memcpy(page_address(sbio->bi_io_vec[j].bv_page), > + >

[PATCH 002 of 4] md: Make 'repair' actually work for raid1.

2007-01-22 Thread NeilBrown
When 'repair' finds a block that is different one the various parts of the mirror. it is meant to write a chosen good version to the others. However it currently writes out the original data to each. The memcpy to make all the data the same is missing. Signed-off-by: Neil Brown <[EMAIL PROTECTE