Re: using same IP subnet on multiple interfaces

2010-08-16 Thread Jason Gunthorpe
On Mon, Aug 16, 2010 at 06:30:04PM +0300, Or Gerlitz wrote: > As for the original issue we were discussing here, Sean - the > conclusion is that with upstream 2.6.35 bits for the rdma connection > to go from hca1 port1 to hca1 port2 (or from hca1 port1 to hca2 > port1), the rdma-cm needs a neighbo

Re: [PATCH v1 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers

2010-08-16 Thread Randy Dunlap
On Mon, 16 Aug 2010 15:17:05 -0700 Vu Pham wrote: > {hm, no text to reply to; oh, the patch is an attachment; please don't do > that} (copy-paste here:) diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 158284f..3573cee 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfi

[PATCH v1 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers

2010-08-16 Thread Vu Pham
>From 17b0c5412e085e1f288c05cb667ec36e4a05c59b Mon Sep 17 00:00:00 2001 From: Vu Pham Date: Mon, 16 Aug 2010 14:48:01 -0700 Subject: [PATCH 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers Add entries in scsi's Kconfig and Makefile to enable mlx4_fc (fcoe/fcoib offload driver) and mlx

[PATCH v1 03/10] mlx4_core: Add mr_reserve_range to pre-reserve a range of MPTs

2010-08-16 Thread Vu Pham
>From b570c5df5006119ac626d96551cc0a9935037e5f Mon Sep 17 00:00:00 2001 From: Vu Pham Date: Tue, 10 Aug 2010 14:10:57 -0700 Subject: [PATCH 03/10] mlx4_core: Add mr_reserve_range to pre-reserve a range of MPTs Add MPTs mr_reserve/free_range Remove QPs and MPTs static reservation for FC_EXCH by

[PATCH v1 06/10] mlx4: Enable create and attach cq to the vector with least number of cqs already attached

2010-08-16 Thread Vu Pham
>From 2d10665af8bfa41f772bedc18592b76b96c06729 Mon Sep 17 00:00:00 2001 From: Vu Pham Date: Tue, 10 Aug 2010 14:33:51 -0700 Subject: [PATCH 06/10] mlx4: Enable create and attach cq to the vector with least number of cqs already attached When the vector number passed to mlx4_cq_alloc is MLX4_LEA

[PATCH v1 07/10] mlx4_core: Enable T11 support bit in mlx4 device

2010-08-16 Thread Vu Pham
>From 85efcd1d8e1fae3bd5293d923eaf1aa50d54cbce Mon Sep 17 00:00:00 2001 From: Vu Pham Date: Fri, 13 Aug 2010 10:01:31 -0700 Subject: [PATCH 07/10] mlx4_core: Enable T11 support bit in mlx4 device Enable T11 support bit in mlx4 device Add bool parameter to enable/disable pre_t11 support Add inte

[PATCH v1 08/10] mlx4: Add API to query protocol device of specific port on mlx4_device

2010-08-16 Thread Vu Pham
>From f29fe7ee6b8563eb362e22b8276e817e0337f048 Mon Sep 17 00:00:00 2001 From: Vu Pham Date: Mon, 16 Aug 2010 10:16:42 -0700 Subject: [PATCH 08/10] mlx4: Add API to query protocol device of specific port on mlx4_device Adding new fields in mlx4_interface to set the type of protocol (IB, EN,...)

[PATCH v1 02/10] mlx4_core: Add mr_alloc_reserved to able create MPTs with pre-reserve range

2010-08-16 Thread Vu Pham
>From 7c943349148dcbcb173814a9b6800ac2a2b12626 Mon Sep 17 00:00:00 2001 From: Vu Pham Date: Tue, 10 Aug 2010 14:03:53 -0700 Subject: [PATCH 02/10] mlx4_core: Add mr_alloc_reserved to able create MPTs with pre-reserve range As we did with QPs, range of the MPTs are pre-reserved (the MPTs that ar

[PATCH v1 0/10] Add fcoe, fcoib drivers for mlx4 device

2010-08-16 Thread Vu Pham
Hi Roland, Thanks for your feedbacks for previous patch set. I reworked, rearranged order of the patches as suggested. Please ignore the previous patch set. Here is the new one. The following series implements fcoe and fcoib offload driver for mlx4 device mlx4_fc: implement fcoe/fcoib, hook

[PATCH v1 04/10] mlx4_core: Add interface to allocate fmr with pre-reserved MPTs

2010-08-16 Thread Vu Pham
>From 9652f29170c7daabf2e9a62acb848a05dc71db9a Mon Sep 17 00:00:00 2001 From: Vu Pham Date: Tue, 10 Aug 2010 14:16:50 -0700 Subject: [PATCH 04/10] mlx4_core: Add interface to allocate fmr with pre-reserved MPTs As we did with MRs, the fmr_alloc() will call mr_alloc() to allocate bitmap and crea

[PATCH v1 05/10] mlx4_core: Map phys_fmr with first byte offset enabled

2010-08-16 Thread Vu Pham
>From 1afc1f9cfe33444c26dc027556035c7c85a9a565 Mon Sep 17 00:00:00 2001 From: Vu Pham Date: Tue, 10 Aug 2010 14:27:23 -0700 Subject: [PATCH 05/10] mlx4_core: Map phys_fmr with first byte offset enabled map_phys_fmr_fbo() is very much like the original map_phys_fmr(): . allows setting an FBO

[PATCH v1 01/10] mlx4_core: Change fw profile and qp context to enable FC

2010-08-16 Thread Vu Pham
>From 5fd7e9795e085ff64b2396a5339f98e9b7021965 Mon Sep 17 00:00:00 2001 From: Vu Pham Date: Tue, 10 Aug 2010 13:55:43 -0700 Subject: [PATCH 01/10] mlx4_core: Change fw profile and qp context to enable FC Increase num_qp, num_mpt resource in fw profile to enable FC Add fields in qp context and q

Re: [PATCHv9 09/12] ib_core: Add VLAN support to IBoE

2010-08-16 Thread Roland Dreier
I think I've lost the plot a bit here. > The 3 bit user priority field is identical to the 3 bits of the SL. I'm having a hard time figuring out what this sentence has to do with this patch. I don't see anywhere in the patch where the sl field is used except for copying the TOS into it, and I d

[PATCH 3/3 v5] IB/srp: Reduce number of BUSY conditions

2010-08-16 Thread Bart Van Assche
As proposed by the SRP (draft) standard, ib_srp reserves one ring element for SRP_TSK_MGMT requests. This patch makes sure that the SCSI mid-layer never tries to queue more than (SRP request limit) - 1 SCSI commands to ib_srp. This improves performance for targets whose request limit is less than o

[PATCH 2/3 v5] IB/srp: Implement SRP_CRED_REQ and SRP_AER_REQ

2010-08-16 Thread Bart Van Assche
Implements SRP_CRED_REQ and SRP_AER_REQ, which are information units defined in the SRP (draft) standard. Adds declarations for the SRP_CRED_REQ, SRP_CRED_RSP, SRP_AER_REQ and SRP_AER_RSP information units to include/scsi/srp.h. Changes function definition order in ib_srp in order to avoid having

[PATCH 1/3 v5] IB/srp: Preparation for transmit ring response allocation

2010-08-16 Thread Bart Van Assche
The information unit transmit ring (srp_target.tx_ring) in ib_srp is currently only used for allocating requests sent by the initiator to the target. This patch prepares using that ring buffer for allocation of both requests and responses. Also, this patch differentiates the uses of SRP_SQ_SIZE, in

[PATCH 0/3 v5] IB/srp: Add SRP_CRED_REQ and SRP_AER_REQ support

2010-08-16 Thread Bart Van Assche
This series of three patches adds SRP_CRED_REQ ans SRP_AER_REQ support in ib_srp. Both are information units defined in the SRP (draft) standard. Changes in v5 compared to v4: - Added support for processing the SRP_AER_REQ information unit. - Introduced a new symbolic name, SRP_NORMAL_REQ_SQ_SIZE,

Re: [PATCH 1/3 v4] IB/srp: Preparation for transmit ring response allocation

2010-08-16 Thread Bart Van Assche
On Sat, Aug 14, 2010 at 7:04 PM, David Dillow wrote: > > On Sat, 2010-08-14 at 09:35 +0200, Bart Van Assche wrote: > > On Fri, Aug 13, 2010 at 8:24 PM, David Dillow wrote: > > > > > > > + > > > > +     rsv = (req_type == SRP_REQ_NORMAL) ? SRP_TSK_MGMT_RSV : 0; > > > > > > > >       srp_send_compl

Re: RDMA tutorial feedback

2010-08-16 Thread Tarick Bedeir
On Mon, Aug 16, 2010 at 1:00 AM, Hefty, Sean wrote: >> When I started working on an IB-aware app last year, I couldn't find >> much in the way of an RDMA/verbs/IB tutorial on the web.  This doesn't >> seem to have changed, so I put together a few posts on my blog that I >> hope will be of use to t

[PATCH 2/16] drivers/infiniband/hw/cxgb4: Remove unnecessary error code assignment

2010-08-16 Thread Julia Lawall
From: Julia Lawall This code initializes ret to -ENOMEM, but actually ret is not used in the code starting at err7, and -ENOMEM is always returned in this case, so the initialization of ret is unnecessary. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) //

Re: [PATCH v2] rdma/ib_pack.h: add new bth opcodes

2010-08-16 Thread Bob Pearson
On 08/12/2010 01:35 AM, Or Gerlitz wrote: Bob Pearson wrote: I was wondering if I could use this to cause ConnectX RDMAoE senders to slow down in response to these packets. There is a challenge managing fast ROCE senders in networks that may not fully implement per priority pause. Hi Bob, QC

Re: using same IP subnet on multiple interfaces

2010-08-16 Thread Or Gerlitz
Jason Gunthorpe wrote: > [...] The socket that is bound to a device will then use its device for > sending, > but other sockets not bound to devices will do route lookups and use the lo > device. > Do: [...] To see the difference in each side. sure, makes sense, the ping-reply code does route l

Re: [PATCH] RDMA/nes: double CLOSE event indication crash

2010-08-16 Thread Or Gerlitz
Latif, Faisal wrote: > BUG() was in iw_cm.ko in its close handler mentioned as core in my email and > caused by iw_nes.ko. I see, looks like iwcm.c accounts for most of the BUG* calls made from the core, could be nice to reduce them over time. Or. > # grep -n BUG drivers/infiniband/core/*.c |

RE: [PATCH] RDMA/nes: double CLOSE event indication crash

2010-08-16 Thread Latif, Faisal
>-Original Message- >From: Or Gerlitz [mailto:ogerl...@voltaire.com] >Sent: Sunday, August 15, 2010 12:41 AM >To: Latif, Faisal >Cc: Roland Dreier; linux-rdma@vger.kernel.org >Subject: Re: [PATCH] RDMA/nes: double CLOSE event indication crash > >Faisal Latif wrote: >> During a stress testi

Re: [PATCHv9 09/12] ib_core: Add VLAN support to IBoE

2010-08-16 Thread Eli Cohen
On Fri, Aug 06, 2010 at 10:49:15AM -0600, Jason Gunthorpe wrote: > On Fri, Aug 06, 2010 at 05:41:53PM +0300, Eli Cohen wrote: > > -static inline void iboe_mac_to_ll(union ib_gid *gid, u8 *mac) > > +static inline void iboe_mac_vlan_to_ll(union ib_gid *gid, u8 *mac, u16 vid) > > { > > memset(gid

Re: [PATCHv9 3/4] libibverbs: Add API to resolve GID to L2 address

2010-08-16 Thread Eli Cohen
On Fri, Aug 06, 2010 at 10:45:52AM -0600, Jason Gunthorpe wrote: > On Fri, Aug 06, 2010 at 05:43:37PM +0300, Eli Cohen wrote: > > > +int resolve_eth_gid(struct ibv_pd *pd, uint8_t port_num, > > + union ibv_gid *dgid, uint8_t sgid_index, > > + uint8_t mac[], uint16_t *vl