Re: ibacm fixes/updates

2012-04-05 Thread Doug Ledford
On 04/02/2012 04:49 PM, Hefty, Sean wrote: By default ibacm expects to find its configuration files in /etc/ibacm. This adds to the proliferation of directories in /etc/ needlessly. We already have a number of RDMA related directories to choose from depending on your install (OFED ==

Re: [PATCH] ibacm: Fixes to ACM package to support distros

2012-04-05 Thread Doug Ledford
On 04/03/2012 03:10 PM, Hefty, Sean wrote: Set of changes to fixup the ibacm package for inclusion into RedHat 6. Changes are based on feedback from Doug Ledford dledf...@redhat.com. These are primarily changes to the build files, along with name changes to the man pages and sample

Re: [RFC] Proposal to change Node Description naming scheme for HCA's

2012-04-05 Thread Doug Ledford
On 04/04/2012 01:12 PM, Jason Gunthorpe wrote: On Tue, Apr 03, 2012 at 07:14:42PM -0700, Ira Weiny wrote: On Mon, 2 Apr 2012 12:45:45 -0600 Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Mon, Apr 02, 2012 at 03:27:35PM +, Heinz, Michael William wrote: Any ideas on how we

Re: [RFC] Proposal to change Node Description naming scheme for HCA's

2012-04-05 Thread Jason Gunthorpe
On Thu, Apr 05, 2012 at 01:46:19PM -0400, Doug Ledford wrote: The purpose of the udev hook path is to set the node description on initial device insertion, which may be before, or after the DHCP process completes, in such cases. Well, a udev rule is guaranteed to be before dhcp completes

Re: [RFC] Proposal to change Node Description naming scheme for HCA's

2012-04-05 Thread Bart Van Assche
On 03/31/12 00:39, Ira Weiny wrote: First, a question: what package installs the openibd script in OFED? For the life of me I can't find this script in 1.5.4.1 or 3.2 ... :-/ [*] That's easy to figure out: $ rpm -qf /etc/init.d/openibd kernel-ib-1.5.4-3.0.12+.x86_64 Bart. -- To

Re: [RFC] Proposal to change Node Description naming scheme for HCA's

2012-04-05 Thread Ira Weiny
On Thu, 05 Apr 2012 18:31:15 + Bart Van Assche bvanass...@acm.org wrote: On 03/31/12 00:39, Ira Weiny wrote: First, a question: what package installs the openibd script in OFED? For the life of me I can't find this script in 1.5.4.1 or 3.2 ... :-/ [*] That's easy to figure

RE: [PATCH] ibacm: Fixes to ACM package to support distros

2012-04-05 Thread Hefty, Sean
I've incorporated most of the changes, but see below. -EXTRA_DIST = src/acm_mad.h src/libacm.h \ -linux/osd.h linux/dlist.h ibacm.spec.in $(man_MANS) acm_opts.cfg \ -acm_addr.cfg +EXTRA_DIST = src/acm_mad.h src/libacm.h ibacm.init \ +linux/osd.h linux/dlist.h

Re: [PATCH] ibacm: Fixes to ACM package to support distros

2012-04-05 Thread Bart Van Assche
On 04/05/12 19:10, Hefty, Sean wrote: I create a .tar.gz package using 'make dist', copy it to another system, then install it using 'configure make install'. When I do that, sysconfdir defaults to /usr/local/etc, sbindir /usr/local /sbin, and bindir to /usr/local/bin. I added /usr/local

[PATCH][TRIVIAL] ibacm/acme.C: Fix typo in show_path output

2012-04-05 Thread Hal Rosenstock
Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/src/acme.c b/src/acme.c index 3d7461b..768f17e 100644 --- a/src/acme.c +++ b/src/acme.c @@ -419,7 +419,7 @@ static void show_path(struct ibv_path_record *path) printf( flow label: 0x%x\n, fl_hop 8); printf( hop

[PATCH][TRIVIAL] ibacm/acme.c: Change format for LIDs

2012-04-05 Thread Hal Rosenstock
Standard format for unicast LIDs is decimal rather than hex Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/src/acme.c b/src/acme.c index 3d7461b..def8942 100644 --- a/src/acme.c +++ b/src/acme.c @@ -413,8 +413,8 @@ static void show_path(struct ibv_path_record *path)

[PATCH] ibacm/libacm.c: Use IPv4 rather than IPv6 for ACM server communication

2012-04-05 Thread Hal Rosenstock
When both IPv4 and IPv6 are running, getaddrinfo indicates IPv6 rather than IPv4 and that currently causes a failure to connect to the ACM server. Fix is to set the address family in the hint to getaddrinfo to IPv4. Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/src/libacm.c

Re: [PATCH] ibacm: Fixes to ACM package to support distros

2012-04-05 Thread Doug Ledford
On 04/05/2012 03:10 PM, Hefty, Sean wrote: I've incorporated most of the changes, but see below. -EXTRA_DIST = src/acm_mad.h src/libacm.h \ - linux/osd.h linux/dlist.h ibacm.spec.in $(man_MANS) acm_opts.cfg \ - acm_addr.cfg +EXTRA_DIST = src/acm_mad.h src/libacm.h ibacm.init \ +

Re: [PATCH] ibacm: Fixes to ACM package to support distros

2012-04-05 Thread Jason Gunthorpe
On Thu, Apr 05, 2012 at 07:10:25PM +, Hefty, Sean wrote: +PATH=$PATH:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin I'm not very keen on including /usr/local in the search path on system To say that I'm not sure what autotools and the init scripts are doing is an

Re: [PATCH] ibacm/libacm.c: Use IPv4 rather than IPv6 for ACM server communication

2012-04-05 Thread Jason Gunthorpe
On Thu, Apr 05, 2012 at 04:05:24PM -0400, Hal Rosenstock wrote: When both IPv4 and IPv6 are running, getaddrinfo indicates IPv6 rather than IPv4 and that currently causes a failure to connect to the ACM server. Fix is to set the address family in the hint to getaddrinfo to IPv4. We are in

[PATCH] ibacm/acme.c: acm/acme.c: Better error handling in resolve_gid

2012-04-05 Thread Hal Rosenstock
A return of 0 is an error for inet_pton but if 0 is returned from resolve_gid, show_path is mistakenly called so if 0 is returned from inet_pton, return -1 instead (which is what is done elsewhere in acme). Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/src/acme.c b/src/acme.c

RE: [PATCH][TRIVIAL] ibacm/acme.C: Fix typo in show_path output

2012-04-05 Thread Hefty, Sean
Thanks - applied -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] ibacm/libacm.c: Use IPv4 rather than IPv6 for ACM server communication

2012-04-05 Thread Hefty, Sean
thanks - applied I will add a separate patch to support IPv6, since librdmacm should be updated as well. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] ibacm/acme.c: acm/acme.c: Better error handling in resolve_gid

2012-04-05 Thread Hefty, Sean
applied Thanks for the changes! -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] ibacm: Fixes to ACM package to support distros

2012-04-05 Thread Hefty, Sean
In this instance you need to have configure variable substitute your init script as well. You should not manipulate PATH from an init.d script, and you should use an absolute path to the daemon to avoid contamination from the invoking user's environment. This is exactly what I wanted to do...

RE: [PATCH] ibacm: Fixes to ACM package to support distros

2012-04-05 Thread Hefty, Sean
I create a .tar.gz package using 'make dist', copy it to another system, then install it using 'configure make install'. When I do that, sysconfdir defaults to /usr/local/etc, sbindir /usr/local/sbin, and bindir to /usr/local/bin. I added /usr/local to PATH, so that the init script