Re: [PATCH RFC for-next] net/mlx4_core: Fix racy flow in the driver CQ completion handler

2012-09-11 Thread Or Gerlitz
On Tue, Sep 11, 2012 at 9:03 AM, Jack Morgenstein ja...@dev.mellanox.co.il wrote: On Monday 10 September 2012 16:27, Or Gerlitz wrote: I took a look on the practice/wrapping used over the mm subsystem for radix_tree_lookup calls, whose maintainer, Andrew Morton is signed on the patch Roland

Re: [PATCH] IB: new module params. cm_response_timeout, max_cm_retries

2012-09-11 Thread Yann Droneaud
Le lundi 10 septembre 2012 à 19:11 +, Hefty, Sean a écrit : Create two kernel parameters, in order to make variables configurable. i.e. cma_cm_response_timeout for CM response timeout, and cma_max_cm_retries for the number of retries. They can now be configured via command line

[PATCH 1/6] opensm: Add .gitignore

2012-09-11 Thread Bart Van Assche
Signed-off-by: Bart Van Assche bvanass...@acm.org --- .gitignore | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 000..4dea307 --- /dev/null +++

[PATCH 4/6] opensm: osm_pkey: Remove unused variables

2012-09-11 Thread Bart Van Assche
Signed-off-by: Bart Van Assche bvanass...@acm.org --- opensm/osm_pkey.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/opensm/osm_pkey.c b/opensm/osm_pkey.c index 98e2aee..bb45f57 100644 --- a/opensm/osm_pkey.c +++ b/opensm/osm_pkey.c @@ -369,9 +369,6 @@ ib_net16_t

[PATCH 5/6] opensm: Add command-line option --pidfile

2012-09-11 Thread Bart Van Assche
This option is necessary to control opensm from an LSB-compliant init script. Signed-off-by: Bart Van Assche bvanass...@acm.org --- opensm/main.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/opensm/main.c b/opensm/main.c index

[PATCH 6/6] opensm: /etc/init.d/opensmd: Port to Debian

2012-09-11 Thread Bart Van Assche
Signed-off-by: Bart Van Assche bvanass...@acm.org --- scripts/opensm.init.in | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/scripts/opensm.init.in b/scripts/opensm.init.in index 01d2bb9..1b9348c 100644 --- a/scripts/opensm.init.in +++ b/scripts/opensm.init.in

Re: [PATCH 2/8] opensm/complib: define if statements with branch prediction hints

2012-09-11 Thread Yevgeny Kliteynik
I would not abstract the 'if' statement. If CL_PREDICT_FALSE/TRUE are not readable, then shorten those. if (PF(...)) is just as readable as if_PF(...) OK, agree. I'll issue a v2 shortly - the only difference would be change in this macro and rebase to the updated trunk. -- YK --

[PATCH 2/8 v2] opensm/complib: define macros for for if statements with branch prediction hints

2012-09-11 Thread Yevgeny Kliteynik
Defined PT and PF for predict true and predict false respectively. Signed-off-by: Yevgeny Kliteynik klit...@dev.mellanox.co.il --- include/complib/cl_types_osd.h | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/include/complib/cl_types_osd.h

[PATCH 4/8 v2] opensm/libvendor/osm_vendor_ibumad_sa.c: use wrapper function instead of direct access

2012-09-11 Thread Yevgeny Kliteynik
Use existing wrapper function to get to context instead of direct access. Signed-off-by: Yevgeny Kliteynik klit...@dev.mellanox.co.il --- libvendor/osm_vendor_ibumad_sa.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/libvendor/osm_vendor_ibumad_sa.c

[PATCH 5/8 v2] opensm/libvendor/osm_vendor_ibumad.c:rename mad to p_mad to indicate pointer

2012-09-11 Thread Yevgeny Kliteynik
Signed-off-by: Yevgeny Kliteynik klit...@dev.mellanox.co.il --- libvendor/osm_vendor_ibumad.c | 44 +-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/libvendor/osm_vendor_ibumad.c b/libvendor/osm_vendor_ibumad.c index b068443..e0c9f90

[PATCH 6/8 v2] opensm/libvendor/osm_vendor_ibumad.c: validate response MAD properties

2012-09-11 Thread Yevgeny Kliteynik
Check that attribute ID, attribute modifier and transaction ID are the same in request and response. Note that just by checking these we cover a very wide range of possible bugs in SMAs. Attribute modifier is used in PortInfo, LFT, MFT, and others. Signed-off-by: Yevgeny Kliteynik

[PATCH 7/8 v2] opensm/osm_port_info_rcv.c: check received local_port_num

2012-09-11 Thread Yevgeny Kliteynik
Signed-off-by: Yevgeny Kliteynik klit...@dev.mellanox.co.il --- opensm/osm_port_info_rcv.c | 16 1 file changed, 16 insertions(+) diff --git a/opensm/osm_port_info_rcv.c b/opensm/osm_port_info_rcv.c index c3bc66c..442bc3f 100644 --- a/opensm/osm_port_info_rcv.c +++

[PATCH 8/8 v2] opensm/osm_port_info_rcv.c: use PF() hint on fatal conditions

2012-09-11 Thread Yevgeny Kliteynik
Signed-off-by: Yevgeny Kliteynik klit...@dev.mellanox.co.il --- opensm/osm_port_info_rcv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/opensm/osm_port_info_rcv.c b/opensm/osm_port_info_rcv.c index 442bc3f..2a6d037 100644 --- a/opensm/osm_port_info_rcv.c +++

Re: [PATCH for-next V2 02/22] IB/core: change pkey table lookups to support full and partial membership for the same pkey

2012-09-11 Thread Doug Ledford
On 8/3/2012 4:40 AM, Jack Morgenstein wrote: Enhance the cached and non-cached pkey table lookups to enable limited and full members of the same pkey to co-exist in the pkey table. This is necessary for SRIOV to allow for a scheme where some guests would have the full membership pkey in

Re: [PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-09-11 Thread Doug Ledford
On 8/3/2012 4:40 AM, Jack Morgenstein wrote: When port pkey table potentially contains both full and partial membership copies for the same pkey, we need a function to find the exact (16-bit) pkey index. The code on this patch is fine, just see my previous email about the function naming...

Re: [PATCH for-next V2 04/22] IB/mlx4: SRIOV IB context objects and proxy/tunnel sqp support

2012-09-11 Thread Doug Ledford
On 8/3/2012 4:40 AM, Jack Morgenstein wrote: 1. Introduce the basic sriov parvirtualization context objects for multiplexing and demultiplexing MADs. 2. Introduce support for the new proxy and tunnel QP types. This patch introduces the objects required by the master for managing QP

Re: [PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-09-11 Thread Doug Ledford
On 8/3/2012 4:40 AM, Jack Morgenstein wrote: When port pkey table potentially contains both full and partial membership copies for the same pkey, we need a function to find the exact (16-bit) pkey index. This is particularly necessary when the master forwards QP1 MADS sent by guests. If

Re: [PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-09-11 Thread Roland Dreier
On Tue, Sep 11, 2012 at 10:12 AM, Doug Ledford dledf...@redhat.com wrote: As a second note, I would like to know why Intel (previously QLogic) does not use these functions in their driver and what it would take to get all drivers to use the functions. Do we need to add more to them? In my

Re: [PATCH] RDMA/cxgb4: move the dereference below the NULL test

2012-09-11 Thread Roland Dreier
applied, thanks -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-09-11 Thread Roland Dreier
On Tue, Sep 11, 2012 at 1:34 PM, Doug Ledford dledf...@redhat.com wrote: Well, at this point, the mlx4 driver uses them, the rdmacm kernel driver uses them, and both QLogic/Intel drivers have their own internal pkey table implementation. So, it isn't so much upper layer as it is drivers.

[PATCH] librdmacm/rsockets: Document rsocket protocol and design

2012-09-11 Thread Hefty, Sean
Include a brief overview of the rsocket protocol and underlying design with the source code to make it easier for someone trying to decipher the actual code. Signed-off-by: Sean Hefty sean.he...@intel.com --- docs/rsocket | 144 ++ 1 files

Re: [PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-09-11 Thread Doug Ledford
On 9/11/2012 4:43 PM, Roland Dreier wrote: On Tue, Sep 11, 2012 at 1:34 PM, Doug Ledford dledf...@redhat.com wrote: Well, at this point, the mlx4 driver uses them, the rdmacm kernel driver uses them, and both QLogic/Intel drivers have their own internal pkey table implementation. So, it isn't