Hi Mike,
On 03/27/2013 10:41 PM, Marciniszyn, Mike wrote:
>> -if (ipath_verbs_register_sysfs(dev))
> I would suggest modifying ipath_verbs_register_sysfs() to correctly return
> the failure from device_create_file() in ret out of ipath_verbs.c:
>
> ...
>
> I will post a patch shortly for qib,
On Wed, Mar 27, 2013 at 03:29:34PM -0400, Jeff Layton wrote:
> (Note: compile-tested only)
>
> Signed-off-by: Jeff Layton
> Cc: Tejun Heo
> Cc: Steve Wise
> Cc: Tom Tucker
> Cc: linux-rdma@vger.kernel.org
Reviewed-by: Tejun Heo
Thanks.
--
tejun
--
To unsubscribe from this list: send the li
(Note: compile tested only)
Signed-off-by: Jeff Layton
Cc: Tejun Heo
Cc: Jack Morgenstein
Cc: Or Gerlitz
Cc: Roland Dreier
Cc: linux-rdma@vger.kernel.org
---
drivers/infiniband/hw/mlx4/cm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/cm.c
(Note: compile-tested only)
Signed-off-by: Jeff Layton
Cc: Tejun Heo
Cc: Steve Wise
Cc: Tom Tucker
Cc: linux-rdma@vger.kernel.org
---
drivers/infiniband/hw/amso1100/c2.h| 1 -
drivers/infiniband/hw/amso1100/c2_qp.c | 3 +--
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/dri
As I said before this is really what we should do so thanks, however, see below.
On Tue, 26 Mar 2013 11:31:15 -0700
Boris Chiu wrote:
> From 493e8ed95e32f9c3e337f758a979120392c9e412 Mon Sep 17 00:00:00 2001
> From: Brendan Doyle
> Date: Tue, 12 Mar 2013 19:38:52 +
> Subject: [PATCH] libibma
On Wed, 27 Mar 2013 09:27:55 -0700
Tejun Heo wrote:
> On Wed, Mar 27, 2013 at 09:18:04AM -0400, Jeff Layton wrote:
> > void c2_init_qp_table(struct c2_dev *c2dev)
> > {
> > spin_lock_init(&c2dev->qp_table.lock);
> > - idr_init(&c2dev->qp_table.idr);
> > + idr_init_cyclic(&c2dev->qp_tabl
On Wed, 2013-03-27 at 08:43 -0400, Hal Rosenstock wrote:
> On 3/26/2013 2:16 PM, Albert Chu wrote:
> > Signed-off-by: Albert L. Chu
> > ---
> > opensm/osm_helper.c |1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/opensm/osm_helper.c b/opensm/osm_helper.c
> > in
On Wed, Mar 27, 2013 at 09:18:04AM -0400, Jeff Layton wrote:
> void c2_init_qp_table(struct c2_dev *c2dev)
> {
> spin_lock_init(&c2dev->qp_table.lock);
> - idr_init(&c2dev->qp_table.idr);
> + idr_init_cyclic(&c2dev->qp_table.idr, 0);
> }
Why is this necessary? In general, why is
> - if (ipath_verbs_register_sysfs(dev))
I would suggest modifying ipath_verbs_register_sysfs() to correctly return the
failure from device_create_file() in ret out of ipath_verbs.c:
static int ipath_verbs_register_sysfs(struct ib_device *dev)
{
int i;
int ret;
for (
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/infiniband/hw/ipath/ipath_verbs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/infin
On 03/26/2013 02:16 PM, Jason Gunthorpe wrote:
> On Tue, Mar 26, 2013 at 09:46:28AM -0700, Roland Dreier wrote:
>>> Checkpatch recommends since some time to use sizeof(e) instead of sizeof e,
>>> isn't it ?
>>
>> I actually prefer "sizeof e" since sizeof is an operator, not a
>> function. "sizeof(
You have missed Signed-off-by ;)
On 3/27/13, Husam Kahalah wrote:
> From d61f2580b829fa2fc56aea15bd98ef3a607d9aba Mon Sep 17 00:00:00 2001
> From: Husam kahalah
> Date: Mon, 25 Feb 2013 10:53:25 +0200
> Subject: [PATCH] infiniband-diags/saquery.c: switchinfo support added
>
> ---
> src/saque
(Note: compile tested only)
Signed-off-by: Jeff Layton
Cc: Tejun Heo
Cc: Jack Morgenstein
Cc: Or Gerlitz
Cc: Roland Dreier
Cc: linux-rdma@vger.kernel.org
---
drivers/infiniband/hw/mlx4/cm.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/c
(Note: compile-tested only)
Signed-off-by: Jeff Layton
Cc: Tejun Heo
Cc: Steve Wise
Cc: Tom Tucker
Cc: linux-rdma@vger.kernel.org
---
drivers/infiniband/hw/amso1100/c2.h| 1 -
drivers/infiniband/hw/amso1100/c2_qp.c | 5 ++---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/
From 5c21f13092977fb45180e54a9eefcb081afa1684 Mon Sep 17 00:00:00 2001
From: Husam Kahalah
Date: Sun, 3 Mar 2013 09:40:42 +0200
Subject: [PATCH] switchinfo support added manual
---
doc/rst/saquery.8.in.rst |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/rst/saquery.8.
From d61f2580b829fa2fc56aea15bd98ef3a607d9aba Mon Sep 17 00:00:00 2001
From: Husam kahalah
Date: Mon, 25 Feb 2013 10:53:25 +0200
Subject: [PATCH] infiniband-diags/saquery.c: switchinfo support added
---
src/saquery.c | 55
+++
1 files cha
On 3/26/2013 2:16 PM, Albert Chu wrote:
> Signed-off-by: Albert L. Chu
> ---
> opensm/osm_helper.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/opensm/osm_helper.c b/opensm/osm_helper.c
> index 219554a..95462a7 100644
> --- a/opensm/osm_helper.c
> +++ b/opensm/os
17 matches
Mail list logo
