Re: smatch warnings on the IB core

2013-10-29 Thread Or Gerlitz
On 28/10/2013 18:32, Hefty, Sean wrote: Visually inspecting the code for both of these, I don't see anything wrong. In both cases the listen mutex is acquired near the top of the function and released at the end. I don't see how you exit either function with the mutex locked. In the top

Re: ACK behaviour difference LRO/GRO

2013-10-29 Thread Wendy Cheng
On Mon, Oct 28, 2013 at 12:34 PM, Markus Stockhausen stockhau...@collogia.de wrote: Hello, about two month we had some problems with IPoIB transfer speeds . See more http://marc.info/?l=linux-rdmam=137823326109158w=2 After some quite hard test iterations the problem seems to come from the

Re: [PATCH RFC v1 01/10] IB/core: Introduce protected memory regions

2013-10-29 Thread Or Gerlitz
On 28/10/2013 23:22, Hefty, Sean wrote: Assuming that flags will be a bitwise OR of values, they should be an int, not an enum. Hi Sean, anything else from your side re the IB core patches and this series in general? Or. -- To unsubscribe from this list: send the line unsubscribe

Re: smatch warnings on the IB core

2013-10-29 Thread Dan Carpenter
On Sun, Oct 27, 2013 at 08:45:25AM +0200, Or Gerlitz wrote: Hi Dan, With the latest smatch I still see these hits on the IB core, basically, I would be happy to see the IB stack free from such warnings and then we can easily require each new patch not to introduce them... can you shed some

Re: [PATCH RFC v1 01/10] IB/core: Introduce protected memory regions

2013-10-29 Thread Sagi Grimberg
On 10/28/2013 11:22 PM, Hefty, Sean wrote: +enum ib_mr_create_flags { + IB_MR_SIGNATURE_EN = 1, +}; + +/** + * ib_mr_init_attr - Memory region init attributes passed to routine + * ib_create_mr. + * @max_reg_descriptors: max number of registration units that + * may be used

Re: ACK behaviour difference LRO/GRO

2013-10-29 Thread Or Gerlitz
On 28/10/2013 21:34, Markus Stockhausen wrote: After some quite hard test iterations the problem seems to come from the IPoIB switch from LRO to GRO between kernels 2.6.37 and 2.6.38. I built a test setup with a 2.6.38 kernel and additionaly compiled a 2.6.37 ib_ipoib module against it. This

AW: ACK behaviour difference LRO/GRO

2013-10-29 Thread Markus Stockhausen
Von: Or Gerlitz [ogerl...@mellanox.com] Gesendet: Dienstag, 29. Oktober 2013 09:31 An: Markus Stockhausen; linux-rdma@vger.kernel.org; Yishai Hadas Cc: s.wendy.ch...@gmail.com; Erez Shitrit; Saeed Mahameed Betreff: Re: ACK behaviour difference LRO/GRO

Re: AW: ACK behaviour difference LRO/GRO

2013-10-29 Thread Or Gerlitz
On 29/10/2013 13:10, Markus Stockhausen wrote: Just to be on the right way: What are the basics to get GRO working with a ConnectX (not 2 or 3) card in 2044 MTU datagram mode? - enable GRO with ethtool. - Activate Coalescing with ethtool? If yes how? GRO is SW element of the network stack, so

Re: AW: ACK behaviour difference LRO/GRO

2013-10-29 Thread Erez Shitrit
בתאריך 10/29/2013 1:43 PM, ציטוט Or Gerlitz: On 29/10/2013 13:10, Markus Stockhausen wrote: Just to be on the right way: What are the basics to get GRO working with a ConnectX (not 2 or 3) card in 2044 MTU datagram mode? - enable GRO with ethtool. - Activate Coalescing with ethtool? If yes

Re: AW: ACK behaviour difference LRO/GRO

2013-10-29 Thread Or Gerlitz
On 29/10/2013 14:55, Erez Shitrit wrote: In addition to what Or just wrote, GRO currently doesn't work on ipoib interfaces, that according to bad handling mac address that are not 6 bytes (we have plans to fix that in the near future), that is the reason you don't see 64k packets on tcpdump

AW: AW: ACK behaviour difference LRO/GRO

2013-10-29 Thread Markus Stockhausen
Von: Or Gerlitz [ogerl...@mellanox.com] Gesendet: Dienstag, 29. Oktober 2013 14:58 An: Erez Shitrit Cc: Markus Stockhausen; linux-rdma@vger.kernel.org; Yishai Hadas; s.wendy.ch...@gmail.com; Erez Shitrit; Saeed Mahameed Betreff: Re: AW: ACK behaviour difference LRO/GRO On 29/10/2013

Re: AW: AW: ACK behaviour difference LRO/GRO

2013-10-29 Thread Or Gerlitz
On 29/10/2013 17:54, Markus Stockhausen wrote: Should I exepect GRO to work on Mellanox IB cards with Linux 3.12 in general? YES -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

RE: [PATCH RFC v1 01/10] IB/core: Introduce protected memory regions

2013-10-29 Thread Hefty, Sean
Hi Sean, anything else from your side re the IB core patches and this series in general? Do we have a user of these changes? -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH RFC v1 01/10] IB/core: Introduce protected memory regions

2013-10-29 Thread Or Gerlitz
On Tue, Oct 29, 2013 at 9:34 PM, Hefty, Sean sean.he...@intel.com wrote: Hi Sean, anything else from your side re the IB core patches and this series in general? Do we have a user of these changes? Oh sure, we didn't do that just for the fun of it... Sagi is working to enhance the upstream

Re: AW: AW: ACK behaviour difference LRO/GRO

2013-10-29 Thread Markus Stockhausen
Von: Or Gerlitz [ogerl...@mellanox.com] Gesendet: Dienstag, 29. Oktober 2013 16:55 An: Markus Stockhausen; Erez Shitrit Cc: linux-rdma@vger.kernel.org; Yishai Hadas; s.wendy.ch...@gmail.com; Saeed Mahameed Betreff: Re: AW: AW: ACK behaviour difference LRO/GRO On 29/10/2013 17:54, Markus