Re: [PATCH 7/8] xprtrdma: Split the completion queue

2014-04-17 Thread Sagi Grimberg
On 4/17/2014 5:34 PM, Steve Wise wrote: You could use a small array combined with a loop and a budget count. So the code would grab, say, 4 at a time, and keep looping polling up to 4 until the CQ is empty or the desired budget is reached... Bingo... couldn't agree more. Poll Arrays are a

Re: [PATCH 7/8] xprtrdma: Split the completion queue

2014-04-17 Thread Sagi Grimberg
On 4/17/2014 4:55 PM, Chuck Lever wrote: On Apr 17, 2014, at 3:06 AM, Sagi Grimberg wrote: On 4/16/2014 9:21 PM, Chuck Lever wrote: Passing a small array to ip_poll_cq() is actually easy to do, and is exactly equivalent to a poll budget. The struct ib_wc should be taken off the stack anyway,

RE: [PATCH] svcrdma: refactor marshalling logic

2014-04-17 Thread Steve Wise
Tested-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 7/8] xprtrdma: Split the completion queue

2014-04-17 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On > Behalf Of Chuck Lever > Sent: Thursday, April 17, 2014 8:55 AM > To: Sagi Grimberg > Cc: Steve Wise; Linux NFS Mailing List; linux-rdma@vger.kernel.org > Subject: Re: [PATCH 7/8

Re: [PATCH 7/8] xprtrdma: Split the completion queue

2014-04-17 Thread Chuck Lever
On Apr 17, 2014, at 3:06 AM, Sagi Grimberg wrote: > On 4/16/2014 9:21 PM, Chuck Lever wrote: >> Passing a small array to ip_poll_cq() is actually easy to do, and is >> exactly equivalent to a poll budget. The struct ib_wc should be taken >> off the stack anyway, IMO. >> >> The only other exampl

Re: [PATCH 7/8] xprtrdma: Split the completion queue

2014-04-17 Thread Sagi Grimberg
On 4/16/2014 9:21 PM, Chuck Lever wrote: Passing a small array to ip_poll_cq() is actually easy to do, and is exactly equivalent to a poll budget. The struct ib_wc should be taken off the stack anyway, IMO. The only other example I see in 3.15 right now is IPoIB, which seems to do exactly this.