Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-23 Thread Matan Barak
On Wed, Dec 23, 2015 at 7:57 PM, Doug Ledford wrote: > On 12/23/2015 11:35 AM, Matan Barak wrote: >> On Wed, Dec 23, 2015 at 6:08 PM, Doug Ledford wrote: >>> On 12/22/2015 02:26 PM, Matan Barak wrote: On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford wrote: > On 12/22/2015 05:47 AM, Or Gerl

Re: [PATCH rdma-RC] IB/cm: Fix sleeping while atomic when creating AH from WC

2015-12-23 Thread Matan Barak
On Wed, Dec 23, 2015 at 10:04 PM, Doug Ledford wrote: > On 10/15/2015 12:58 PM, Hefty, Sean wrote: > ib_create_ah_from_wc needs to resolve the DMAC in order to create the > AH (this may result sending an ARP and waiting for response). > CM uses this function (which is now sleepable). >

Re: [PATCH V1 08/16] i40iw: add files for iwarp interface

2015-12-23 Thread Faisal Latif
On Wed, Dec 23, 2015 at 08:42:01AM -0800, Or Gerlitz wrote: > On 12/22/2015 1:13 AM, Faisal Latif wrote: > > + > > +enum i40iw_memreg_type { > > + IW_MEMREG_TYPE_MEM = 0x, > > + IW_MEMREG_TYPE_QP = 0x0001, > > + IW_MEMREG_TYPE_CQ = 0x0002, > > + IW_MEMREG_TYPE_MW = 0x0003, > > + IW_ME

Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver

2015-12-23 Thread Faisal Latif
On Wed, Dec 23, 2015 at 09:05:08AM -0800, Or Gerlitz wrote: > On 12/22/2015 1:13 AM, Faisal Latif wrote: > > This driver provides iWARP RDMA functionality for the Intel(R) X722 Ethernet > > controller for PCI Physical Functions. > > Is there any public info on the X722, I didn't manage to find suc

Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver

2015-12-23 Thread Faisal Latif
On Wed, Dec 23, 2015 at 08:39:32AM -0800, Or Gerlitz wrote: > On 12/23/2015 6:35 PM, Faisal Latif wrote: > > I will provide new patch series for latest k.o. Also will make sure of > > shallow threading for the series. > > Please make sure that the cover letter will include the full output of > t

Re: [PATCH V1 15/16] i40iw: add entry in rdma_netlink

2015-12-23 Thread Faisal Latif
On Wed, Dec 23, 2015 at 08:50:15AM -0800, Or Gerlitz wrote: > On 12/22/2015 1:13 AM, Faisal Latif wrote: > > Add entry for port mapper services. > > > > Signed-off-by: Faisal Latif > > --- > > include/uapi/rdma/rdma_netlink.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/includ

Re: [PATCH 2/2] IB/mlx4: Convert kmalloc to be kmalloc_array to fix checkpatch warnings

2015-12-23 Thread Doug Ledford
On 12/17/2015 02:31 AM, Leon Romanovsky wrote: > From: Leon Romanovsky > > Convert kmalloc to be kmalloc_array to fix warnings below: > > WARNING: Prefer kmalloc_array over kmalloc with multiply > + qp->sq.wrid = kmalloc(qp->sq.wqe_cnt * sizeof(u64), > > WARNING: Prefer kmalloc_ar

Re: [PATCH 1/2] IB/mlx4: Suppress memory allocations warnings in kmalloc->__vmalloc flows

2015-12-23 Thread Doug Ledford
On 12/17/2015 02:31 AM, Leon Romanovsky wrote: > From: Leon Romanovsky > > Failure in kmalloc memory allocations will throw a warning about it. > Such warnings are not needed anymore, since in commit 0ef2f05c7e02 > ("IB/mlx4: Use vmalloc for WR buffers when needed"), fallback mechanism > from kma

Re: [PATCH] IB/mad: Ensure fairness in ib_mad_completion_handler

2015-12-23 Thread Doug Ledford
On 12/23/2015 03:01 PM, ira.weiny wrote: > Doug, > > With your email troubles I just wanted to make sure you did not lose track of > this patch. > > https://patchwork.kernel.org/patch/7822511/ I've got it, thanks. > Thanks, > Ira > > On Thu, Dec 10, 2015 at 04:52:30PM -0500, ira.we...@intel.co

Re: FW: [PATCH for-next v1 0/2] Advertise atomic operations support in mlx5

2015-12-23 Thread Doug Ledford
On 12/23/2015 12:05 PM, eran ben elisha wrote: >>> >>> If the firmware supports host endianness, try to configure the >>> hardware to work this way, and on success propagate this capability to >>> the upper layers, otherwise advertise that atomic operations aren't >>> supported. >> >> If you are n

Re: [PATCH V1 0/3] Add cross-channel support

2015-12-23 Thread Doug Ledford
On 12/20/2015 05:16 AM, Leon Romanovsky wrote: > From: Leon Romanovsky > > This patchset adds cross-channel support. > > The cross-channel feature allows to execute WQEs that involve > synchronization of I/O operations’ on different QPs. > > This capability enables to program complex flows with

Re: [PATCH for-next V2 0/5] User-space time-stamping support for mlx5_ib

2015-12-23 Thread Doug Ledford
On 12/23/2015 12:16 PM, Or Gerlitz wrote: > On Tue, Dec 15, 2015 at 8:30 PM, Matan Barak wrote: > >> This patch-set adds user-space support for time-stamping in mlx5_ib. >> It implements the necessary API: >> (a) ib_create_cq_ex - Add support for CQ creation flags >> (b) ib_query_device - return

Re: [PATCH net-next 0/2] new maintainers for Mellanox mlx4/mlx5 core and IB drivers

2015-12-23 Thread David Miller
From: Doug Ledford Date: Wed, 23 Dec 2015 13:31:06 -0500 > On 12/23/2015 11:30 AM, Or Gerlitz wrote: >> Hi Dave, Doug >> >> We're happily assigning new maintainers for mlx4/mlx5 core and IB drivers. >> >> This is aligned with Eli (mlx5) and Roland (mlx4). >> >> FWIW, I did the whole change to

Re: [PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure

2015-12-23 Thread Doug Ledford
On 12/21/2015 11:36 AM, ira.weiny wrote: > On Mon, Dec 21, 2015 at 12:03:46AM -0800, Christoph Hellwig wrote: >> On Mon, Dec 21, 2015 at 08:37:26AM +0200, Leon Romanovsky wrote: >>> You are right and it is a preferred way for me too, however the >>> downside of such change will be one of two: >>> 1

Re: device attr cleanup

2015-12-23 Thread Doug Ledford
On 12/23/2015 04:31 PM, J. Bruce Fields wrote: > On Thu, Dec 10, 2015 at 07:49:59PM -0500, Chuck Lever wrote: >> >>> On Dec 10, 2015, at 6:30 PM, Christoph Hellwig wrote: >>> >>> On Thu, Dec 10, 2015 at 11:07:03AM -0700, Jason Gunthorpe wrote: The ARM folks do this sort of stuff on a regular

Re: [RFC] Generic InfiniBand transport done in software

2015-12-23 Thread ira.weiny
On Tue, Dec 22, 2015 at 02:38:10PM +0200, Moni Shoua wrote: > Hi, > > In the past months the need for a kernel module that implements the InfiniBand > transport in software and unify all the InfiniBand software drivers has > been raised. Since then, nobody has submitted any design proposal that sa

Re: [PATCH 3/3] staging/rdma/hfi1: check for ARMED->ACTIVE transition in receive interrupt

2015-12-23 Thread Jubin John
On Fri, Dec 18, 2015 at 09:31:39AM +0300, Dan Carpenter wrote: > Possible off by one, but mostly the whitespace makes me itch. > > Jim was not on the CC list. > > On Thu, Dec 17, 2015 at 07:24:15PM -0500, Jubin John wrote: > > From: Jim Snow > > > > The link state will transition from ARMED to

Re: device attr cleanup (was: Handle mlx4 max_sge_rd correctly)

2015-12-23 Thread J. Bruce Fields
On Thu, Dec 10, 2015 at 07:49:59PM -0500, Chuck Lever wrote: > > > On Dec 10, 2015, at 6:30 PM, Christoph Hellwig wrote: > > > > On Thu, Dec 10, 2015 at 11:07:03AM -0700, Jason Gunthorpe wrote: > >> The ARM folks do this sort of stuff on a regular basis.. Very early on > >> Doug prepares a topic

Re: [PATCH v4 00/11] NFS/RDMA server patches for v4.5

2015-12-23 Thread J. Bruce Fields
On Wed, Dec 16, 2015 at 05:40:09PM +0530, Devesh Sharma wrote: > iozone passed on ocrdma device. What other testing has there been of this patchset? Connectathon, xfstests, and pynfs make more of an effort to test corner cases, iozone isn't much of a test of correctness. --b. > Link bounce fail

[PATCH] staging: rdma: hfi1: diag: constify hfi1_filter_array structure

2015-12-23 Thread Julia Lawall
The hfi1_filter_array structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/staging/rdma/hfi1/diag.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rdma/hfi1/diag.c b/drivers/stagin

Re: [PATCH v2 00/10] iSER support for remote invalidate

2015-12-23 Thread Or Gerlitz
On Mon, Dec 21, 2015 at 3:29 PM, Sagi Grimberg wrote: >> Sagi, are you going to spin an increment in the initiator version? > I don't know if it's worth a driver version update? yes, I think it does. Finally we're getting real close to the visions of the spec authors... do you have some perfor

Re: [RFC] Generic InfiniBand transport done in software

2015-12-23 Thread Dennis Dalessandro
On Wed, Dec 23, 2015 at 06:28:08PM +0200, Moni Shoua wrote: This makes no mention of the already posted work which aims to consolidate the qib and hfi1 drivers verbs implementation. However it does seem to be mostly in line with what we have already presented for rdmavt and the direction the ne

Re: [PATCH rdma-RC] IB/cm: Fix sleeping while atomic when creating AH from WC

2015-12-23 Thread Doug Ledford
On 10/15/2015 12:58 PM, Hefty, Sean wrote: ib_create_ah_from_wc needs to resolve the DMAC in order to create the AH (this may result sending an ARP and waiting for response). CM uses this function (which is now sleepable). >>> >>> This is a significant change to the CM. The CM calls

Re: [PATCH 0/2] IB multicast cleanup patches V2

2015-12-23 Thread ira.weiny
On Wed, Dec 23, 2015 at 01:11:11PM -0500, Doug Ledford wrote: > On 12/21/2015 09:42 AM, Christoph Lameter wrote: > > V1->V2 > > - Add Reviewed by's for first patch from Ira Weiny > > - Change name of ipoib_check_mcast_sendonly() to > > ipoib_check_and_add_mcast_sendonly() as requested by Ira

Re: [PATCH] IB/mad: Ensure fairness in ib_mad_completion_handler

2015-12-23 Thread ira.weiny
Doug, With your email troubles I just wanted to make sure you did not lose track of this patch. https://patchwork.kernel.org/patch/7822511/ Thanks, Ira On Thu, Dec 10, 2015 at 04:52:30PM -0500, ira.we...@intel.com wrote: > From: Dean Luick > > It was found that when a process was rapidly send

Re: [PATCH v4 01/11] svcrdma: Do not send XDR roundup bytes for a write chunk

2015-12-23 Thread J. Bruce Fields
On Mon, Dec 21, 2015 at 05:11:56PM -0500, Chuck Lever wrote: > > > On Dec 21, 2015, at 4:29 PM, J. Bruce Fields wrote: > > > > On Mon, Dec 21, 2015 at 04:15:23PM -0500, Chuck Lever wrote: > >> > >>> On Dec 21, 2015, at 4:07 PM, J. Bruce Fields wrote: > >>> > >>> On Mon, Dec 14, 2015 at 04:30:

Re: [PATCH] IB/usnic: Handle 0 counts in resource allocation

2015-12-23 Thread Doug Ledford
On 12/09/2015 01:42 PM, Nelson Escobar wrote: > Signed-off-by: Dave Goodell > Reviewed-by: Reese Faucette > Reviewed-by: Xuyang Wang > Signed-off-by: Nelson Escobar > --- > drivers/infiniband/hw/usnic/usnic_vnic.c | 54 > +--- > 1 file changed, 29 insertions(+), 25

Re: completion queue abstraction V2

2015-12-23 Thread Doug Ledford
On 12/07/2015 03:51 PM, Christoph Hellwig wrote: > This series adds a new RDMA core abstraction that insulated the > ULPs from the nitty gritty details of CQ polling. See the individual > patches for more details. > > Note that this series should be applied on top of my > "IB: merge struct ib_dev

Re: [PATCH] IB/mlx4: Replace kfree with kvfree in mlx4_ib_destroy_srq

2015-12-23 Thread Doug Ledford
On 12/16/2015 09:54 PM, Wengang Wang wrote: > Commit 0ef2f05c7e02ff99c0b5b583d7dee2cd12b053f2 uses vmalloc for WR buffers > when needed and uses kvfree to free the buffers. It missed changing kfree > to kvfree in mlx4_ib_destroy_srq(). > > Reported-by: Matthew Finaly > Signed-off-by: Wengang Wang

Re: [PATCH 0/3] IB core: 64 bit counter support V3

2015-12-23 Thread Doug Ledford
On 12/21/2015 09:20 AM, Christoph Lameter wrote: > V2->V3 > - Also add support for NOIETF counter mode where we have 64 bit > counters but not the multicast/unicast counters. > - Add Reviewed-by's from Hal. > > V1->V2 > - Add detection of the capability for 64 bit counter support > -

Re: ocrdma failure in 4.4.0-rc5

2015-12-23 Thread Doug Ledford
On 12/23/2015 01:53 PM, Devesh Sharma wrote: > Hi Dough, > > I was all set to send you an update in my morning tomorrow. Let me > give you a brief update here > > The deadlock is caused being caused due to following two facts: > A. be2net is sending open/close event to ocrdma holding > device_lis

Re: ocrdma failure in 4.4.0-rc5

2015-12-23 Thread Devesh Sharma
Hi Dough, I was all set to send you an update in my morning tomorrow. Let me give you a brief update here The deadlock is caused being caused due to following two facts: A. be2net is sending open/close event to ocrdma holding device_list_mutex. Nic Open/close hooks are called under rtnl lock from

Re: [PATCH net-next 0/2] new maintainers for Mellanox mlx4/mlx5 core and IB drivers

2015-12-23 Thread Doug Ledford
On 12/23/2015 11:30 AM, Or Gerlitz wrote: > Hi Dave, Doug > > We're happily assigning new maintainers for mlx4/mlx5 core and IB drivers. > > This is aligned with Eli (mlx5) and Roland (mlx4). > > FWIW, I did the whole change to go through netdev. Hi Dave, I've picked these up. Thanks Or. >

Re: MR cleanups / dead code removal V2

2015-12-23 Thread Doug Ledford
On 12/23/2015 01:12 PM, Christoph Hellwig wrote: > Hi Doug, > > this series (on top of your k.o/for-4.5 branch) has various MR-related > cleanups: starting to document the device capabilities, removing lots > of dead MR/MW code and removing a useless field in struct ib_mr. This > should be fairl

[PATCH 10/10] IB: remove the write-only usecnt field from struct ib_mr

2015-12-23 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Reviewed-by: Bart Van Assche Reviewed-by: Sagi Grimberg --- drivers/infiniband/core/uverbs_cmd.c| 6 -- drivers/infiniband/core/verbs.c | 8 +--- drivers/infiniband/hw/cxgb3/iwch_provider.c | 3 --- drivers/infiniband/hw/cxgb4/mem.c

[PATCH 09/10] IB: remove the struct ib_phys_buf definition

2015-12-23 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Reviewed-by: Jason Gunthorpe [core] Reviewed-by: Steve Wise --- include/rdma/ib_verbs.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 1778442..197b620 100644 --- a/incl

[PATCH 08/10] ehca: stop using struct ib_phys_buf

2015-12-23 Thread Christoph Hellwig
And simplify the calling convention for full-memory registrations. Signed-off-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Reviewed-by: Jason Gunthorpe [core] Reviewed-by: Steve Wise --- drivers/staging/rdma/ehca/ehca_classes.h | 5 +- drivers/staging/rdma/ehca/ehca_mrmw.c| 94 ++

[PATCH 07/10] amso1100: fold c2_reg_phys_mr into c2_get_dma_mr

2015-12-23 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Reviewed-by: Jason Gunthorpe [core] Reviewed-by: Steve Wise --- drivers/staging/rdma/amso1100/c2_provider.c | 71 ++--- 1 file changed, 14 insertions(+), 57 deletions(-) diff --git a/drivers/staging/rdma/amso1

[PATCH 03/10] IB: remove support for phys MRs

2015-12-23 Thread Christoph Hellwig
We have stopped using phys MRs in the kernel a while ago, so let's remove all the cruft used to implement them. Signed-off-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Reviewed-by: Jason Gunthorpe [core] Reviewed-By: Devesh Sharma [ocrdma] Reviewed-by: Steve Wise --- drivers/infiniband/hw

[PATCH 02/10] IB: remove ib_query_mr

2015-12-23 Thread Christoph Hellwig
This functionality has no users and was only supported by the staged out EHCA driver. Signed-off-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Reviewed-by: Jason Gunthorpe [core] Reviewed-by: Steve Wise --- drivers/infiniband/core/verbs.c | 7 - drivers/staging/rdma/ehca/ehca_

[PATCH 06/10] nes: simplify nes_reg_phys_mr calling conventions

2015-12-23 Thread Christoph Hellwig
Just pass and address/size pair instead of an ib_phys_buf array. Signed-off-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Reviewed-by: Jason Gunthorpe [core] Reviewed-by: Steve Wise --- drivers/infiniband/hw/nes/nes_cm.c| 10 +-- drivers/infiniband/hw/nes/nes_verbs.c | 140 ---

[PATCH 05/10] cxgb3: simplify iwch_get_dma_wr

2015-12-23 Thread Christoph Hellwig
Fold simplified versions of build_phys_page_list and iwch_register_phys_mem into iwch_get_dma_wr now that no other callers are left. Signed-off-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Reviewed-by: Jason Gunthorpe [core] Reviewed-by: Steve Wise --- drivers/infiniband/hw/cxgb3/iwch_mem

[PATCH 04/10] IB: remove in-kernel support for memory windows

2015-12-23 Thread Christoph Hellwig
Remove the unused ib_allow_mw and ib_bind_mw functions, remove the unused IB_WR_BIND_MW and IB_WC_BIND_MW opcodes and move ib_dealloc_mw into the uverbs module. Signed-off-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Reviewed-by: Jason Gunthorpe [core] Reviewed-by: Steve Wise --- Document

MR cleanups / dead code removal V2

2015-12-23 Thread Christoph Hellwig
Hi Doug, this series (on top of your k.o/for-4.5 branch) has various MR-related cleanups: starting to document the device capabilities, removing lots of dead MR/MW code and removing a useless field in struct ib_mr. This should be fairly uncontroversial I hope, so I'd like to get it in before any

[PATCH 01/10] IB: start documenting device capabilities

2015-12-23 Thread Christoph Hellwig
Just IB_DEVICE_LOCAL_DMA_LKEY and IB_DEVICE_MEM_MGT_EXTENSIONS for now as I'm most familar with those. Signed-off-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Reviewed-By: Jason Gunthorpe --- include/rdma/ib_verbs.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/in

Re: [PATCH 0/2] IB multicast cleanup patches V2

2015-12-23 Thread Doug Ledford
On 12/21/2015 09:42 AM, Christoph Lameter wrote: > V1->V2 > - Add Reviewed by's for first patch from Ira Weiny > - Change name of ipoib_check_mcast_sendonly() to > ipoib_check_and_add_mcast_sendonly() as requested by Ira > > This patchset cleans up the code a bit after the last round of mu

Re: ocrdma failure in 4.4.0-rc5

2015-12-23 Thread Doug Ledford
On 12/20/2015 11:29 PM, Devesh Sharma wrote: > Hi Dough, > > Thanks for your note. > > We will root cause the issue asap and get back to you with the fix. Ping. Any update? > -Regards > Devesh > > On Sun, Dec 20, 2015 at 1:41 AM, Doug Ledford wrote: >> Hi Devesh, >> >> Testing 4.4.0-rc5, the

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-23 Thread Doug Ledford
On 12/23/2015 11:35 AM, Matan Barak wrote: > On Wed, Dec 23, 2015 at 6:08 PM, Doug Ledford wrote: >> On 12/22/2015 02:26 PM, Matan Barak wrote: >>> On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford wrote: On 12/22/2015 05:47 AM, Or Gerlitz wrote: > On 12/21/2015 5:01 PM, Matan Barak wrote: >

Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver

2015-12-23 Thread Doug Ledford
On 12/23/2015 11:35 AM, Faisal Latif wrote: > On Wed, Dec 23, 2015 at 11:09:56AM -0500, Doug Ledford wrote: >> On 12/21/2015 06:13 PM, Faisal Latif wrote: >>> This (V1) series contains the addition of the i40iw.ko driver after >>> incorporating the feedback from Christoph Hellwig and Joe Perches fo

Re: [PATCH for-next V2 00/10] Add RoCE support to the mlx5 driver

2015-12-23 Thread Doug Ledford
On 12/23/2015 11:47 AM, Matan Barak wrote: > Hi Doug, > > This patchset adds RoCE V1 and RoCE V2 support to the mlx5 device > driver. > > This patchset was applied and tested over the third version of > "Add RoCE v2 support". This one worked. Thanks, applied. > Regards, > Achiad and Matan > >

Re: [PATCH for-next V2 0/5] User-space time-stamping support for mlx5_ib

2015-12-23 Thread Or Gerlitz
On Tue, Dec 15, 2015 at 8:30 PM, Matan Barak wrote: > This patch-set adds user-space support for time-stamping in mlx5_ib. > It implements the necessary API: > (a) ib_create_cq_ex - Add support for CQ creation flags > (b) ib_query_device - return timestamp_mask and hca_core_clock. > We also add

Re: FW: [PATCH for-next v1 0/2] Advertise atomic operations support in mlx5

2015-12-23 Thread eran ben elisha
>> >> If the firmware supports host endianness, try to configure the >> hardware to work this way, and on success propagate this capability to >> the upper layers, otherwise advertise that atomic operations aren't >> supported. > > If you are not going to allow any support except for host endian,

Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver

2015-12-23 Thread Or Gerlitz
On 12/22/2015 1:13 AM, Faisal Latif wrote: This driver provides iWARP RDMA functionality for the Intel(R) X722 Ethernet controller for PCI Physical Functions. Is there any public info on the X722, I didn't manage to find such. It also has support for Virtual Function driver (i40iwvf.ko), whic

[PATCH for-next V2 08/10] IB/mlx5: Support IB device's callbacks for adding/deleting GIDs

2015-12-23 Thread Matan Barak
From: Achiad Shochat These callbacks write into the mlx5 RoCE address table. Upon del_gid we write a zero'd GID. Signed-off-by: Achiad Shochat --- drivers/infiniband/hw/mlx5/main.c | 89 +++ include/linux/mlx5/device.h | 20 + 2 files changed,

[PATCH for-next V2 06/10] IB/mlx5: Extend query_device/port to support RoCE

2015-12-23 Thread Matan Barak
From: Achiad Shochat Using the vport access functions to retrieve the Ethernet specific information and return this information in ib_query_device and ib_query_port. Signed-off-by: Achiad Shochat --- drivers/infiniband/hw/mlx5/main.c | 75 +++ include/linux/

[PATCH for-next V2 10/10] IB/mlx5: Support RoCE

2015-12-23 Thread Matan Barak
From: Achiad Shochat Advertise RoCE support for IB/core layer and set the hardware to work in RoCE mode. Signed-off-by: Achiad Shochat --- drivers/infiniband/hw/mlx5/main.c | 48 +++ 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/drivers/infi

[PATCH for-next V2 07/10] IB/mlx5: Set network_hdr_type upon RoCE responder completion

2015-12-23 Thread Matan Barak
From: Achiad Shochat When handling a responder completion, if the link layer is Ethernet, set the work completion network_hdr_type field according to CQE's info and the IB_WC_WITH_NETWORK_HDR_TYPE flag. Signed-off-by: Achiad Shochat --- drivers/infiniband/hw/mlx5/cq.c | 17 + i

[PATCH for-next V2 09/10] IB/mlx5: Add RoCE fields to Address Vector

2015-12-23 Thread Matan Barak
From: Achiad Shochat Set the address handle and QP address path fields according to the link layer type (IB/Eth). Signed-off-by: Achiad Shochat --- drivers/infiniband/hw/mlx5/ah.c | 32 +-- drivers/infiniband/hw/mlx5/main.c| 21 ++ drivers/infin

[PATCH for-next V2 05/10] net/mlx5_core: Introduce access functions to query vport RoCE fields

2015-12-23 Thread Matan Barak
From: Achiad Shochat Introduce access functions to query NIC vport system_image_guid, node_guid and qkey_viol_cntr. Signed-off-by: Achiad Shochat --- drivers/net/ethernet/mellanox/mlx5/core/vport.c | 62 + include/linux/mlx5/mlx5_ifc.h | 10 +++- inclu

[PATCH for-next V2 03/10] net/mlx5_core: Break down the vport mac address query function

2015-12-23 Thread Matan Barak
From: Achiad Shochat Introduce a new function called mlx5_query_nic_vport_context(). This function gets all the NIC vport attributes from the device. The MAC address is just one of the NIC vport attributes, so mlx5_query_nic_vport_mac_address() is now just a wrapper function above mlx5_query_nic

[PATCH for-next V2 01/10] IB/mlx5: Support IB device's callback for getting the link layer

2015-12-23 Thread Matan Barak
From: Achiad Shochat Make the existing mlx5_ib_port_link_layer() signature match the ib device callback signature (add port_num parameter). Refactor it to use a sub function so that the link layer could be queried also before the ibdev is created. Signed-off-by: Achiad Shochat --- drivers/infi

[PATCH for-next V2 02/10] IB/mlx5: Support IB device's callback for getting its netdev

2015-12-23 Thread Matan Barak
From: Achiad Shochat For Eth ports only: Maintain a net device pointer in mlx5_ib_device and update it upon NETDEV_REGISTER and NETDEV_UNREGISTER events if the net-device and IB device have the same PCI parent device. Implement the get_netdev callback to return this net device. Signed-off-by: Ac

[PATCH for-next V2 00/10] Add RoCE support to the mlx5 driver

2015-12-23 Thread Matan Barak
Hi Doug, This patchset adds RoCE V1 and RoCE V2 support to the mlx5 device driver. This patchset was applied and tested over the third version of "Add RoCE v2 support". Regards, Achiad and Matan Changes from V1: - Rebased over Doug's k.o/for-4.4-rc branch. Changes from V0: - Fixed using rwlo

[PATCH for-next V2 04/10] net/mlx5_core: Introduce access functions to enable/disable RoCE

2015-12-23 Thread Matan Barak
From: Achiad Shochat A mlx5 Ethernet port must be explicitly enabled for RoCE. When RoCE is not enabled on the port, the NIC will refuse to create QPs attached to it and incoming RoCE packets will be considered by the NIC as plain Ethernet packets. Signed-off-by: Achiad Shochat --- drivers/net

Re: [PATCH V1 15/16] i40iw: add entry in rdma_netlink

2015-12-23 Thread Or Gerlitz
On 12/22/2015 1:13 AM, Faisal Latif wrote: Add entry for port mapper services. Signed-off-by: Faisal Latif --- include/uapi/rdma/rdma_netlink.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/rdma/rdma_netlink.h b/include/uapi/rdma/rdma_netlink.h index c19a5dc..4fa418d 10064

Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver

2015-12-23 Thread Or Gerlitz
On 12/23/2015 6:35 PM, Faisal Latif wrote: I will provide new patch series for latest k.o. Also will make sure of shallow threading for the series. Please make sure that the cover letter will include the full output of the git generated cover-letter so we can see the location of changes you

Re: [PATCH V1 08/16] i40iw: add files for iwarp interface

2015-12-23 Thread Or Gerlitz
On 12/22/2015 1:13 AM, Faisal Latif wrote: + +enum i40iw_memreg_type { + IW_MEMREG_TYPE_MEM = 0x, + IW_MEMREG_TYPE_QP = 0x0001, + IW_MEMREG_TYPE_CQ = 0x0002, + IW_MEMREG_TYPE_MW = 0x0003, + IW_MEMREG_TYPE_FMR = 0x0004, + IW_MEMREG_TYPE_FMEM = 0x0005, +};

Re: [PATCH for-next V1 00/10] Add RoCE support to the mlx5 driver

2015-12-23 Thread Matan Barak
On Wed, Dec 23, 2015 at 6:07 PM, Doug Ledford wrote: > On 12/23/2015 08:17 AM, Matan Barak wrote: >> Hi Doug, >> >> This patchset adds RoCE V1 and RoCE V2 support to the mlx5 device >> driver. >> >> This patchset was applied and tested over the third version of >> "Add RoCE v2 support". >> >> Rega

Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver

2015-12-23 Thread Faisal Latif
On Wed, Dec 23, 2015 at 11:09:56AM -0500, Doug Ledford wrote: > On 12/21/2015 06:13 PM, Faisal Latif wrote: > > This (V1) series contains the addition of the i40iw.ko driver after > > incorporating the feedback from Christoph Hellwig and Joe Perches for > > initial series. > > > > This driver prov

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-23 Thread Matan Barak
On Wed, Dec 23, 2015 at 6:08 PM, Doug Ledford wrote: > On 12/22/2015 02:26 PM, Matan Barak wrote: >> On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford wrote: >>> On 12/22/2015 05:47 AM, Or Gerlitz wrote: On 12/21/2015 5:01 PM, Matan Barak wrote: > Previously, cma_match_net_dev called cma_pro

[PATCH net-next 1/2] MAINTAINERS: Assign new maintainers to Mellanox mlx5 core and IB drivers

2015-12-23 Thread Or Gerlitz
Matan and Leon step in as co-maintainers to replace Eli Cohen who wrote and maintained the core and IB drivers. Signed-off-by: Or Gerlitz --- MAINTAINERS | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index c6b78b0..c7586a5 100644 --

[PATCH net-next 2/2] MAINTAINERS: Assign maintainer to Mellanox mlx4 core and IB drivers

2015-12-23 Thread Or Gerlitz
The driver was written originally by Roland Dreier, currently there's no official maintainer. Yishai steps in as maintainer. Signed-off-by: Or Gerlitz Cc: Roland Dreier --- MAINTAINERS | 19 +++ 1 file changed, 19 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c7586

[PATCH net-next 0/2] new maintainers for Mellanox mlx4/mlx5 core and IB drivers

2015-12-23 Thread Or Gerlitz
Hi Dave, Doug We're happily assigning new maintainers for mlx4/mlx5 core and IB drivers. This is aligned with Eli (mlx5) and Roland (mlx4). FWIW, I did the whole change to go through netdev. Or. Or Gerlitz (2): MAINTAINERS: Assign new maintainers to Mellanox mlx5 core and IB drivers MAIN

RE: [RFC contig pages support 1/2] IB: Supports contiguous memory operations

2015-12-23 Thread Shachar Raindel
> -Original Message- > From: Vlastimil Babka [mailto:vba...@suse.cz] > Sent: Tuesday, December 22, 2015 4:59 PM > > On 12/13/2015 01:48 PM, Shachar Raindel wrote: > > > > > >> -Original Message- > >> From: Christoph Hellwig [mailto:h...@infradead.org] > >> Sent: Wednesday, Decemb

Re: [RFC] Generic InfiniBand transport done in software

2015-12-23 Thread Moni Shoua
> > > This makes no mention of the already posted work which aims to consolidate > the qib and hfi1 drivers verbs implementation. However it does seem to be > mostly in line with what we have already presented for rdmavt and the > direction the next set of patches is going in. Have you seen somethi

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-23 Thread Matan Barak
On Wed, Dec 23, 2015 at 6:08 PM, Doug Ledford wrote: > On 12/22/2015 02:26 PM, Matan Barak wrote: >> On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford wrote: >>> On 12/22/2015 05:47 AM, Or Gerlitz wrote: On 12/21/2015 5:01 PM, Matan Barak wrote: > Previously, cma_match_net_dev called cma_pro

Re: [PATCH] IB/usnic: Fix resource leak in error case

2015-12-23 Thread Doug Ledford
On 12/09/2015 01:42 PM, Nelson Escobar wrote: > Signed-off-by: Dave Goodell > Reviewed-by: Reese Faucette > Reviewed-by: Xuyang Wang > Signed-off-by: Nelson Escobar > --- > drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/d

Re: [PATCH] IB/usnic: Support more QP state transitions

2015-12-23 Thread Doug Ledford
On 12/09/2015 01:42 PM, Nelson Escobar wrote: > They were already implemented at a lower layer, but the upper level > routine placed arbitrary restrictions on which transitions were > permitted. Simplify the state machine logic to live wholly in > usnic_ib_qp_grp_modify. > > Signed-off-by: Dave G

Re: [PATCH] IB/usnic: Fix message typo

2015-12-23 Thread Doug Ledford
On 12/09/2015 01:42 PM, Nelson Escobar wrote: > Signed-off-by: Dave Goodell > Reviewed-by: Reese Faucette > Reviewed-by: Xuyang Wang > Signed-off-by: Nelson Escobar > --- > drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/d

Re: [PATCH] IB/usnic: Improve a failure message

2015-12-23 Thread Doug Ledford
On 12/09/2015 01:42 PM, Nelson Escobar wrote: > Signed-off-by: Nelson Escobar > Reviewed-by: Dave Goodell > --- > drivers/infiniband/hw/usnic/usnic_debugfs.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/hw/usnic/usnic_debugfs.c > b/drivers/in

Re: [PATCH] IB/usnic: Fix incorrect cast in usnic_ib_fw_string_to_u64

2015-12-23 Thread Doug Ledford
On 12/09/2015 01:42 PM, Nelson Escobar wrote: > Signed-off-by: Christian Benvenuti > Signed-off-by: Nelson Escobar > Reviewed-by: Dave Goodell > --- > drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/usn

Re: [PATCH] IB/usnic: Remove unused prototype

2015-12-23 Thread Doug Ledford
On 12/09/2015 01:39 PM, Nelson Escobar wrote: > query_protocol() was added in commit 6b90a6d66b17 ("IB/Verbs: > Implement new callback query_protocol()") and then removed in > commit f9b22e355d38 ("IB/core: Convert core to use bitfield > for caps"). > > This left behind an unused prototype. > > S

Re: [PATCH] IB/usnic: delete unneeded IS_ERR test

2015-12-23 Thread Doug Ledford
On 12/22/2015 10:29 AM, Dave Goodell wrote: > [copying Nelson too] > > On Sat, Dec 19, 2015 at 09:48:59PM +0100, Julia Lawall wrote: >> kzalloc doesn't return ERR_PTR, so there is no need to test for it. >> >> The semantic match that finds this problem is as follows: >> (http://coccinelle.lip6.fr/

Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver

2015-12-23 Thread Doug Ledford
On 12/21/2015 06:13 PM, Faisal Latif wrote: > This (V1) series contains the addition of the i40iw.ko driver after > incorporating the feedback from Christoph Hellwig and Joe Perches for > initial series. > > This driver provides iWARP RDMA functionality for the Intel(R) X722 Ethernet > controller

Re: [PATCH for-next V1 00/10] Add RoCE support to the mlx5 driver

2015-12-23 Thread Doug Ledford
On 12/23/2015 08:17 AM, Matan Barak wrote: > Hi Doug, > > This patchset adds RoCE V1 and RoCE V2 support to the mlx5 device > driver. > > This patchset was applied and tested over the third version of > "Add RoCE v2 support". > > Regards, > Achiad > > Changes from V0: > - Fixed using rwlock be

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-23 Thread Doug Ledford
On 12/22/2015 02:26 PM, Matan Barak wrote: > On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford wrote: >> On 12/22/2015 05:47 AM, Or Gerlitz wrote: >>> On 12/21/2015 5:01 PM, Matan Barak wrote: Previously, cma_match_net_dev called cma_protocol_roce which tried to verify that the IB device use

Re: [PATCH for-next v1 0/2] Advertise atomic operations support in mlx5

2015-12-23 Thread Doug Ledford
On 12/14/2015 09:34 AM, Eran Ben Elisha wrote: > Hi Doug, > > This patch set adds the functionality to advertise standard atomic operations > capabilities for mlx5 driver. The Hardware can be configured to work in two > modes according to the device capabilities: 1. Big Endian requestor respond 2

Re: [PATCH for-next V3 00/11] Add RoCE v2 support

2015-12-23 Thread Doug Ledford
On 12/23/2015 07:56 AM, Matan Barak wrote: > Hi Doug, > > This series adds the support for RoCE v2. In order to support RoCE v2, > we add gid_type attribute to every GID. When the RoCE GID management > populates the GID table, it duplicates each GID with all supported types. > This gives the user

Re: [PATCH for-next V3 00/11] Add RoCE v2 support

2015-12-23 Thread Doug Ledford
On 12/23/2015 07:56 AM, Matan Barak wrote: > Hi Doug, > This patch is applied on the "Change per-entry locks in GID cache to > table lock" series which was sent to the mailing list. The "Change per-entry locks..." patchset emails are missing from my mail folder (another casualty of that mail inci

Re: [PATCH for-next V3 01/11] IB/core: Add gid_type to gid attribute

2015-12-23 Thread Sagi Grimberg
+static const char * const gid_type_str[] = { ^^ ^^ IMHO, The white spaces can be a little bit confusing to understand. Pay attention to the double const - I think it's more clear that way. I agree. + [IB_GID_TYPE_IB]= "IB/RoCE v1", +}; + +const char *ib

Re: [PATCH for-next V3 01/11] IB/core: Add gid_type to gid attribute

2015-12-23 Thread Matan Barak
On Wed, Dec 23, 2015 at 3:40 PM, Leon Romanovsky wrote: > On Wed, Dec 23, 2015 at 02:56:47PM +0200, Matan Barak wrote: >> In order to support multiple GID types, we need to store the gid_type >> with each GID. This is also aligned with the RoCE v2 annex "RoCEv2 PORT >> GID table entries shall have

Re: [PATCH for-next V3 01/11] IB/core: Add gid_type to gid attribute

2015-12-23 Thread Leon Romanovsky
On Wed, Dec 23, 2015 at 02:56:47PM +0200, Matan Barak wrote: > In order to support multiple GID types, we need to store the gid_type > with each GID. This is also aligned with the RoCE v2 annex "RoCEv2 PORT > GID table entries shall have a "GID type" attribute that denotes the L3 > Address type". T

Re: [PATCH for-next V3 00/11] Add RoCE v2 support

2015-12-23 Thread Matan Barak
On Wed, Dec 23, 2015 at 2:56 PM, Matan Barak wrote: > Hi Doug, > > This series adds the support for RoCE v2. In order to support RoCE v2, > we add gid_type attribute to every GID. When the RoCE GID management > populates the GID table, it duplicates each GID with all supported types. > This gives

[PATCH for-next V1 07/10] IB/mlx5: Set network_hdr_type upon RoCE responder completion

2015-12-23 Thread Matan Barak
From: Achiad Shochat When handling a responder completion, if the link layer is Ethernet, set the work completion network_hdr_type field according to CQE's info and the IB_WC_WITH_NETWORK_HDR_TYPE flag. Signed-off-by: Achiad Shochat --- drivers/infiniband/hw/mlx5/cq.c | 17 + i

[PATCH for-next V1 08/10] IB/mlx5: Support IB device's callbacks for adding/deleting GIDs

2015-12-23 Thread Matan Barak
From: Achiad Shochat These callbacks write into the mlx5 RoCE address table. Upon del_gid we write a zero'd GID. Signed-off-by: Achiad Shochat --- drivers/infiniband/hw/mlx5/main.c | 89 +++ include/linux/mlx5/device.h | 20 + 2 files changed,

[PATCH for-next V1 04/10] net/mlx5_core: Introduce access functions to enable/disable RoCE

2015-12-23 Thread Matan Barak
From: Achiad Shochat A mlx5 Ethernet port must be explicitly enabled for RoCE. When RoCE is not enabled on the port, the NIC will refuse to create QPs attached to it and incoming RoCE packets will be considered by the NIC as plain Ethernet packets. Signed-off-by: Achiad Shochat --- drivers/net

[PATCH for-next V1 05/10] net/mlx5_core: Introduce access functions to query vport RoCE fields

2015-12-23 Thread Matan Barak
From: Achiad Shochat Introduce access functions to query NIC vport system_image_guid, node_guid and qkey_viol_cntr. Signed-off-by: Achiad Shochat --- drivers/net/ethernet/mellanox/mlx5/core/vport.c | 62 + include/linux/mlx5/mlx5_ifc.h | 10 +++- inclu

[PATCH for-next V1 06/10] IB/mlx5: Extend query_device/port to support RoCE

2015-12-23 Thread Matan Barak
From: Achiad Shochat Using the vport access functions to retrieve the Ethernet specific information and return this information in ib_query_device and ib_query_port. Signed-off-by: Achiad Shochat --- drivers/infiniband/hw/mlx5/main.c | 75 +++ include/linux/

[PATCH for-next V1 10/10] IB/mlx5: Support RoCE

2015-12-23 Thread Matan Barak
From: Achiad Shochat Advertise RoCE support for IB/core layer and set the hardware to work in RoCE mode. Signed-off-by: Achiad Shochat --- drivers/infiniband/hw/mlx5/main.c | 48 +++ 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/drivers/infi

[PATCH for-next V1 09/10] IB/mlx5: Add RoCE fields to Address Vector

2015-12-23 Thread Matan Barak
From: Achiad Shochat Set the address handle and QP address path fields according to the link layer type (IB/Eth). Signed-off-by: Achiad Shochat --- drivers/infiniband/hw/mlx5/ah.c | 32 +-- drivers/infiniband/hw/mlx5/main.c| 21 ++ drivers/infin

  1   2   >