Re: [PATCH rdma-next V2 01/32] IB/core: Macro for RoCEv2 UDP port

On Thu, Dec 24, 2015 at 11:17:47AM +0200, Kamal Heib wrote: > From: Amir Vadai > > Adding a macro for RoCEv2 UDP destination port. You are adding define and not macro. > > Signed-off-by: Amir Vadai > Signed-off-by: Kamal Heib > --- > include/rdma/ib_verbs.h | 2 ++ > 1 file changed, 2 insert

Re: [PATCH 5/6] IB/uapi: expose uverbs WC status codes

On Thu, Dec 24, 2015 at 03:39:26PM +0100, Christoph Hellwig wrote: > This exposes the WC status codes supported by uverbs as part of the uapi > headers. It follows the same scheme as the WR opcodes. > > Signed-off-by: Christoph Hellwig > --- > include/rdma/ib_verbs.h | 44 > ++

Re: [PATCH 3/6] IB/uapi: expose uverbs WC opcodes

On Thu, Dec 24, 2015 at 03:39:24PM +0100, Christoph Hellwig wrote: > This exposes the WC opcodes supported by uverbs as part of the uapi > headers. It follows the same scheme as the WR opcodes. > > Signed-off-by: Christoph Hellwig > --- > include/rdma/ib_verbs.h | 29 +-

Re: [PATCH 1/6] IB/uapi: expose uverbs WR opcodes

On Thu, Dec 24, 2015 at 03:39:22PM +0100, Christoph Hellwig wrote: > #define MLX5_IB_SEND_UMR_UPDATE_MTT (IB_SEND_RESERVED_START << 2) > #define MLX5_IB_QPT_REG_UMR IB_QPT_RESERVED1 > -#define MLX5_IB_WR_UMR IB_WR_RESERVED1 > +#define MLX5_IB_WR_UMR (IB_WR_END +

Re: [PATCH 4/6] IB/uapi: expose uverbs WC flags

On Thu, Dec 24, 2015 at 03:39:25PM +0100, Christoph Hellwig wrote: > This exposes the WC flags supported by uverbs as part of the uapi > headers. It follows the same scheme as the WR opcodes. > > Signed-off-by: Christoph Hellwig > --- > include/rdma/ib_verbs.h | 14 +++--- > includ

[PATCH v2 1/6] InfiniBand-ocrdma: One jump label less in ocrdma_alloc_ucontext_pd()

From: Markus Elfring Date: Sat, 26 Dec 2015 22:18:38 +0100 This issue was detected by using the Coccinelle software. * Let us return directly if a call of the _ocrdma_alloc_pd() function failed. * Reduce the scope for the local variable "status" to one case of an if statement. * Delete the

Re: [PATCH 1/6] InfiniBand-ocrdma: One variable and jump label less in ocrdma_alloc_ucontext_pd()

[if your patch is applied to the wrong git tree, please drop us a note to help improving the system] Hi Markus, [auto build test WARNING on v4.4-rc6] [also build test WARNING on next-20151223] url: https://github.com/0day-ci/linux/commits/SF-Markus-Elfring/InfiniBand-ocrdma-Fine-tuning-for-s

[PATCH 6/6] InfiniBand-ocrdma: Delete an unnecessary variable in ocrdma_dealloc_pd()

From: Markus Elfring Date: Sat, 26 Dec 2015 19:09:23 +0100 1. Return zero in one case directly. 2. Return the value from a call of the _ocrdma_dealloc_pd() function without using an extra assignment for the local variable. 3. Remove the variable "status" in this function then. Signed-off-by

[PATCH 5/6] InfiniBand-ocrdma: Returning only value constants in ocrdma_resize_cq()

From: Markus Elfring Date: Sat, 26 Dec 2015 18:54:47 +0100 Return constant integer values without storing them in the local variable "status". Signed-off-by: Markus Elfring --- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --gi

[PATCH 4/6] InfiniBand-ocrdma: Return a value from a function call in _ocrdma_modify_qp() directly

From: Markus Elfring Date: Sat, 26 Dec 2015 18:40:43 +0100 Return the value from a call of the ocrdma_mbx_modify_qp() function without using an extra assignment for the local variable "status". Signed-off-by: Markus Elfring --- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 +--- 1 file chang

[PATCH 3/6] InfiniBand-ocrdma: Returning only value constants in ocrdma_qp_state_change()

From: Markus Elfring Date: Sat, 26 Dec 2015 18:28:35 +0100 Return zero at the end without using the local variable "status". Signed-off-by: Markus Elfring --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/oc

[PATCH 2/6] InfiniBand-ocrdma: Delete unnecessary variable initialisations in 11 functions

From: Markus Elfring Date: Sat, 26 Dec 2015 18:18:18 +0100 The variable "status" will be set to an appropriate value a bit later. Thus let us omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/ocrdma/ocrdma_ah.c| 2 +- drivers/infini

[PATCH 1/6] InfiniBand-ocrdma: One variable and jump label less in ocrdma_alloc_ucontext_pd()

From: Markus Elfring Date: Sat, 26 Dec 2015 17:16:00 +0100 This issue was detected by using the Coccinelle software. * Let us return directly if a call of the _ocrdma_alloc_pd() function failed. * Delete the jump label "err" and the local variable "status" then. Signed-off-by: Markus Elfring

[PATCH 0/6] InfiniBand-ocrdma: Fine-tuning for some function implementations

From: Markus Elfring Date: Sat, 26 Dec 2015 19:30:54 +0100 Several update suggestions were taken into account from static source code analysis. Markus Elfring (6): One variable and jump label less in ocrdma_alloc_ucontext_pd() Delete unnecessary variable initialisations in 11 functions Ret

Re: [PATCH rdma-next V2 00/32] Soft-RoCE driver

On 12/24/2015 09:20 AM, Christoph Hellwig wrote: > On Thu, Dec 24, 2015 at 02:58:10PM +0200, Or Gerlitz wrote: >> On Thu, Dec 24, 2015 at 12:02 PM, Christoph Hellwig >> wrote: >>> On Thu, Dec 24, 2015 at 11:17:46AM +0200, Kamal Heib wrote: We've located the driver in the staging subtree. Thi

Re: [PATCH 0/4] ocrdma bug fix for linux-4.4-rc

On 12/24/2015 01:14 PM, Devesh Sharma wrote: > This patch series fixes for critical bugs introduced due to recent > changes in linux Infiniband stack. > > Patch 0001 fixes a vlan-id assignment issues in presence of PFC. > This bug was introduced recently got introduced and it fixes > dbf727de7440

Re: [PATCH rdma-next V2 00/32] Soft-RoCE driver

On Thu, 2015-12-24 at 11:17 +0200, Kamal Heib wrote: > Doug and list Hi, > > This patchset introduces Soft RoCE driver. Thanks to submit this driver. I have been looking for this kind of driver a while to setup a RDMA environment with 2 virtual machines. I did a quick test with 2 VMs. root@vm1: