Re: [RFC] Generic InfiniBand transport done in software

doesn't break or otherwise negatively impact qib and/or hfi1, then it should be fine. If it does, then I'm sure Intel will work with you to find a solution that doesn't negatively impact them. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

[PULL REQUEST] Please pull rdma.git

/net/ethernet/emulex/benet/be_roce.h | 4 +- 12 files changed, 134 insertions(+), 101 deletions(-) -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH rdma-next V2 00/32] Soft-RoCE driver

cess is it, might be more > sensible to get it into shape and then merge it directly. You'll > probably save yourself a lot of work that way. > Greg and I have an agreement (again) on staging/rdma. This shouldn't be an issue. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH 0/4] ocrdma bug fix for linux-4.4-rc

/be_main.c | 4 -- > drivers/net/ethernet/emulex/benet/be_roce.c | 36 -- > drivers/net/ethernet/emulex/benet/be_roce.h | 4 +- > 10 files changed, 124 insertions(+), 93 deletions(-) > Thanks Devesh, I'll review and test this later today. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH V1 0/3] Add cross-channel support

The root issue here is that nothing was picked before 4.4-rc6, so we're > in a situation where rebases are needed in the own-maintainer tree > (github) to make things right. No way to avoid that. > > We should aim that for 4.6 and onward, code for -next will start getting > in around rc1-2 and then things will be more robust, etc > > Or. > > Or. > -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/usnic: Fix incorrect cast in usnic_ib_fw_string_to_u64

nic/usnic_ib_verbs.c > @@ -51,7 +51,7 @@ > > static void usnic_ib_fw_string_to_u64(char *fw_ver_str, u64 *fw_ver) > { > - *fw_ver = (u64) *fw_ver_str; > + *fw_ver = *((u64 *)fw_ver_str); > } > > static int usnic_ib_fill_create_qp_resp(struct usn

Re: [PATCH] IB/usnic: Improve a failure message

te dbg fs entry for flow %u\n", > - qp_flow->flow->flow_id); > + usnic_err("Failed to create dbg fs entry for flow %u with error > %ld\n", > + qp_flow->flow->flow_id, > +

Re: [PATCH] IB/usnic: delete unneeded IS_ERR test

t;> (http://coccinelle.lip6.fr/) >> >> // >> @@ >> expression x,e; >> @@ >> >> * x = kzalloc(...) >> ... when != x = e >> * IS_ERR_OR_NULL(x) >> // >> >> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > >

Re: [PATCH] IB/usnic: Remove unused prototype

t; int usnic_ib_query_qp(struct ib_qp *qp, struct ib_qp_attr *qp_attr, > int qp_attr_mask, > struct ib_qp_init_attr *qp_init_attr); > Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH for-next V3 00/11] Add RoCE v2 support

another casualty of that mail incident). So, consider this the notice that that patch set has in fact been picked up for 4.5. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver

Ledford's k.o/for-4.5 > *Change to i40e client patch regarding mailing list - this is consistent > with other i40e files. > *Removed error from i40iw_pr_err() -done > *cqp_request() change from bitfields to bool -done > -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/usnic: Fix resource leak in error case

t; usnic_vnic_put_resources(res_chunk_list[i]); > kfree(res_chunk_list); > return ERR_PTR(err); > Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH for-next V3 00/11] Add RoCE v2 support

his gives the user the ability to communicate over each supported > type. Thanks for rebasing Matan. Applied for 4.5. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH for-next v1 0/2] Advertise atomic operations support in mlx5

/infiniband/hw/mlx5/main.c | 28 - > drivers/net/ethernet/mellanox/mlx5/core/main.c | 57 > +- > include/linux/mlx5/driver.h| 5 +++ > include/linux/mlx5/mlx5_ifc.h | 22 ++ > 4 files ch

Re: [PATCH] IB/usnic: Support more QP state transitions

else { > - usnic_err("Unexpected combination mask: %u state: %u\n", > - attr_mask & IB_QP_STATE, attr->qp_state); > + usnic_err("Unhandled request, attr_mask=0x%x\n", attr_mask); > status = -EINVAL; > } > > +out_unlock: > mutex_unlock(_grp->vf->pf->usdev_lock); > return status; > } > Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/usnic: Fix message typo

sistioned %u from %s to %s", > + usnic_info("Transitioned %u from %s to %s", > qp_grp->grp_id, > usnic_ib_qp_grp_state_to_string(old_state), > usnic_ib_qp_grp_state_to_string(new_state)); > Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

On 12/22/2015 02:26 PM, Matan Barak wrote: > On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford <dledf...@redhat.com> wrote: >> On 12/22/2015 05:47 AM, Or Gerlitz wrote: >>> On 12/21/2015 5:01 PM, Matan Barak wrote: >>>> Previously, cma_match_net_dev called cma_prot

Re: [PATCH for-next V1 00/10] Add RoCE support to the mlx5 driver

| 8 + > 11 files changed, 578 insertions(+), 57 deletions(-) > This series doesn't apply to my tree even after the GID table lock series and the RoCEv2-V3 series. I'm guessing you have some other mlx5 specific series in your tree? -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver

On 12/23/2015 11:35 AM, Faisal Latif wrote: > On Wed, Dec 23, 2015 at 11:09:56AM -0500, Doug Ledford wrote: >> On 12/21/2015 06:13 PM, Faisal Latif wrote: >>> This (V1) series contains the addition of the i40iw.ko driver after >>> incorporating the feedback from Christ

Re: [PATCH 0/2] IB multicast cleanup patches V2

ions exported from ipoib_multicast.c > > This patchset can be retrieved from a git repo on kernel.org via > > git pull git://git.kernel.org/pub/scm/linux/kernel/git/christoph/rdma.git > cleanup > Thanks, applied (with Ira's name fixed). -- Doug Ledford <dledf...@redhat.com>

Re: ocrdma failure in 4.4.0-rc5

so the sooner the better ;-) Thanks for the update. > -Regards > Devesh > > > On Wed, Dec 23, 2015 at 11:29 PM, Doug Ledford <dledf...@redhat.com> wrote: >> On 12/20/2015 11:29 PM, Devesh Sharma wrote: >>> Hi Dough, >>> >>> Thanks for your

Re: [PATCH] IB/mlx4: Replace kfree with kvfree in mlx4_ib_destroy_srq

ib_umem_release(msrq->umem); > } else { > - kfree(msrq->wrid); > + kvfree(msrq->wrid); > mlx4_buf_free(dev->dev, msrq->msrq.max << msrq->msrq.wqe_shift, > >buf); >

Re: [PATCH net-next 0/2] new maintainers for Mellanox mlx4/mlx5 core and IB drivers

ked these up. Thanks Or. > Or. > > Or Gerlitz (2): > MAINTAINERS: Assign new maintainers to Mellanox mlx5 core and IB drivers > MAINTAINERS: Assign maintainer to Mellanox mlx4 core and IB drivers > > MAINTAINERS | 32 +--- > 1 file changed, 2

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

On 12/23/2015 11:35 AM, Matan Barak wrote: > On Wed, Dec 23, 2015 at 6:08 PM, Doug Ledford <dledf...@redhat.com> wrote: >> On 12/22/2015 02:26 PM, Matan Barak wrote: >>> On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford <dledf...@redhat.com> wrote: >>>>

Re: ocrdma failure in 4.4.0-rc5

On 12/20/2015 11:29 PM, Devesh Sharma wrote: > Hi Dough, > > Thanks for your note. > > We will root cause the issue asap and get back to you with the fix. Ping. Any update? > -Regards > Devesh > > On Sun, Dec 20, 2015 at 1:41 AM, Doug Ledford <dledf...@r

Re: [PATCH for-next V2 00/10] Add RoCE support to the mlx5 driver

x5/mlx5_ifc.h | 10 +- > include/linux/mlx5/qp.h | 21 +- > include/linux/mlx5/vport.h | 8 + > 11 files changed, 578 insertions(+), 57 deletions(-) > -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: MR cleanups / dead code removal V2

This > should be fairly uncontroversial I hope, so I'd like to get it in before > any real MR changes. > > Changes since V1: > - rebase > - updated description for the last patch > - additional ACKs > Thanks for rebasing it. Applied. -- Doug Ledford <dledf...@red

Re: [PATCH 0/3] IB core: 64 bit counter support V3

ers, and does not transfer v1 tags from cover letters to the subsequent patches). This makes it *much* easier for me to pick out which of your patches in patchworks are the most recent. Thanks ;-) -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure

As for the BIT macros, I haven't looked at their implementation. If Christoph thinks they are crap, then absent my own opinion on the issue, which I'm not inclined to go form at 10:30pm on Dec. 23rd, I'll trust his judgment ;-) -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH V1 0/3] Add cross-channel support

insertions(+), 42 deletions(-) > I took the series as is. Please make sure to resubmit the libibverbs portion of these changes with the requested man page updates. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: device attr cleanup

The patch I took is much less intrusive, but you might still need to adjust things slightly. I've pushed my current WIP for-next branch to my github repo: git://github.com/dledford/linux.git for-next This branch might get rebased still yet before it gets pushed to my official repo at k.o, but it is perfectly fine to check that your patches will merge with my for-next branch without conflicts. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH for-next V2 0/5] User-space time-stamping support for mlx5_ib

ntainer of the mlx5_ib driver and this series > doesn't add any IB/core changes, we see no reason that it can't go > into 4.5. make sense? I didn't see anything wrong with the set. It's been picked up for 4.5. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: completion queue abstraction V2

here: please include the v1/v2 in your --subject-prefix you pass to git. Patchworks does not preserve cover letters nor propagate flags from cover letter to patch series :-/ -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/usnic: Handle 0 counts in resource allocation

drivers/infiniband/hw/usnic/usnic_vnic.c | 54 > +--- > 1 file changed, 29 insertions(+), 25 deletions(-) Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: FW: [PATCH for-next v1 0/2] Advertise atomic operations support in mlx5

s in mind for next time. > >> >>> IB/mlx5: Advertise atomic capabilities in query device >>> >>> drivers/infiniband/hw/mlx5/main.c | 28 - >>> drivers/net/ethernet/mellanox/mlx5/core/main.c | 57 >>> ++++++

Re: [PATCH 2/2] IB/mlx4: Convert kmalloc to be kmalloc_array to fix checkpatch warnings

truct ib_pd *pd, > if (err) > goto err_mtt; > > - srq->wrid = kmalloc(srq->msrq.max * sizeof(u64), > + srq->wrid = kmalloc_array(srq->msrq.max, sizeof(u64), > GFP_KERNEL | __GFP_NOWARN); > if (!s

Re: [PATCH] IB/mad: Ensure fairness in ib_mad_completion_handler

rk) >> } >> } else >> mad_error_handler(port_priv, ); >> + >> +if (++count > MAD_COMPLETION_PROC_LIMIT) { >> +queue_work(port_priv->wq, _priv->work); >> +break; >> +} >> } >> } >> >> -- >> 1.8.2 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/2] IB/mlx4: Suppress memory allocations warnings in kmalloc->__vmalloc flows

+ srq->wrid = kmalloc(srq->msrq.max * sizeof(u64), > + GFP_KERNEL | __GFP_NOWARN); > if (!srq->wrid) { > srq->wrid = __vmalloc(srq->msrq.max * sizeof(u64), > GFP_KERNEL, PAGE_KERNEL); > Applied with some edits to the commit message, thanks. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

uest and checking this port >> of the device. >> >> Fixes: b8cab5dab15f ('IB/cma: Accept connection without a valid netdev >> on RoCE') >> Signed-off-by: Matan Barak<mat...@mellanox.com> > > seems that the patch is missing from patchworks, I can't expla

Re: device attr cleanup

On 12/22/2015 02:19 PM, Doug Ledford wrote: > On 12/22/2015 02:56 AM, Or Gerlitz wrote: >> On Wed, Dec 16, 2015 at 7:53 AM, Or Gerlitz <ogerl...@mellanox.com> wrote: >>> On 12/15/2015 9:03 PM, Doug Ledford wrote: >> >>>> Or, you specifically as

Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver

ase use shallow threading on patch submissions like this. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

On 12/22/2015 02:26 PM, Matan Barak wrote: > On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford <dledf...@redhat.com> wrote: >> On 12/22/2015 05:47 AM, Or Gerlitz wrote: >>> On 12/21/2015 5:01 PM, Matan Barak wrote: >>>> Previously, cma_match_net_dev called cma_prot

Re: [RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

library changes, let me know that public git commit >>>>> and I can pull it into the staging-next branch and you can continue to >>>>> send me staging patches that way. >>>> >>>> Won't this cause a conflict during the merge window? >>> >>> No, git is good :) >>> >>>> How do we handle changes which affect both qib and hfi1? >>> >>> I don't know, now this gets messy... >>> >> >> Agreed and this is what we are worried about. >> >> Can we do what Dan and Doug have proposed in the past and have Doug take over >> the staging/rdma sub-tree? >> >> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-November/081922.html >> >> I think the upcoming merge window is a reasonable time for him to do that. > > Ok, but keeping on top of all of the generic staging patches that come > in is a tough thing to do, that's up to Doug, if he is ready for it... I'm not worried about that. Patchworks makes the workflow reasonable. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: device attr cleanup

On 12/22/2015 02:56 AM, Or Gerlitz wrote: > On Wed, Dec 16, 2015 at 7:53 AM, Or Gerlitz <ogerl...@mellanox.com> wrote: >> On 12/15/2015 9:03 PM, Doug Ledford wrote: > >>> Or, you specifically asked me to wait until this week. I made my >>> initial impress

Re: RoCE passive side failures on 4.4-rc5

ame behavior with both 4.4-rc2 and 4.4-rc5 >> >> Or. > > I've posted a patch that fixes that, please take a look at [1]. > > Regards, > Matan > > [1] https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg30777.html I've been seeing this too in my 4.4-rc testing, so I'll have test results today. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

ocrdma failure in 4.4.0-rc5

Hi Devesh, Testing 4.4.0-rc5, the ocrdma driver is failing for me (100% reliably). If you have vlans off of the main device, this is what I get from the Fedora rawhide 4.4.0-rc5 kernel: -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD [ 26.692881] be2net :8

Re: [PATCH for-next V2 00/11] Add RoCE v2 support

into my continued response. 1 - Actually, for any received packet with associated IP address information. We've only enabled net namespaces for IP connections between user space applications, for direct IB connections or for kernel connections there is not yet any namespace support. -- Doug Ledf

Re: [PATCH 3/3] IB core: Display 64 bit counters from the extended set

On 12/15/2015 04:46 PM, Doug Ledford wrote: > On 12/15/2015 04:42 PM, Hal Rosenstock wrote: >> On 12/15/2015 4:20 PM, Jason Gunthorpe wrote: >>>> The unicast/multicast extended counters are not always supported - >>>>> depends

Re: [PATCH] IB/ipoib: Change sendq threshold size

this backed by tests? why not 75% or 25%? Much like Erez, I suspect this is a bad change. Unless there are performance numbers to show that under heavy usage this is actually a positive change, I'm not inclined to take it. -- Doug Ledford <dledf...@redhat.com> GPG KeyID:

Re: device attr cleanup

is in the air > for ***months***, it would be fair enough to ask the maintainer not to > cut it this way or another before next week, Doug, agree? Or, you specifically asked me to wait until this week. I made my initial impressions clear (I don't necessarily like the removal of the attr struct, but I

Re: [PATCH for-next V2 00/11] Add RoCE v2 support

ent spec compliant, but still unacceptable. The spec itself is silent on namespaces. But, you guys wanted, and you got, namespace support. Since that's beyond spec, and carries security requirements, I think it's fair to say that from now on, the Linux kernel RDMA stack can no longer *just* be spec compliant. There are additional concerns that must always be addressed with new changes, and those are the namespace constraint preservation concerns. Since you and Jason did not reach a consensus, I have to dig in and see if these patches make it possible to break namespace confinement, either accidentally or with intentionally tricky behavior. That's going to take me some time. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH 3/3] IB core: Display 64 bit counters from the extended set

ted, perhaps it is best not to populate these counters in > sysfs so one can discern between counter not supported and 0 value. > > I'm still working on definitive mthca answer but think the attribute is > not supported there. Does anyone out there have an mthca setup where > they can

Re: [PATCH 10/13] IB/srp: use the new CQ API

ttr struct elements in an organized sub-struct, it's fine and it definitely improves on all of those query calls). -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: device attr cleanup (was: Handle mlx4 max_sge_rd correctly)

On 12/11/2015 01:14 AM, Jason Gunthorpe wrote: > On Thu, Dec 10, 2015 at 11:56:50PM -0500, Doug Ledford wrote: > >> Looking at struct netdevice, it has the sort of organization I would >> call reasonable. Things like struct tx_stats is a struct, even though >> it's embed

Re: [PATCH libibcm] cmpost.c: Handle ibv_get_device_list returning no IB devices in init()

elease was over > 6 years ago. Not to mention the fact that libibcm is completely lacking all documentation if I recall correctly. No man pages or anything like that. We've considered it deprecated for quite some time. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E

[PULL REQUEST] Please pull rdma.git

/mlx4/cmd.c | 2 +- include/linux/mlx4/device.h | 11 include/rdma/ib_mad.h| 2 ++ include/rdma/ib_verbs.h | 1 + 19 files changed, 146 insertions(+), 102 deletions(-) -- Doug Ledford <dledf...@redhat.com> GPG

Re: [PATCH v2 1/1] IB/sa: Put netlink request into the request list before sending

;> request is put on the request list, we need to put the request on the list >> first. >> >> Signed-off-by: Kaike Wan <kaike....@intel.com> >> --- > > Reported-by: Saurabh Sengar <saurabh.tr...@gmail.com> > This was pulled in for 4.4-rc. Thanks. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: device attr cleanup (was: Handle mlx4 max_sge_rd correctly)

reason, and *only* that reason, I'm inclined to take your patch. Otherwise, I wouldn't touch it. The rest of the kernel may think a disorganized, flat namespace is fruit punch kool-aid...I happen to prefer things differently. But I'm willing to acquiesce to the needs of a high performance kernel s

Re: device attr cleanup (was: Handle mlx4 max_sge_rd correctly)

rnel.org >> Cc: ira.weiny; Christoph Hellwig; Jason Gunthorpe; Or Gerlitz; Steve Wise; >> Or Gerlitz; Sagi Grimberg; Doug Ledford >> Subject: Re: device attr cleanup (was: Handle mlx4 max_sge_rd correctly) >> >> >>> On Dec 10, 2015, at 3:27 AM, Sagi Gri

Re: device attr cleanup (was: Handle mlx4 max_sge_rd correctly)

On 12/10/2015 06:29 PM, Christoph Hellwig wrote: > On Thu, Dec 10, 2015 at 12:46:54PM -0500, Doug Ledford wrote: >> Organization. Let's be fair, the totally flat namespace you are >> preferring is the equivalent of a teenager that is completely incapable >> of picking thier

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

0x8001 in that case won't work either. Nope. The suggestion here would break our setup. Well, *would* being the operative word where what I mean is would if we used ibacm. But that's a story for another email... -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH v2 0/2] Handle mlx4 max_sge_rd correctly

On 12/08/2015 01:17 PM, Doug Ledford wrote: > On 12/08/2015 01:13 PM, Sagi Grimberg wrote: >> >>> I've pulled these in. Both of them failed to apply, and the first one >>> was just flat baffling in terms of how Sagi is working from a source >>> base so di

Re: [PATCH v2 0/2] Handle mlx4 max_sge_rd correctly

ke sure I'm not missing something since they were so far off from applying to an upstream kernel. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH v2 1/2] mlx4: Expose correct max_sge_rd limit

> + * - rdma segment (16 bytes) > + * - scatter elements (16 bytes each) > + */ > + MLX4_MAX_SGE_RD = (512 - 16 - 16) / 16 > +}; > + > +enum { > MLX4_DEV_PMC_SUBTYPE_GUID_INFO = 0x14, > MLX4_DEV_PMC_SUBTYPE_PORT_INFO = 0x15, > MLX4_DEV_PMC_SUBTYPE_PKEY_TABLE = 0x16, > -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH v2 0/2] Handle mlx4 max_sge_rd correctly

big and not the right sort of fix for 4.4-rc. I had it on my radar for getting into for-next. So, it'll have to be fixed up to apply over the top of your patches which will already be applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/qib: Minor fixes to qib per SFF 8636

Reviewed-by: Mike Marciniszyn <mike.marcinis...@intel.com> > Reported-by: Easwar Hariharan <easwar.hariha...@intel.com> > Signed-off-by: Easwar Hariharan <easwar.hariha...@intel.com> > Signed-off-by: Mike Marciniszyn <mike.marcinis...@intel.com> Pulled in for 4.4

Re: 4.4's rdma plate

On 12/08/2015 04:07 PM, Or Gerlitz wrote: > On Fri, Oct 23, 2015 at 5:52 PM, Doug Ledford <dledf...@redhat.com> wrote: >> On 10/23/2015 02:46 AM, Or Gerlitz wrote: > >>> Doug, there are few singleton patches to mlxN drivers, just to make >>> sure they are not

Re: device attr cleanup (was: Handle mlx4 max_sge_rd correctly)

On 12/08/2015 04:00 PM, Or Gerlitz wrote: > On Tue, Dec 8, 2015 at 8:17 PM, Doug Ledford <dledf...@redhat.com> wrote: >> >> On 12/08/2015 01:13 PM, Sagi Grimberg wrote: > > >> >>> I mentioned this in v1. This patch set is applied over Christoph

Re: 4.4's rdma plate

On 12/08/2015 04:07 PM, Or Gerlitz wrote: > On Fri, Oct 23, 2015 at 5:52 PM, Doug Ledford <dledf...@redhat.com> wrote: >> On 10/23/2015 02:46 AM, Or Gerlitz wrote: > >>> Doug, there are few singleton patches to mlxN drivers, just to make >>> sure they are not

Re: [PATCH 0/6] SRP initiator related bug fixes

lse ? I was just getting ready to pull this set in. The only one you actually changed, and therefore needs either a resubmit or I have to be careful to get the follow-on version in Patchworks is 5/6, yes? -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: stalled again

ly down at home and I'm simply horribly behind. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH for-next V1 0/9] Add RoCE v2 support

ths the patches > are waiting. > > Or. > > [1] http://marc.info/?l=linux-rdma=143948192926723=2 > >> Otherwise, could we please push this series to v4.5? >> If you need, I can rebase it over your for-4.5 branch once you'll open >> such a branch. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: HFI1 code duplication todo

On 11/20/2015 11:39 AM, Greg KH wrote: > On Fri, Nov 20, 2015 at 10:41:16AM -0500, Doug Ledford wrote: >> To that end, I've opened my 4.4-rc branch and deleted the three >> deprecated drivers from staging and moved hfi1 to the rdma tree. I've >> sent an email to Linus to

Re: HFI1 code duplication todo

've sent an email to Linus to see if he's ok taking those changes, and if so, I'll get them submitted and then open up my for-4.5 branch early to be able to start taking for-next patches. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: HFI1 code duplication todo

>> to rc1. > > It's not a problem, life happens (congratulations by the way), Thanks :-) > but don't > rush things now, why not just wait until the next merge window, there > are no deadlines here that require this to happen for 4.4-final. I'm actually not in a rush to

[PULL REQUEST] Please pull rdma.git

odell\) (1): MAINTAINERS: update usnic maintainer contacts Devesh Sharma (1): RDMA/ocrdma: Prevent CQ-Doorbell floods Doron Tsur (2): IB/core: Fix memory corruption in ib_cache_gid_set_default_gid IB/cm: Fix rb-tree duplicate free and use-after-free Doug Ledford (6): Merge

Re: shrink struct ib_send_wr V4

lete them in a week or so when I send my pull request. I have a few other things to touch up before then and I have patches that touch those drivers, so in order to avoid merge issues that would seem the best course at this point. -- Doug Ledford <dledf...@redhat.com> GPG

Re: shrink struct ib_send_wr V4

On 11/04/2015 12:16 PM, Greg Kroah-Hartman wrote: > On Wed, Nov 04, 2015 at 10:00:38AM -0500, Doug Ledford wrote: >> On 11/02/2015 11:16 PM, Greg Kroah-Hartman wrote: >>> This too was something we discussed at the kernel summit, it's >>> recommended that you just de

Re: shrink struct ib_send_wr V4

On 11/01/2015 01:06 PM, Greg Kroah-Hartman wrote: > On Sun, Nov 01, 2015 at 02:10:48PM +0200, Or Gerlitz wrote: >> On 10/29/2015 1:51 PM, Christoph Hellwig wrote: >>> On Wed, Oct 28, 2015 at 10:57:59PM -0400, Doug Ledford wrote: >>>>>>> I had to do

Re: shrink struct ib_send_wr V4

On 11/02/2015 06:37 PM, Greg Kroah-Hartman wrote: > On Mon, Nov 02, 2015 at 06:20:40PM -0500, Doug Ledford wrote: >> 1) Aging, but working, drivers that will be removed in the future. >> Since we no longer have a deprecation mechanism, I was informed that the >> normal pro

Re: shrink struct ib_send_wr V4

On 11/02/2015 07:18 PM, Jason Gunthorpe wrote: > On Mon, Nov 02, 2015 at 07:02:04PM -0500, Doug Ledford wrote: > >> Because they are *scheduled* for removal. If I simply didn't care if >> they went away, then I wouldn't screw around with deprecating them or >> tagging

Re: shrink struct ib_send_wr V4

On 11/02/2015 07:49 PM, Greg Kroah-Hartman wrote: > On Mon, Nov 02, 2015 at 07:02:04PM -0500, Doug Ledford wrote: >>> so overall it still benifits being in the >>> staging tree, so a few minor breakages every once in a while should be >>> easy for you to fix up, _if_

Re: [PATCH] IB/core, cma: Make __attribute_const__ declarations sparse-friendly

On 10/29/2015 05:16 PM, Bart Van Assche wrote: > On 08/14/2015 12:27 PM, Doug Ledford wrote: >> On 08/03/2015 01:01 PM, Bart Van Assche wrote: >>> Move the __attribute_const__ declarations such that sparse understands >>> that these apply to the function itself

Re: [PATCH v5 00/26] New fast registration API

On 10/29/2015 01:42 AM, Or Gerlitz wrote: > On Thu, Oct 29, 2015 at 4:34 AM, Doug Ledford <dledf...@redhat.com> wrote: >> Yes, I've pulled this in for 4.4. Thanks! > > Doug, we want to run regression over the 4.4 bits, when do you expect > for them to show up @ your kerne

Re: [PATCH 28/26] IB/ipath: Remove fast registration from the code

a/drivers/staging/rdma/ipath/ipath_verbs.h > +++ b/drivers/staging/rdma/ipath/ipath_verbs.h > @@ -280,7 +280,6 @@ struct ipath_swqe { > union { > struct ib_send_wr wr; /* don't use wr.sg_list */ > struct ib_ud_wr ud_wr; > - struct i

Re: shrink struct ib_send_wr V4

On 10/29/2015 07:51 AM, Christoph Hellwig wrote: > On Wed, Oct 28, 2015 at 10:57:59PM -0400, Doug Ledford wrote: >>> I had to do a minor hand merge to get this to apply, but it has been >>> pulled in for 4.4. >> >> This breaks all of the drivers in staging BTW.

Re: [PATCH v5 00/26] New fast registration API

On 10/29/2015 10:33 AM, Sagi Grimberg wrote: > > > On 29/10/2015 16:16, Doug Ledford wrote: >> On 10/29/2015 01:42 AM, Or Gerlitz wrote: >>> On Thu, Oct 29, 2015 at 4:34 AM, Doug Ledford <dledf...@redhat.com> >>> wrote: >>>> Yes, I've pulled thi

Re: [PATCH 28/26] IB/ipath: Remove fast registration from the code

On 10/29/2015 11:45 AM, Doug Ledford wrote: > On 10/29/2015 11:33 AM, Sagi Grimberg wrote: >> The driver does not support it anyway, and the support >> should be added to a generic layer shared by both hfi1, >> qib and softroce drivers. > > Thanks, applied. Thanks fo

Re: [PATCH v5 27/26] IB/hfi1: Remove fast registration from the code

struct ib_atomic_wr atomic_wr; > struct ib_ud_wr ud_wr; > - struct ib_fast_reg_wr fast_reg_wr; > }; > u32 psn;/* first packet sequence number */ > u32 lpsn; /* last packet sequence number */ > @@ -1026,13 +1025,6 @@ struct ib_mr *hfi1_alloc_mr(struct ib_pd *pd, > enum ib_mr_type mr_type, > u32 max_entries); > > -struct ib_fast_reg_page_list *hfi1_alloc_fast_reg_page_list( > - struct ib_device *ibdev, int page_list_len); > - > -void hfi1_free_fast_reg_page_list(struct ib_fast_reg_page_list *pl); > - > -int hfi1_fast_reg_mr(struct hfi1_qp *qp, struct ib_fast_reg_wr *wr); > - > struct ib_fmr *hfi1_alloc_fmr(struct ib_pd *pd, int mr_access_flags, > struct ib_fmr_attr *fmr_attr); > > -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH v5 00/26] New fast registration API

won't break for any of them ;-) > I'll send a patch for hfi1 and ipath. Thanks! -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH libibverbs] Makefile.am: Fix "make distcheck"

t; Signed-off-by: Alaa Hleihel <a...@mellanox.com> > --- > Hi Doug, > > This fixes a "make distcheck" issue. make distcheck > was broken because it tried to use src/neigh.h and > src/nl1_compat.h header files. > > Regards, > Alaa and Matan Thanks, applied.

Re: [PATCH v7 0/4] Add network namespace support in the RDMA-CM

net/rds/rdma_transport.c | 4 +- > net/sunrpc/xprtrdma/svc_rdma_transport.c | 4 +- > net/sunrpc/xprtrdma/verbs.c| 3 +- > 16 files changed, 142 insertions(+), 61 deletions(-) > -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH v5 00/26] New fast registration API

ed this in for 4.4. Thanks! -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: shrink struct ib_send_wr V4

On 10/28/2015 10:25 PM, Doug Ledford wrote: > On 09/13/2015 11:13 AM, Christoph Hellwig wrote: >> This series shrinks the WR size by splitting out the different WR >> types. >> >> Patch number one is too large for the mailinglist, so if you didn't >> get it

Re: shrink struct ib_send_wr V4

To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: 4.4's rdma plate

On 10/23/2015 02:46 AM, Or Gerlitz wrote: >> On Tue, Oct 20, 2015 at 7:31 PM, Doug Ledford <dledf...@redhat.com> wrote: > >>> [...] Next I'll be pulling simple for-next items, then I'll be reviewing the >>> RoCE GID cadche usage in verbs/cma v2 patchset, th

Re: [PATCH] IB/iser: Remove an unused variable

On 10/22/2015 01:59 PM, Bart Van Assche wrote: > Detected this by compiling with W=1. > > Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> > Cc: Sagi Grimberg <sa...@mellanox.com> Thanks Bart, applied. -- Doug Ledford <dledf...@redhat.com>

Re: [PATCH] iser-target: Remove an unused variable

On 10/22/2015 02:14 PM, Bart Van Assche wrote: > Detected this by compiling with W=1. > > Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> > Cc: Sagi Grimberg <sa...@mellanox.com> Thanks Bart, applied. -- Doug Ledford <dledf...@redhat.com>

[PULL REQUEST] Please pull rdma.git

/infiniband/core/ucma.c | 7 ++- 5 files changed, 46 insertions(+), 14 deletions(-) -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH rdma-RC] IB/cm: Fix rb-tree duplicate free and use-after-free

On 10/20/2015 04:27 PM, Doug Ledford wrote: > On 10/15/2015 11:15 AM, Matan Barak wrote: >> >> >> On 10/12/2015 7:37 PM, Hefty, Sean wrote: >>>> ib_send_cm_sidr_rep could sometimes erase the node from the sidr >>>> (depending on errors in the process).

  1   2   3   4   5   6   7   8   >