Re: [PATCH v4 2/2] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

2015-12-21 Thread Greg KH
On Tue, Dec 01, 2015 at 02:47:57PM -0500, ira.we...@intel.com wrote: > From: Dean Luick > > Correctly set half-swing for integrated devices. A0 needs all fields set for > CcePcieCtrl. B0 and later only need a few fields set. > > Reviewed-by: Stuart Summers

Re: [PATCH v2 05/17] staging/rdma/hfi1: Clean up comments

2015-12-21 Thread Greg KH
On Tue, Dec 01, 2015 at 03:38:14PM -0500, Jubin John wrote: > From: Edward Mascarenhas > > Clean up comments by deleting numbering and terms internal to Intel. > > The information on the actual bugs is not deleted. > > Reviewed-by: Mike Marciniszyn

Re: [PATCH v2 0/5] Clean up SDMA engine code

2015-12-21 Thread Greg KH
On Mon, Dec 21, 2015 at 06:48:03PM -0500, ira.weiny wrote: > On Tue, Dec 08, 2015 at 05:10:08PM -0500, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > Various improvements to the SDMA engine code. > > Greg, > > Thanks for reviewing and accepting our patches to

Re: [PATCH v2 01/13] staging/rdma/hfi1: Use BIT macro

2015-12-21 Thread Greg KH
On Mon, Nov 16, 2015 at 09:59:23PM -0500, Jubin John wrote: > This patch fixes the checkpatch issue: > CHECK: Prefer using the BIT macro > > Use of BIT macro for HDRQ_INCREMENT in chip.h causes a change in > format specifier for error message in init.c in order to avoid a > build warning. > >

Re: [PATCH v4 0/2] staging/rdma/hfi1: set Gen 3 half-swing for integrated devices.

2015-12-14 Thread Greg KH
On Mon, Dec 14, 2015 at 02:54:09PM -0500, ira.weiny wrote: > Any further feedback on this series? I'm way behind on staging patches right now (1000+ patches behind...), hopefully will catch up on them this week. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe

Re: hfi1 patches and ordering

2015-12-14 Thread Greg KH
On Mon, Dec 14, 2015 at 09:52:31PM +, Marciniszyn, Mike wrote: > Greg, > > We have other patch series close to being submitted. > > Some depend on the inflight patches you are behind on, some on each other. > > What is the best way of handling this to insure no conflicts? I apply patches

Re: [PATCH v3 3/3] staging/rdma/hfi1: Method to toggle "fast ECN" detection

2015-11-22 Thread Greg KH
On Sun, Nov 22, 2015 at 09:15:02PM -0500, ira.weiny wrote: > On Thu, Nov 19, 2015 at 04:54:44PM -0800, Greg KH wrote: > > On Mon, Nov 09, 2015 at 06:34:44PM -0500, ira.we...@intel.com wrote: > > > From: Vennila Megavannan <vennila.megavan...@intel.com> > > > >

Re: [PATCH v2 2/2] staging/rdma/hfi1: Eliminate WARN_ON when VL is invalid

2015-11-20 Thread Greg KH
On Fri, Nov 20, 2015 at 04:43:56PM +, Marciniszyn, Mike wrote: > > > > > > Is the inprocess branch available? > > > > I do not understand what you mean here :( > > Does it fail to apply to staging-next or staging-testing or something else? As both trees are now the same, it fails to apply

Re: [PATCH v2 2/2] staging/rdma/hfi1: Eliminate WARN_ON when VL is invalid

2015-11-20 Thread Greg KH
On Fri, Nov 20, 2015 at 03:23:55PM +, Marciniszyn, Mike wrote: > > > drivers/staging/rdma/hfi1/sdma.c | 12 ++-- > > > 1 files changed, 10 insertions(+), 2 deletions(-) > > > > Doesn't apply to my tree :( > > Ok. > > Is the inprocess branch available? I do not understand what

Re: [PATCH v3] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

2015-11-20 Thread Greg KH
On Fri, Nov 20, 2015 at 03:14:19PM +, Marciniszyn, Mike wrote: > > > + dd_dev_info(dd, "%s: program XMT margin, CcePcieCtrl 0x%llx\n", > > > + fname, pcie_ctrl); > > > > Why spam the log with this all the time? Shouldn't this be a debug line > > instead? > > The current

Re: HFI1 code duplication todo

2015-11-20 Thread Greg KH
On Fri, Nov 20, 2015 at 10:41:16AM -0500, Doug Ledford wrote: > To that end, I've opened my 4.4-rc branch and deleted the three > deprecated drivers from staging and moved hfi1 to the rdma tree. I've > sent an email to Linus to see if he's ok taking those changes, and if > so, I'll get them

Re: [PATCH 18/18] staging/rdma/hfi1: Workaround CONFIG_SDMA_VERBOSITY timing issue

2015-11-20 Thread Greg KH
On Fri, Nov 20, 2015 at 04:01:18PM +, Marciniszyn, Mike wrote: > > That sounds like a horrid hack, and this implies that a slower machine will > > still have this problem... > > Greg, > > I'm NAK'ing this patch for two reasons: > 1. Code underneath the CONFIG option is only used during

Re: HFI1 code duplication todo

2015-11-20 Thread Greg KH
On Fri, Nov 20, 2015 at 11:58:18AM -0500, Doug Ledford wrote: > On 11/20/2015 11:39 AM, Greg KH wrote: > > On Fri, Nov 20, 2015 at 10:41:16AM -0500, Doug Ledford wrote: > >> To that end, I've opened my 4.4-rc branch and deleted the three > >> deprecated drivers

Re: [PATCH 18/18] staging/rdma/hfi1: Workaround CONFIG_SDMA_VERBOSITY timing issue

2015-11-19 Thread Greg KH
On Fri, Nov 13, 2015 at 07:37:16PM -0800, Jubin John wrote: > Enabling CONFIG_SDMA_VERBOSITY exposes a timing issue in the > driver/DC firmware. Removing the CCE_INT_* CSR reads from > sdma_dumpstate and a sdma_dumpstate call from the sdma_sendctrl() > works around the issue That sounds like a

Re: [PATCH 06/18] staging/rdma/hfi: Add one-time LCB reset

2015-11-19 Thread Greg KH
On Fri, Nov 13, 2015 at 07:37:04PM -0800, Jubin John wrote: > From: Dean Luick > > Add one-time LCB reset on driver load to pre-emptively work > around any LCB power cycle issues. You dropped a character in your Subject line :( -- To unsubscribe from this list: send the

Re: [PATCH 09/18] staging/rdma/hfi1: Correctly limit VLs against SDMA engines

2015-11-19 Thread Greg KH
On Fri, Nov 13, 2015 at 07:37:07PM -0800, Jubin John wrote: > From: Dean Luick > > Correctly reduce the number of VLs when limited by the number > of SDMA engines. why? What does this "solve"? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the

Re: [PATCH 07/18] staging/rdma/hfi1: Extend quiet timeout

2015-11-19 Thread Greg KH
On Fri, Nov 13, 2015 at 07:37:05PM -0800, Jubin John wrote: > From: Dean Luick > > The longest quiet timeout is now 6s. Extend the driver wait. To what? And why? What does this fix? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of

Re: [PATCH v2 2/2] staging/rdma/hfi1: Eliminate WARN_ON when VL is invalid

2015-11-19 Thread Greg KH
On Mon, Nov 09, 2015 at 07:18:21PM -0500, Jubin John wrote: > From: Ira Weiny > > sdma_select_engine_vl only needs to protect itself from an invalid VL. > Something higher up the stack should be warning the user when they try > to use an SL which maps to an invalid VL. > >

Re: [PATCH 01/18] staging/rdma/hfi1: Support alternate firmware names

2015-11-19 Thread Greg KH
On Fri, Nov 13, 2015 at 07:36:59PM -0800, Jubin John wrote: > From: Dean Luick > > Add support for an automatic fallback for firmware names. Why? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org

Re: [PATCH v3 3/3] staging/rdma/hfi1: Method to toggle "fast ECN" detection

2015-11-19 Thread Greg KH
On Mon, Nov 09, 2015 at 06:34:44PM -0500, ira.we...@intel.com wrote: > From: Vennila Megavannan > > Add a module paramter to toggle prescan/Fast ECN Detection and remove the > Kconfig option which used to control this. Ick, no, not a module parameter, that's horrid

Re: [PATCH 05/18] staging/rdma/hfi1: Clean up comments

2015-11-19 Thread Greg KH
On Fri, Nov 13, 2015 at 07:37:03PM -0800, Jubin John wrote: > From: Edward Mascarenhas > > Clean up comments In what way? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 03/18] staging/rdma/hfi1: Add aeth name syndrome decode

2015-11-19 Thread Greg KH
On Fri, Nov 13, 2015 at 07:37:01PM -0800, Jubin John wrote: > From: Dean Luick > > Add aeth name syndrome decode Again, why? Come on, be more descriptive about why you are making the change, not what the change is, we can all read code. Please fix this whole series up

Re: [PATCH 02/18] staging/rdma/hfi1: Decode CNP opcode

2015-11-19 Thread Greg KH
On Fri, Nov 13, 2015 at 07:37:00PM -0800, Jubin John wrote: > From: Dean Luick > > Add CNP opcode decode Why? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v3] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

2015-11-19 Thread Greg KH
On Mon, Nov 16, 2015 at 05:03:49PM -0500, ira.we...@intel.com wrote: > From: Dean Luick > > Correctly set half-swing for integrated devices. A0 needs all fields set for > CcePcieCtrl. B0 and later only need a few fields set. > > Reviewed-by: Stuart Summers

Re: [PATCH v4 5/9] staging/rdma/hfi1: Add function stubs for TID caching

2015-11-09 Thread Greg KH
On Mon, Nov 09, 2015 at 07:11:03PM -0500, ira.weiny wrote: > On Fri, Nov 06, 2015 at 05:02:35PM -0800, Greg KH wrote: > > On Fri, Oct 30, 2015 at 06:58:44PM -0400, ira.we...@intel.com wrote: > > > From: Mitko Haralanov <mitko.harala...@intel.com> > > > >

Re: [PATCH v4 6/9] staging/rdma/hfi1: Implement Expected Receive TID caching

2015-11-06 Thread Greg KH
On Fri, Oct 30, 2015 at 06:58:45PM -0400, ira.we...@intel.com wrote: > From: Mitko Haralanov > > Expected receives work by user-space libraries (PSM) calling into the driver > with information about the user's receive buffer and have the driver DMA-map > that buffer

Re: [PATCH 3/3] staging/rdma/hfi1: Method to toggle "fast ECN" detection

2015-11-06 Thread Greg KH
On Thu, Nov 05, 2015 at 12:02:25PM -0500, ira.weiny wrote: > On Thu, Nov 05, 2015 at 10:56:27AM +0300, Dan Carpenter wrote: > > On Wed, Nov 04, 2015 at 09:10:11PM -0500, ira.we...@intel.com wrote: > > > From: Vennila Megavannan > > > > > > Add a module paramter to

Re: [PATCH v4 5/9] staging/rdma/hfi1: Add function stubs for TID caching

2015-11-06 Thread Greg KH
On Fri, Oct 30, 2015 at 06:58:44PM -0400, ira.we...@intel.com wrote: > From: Mitko Haralanov > > Add mmu notify helper functions and TID caching function stubs in preparation > for the TID caching implementation. > > TID caching makes use of the MMU notifier to allow

Re: [PATCH RESEND 11/11] staging/rdma/hfi1: Workaround to prevent corruption during packet delivery

2015-11-06 Thread Greg KH
On Fri, Nov 06, 2015 at 08:07:06PM -0500, Jubin John wrote: > --- a/drivers/staging/rdma/hfi1/hfi.h > +++ b/drivers/staging/rdma/hfi1/hfi.h > @@ -1084,6 +1084,10 @@ struct hfi1_devdata { > /* Save the enabled LCB error bits */ > u64 lcb_err_en; > u8 dc_shutdown; > + > + /*

Re: [PATCH RESEND 10/11] staging/rdma/hfi1: Eliminate WARN_ON when VL is invalid

2015-11-06 Thread Greg KH
On Fri, Nov 06, 2015 at 08:07:05PM -0500, Jubin John wrote: > From: Ira Weiny > > sdma_select_engine_vl only needs to protect itself from an invalid VL. > Something higher up the stack should be warning the user when they try > to use an SL which maps to an invalid VL. > >

Re: [PATCH v4 6/9] staging/rdma/hfi1: Implement Expected Receive TID caching

2015-10-30 Thread Greg KH
Meta-comment, you put "v4" in the subject, in a place where I can't sort this series and expect them to be applied in the correct order. You need a 'v4' in all of the patches (git format-patch will do it automatically for you.) As this is, it's a pain to apply, please fix up and resend. thanks,

Re: [PATCH v3 23/23] staging/rdma/hfi1: Update driver version string to 0.9-294

2015-10-27 Thread Greg KH
On Mon, Oct 26, 2015 at 10:28:49AM -0400, ira.we...@intel.com wrote: > From: Jubin John > > Signed-off-by: Jubin John > Signed-off-by: Ira Weiny > --- > drivers/staging/rdma/hfi1/common.h | 2 +- > 1 file changed, 1

Re: [PATCH v3 19/23] staging/rdma/hfi: modify workqueue for parallelism

2015-10-27 Thread Greg KH
On Mon, Oct 26, 2015 at 10:28:45AM -0400, ira.we...@intel.com wrote: > From: Mike Marciniszyn > > The workqueue is currently single threaded per port which for a small number > of > SDMA engines is ok. > > For hfi1, the there are up to 16 SDMA engines that can be

Re: [PATCH v3 12/23] staging/rdma/hfi1: Macro code clean up

2015-10-27 Thread Greg KH
On Mon, Oct 26, 2015 at 10:28:38AM -0400, ira.we...@intel.com wrote: > From: Mitko Haralanov > > Clean up the context and sdma macros and move them to a more logical place in > hfi.h > > Signed-off-by: Mitko Haralanov > Signed-off-by: Ira

Re: [PATCH v3 14/23] staging/rdma/hfi1: Implement Expected Receive TID caching

2015-10-27 Thread Greg KH
On Mon, Oct 26, 2015 at 10:28:40AM -0400, ira.we...@intel.com wrote: > From: Mitko Haralanov > > Expected receives work by user-space libraries (PSM) calling into the > driver with information about the user's receive buffer and have the driver > DMA-map that buffer

Re: [PATCH v3 23/23] staging/rdma/hfi1: Update driver version string to 0.9-294

2015-10-27 Thread Greg KH
On Tue, Oct 27, 2015 at 05:00:22PM -0400, ira.weiny wrote: > On Tue, Oct 27, 2015 at 05:46:41PM +0900, Greg KH wrote: > > On Mon, Oct 26, 2015 at 10:28:49AM -0400, ira.we...@intel.com wrote: > > > From: Jubin John <jubin.j...@intel.com> > > > > > > Signe

Re: [PATCH v3 12/23] staging/rdma/hfi1: Macro code clean up

2015-10-27 Thread Greg KH
On Tue, Oct 27, 2015 at 04:51:15PM -0400, ira.weiny wrote: > On Tue, Oct 27, 2015 at 05:19:10PM +0900, Greg KH wrote: > > On Mon, Oct 26, 2015 at 10:28:38AM -0400, ira.we...@intel.com wrote: > > > From: Mitko Haralanov <mitko.harala...@intel.com> > > > > >

Re: [PATCH 2195/2195] Staging: rdma: amso1100: Fix multiple assignments on single line.

2015-10-25 Thread Greg KH
On Sun, Oct 25, 2015 at 04:50:06AM -0600, Weston Silbaugh wrote: > Multiple assignments should be avoided. > > For example: > > cm_event.ird = cm_event.ord = 128; > > Should be: > > cm_event.ird = 128; > cm_event.ord = 128; > > Signed-off-by: Weston Silbaugh Where

Re: [PATCH 00/23] Update driver to 0.9-294

2015-10-19 Thread Greg KH
On Mon, Oct 19, 2015 at 06:16:55PM +, Weiny, Ira wrote: > > > > On Mon, Oct 19, 2015 at 12:43:24PM -0400, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > The following series has bug fixes and updates to the staging hfi1 driver. > > > > Why are you adding

Re: [PATCH 15/23] staging/rdma/hfi1: Implement Expected Receive TID caching

2015-10-19 Thread Greg KH
On Mon, Oct 19, 2015 at 12:43:39PM -0400, ira.we...@intel.com wrote: > From: Mitko Haralanov > > Expected receives work by user-space libraries (PSM) calling into the driver > with information about the user's receive buffer and have the driver DMA-map > that buffer

Re: [PATCH 00/23] Update driver to 0.9-294

2015-10-19 Thread Greg KH
On Mon, Oct 19, 2015 at 12:43:24PM -0400, ira.we...@intel.com wrote: > From: Ira Weiny > > The following series has bug fixes and updates to the staging hfi1 driver. Why are you adding new functionality to this driver before it is moved out of drivers/staging/ ? I _REALLY_

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-08-18 Thread Greg KH
On Tue, Aug 18, 2015 at 08:11:26PM -0700, Doug Ledford wrote: On Aug 18, 2015, at 7:49 PM, Greg KH g...@kroah.com wrote: On Tue, Aug 18, 2015 at 06:24:40PM -0700, Doug Ledford wrote: Are you going to be responsible for all of the patches sent to it and you just want me

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-08-18 Thread Greg KH
On Tue, Aug 18, 2015 at 06:24:40PM -0700, Doug Ledford wrote: On Aug 18, 2015, at 4:11 PM, Greg KH g...@kroah.com wrote: On Tue, Aug 18, 2015 at 10:00:39AM -0700, Doug Ledford wrote: On Aug 18, 2015, at 9:50 AM, Greg KH g...@kroah.com wrote: On Tue, Aug 18, 2015 at 04:29:50PM

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-08-18 Thread Greg KH
On Tue, Aug 18, 2015 at 10:00:39AM -0700, Doug Ledford wrote: On Aug 18, 2015, at 9:50 AM, Greg KH g...@kroah.com wrote: On Tue, Aug 18, 2015 at 04:29:50PM +, Marciniszyn, Mike wrote: Subject: Re: [PATCH] Kconfig: add temporary PCI dependency On Tue, Aug 18, 2015 at 10:15:42AM

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-08-18 Thread Greg KH
On Tue, Aug 18, 2015 at 04:29:50PM +, Marciniszyn, Mike wrote: Subject: Re: [PATCH] Kconfig: add temporary PCI dependency On Tue, Aug 18, 2015 at 10:15:42AM -0400, Mike Marciniszyn wrote: The move from infiniband to staging requires a temporary PCI dependency to fix 0-day build

Re: [PATCH] MAINTAINERS: Add maintainer section for hfi1

2015-08-18 Thread Greg KH
On Tue, Aug 18, 2015 at 04:04:15PM +, Marciniszyn, Mike wrote: +HFI1 DRIVER +M: Mike Marciniszyn infinip...@intel.com +L: linux-rdma@vger.kernel.org +L: de...@driverdev.osuosl.org +S: Supported +F: drivers/staging/hfi1 Why do this for a

Re: [PATCH] MAINTAINERS: Add maintainer section for hfi1

2015-08-18 Thread Greg KH
On Tue, Aug 18, 2015 at 10:06:09AM -0400, Mike Marciniszyn wrote: Signed-off-by: Mike Marciniszyn mike.marcinis...@intel.com --- 0 files changed diff --git a/MAINTAINERS b/MAINTAINERS index b3c1a56..45953e9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9892,6 +9892,13 @@ M: Arnaud

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-08-18 Thread Greg KH
On Tue, Aug 18, 2015 at 10:15:42AM -0400, Mike Marciniszyn wrote: The move from infiniband to staging requires a temporary PCI dependency to fix 0-day build issues. The drivers/infiniband/hw/Kconfig gratuitously added it for all drivers. Signed-off-by: Mike Marciniszyn

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch.

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote: On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: We should prefer `const struct pci_device_id

Re: [PATCH v3.10.y 0/4] IB/IPoIB fixes for SRIOV / cloud environment

2013-08-25 Thread Greg KH
On Sun, Aug 25, 2013 at 11:10:36AM +0300, Or Gerlitz wrote: On 23/08/2013 01:36, Roland Dreier wrote: Sorry for not replying. My feeling about these patches is basically meh. English (please)? That was English: http://www.urbandictionary.com/define.php?term=meh They seem to be

Re: [PATCH v3.10.y 0/4] IB/IPoIB fixes for SRIOV / cloud environment

2013-08-22 Thread Greg KH
On Mon, Aug 12, 2013 at 01:38:59PM +0300, Or Gerlitz wrote: On 06/08/2013 14:22, Or Gerlitz wrote: On 06/08/2013 12:38, Greg KH wrote: On Tue, Aug 06, 2013 at 11:38:38AM +0300, Or Gerlitz wrote: Hi Greg, This series contains few fixes to the IB core, mlx4 IB driver and IPoIB

Re: [PATCH 0/2] fs: supply inode uid/gid setting interface

2013-08-22 Thread Greg KH
On Fri, Aug 23, 2013 at 10:48:36AM +0800, Rui Xiang wrote: This patchset implements an accessor functions to set uid/gid in inode struct. Just finish code clean up. Why? -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org

Re: [PATCH v3.10.y 0/4] IB/IPoIB fixes for SRIOV / cloud environment

2013-08-06 Thread Greg KH
On Tue, Aug 06, 2013 at 11:38:38AM +0300, Or Gerlitz wrote: Hi Greg, This series contains few fixes to the IB core, mlx4 IB driver and IPoIB. The patches enable working properly with IPoIB devices set over SRIOV Virtual Functions probed to VMs in cloud environment when the cloud

Re: [PATCH 407/493] infiniband: remove use of __devexit

2012-11-19 Thread Greg KH
On Mon, Nov 19, 2012 at 01:09:21PM -0700, Jason Gunthorpe wrote: On Mon, Nov 19, 2012 at 01:25:56PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devexit is no longer needed. I'm sad to hear this, it is an easy space saver on my non-modular emebedded systems

Re: [PATCH 407/493] infiniband: remove use of __devexit

2012-11-19 Thread Greg KH
On Mon, Nov 19, 2012 at 02:49:22PM -0700, Jason Gunthorpe wrote: On Mon, Nov 19, 2012 at 12:19:38PM -0800, Greg KH wrote: On Mon, Nov 19, 2012 at 01:09:21PM -0700, Jason Gunthorpe wrote: On Mon, Nov 19, 2012 at 01:25:56PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is going away

Re: [PATCH 407/493] infiniband: remove use of __devexit

2012-11-19 Thread Greg KH
On Mon, Nov 19, 2012 at 03:48:45PM -0700, Jason Gunthorpe wrote: On Mon, Nov 19, 2012 at 02:06:32PM -0800, Greg KH wrote: 5k isn't a lot, but in the context of 'I have to figure out how to trim ~1MB off the 3.6 kernel to run it in our smallest hardware' it is the wrong direction

Re: [PATCH] prevent CVE-2012-2372 rds-ping causes kernel panic

2012-10-22 Thread Greg KH
On Mon, Oct 22, 2012 at 02:12:54PM -0400, Jay Fenlason wrote: If you use rds-ping of the local IP address of some Infiniband HCAs (QLogic, possibly others) the machine will panic with a BUG_ON due to an overly restrictive check. Loosen the restriction a bit This should have gotten sent a

Re: [PATCH] core/verb.c: fix kernel panic: always initialize struct ib_qp *qp-usecnt

2012-01-19 Thread Greg KH
On Thu, Jan 19, 2012 at 08:46:41PM +0100, Bernd Schubert wrote: We have just been investigating kernel panics related to cq-ibcq.event_handler() completion calls. Reason is that ib_destroy_qp() fails with -EBUSY. Further investigation revealed qp-usecnt is not initialized. This counter was

Re: [patch v2 13/37] add rxe_verbs.c

2011-08-15 Thread Greg KH
On Mon, Aug 15, 2011 at 04:58:44PM +0200, Bart Van Assche wrote: On Mon, Aug 15, 2011 at 4:45 PM, Greg KH gre...@suse.de wrote: On Mon, Aug 15, 2011 at 04:33:14PM +0200, Bart Van Assche wrote: On Sun, Jul 24, 2011 at 9:43 PM,  rpear...@systemfabricworks.com wrote: +   for (i = 0; i

Re: [patch v2 13/37] add rxe_verbs.c

2011-08-15 Thread Greg KH
On Mon, Aug 15, 2011 at 06:02:23PM +0200, Bart Van Assche wrote: On Mon, Aug 15, 2011 at 5:07 PM, Greg KH gre...@suse.de wrote: For a device, you HAVE to be creating these attributes before the hotplug event is sent out, and to do that, you need to set the correct pointer before registering

Re: [stable] [PATCH 2.6.36] RDMA/cxgb3: Turn off rx coalescing for iwarp connections.

2010-09-18 Thread Greg KH
On Sat, Sep 18, 2010 at 07:38:21PM -0500, Steve Wise wrote: The HW by default has RX coalescing on. For iwarp connections, this was causing a 100ms delay in connection establishement due to the ingress MPA Start message being stalled in HW. So explicitly turn rx coalescing off when setting