Re: stalled again

2015-12-01 Thread Greg Kroah-Hartman
On Tue, Dec 01, 2015 at 06:30:28PM +0200, Or Gerlitz wrote: > Doug, > > We're against into this... upstream is on 4.4-rc3 while your latest branch > in kernel.org (the one that carries thefor-next tag) is rebased to > 4.3-rc3... > > --> our internal build and review systems for patches to linux-r

Re: [PATCH 5/9] staging/rdma/hfi1: Add function stubs for TID caching

2015-11-19 Thread Greg Kroah-Hartman
On Thu, Nov 12, 2015 at 07:58:54AM +0200, Or Gerlitz wrote: > On Sat, Oct 31, 2015 at 12:41 AM, wrote: > > From: Mitko Haralanov > > > > Add mmu notify helper functions and TID caching function stubs in > > preparation > > for the TID caching implementation. > > > > TID caching makes use of the

Re: shrink struct ib_send_wr V4

2015-11-04 Thread Greg Kroah-Hartman
On Wed, Nov 04, 2015 at 10:00:38AM -0500, Doug Ledford wrote: > On 11/02/2015 11:16 PM, Greg Kroah-Hartman wrote: > > This too was something we discussed at the kernel summit, it's > > recommended that you just delete the drivers from where they are now, no > > need to

Re: shrink struct ib_send_wr V4

2015-11-03 Thread Greg Kroah-Hartman
On Tue, Nov 03, 2015 at 11:59:02AM -0500, Chuck Lever wrote: > > > On Nov 2, 2015, at 6:37 PM, Greg Kroah-Hartman > > wrote: > > > > On Mon, Nov 02, 2015 at 06:20:40PM -0500, Doug Ledford wrote: > >> 1) Aging, but working, drivers that will be removed in

Re: shrink struct ib_send_wr V4

2015-11-02 Thread Greg Kroah-Hartman
On Mon, Nov 02, 2015 at 10:14:06PM -0500, Doug Ledford wrote: > On 11/02/2015 07:49 PM, Greg Kroah-Hartman wrote: > > On Mon, Nov 02, 2015 at 07:02:04PM -0500, Doug Ledford wrote: > >>> so overall it still benifits being in the > >>> staging tree, so a few mino

Re: shrink struct ib_send_wr V4

2015-11-02 Thread Greg Kroah-Hartman
On Mon, Nov 02, 2015 at 09:03:35PM -0500, Doug Ledford wrote: > On 11/02/2015 08:28 PM, Jason Gunthorpe wrote: > > On Mon, Nov 02, 2015 at 07:52:05PM -0500, Doug Ledford wrote: > >> It shouldn't be. I reviewed those changes and they looked right (given > >> the limitations). All you needed was to

Re: shrink struct ib_send_wr V4

2015-11-02 Thread Greg Kroah-Hartman
On Mon, Nov 02, 2015 at 05:18:45PM -0700, Jason Gunthorpe wrote: > On Mon, Nov 02, 2015 at 07:02:04PM -0500, Doug Ledford wrote: > > > Because they are *scheduled* for removal. If I simply didn't care if > > they went away, then I wouldn't screw around with deprecating them or > > tagging them to

Re: shrink struct ib_send_wr V4

2015-11-02 Thread Greg Kroah-Hartman
On Mon, Nov 02, 2015 at 07:02:04PM -0500, Doug Ledford wrote: > > so overall it still benifits being in the > > staging tree, so a few minor breakages every once in a while should be > > easy for you to fix up, _if_ they happen. > > > > Again, I don't know of any recent api change that has caused

Re: shrink struct ib_send_wr V4

2015-11-02 Thread Greg Kroah-Hartman
On Mon, Nov 02, 2015 at 06:20:40PM -0500, Doug Ledford wrote: > 1) Aging, but working, drivers that will be removed in the future. > Since we no longer have a deprecation mechanism, I was informed that the > normal procedure now is to move the driver to staging for a while and > then remove it perm

Re: shrink struct ib_send_wr V4

2015-11-01 Thread Greg Kroah-Hartman
On Sun, Nov 01, 2015 at 02:10:48PM +0200, Or Gerlitz wrote: > On 10/29/2015 1:51 PM, Christoph Hellwig wrote: > >On Wed, Oct 28, 2015 at 10:57:59PM -0400, Doug Ledford wrote: > >I had to do a minor hand merge to get this to apply, but it has been > >pulled in for 4.4. > >>> > >>>This brea

Re: [PATCH v2 2/2] staging: IB/ipath: remove sched.h header

2015-10-25 Thread Greg Kroah-Hartman
On Sat, Oct 24, 2015 at 07:05:32PM -0700, Greg Kroah-Hartman wrote: > On Sun, Oct 18, 2015 at 09:57:09PM +0800, Geliang Tang wrote: > > sched.h header in ipath_*.c is now unnecessary, since I have added > > sched.h in ipath_kernel.h. So remove it. > > Overall, it's

Re: [PATCH v2 2/2] staging: IB/ipath: remove sched.h header

2015-10-25 Thread Greg Kroah-Hartman
On Sun, Oct 18, 2015 at 09:57:09PM +0800, Geliang Tang wrote: > sched.h header in ipath_*.c is now unnecessary, since I have added > sched.h in ipath_kernel.h. So remove it. Overall, it's best to split this type of thing out, don't "hide" .h includes in another .h file, so I'm not going to take th

Re: [PATCH 1/3] staging: rdma: hfi1: Use setup_timer

2015-10-25 Thread Greg Kroah-Hartman
On Sat, Oct 24, 2015 at 07:58:05AM +0530, Muhammad Falak R Wani wrote: > Use the timer API function setup_timer instead of init_timer, removing > the structure field assignments. > > > > @timer@ > expression e1,e2,e3,fn_ptr; > @@ > -init_timer(&e1); > +setup_timer(&e1, fn_ptr, e2); > ... when !=

Re: [PATCH 1/4] staging: rdma: ipath: Use setup_timer

2015-10-25 Thread Greg Kroah-Hartman
On Sat, Oct 24, 2015 at 07:49:28AM +0530, Muhammad Falak R Wani wrote: > Use the timer API function setup_timer instead of init_timer, removing > the structure field assignments. > > > > @timer@ > expression e1,e2,e3,fn_ptr; > @@ > -init_timer(&e1); > +setup_timer(&e1, fn_ptr, e2); > ... when !=

Re: [PATCH] staging: IB/ipath: use TASK_COMM_LEN in ipath_portdata

2015-10-17 Thread Greg Kroah-Hartman
On Thu, Oct 08, 2015 at 10:04:27PM -0700, Geliang Tang wrote: > Use comm[TASK_COMM_LEN] instead of comm[16]. Add linux/sched.h > header in ipath_kernel.h, and remove linux/sched.h header from > ipath_*.c which have included ipath_kernel.h. That's a lot of different things to be doing all in one pa

Re: [PATCH] staging: rdma: Fix braces around if/else

2015-10-04 Thread Greg Kroah-Hartman
On Sun, Oct 04, 2015 at 11:05:50AM +0200, Martin Kletzander wrote: > On Sun, Oct 04, 2015 at 08:20:09AM +0100, Greg Kroah-Hartman wrote: > >On Sun, Oct 04, 2015 at 09:47:52AM +0300, Or Gerlitz wrote: > >>On 10/3/2015 11:55 PM, Martin Kletzander wrote: > >>>Get ri

Re: [PATCH] staging: rdma: Fix braces around if/else

2015-10-04 Thread Greg Kroah-Hartman
On Sun, Oct 04, 2015 at 09:47:52AM +0300, Or Gerlitz wrote: > On 10/3/2015 11:55 PM, Martin Kletzander wrote: > >Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl. > > Hi Greg, > > Is there a way to signal people/tools that a certain driver parks in staging > on their way **ou

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-21 Thread Greg Kroah-Hartman
On Mon, Sep 21, 2015 at 01:03:52PM -0400, Doug Ledford wrote: > On 09/21/2015 12:48 PM, Greg Kroah-Hartman wrote: > > > But, that's already not happening, as is obvious by my inbox. > > Yeah, I see that. > > > So, how about you forward on what you have so fa

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-21 Thread Greg Kroah-Hartman
On Mon, Sep 21, 2015 at 11:42:28AM -0400, Doug Ledford wrote: > On 09/18/2015 11:01 PM, Greg Kroah-Hartman wrote: > > On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote: > >> On 09/16/2015 02:22 AM, Dan Carpenter wrote: > >>> __get_txreq() returns an ERR_PTR

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-20 Thread Greg Kroah-Hartman
On Sat, Sep 19, 2015 at 10:49:52PM +, Weiny, Ira wrote: > > > > On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote: > > > On 09/16/2015 02:22 AM, Dan Carpenter wrote: > > > > __get_txreq() returns an ERR_PTR() but this checks for NULL so it > > > > would oops on failure. > > > > > >

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-18 Thread Greg Kroah-Hartman
On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote: > On 09/16/2015 02:22 AM, Dan Carpenter wrote: > > __get_txreq() returns an ERR_PTR() but this checks for NULL so it would > > oops on failure. > > > > Signed-off-by: Dan Carpenter > > Thanks, applied. Applied to what? Should I just

Re: Deprecating ipath

2015-07-03 Thread Greg Kroah-Hartman
On Fri, Jul 03, 2015 at 01:25:25PM +, Dalessandro, Dennis wrote: > > -Original Message- > > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > > ow...@vger.kernel.org] On Behalf Of Greg Kroah-Hartman > > Sent: Friday, June 26, 2015 12:54 PM > >

Re: Deprecating ipath

2015-06-26 Thread Greg Kroah-Hartman
On Fri, Jun 26, 2015 at 09:23:27AM -0700, Luis R. Rodriguez wrote: > On Fri, Jun 26, 2015 at 9:17 AM, Marciniszyn, Mike > wrote: > > Doug, > > > > We have been given the go ahead to start the deprecation process for thie > > ipath driver. > > That's great! Do you mean removal from Linux? > > >

Re: linux rdma 3.14 merge plans

2014-01-16 Thread Greg Kroah-Hartman
On Thu, Jan 16, 2014 at 11:42:19PM +0200, Or Gerlitz wrote: > On Thu, Jan 16, 2014 at 11:37 PM, Greg Kroah-Hartman > wrote: > > On Thu, Jan 16, 2014 at 01:14:12PM -0800, Nicholas A. Bellinger wrote: > >> On Thu, 2014-01-16 at 12:13 -0800, Roland Dreier wrote: > >> &

Re: linux rdma 3.14 merge plans

2014-01-16 Thread Greg Kroah-Hartman
On Thu, Jan 16, 2014 at 01:14:12PM -0800, Nicholas A. Bellinger wrote: > On Thu, 2014-01-16 at 12:13 -0800, Roland Dreier wrote: > > > > > On Mon, 2014-01-13 at 12:32 -0800, Nicholas A. Bellinger wrote: > > > > Hi Roland & Co, > > > > > > > > Just curious if your planning to take a look at this se

Re: [PATCH 5/6] staging/et131x: Use cached pci_dev->pcie_mpss and pcie_set_readrq() to simplif code

2013-09-09 Thread Greg Kroah-Hartman
d() > to simplify code. > > Signed-off-by: Yijing Wang Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html