Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-11-24 Thread Jason Gunthorpe
On Tue, Nov 24, 2015 at 10:45:14AM +0100, Yann Droneaud wrote: > > Same as my question above, if peer supports this feature do you see > > anything wrong? > > If peer is going to forward this packet to a different network, which > is not IPoIB based, the checksum will be checked and the packet

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-11-24 Thread Yann Droneaud
Hi, Le mercredi 18 novembre 2015 à 12:46 +0200, Yuval Shaia a écrit : > On Thu, Jul 30, 2015 at 03:58:13PM +0200, Yann Droneaud wrote: > > Le jeudi 30 juillet 2015 à 04:46 -0700, Yuval Shaia a écrit : > > > This enhancement suggest the usage of IB CRC instead of CSUM in > > > IPoIB CM. IPoIB CM

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-11-23 Thread Jason Gunthorpe
On Wed, Nov 18, 2015 at 10:27:41PM +0200, Yuval Shaia wrote: > > You need private-data exchange to negotiate the feature. > > > > The feature should be a per-packet csum status header. > > > > When sending a skb that is already fully csumed the receiver sets > > CHECKSUM_UNNECESSARY. > > > >

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-11-18 Thread Yuval Shaia
On Thu, Jul 30, 2015 at 03:58:13PM +0200, Yann Droneaud wrote: > Hi, > > Le jeudi 30 juillet 2015 à 04:46 -0700, Yuval Shaia a écrit : > > This enhancement suggest the usage of IB CRC instead of CSUM in IPoIB > > CM. IPoIB CM uses RC (Reliable Connection) which guarantees the > > corruption

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-11-18 Thread Yuval Shaia
On Thu, Jul 30, 2015 at 07:03:22PM -0700, Bart Van Assche wrote: > On 07/30/15 13:09, Yuval Shaia wrote: > >On Thu, Jul 30, 2015 at 09:38:54AM -0700, Bart Van Assche wrote: > >>On 07/30/2015 04:46 AM, Yuval Shaia wrote: > >>> struct ipoib_cm_data { > >>> __be32 qpn; /* High byte MUST be ignored

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-09-06 Thread Yuval Shaia
On Thu, Sep 03, 2015 at 04:29:45PM -0400, Doug Ledford wrote: > On 07/30/2015 10:03 PM, Bart Van Assche wrote: > > On 07/30/15 13:09, Yuval Shaia wrote: > >> On Thu, Jul 30, 2015 at 09:38:54AM -0700, Bart Van Assche wrote: > >>> On 07/30/2015 04:46 AM, Yuval Shaia wrote: > struct

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-09-03 Thread Doug Ledford
On 07/30/2015 10:03 PM, Bart Van Assche wrote: > On 07/30/15 13:09, Yuval Shaia wrote: >> On Thu, Jul 30, 2015 at 09:38:54AM -0700, Bart Van Assche wrote: >>> On 07/30/2015 04:46 AM, Yuval Shaia wrote: struct ipoib_cm_data { __be32 qpn; /* High byte MUST be ignored on receive */

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-07-30 Thread Yuval Shaia
On Thu, Jul 30, 2015 at 03:58:13PM +0200, Yann Droneaud wrote: Hi, Le jeudi 30 juillet 2015 à 04:46 -0700, Yuval Shaia a écrit : This enhancement suggest the usage of IB CRC instead of CSUM in IPoIB CM. IPoIB CM uses RC (Reliable Connection) which guarantees the corruption free

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-07-30 Thread Jason Gunthorpe
On Thu, Jul 30, 2015 at 11:46:36PM +0300, Yuval Shaia wrote: On Thu, Jul 30, 2015 at 11:15:38AM -0600, Jason Gunthorpe wrote: On Thu, Jul 30, 2015 at 11:51:12AM -0400, Doug Ledford wrote: In its current state, I have my doubts about this patch. However, it seems to me that this should

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-07-30 Thread Yuval Shaia
On Thu, Jul 30, 2015 at 11:15:38AM -0600, Jason Gunthorpe wrote: On Thu, Jul 30, 2015 at 11:51:12AM -0400, Doug Ledford wrote: In its current state, I have my doubts about this patch. However, it seems to me that this should be relatively easy to fix in such a way that you get 90%+ of

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-07-30 Thread Yuval Shaia
On Thu, Jul 30, 2015 at 09:38:54AM -0700, Bart Van Assche wrote: On 07/30/2015 04:46 AM, Yuval Shaia wrote: struct ipoib_cm_data { __be32 qpn; /* High byte MUST be ignored on receive */ __be32 mtu; +__be16 sig; /* must be IPOIB_CM_PROTO_SIG */ +__be16 caps; /* 4 bits

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-07-30 Thread Yuval Shaia
On Thu, Jul 30, 2015 at 11:51:12AM -0400, Doug Ledford wrote: On 07/30/2015 11:20 AM, Yuval Shaia wrote: On Thu, Jul 30, 2015 at 03:58:13PM +0200, Yann Droneaud wrote: Hi, Le jeudi 30 juillet 2015 à 04:46 -0700, Yuval Shaia a écrit : This enhancement suggest the usage of IB CRC instead

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-07-30 Thread Bart Van Assche
On 07/30/15 13:09, Yuval Shaia wrote: On Thu, Jul 30, 2015 at 09:38:54AM -0700, Bart Van Assche wrote: On 07/30/2015 04:46 AM, Yuval Shaia wrote: struct ipoib_cm_data { __be32 qpn; /* High byte MUST be ignored on receive */ __be32 mtu; + __be16 sig; /* must be

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-07-30 Thread Doug Ledford
On 07/30/2015 11:20 AM, Yuval Shaia wrote: On Thu, Jul 30, 2015 at 03:58:13PM +0200, Yann Droneaud wrote: Hi, Le jeudi 30 juillet 2015 à 04:46 -0700, Yuval Shaia a écrit : This enhancement suggest the usage of IB CRC instead of CSUM in IPoIB CM. IPoIB CM uses RC (Reliable Connection) which

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-07-30 Thread Jason Gunthorpe
On Thu, Jul 30, 2015 at 11:51:12AM -0400, Doug Ledford wrote: In its current state, I have my doubts about this patch. However, it seems to me that this should be relatively easy to fix in such a way that you get 90%+ of the performance benefit, and can turn it on by default, and we don't

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-07-30 Thread Bart Van Assche
On 07/30/2015 04:46 AM, Yuval Shaia wrote: struct ipoib_cm_data { __be32 qpn; /* High byte MUST be ignored on receive */ __be32 mtu; + __be16 sig; /* must be IPOIB_CM_PROTO_SIG */ + __be16 caps; /* 4 bits proto ver and 12 bits capabilities */ }; This patch