RE: [PATCH 1/2] mlx4: Expose correct max_sge_rd limit

2015-10-27 Thread Eli Cohen
; Nicholas A. Bellinger; Or Gerlitz; Doug Ledford; Eli Cohen Subject: Re: [PATCH 1/2] mlx4: Expose correct max_sge_rd limit > Hello Sagi, > > Is this the same issue as what has been discussed in > http://www.spinics.net/lists/linux-rdma/msg21799.html ? Looks like it. I think this pat

Re: [PATCH 1/2] mlx4: Expose correct max_sge_rd limit

2015-10-27 Thread Sagi Grimberg
Hello Sagi, Is this the same issue as what has been discussed in http://www.spinics.net/lists/linux-rdma/msg21799.html ? Looks like it. I think this patch addresses this issue, but lets CC Eli to comment if I'm missing something. Thanks for digging this up... Sagi. -- To unsubscribe from thi

Re: [PATCH 1/2] mlx4: Expose correct max_sge_rd limit

2015-10-27 Thread Bart Van Assche
On 10/27/2015 02:40 AM, Sagi Grimberg wrote: mlx4 devices (ConnectX-2, ConnectX-3) can not issue max_sge in a single RDMA_READ request (resulting in a completion error). Thus, expose lower max_sge_rd to avoid this issue. Signed-off-by: Sagi Grimberg --- drivers/infiniband/hw/mlx4/main.c |

Re: [PATCH 1/2] mlx4: Expose correct max_sge_rd limit

2015-10-27 Thread Sagi Grimberg
But AFAIR, the magic number was 28... how this goes hand in hand with your findings? mlx4 max_sge is 32, and isert does max_sge - 2 = 30. So it always used 30... and I run it reliably with this for a while now. This thing exists before I was involved so I might not be familiar with all the deta

Re: [PATCH 1/2] mlx4: Expose correct max_sge_rd limit

2015-10-27 Thread Or Gerlitz
On 10/27/2015 6:03 PM, Sagi Grimberg wrote: So from my discussions with the HW folks a RDMA_READ wqe cannot exceed 512B. The wqe control segment is 16 bytes, the rdma section is 12 bytes (rkey + raddr) and each sge is 16 bytes so the computation is: (512B-16B-12B)/16B = 30. But AFAIR, the mag

Re: [PATCH 1/2] mlx4: Expose correct max_sge_rd limit

2015-10-27 Thread Sagi Grimberg
On 27/10/2015 16:39, Or Gerlitz wrote: On 10/27/2015 11:40 AM, Sagi Grimberg wrote: mlx4 devices (ConnectX-2, ConnectX-3) can not issue max_sge in a single RDMA_READ request (resulting in a completion error). Thus, expose lower max_sge_rd to avoid this issue. Sagi, Hey Or, Still, this pa

Re: [PATCH 1/2] mlx4: Expose correct max_sge_rd limit

2015-10-27 Thread Or Gerlitz
On 10/27/2015 11:40 AM, Sagi Grimberg wrote: mlx4 devices (ConnectX-2, ConnectX-3) can not issue max_sge in a single RDMA_READ request (resulting in a completion error). Thus, expose lower max_sge_rd to avoid this issue. Sagi, I can hear your pain when wearing the iser target driver maintainer

[PATCH 1/2] mlx4: Expose correct max_sge_rd limit

2015-10-27 Thread Sagi Grimberg
mlx4 devices (ConnectX-2, ConnectX-3) can not issue max_sge in a single RDMA_READ request (resulting in a completion error). Thus, expose lower max_sge_rd to avoid this issue. Signed-off-by: Sagi Grimberg --- drivers/infiniband/hw/mlx4/main.c |3 ++- 1 files changed, 2 insertions(+), 1 delet