Re: [PATCH 20/22] IB/iser: Support up to 8MB data transfer in a single command

2015-08-04 Thread Or Gerlitz
On Tue, Aug 4, 2015 at 8:10 PM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: Why SIZE_4K and not PAGE_SIZE? Yes, I'll change that to PAGE_SIZE. Thanks. Would non-4KB pages (e.g. PPC 64KB) be an issue? Would this work between hosts with different page sizes? iser was always using 4K

Re: [PATCH 20/22] IB/iser: Support up to 8MB data transfer in a single command

2015-08-04 Thread Sagi Grimberg
Why SIZE_4K and not PAGE_SIZE? Yes, I'll change that to PAGE_SIZE. Thanks. Would non-4KB pages (e.g. PPC 64KB) be an issue? Would this work between hosts with different page sizes? iser was always using 4K segments for reasons I don't perfectly understand. Maybe Or can comment on this?

Re: [PATCH 20/22] IB/iser: Support up to 8MB data transfer in a single command

2015-08-03 Thread Atchley, Scott
On Aug 2, 2015, at 4:01 AM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: +static void +iser_calc_scsi_params(struct iser_conn *iser_conn, + unsigned int max_sectors) +{ +struct iser_device *device = iser_conn-ib_conn.device; +unsigned short sg_tablesize,

Re: [PATCH 20/22] IB/iser: Support up to 8MB data transfer in a single command

2015-08-02 Thread Sagi Grimberg
+static void +iser_calc_scsi_params(struct iser_conn *iser_conn, + unsigned int max_sectors) +{ +struct iser_device *device = iser_conn-ib_conn.device; +unsigned short sg_tablesize, sup_sg_tablesize; + +sg_tablesize = DIV_ROUND_UP(max_sectors * 512, SIZE_4K); +

Re: [PATCH 20/22] IB/iser: Support up to 8MB data transfer in a single command

2015-07-30 Thread Sagi Grimberg
On 7/30/2015 1:22 PM, Or Gerlitz wrote: On Thu, Jul 30, 2015 at 11:06 AM, Sagi Grimberg sa...@mellanox.com wrote: iser support up to 512KB data transfer in a single scsi command. In order to support up to 8MB, iser needs to pre-allocate larger memory regions and larger page vectors. We

Re: [PATCH 20/22] IB/iser: Support up to 8MB data transfer in a single command

2015-07-30 Thread Steve Wise
On 7/30/2015 3:06 AM, Sagi Grimberg wrote: iser support up to 512KB data transfer in a single scsi command. In order to support up to 8MB, iser needs to pre-allocate larger memory regions and larger page vectors. Given that a few target implementations don't support data transfers of more than