RE: [PATCH 4/9] ocrdma: Driver for Emulex OneConnect RDMA adapter

2012-03-22 Thread Parav.Pandit
Inline. -Original Message- From: Hefty, Sean [mailto:sean.he...@intel.com] Sent: Thursday, March 22, 2012 5:50 AM To: Pandit, Parav; linux-rdma@vger.kernel.org Subject: RE: [PATCH 4/9] ocrdma: Driver for Emulex OneConnect RDMA adapter +static inline void *ocrdma_get_eqe(struct

Re: [PATCH 4/9] ocrdma: Driver for Emulex OneConnect RDMA adapter

2012-03-22 Thread Roland Dreier
Does OneConnect not support UC?  (I thought UC was required for compliance.) As of now UC is unsupported. I need to check with other teams. I'll add the support in follow on checkin after this initial version, if its supported. Is it o.k. if UC is unsupported in this initial release? I

Re: [PATCH 4/9] ocrdma: Driver for Emulex OneConnect RDMA adapter

2012-03-21 Thread Roland Dreier
+int ocrdma_qp_state_machine(struct ocrdma_qp *qp, enum ib_qp_state new_ib_state, +                           enum ib_qp_state *old_ib_state) +{ +       unsigned long flags; +       int status = 0; +       enum ocrdma_qp_state new_state; +       new_state =

Re: [PATCH 4/9] ocrdma: Driver for Emulex OneConnect RDMA adapter

2012-03-21 Thread frank zago
On 03/20/2012 05:39 PM, parav.pan...@emulex.com wrote: From: Parav Pandit parav.pan...@emulex.com + +int ocrdma_mbx_dealloc_lkey(struct ocrdma_dev *dev, int fr_mr, u32 lkey) +{ + int status = -ENOMEM; + struct ocrdma_dealloc_lkey *cmd; + + cmd =

RE: [PATCH 4/9] ocrdma: Driver for Emulex OneConnect RDMA adapter

2012-03-21 Thread Parav.Pandit
-Original Message- From: Roland Dreier [mailto:rol...@purestorage.com] Sent: Wednesday, March 21, 2012 10:04 PM To: Pandit, Parav Cc: linux-rdma@vger.kernel.org; net...@vger.kernel.org Subject: Re: [PATCH 4/9] ocrdma: Driver for Emulex OneConnect RDMA adapter +int

RE: [PATCH 4/9] ocrdma: Driver for Emulex OneConnect RDMA adapter

2012-03-21 Thread Parav.Pandit
-Original Message- From: Roland Dreier [mailto:rol...@purestorage.com] Sent: Thursday, March 22, 2012 1:02 AM To: Pandit, Parav Cc: linux-rdma@vger.kernel.org; net...@vger.kernel.org Subject: Re: [PATCH 4/9] ocrdma: Driver for Emulex OneConnect RDMA adapter On Wed, Mar 21, 2012

RE: [PATCH 4/9] ocrdma: Driver for Emulex OneConnect RDMA adapter

2012-03-21 Thread Hefty, Sean
+static inline void *ocrdma_get_eqe(struct ocrdma_eq *eq) +{ + return (u8 *)eq-q.va + (eq-q.tail * sizeof(struct ocrdma_eqe)); +} casts from (void *) to (u8 *) are not needed. This occurs in multiple places. +enum ib_qp_state get_ibqp_state(enum ocrdma_qp_state qps) +{ + switch